Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/80518/?format=api
{ "id": 80518, "url": "http://patches.dpdk.org/api/patches/80518/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1602596753-32282-7-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1602596753-32282-7-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1602596753-32282-7-git-send-email-arybchenko@solarflare.com", "date": "2020-10-13T13:45:23", "name": "[06/36] common/sfc_efx/base: add max number of Rx scatter buffers", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "b9486d8e504d0a23e4a701c111a841da9810d179", "submitter": { "id": 607, "url": "http://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1602596753-32282-7-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 12916, "url": "http://patches.dpdk.org/api/series/12916/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12916", "date": "2020-10-13T13:45:18", "name": "net/sfc: add EF100 support", "version": 1, "mbox": "http://patches.dpdk.org/series/12916/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/80518/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/80518/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id AA131A04B7;\n\tTue, 13 Oct 2020 15:49:08 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A9DC61DBBE;\n\tTue, 13 Oct 2020 15:46:19 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id D8B0E1DB64\n for <dev@dpdk.org>; Tue, 13 Oct 2020 15:46:02 +0200 (CEST)", "from mx1-us1.ppe-hosted.com (unknown [10.110.50.143])\n by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id\n 717EA200AB for <dev@dpdk.org>; Tue, 13 Oct 2020 13:46:01 +0000 (UTC)", "from us4-mdac16-6.at1.mdlocal (unknown [10.110.49.173])\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 702728009B\n for <dev@dpdk.org>; Tue, 13 Oct 2020 13:46:01 +0000 (UTC)", "from mx1-us1.ppe-hosted.com (unknown [10.110.50.7])\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 07A184007F\n for <dev@dpdk.org>; Tue, 13 Oct 2020 13:46:01 +0000 (UTC)", "from webmail.solarflare.com (uk.solarflare.com [193.34.186.16])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n (No client certificate requested)\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n C53B94C0066\n for <dev@dpdk.org>; Tue, 13 Oct 2020 13:46:00 +0000 (UTC)", "from ukex01.SolarFlarecom.com (10.17.10.4) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id\n 15.0.1497.2; Tue, 13 Oct 2020 14:45:56 +0100", "from opal.uk.solarflarecom.com (10.17.10.1) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server id\n 15.0.1497.2 via Frontend Transport; Tue, 13 Oct 2020 14:45:55 +0100", "from ukv-loginhost.uk.solarflarecom.com\n (ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id 09DDjtuj006006\n for <dev@dpdk.org>; Tue, 13 Oct 2020 14:45:55 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id 8DFDA1613AB\n for <dev@dpdk.org>; Tue, 13 Oct 2020 14:45:55 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "Date": "Tue, 13 Oct 2020 14:45:23 +0100", "Message-ID": "<1602596753-32282-7-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1602596753-32282-1-git-send-email-arybchenko@solarflare.com>", "References": "<1602596753-32282-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.6.1012-25722.003", "X-TM-AS-Result": "No-0.378300-8.000000-10", "X-TMASE-MatchedRID": "DlhWZEuVcQnUVtE/LToEOJSJVT8zAs/055lobknoaffRLEyE6G4DREmu\n L2rym0QBBsHk0c28yIEvnI30VoIMaoeBgdpbkPh8ExdS7WFvZWtp4xorO9dSmdrq3hdu3tKoAZF\n U+mvfGap8bO6hWfRWzo9CL1e45ag4wUGgKARXgvJlpwNsTvdlKaIik2/euMx1FL5/d3sGIoL7js\n HFop9KRRlz1vTsWmwiixzcp/iBykL8OkSa7MC2+8jz0VPUnBA1aN2KuTwsCwKOcdOFHHGmzAwSp\n OqWwolaxzEmlYDkbow+QzXrY3xf9i9OQltRmiCangIgpj8eDcAZ1CdBJOsoY8RB0bsfrpPInxMy\n eYT53Rmi52+Q+FhUeX8bPkeGW7qPTDvu8/YwZ6/mOKQnkbuhH0lWsupqpnTRKGhxV2EKqcvGeGi\n J1lL72hEksr2bR1mg9gbZqKE6kkYckqAQnqJUA6vLjyQveEhYEdOpeiiHeDd69DNEijZ11sPINh\n wTXBeZ", "X-TM-AS-User-Approved-Sender": "Yes", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10-0.378300-8.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.6.1012-25722.003", "X-MDID": "1602596761-jXuI5Tvw4N7c", "X-PPE-DISP": "1602596761;jXuI5Tvw4N7c", "Subject": "[dpdk-dev] [PATCH 06/36] common/sfc_efx/base: add max number of Rx\n\tscatter buffers", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Riverhead QDMA has limitation on maximum number of Rx scatter\nbuffers to be used by a packet. If the limitation is violated,\nthe datapath is dead. FW should ensure that it is OK, but\ndrivers need to know the limitation anyway to check parameters\nwhen Rx queues are configured and MTU is set.\n\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\nReviewed-by: Andy Moreton <amoreton@xilinx.com>\n---\n drivers/common/sfc_efx/base/ef10_nic.c | 3 +++\n drivers/common/sfc_efx/base/efx.h | 2 ++\n drivers/common/sfc_efx/base/rhead_nic.c | 3 +++\n drivers/common/sfc_efx/base/siena_nic.c | 1 +\n 4 files changed, 9 insertions(+)", "diff": "diff --git a/drivers/common/sfc_efx/base/ef10_nic.c b/drivers/common/sfc_efx/base/ef10_nic.c\nindex 81cd436424..df7db6a803 100644\n--- a/drivers/common/sfc_efx/base/ef10_nic.c\n+++ b/drivers/common/sfc_efx/base/ef10_nic.c\n@@ -1156,6 +1156,9 @@ ef10_get_datapath_caps(\n \telse\n \t\tencp->enc_rx_disable_scatter_supported = B_FALSE;\n \n+\t/* No limit on maximum number of Rx scatter elements per packet. */\n+\tencp->enc_rx_scatter_max = -1;\n+\n \t/* Check if the firmware supports packed stream mode */\n \tif (CAP_FLAGS1(req, RX_PACKED_STREAM))\n \t\tencp->enc_rx_packed_stream_supported = B_TRUE;\ndiff --git a/drivers/common/sfc_efx/base/efx.h b/drivers/common/sfc_efx/base/efx.h\nindex a245acfe0f..4b7beb209d 100644\n--- a/drivers/common/sfc_efx/base/efx.h\n+++ b/drivers/common/sfc_efx/base/efx.h\n@@ -1555,6 +1555,8 @@ typedef struct efx_nic_cfg_s {\n \t/* Datapath firmware vport reconfigure support */\n \tboolean_t\t\tenc_vport_reconfigure_supported;\n \tboolean_t\t\tenc_rx_disable_scatter_supported;\n+\t/* Maximum number of Rx scatter segments supported by HW */\n+\tuint32_t\t\tenc_rx_scatter_max;\n \tboolean_t\t\tenc_allow_set_mac_with_installed_filters;\n \tboolean_t\t\tenc_enhanced_set_mac_supported;\n \tboolean_t\t\tenc_init_evq_v2_supported;\ndiff --git a/drivers/common/sfc_efx/base/rhead_nic.c b/drivers/common/sfc_efx/base/rhead_nic.c\nindex 66db68b384..92bc6fdfae 100644\n--- a/drivers/common/sfc_efx/base/rhead_nic.c\n+++ b/drivers/common/sfc_efx/base/rhead_nic.c\n@@ -158,6 +158,9 @@ rhead_board_cfg(\n \t}\n \tencp->enc_rx_buf_align_end = end_padding;\n \n+\t/* FIXME: It should be extracted from design parameters (Bug 86844) */\n+\tencp->enc_rx_scatter_max = 7;\n+\n \t/*\n \t * Riverhead stores a single global copy of VPD, not per-PF as on\n \t * Huntington.\ndiff --git a/drivers/common/sfc_efx/base/siena_nic.c b/drivers/common/sfc_efx/base/siena_nic.c\nindex 9c30e27f59..4137c1e245 100644\n--- a/drivers/common/sfc_efx/base/siena_nic.c\n+++ b/drivers/common/sfc_efx/base/siena_nic.c\n@@ -177,6 +177,7 @@ siena_board_cfg(\n \tencp->enc_fw_assisted_tso_v2_enabled = B_FALSE;\n \tencp->enc_fw_assisted_tso_v2_n_contexts = 0;\n \tencp->enc_tso_v3_enabled = B_FALSE;\n+\tencp->enc_rx_scatter_max = -1;\n \tencp->enc_allow_set_mac_with_installed_filters = B_TRUE;\n \tencp->enc_rx_packed_stream_supported = B_FALSE;\n \tencp->enc_rx_var_packed_stream_supported = B_FALSE;\n", "prefixes": [ "06/36" ] }