Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/80511/?format=api
{ "id": 80511, "url": "http://patches.dpdk.org/api/patches/80511/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1602596753-32282-5-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1602596753-32282-5-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1602596753-32282-5-git-send-email-arybchenko@solarflare.com", "date": "2020-10-13T13:45:21", "name": "[04/36] common/sfc_efx/base: factor out MCDI wrapper to set LEDs", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "77f4d10455d55e5b5747587170189d15a2b596e9", "submitter": { "id": 607, "url": "http://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1602596753-32282-5-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 12916, "url": "http://patches.dpdk.org/api/series/12916/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12916", "date": "2020-10-13T13:45:18", "name": "net/sfc: add EF100 support", "version": 1, "mbox": "http://patches.dpdk.org/series/12916/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/80511/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/80511/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A0EAAA04B7;\n\tTue, 13 Oct 2020 15:46:29 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id CD4E41DB8D;\n\tTue, 13 Oct 2020 15:46:08 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id A7E631DB64\n for <dev@dpdk.org>; Tue, 13 Oct 2020 15:46:01 +0200 (CEST)", "from mx1-us1.ppe-hosted.com (unknown [10.110.50.150])\n by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id\n 48D342005F for <dev@dpdk.org>; Tue, 13 Oct 2020 13:46:00 +0000 (UTC)", "from us4-mdac16-31.at1.mdlocal (unknown [10.110.49.215])\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 46A09800A3\n for <dev@dpdk.org>; Tue, 13 Oct 2020 13:46:00 +0000 (UTC)", "from mx1-us1.ppe-hosted.com (unknown [10.110.49.106])\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n D72E9100071\n for <dev@dpdk.org>; Tue, 13 Oct 2020 13:45:59 +0000 (UTC)", "from webmail.solarflare.com (uk.solarflare.com [193.34.186.16])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n (No client certificate requested)\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n A0766B4006B\n for <dev@dpdk.org>; Tue, 13 Oct 2020 13:45:59 +0000 (UTC)", "from ukex01.SolarFlarecom.com (10.17.10.4) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id\n 15.0.1497.2; Tue, 13 Oct 2020 14:45:55 +0100", "from opal.uk.solarflarecom.com (10.17.10.1) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server id\n 15.0.1497.2 via Frontend Transport; Tue, 13 Oct 2020 14:45:55 +0100", "from ukv-loginhost.uk.solarflarecom.com\n (ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id 09DDjtrX005996\n for <dev@dpdk.org>; Tue, 13 Oct 2020 14:45:55 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id 75ADA1613AB\n for <dev@dpdk.org>; Tue, 13 Oct 2020 14:45:55 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "Date": "Tue, 13 Oct 2020 14:45:21 +0100", "Message-ID": "<1602596753-32282-5-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1602596753-32282-1-git-send-email-arybchenko@solarflare.com>", "References": "<1602596753-32282-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.6.1012-25722.003", "X-TM-AS-Result": "No-2.780200-8.000000-10", "X-TMASE-MatchedRID": "uv6ZDJWKxT6plamT4YpFU60gCFoXW3rv9fvWztwgm5MUFDkgqWz8Dup9\n RpeIFYR42XHJ0L4jOIQs/31GzKkTsQihmwiXCMoGPwKTD1v8YV5MkOX0UoduuVVkJxysad/Ig7l\n N9LOvFDsKc4ljqLtffWgYGQdUi0E8XywERWyRD+6eAiCmPx4NwBnUJ0Ek6yhjxEHRux+uk8hxKp\n vEGAbTDo59f9aQe/k1YmPUBzhyOUoshbQjBnOpNpkvj0f7TL7GbGUThDbINIqPcQWRkU1xjZbj1\n KVgz0HycrwzR2kvOt3NMq8SKT3uJhySoBCeolQDq8uPJC94SFgR06l6KId4N+omcwkrJL7n", "X-TM-AS-User-Approved-Sender": "Yes", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10--2.780200-8.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.6.1012-25722.003", "X-MDID": "1602596760-WlBUoJ4suFUE", "X-PPE-DISP": "1602596760;WlBUoJ4suFUE", "Subject": "[dpdk-dev] [PATCH 04/36] common/sfc_efx/base: factor out MCDI\n\twrapper to set LEDs", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "For consistency it is better to have separate MCDI wrappers.\n\nMake efx_phy_led_mode_t visible even if EFSYS_OPT_PHY_LED_CONTROL\nis disabled to be able to use it in the added wrapper arguments.\n\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\nReviewed-by: Andy Moreton <amoreton@xilinx.com>\n---\n drivers/common/sfc_efx/base/ef10_phy.c | 92 ++++++++++++++++----------\n drivers/common/sfc_efx/base/efx.h | 4 +-\n 2 files changed, 59 insertions(+), 37 deletions(-)", "diff": "diff --git a/drivers/common/sfc_efx/base/ef10_phy.c b/drivers/common/sfc_efx/base/ef10_phy.c\nindex 0005870736..3d07c254bf 100644\n--- a/drivers/common/sfc_efx/base/ef10_phy.c\n+++ b/drivers/common/sfc_efx/base/ef10_phy.c\n@@ -430,6 +430,56 @@ efx_mcdi_phy_set_link(\n \n \treturn (0);\n \n+fail1:\n+\tEFSYS_PROBE1(fail1, efx_rc_t, rc);\n+\n+\treturn (rc);\n+}\n+\n+static\t__checkReturn\tefx_rc_t\n+efx_mcdi_phy_set_led(\n+\t__in\t\tefx_nic_t *enp,\n+\t__in\t\tefx_phy_led_mode_t phy_led_mode)\n+{\n+\tefx_mcdi_req_t req;\n+\tEFX_MCDI_DECLARE_BUF(payload, MC_CMD_SET_ID_LED_IN_LEN,\n+\t\tMC_CMD_SET_ID_LED_OUT_LEN);\n+\tunsigned int led_mode;\n+\tefx_rc_t rc;\n+\n+\treq.emr_cmd = MC_CMD_SET_ID_LED;\n+\treq.emr_in_buf = payload;\n+\treq.emr_in_length = MC_CMD_SET_ID_LED_IN_LEN;\n+\treq.emr_out_buf = payload;\n+\treq.emr_out_length = MC_CMD_SET_ID_LED_OUT_LEN;\n+\n+\tswitch (phy_led_mode) {\n+\tcase EFX_PHY_LED_DEFAULT:\n+\t\tled_mode = MC_CMD_LED_DEFAULT;\n+\t\tbreak;\n+\tcase EFX_PHY_LED_OFF:\n+\t\tled_mode = MC_CMD_LED_OFF;\n+\t\tbreak;\n+\tcase EFX_PHY_LED_ON:\n+\t\tled_mode = MC_CMD_LED_ON;\n+\t\tbreak;\n+\tdefault:\n+\t\tEFSYS_ASSERT(0);\n+\t\tled_mode = MC_CMD_LED_DEFAULT;\n+\t\tbreak;\n+\t}\n+\n+\tMCDI_IN_SET_DWORD(req, SET_ID_LED_IN_STATE, led_mode);\n+\n+\tefx_mcdi_execute(enp, &req);\n+\n+\tif (req.emr_rc != 0) {\n+\t\trc = req.emr_rc;\n+\t\tgoto fail1;\n+\t}\n+\n+\treturn (0);\n+\n fail1:\n \tEFSYS_PROBE1(fail1, efx_rc_t, rc);\n \n@@ -441,15 +491,10 @@ ef10_phy_reconfigure(\n \t__in\t\tefx_nic_t *enp)\n {\n \tefx_port_t *epp = &(enp->en_port);\n-\tefx_mcdi_req_t req;\n-\tEFX_MCDI_DECLARE_BUF(payload, MC_CMD_SET_ID_LED_IN_LEN,\n-\t\tMC_CMD_SET_ID_LED_OUT_LEN);\n \tefx_loopback_type_t loopback_type;\n \tefx_link_mode_t loopback_link_mode;\n \tuint32_t phy_flags;\n-#if EFSYS_OPT_PHY_LED_CONTROL\n-\tunsigned int led_mode;\n-#endif\n+\tefx_phy_led_mode_t phy_led_mode;\n \tboolean_t supported;\n \tefx_rc_t rc;\n \n@@ -477,40 +522,17 @@ ef10_phy_reconfigure(\n \t\tgoto fail2;\n \n \t/* And set the blink mode */\n-\t(void) memset(payload, 0, sizeof (payload));\n-\treq.emr_cmd = MC_CMD_SET_ID_LED;\n-\treq.emr_in_buf = payload;\n-\treq.emr_in_length = MC_CMD_SET_ID_LED_IN_LEN;\n-\treq.emr_out_buf = payload;\n-\treq.emr_out_length = MC_CMD_SET_ID_LED_OUT_LEN;\n \n #if EFSYS_OPT_PHY_LED_CONTROL\n-\tswitch (epp->ep_phy_led_mode) {\n-\tcase EFX_PHY_LED_DEFAULT:\n-\t\tled_mode = MC_CMD_LED_DEFAULT;\n-\t\tbreak;\n-\tcase EFX_PHY_LED_OFF:\n-\t\tled_mode = MC_CMD_LED_OFF;\n-\t\tbreak;\n-\tcase EFX_PHY_LED_ON:\n-\t\tled_mode = MC_CMD_LED_ON;\n-\t\tbreak;\n-\tdefault:\n-\t\tEFSYS_ASSERT(0);\n-\t\tled_mode = MC_CMD_LED_DEFAULT;\n-\t}\n-\n-\tMCDI_IN_SET_DWORD(req, SET_ID_LED_IN_STATE, led_mode);\n+\tphy_led_mode = epp->ep_phy_led_mode;\n #else\n-\tMCDI_IN_SET_DWORD(req, SET_ID_LED_IN_STATE, MC_CMD_LED_DEFAULT);\n-#endif\t/* EFSYS_OPT_PHY_LED_CONTROL */\n-\n-\tefx_mcdi_execute(enp, &req);\n+\tphy_led_mode = EFX_PHY_LED_DEFAULT;\n+#endif\n \n-\tif (req.emr_rc != 0) {\n-\t\trc = req.emr_rc;\n+\trc = efx_mcdi_phy_set_led(enp, phy_led_mode);\n+\tif (rc != 0)\n \t\tgoto fail3;\n-\t}\n+\n out:\n \treturn (0);\n \ndiff --git a/drivers/common/sfc_efx/base/efx.h b/drivers/common/sfc_efx/base/efx.h\nindex 07a7e3c952..a245acfe0f 100644\n--- a/drivers/common/sfc_efx/base/efx.h\n+++ b/drivers/common/sfc_efx/base/efx.h\n@@ -1004,8 +1004,6 @@ extern\t__checkReturn\tefx_rc_t\n efx_phy_verify(\n \t__in\t\tefx_nic_t *enp);\n \n-#if EFSYS_OPT_PHY_LED_CONTROL\n-\n typedef enum efx_phy_led_mode_e {\n \tEFX_PHY_LED_DEFAULT = 0,\n \tEFX_PHY_LED_OFF,\n@@ -1014,6 +1012,8 @@ typedef enum efx_phy_led_mode_e {\n \tEFX_PHY_LED_NMODES\n } efx_phy_led_mode_t;\n \n+#if EFSYS_OPT_PHY_LED_CONTROL\n+\n LIBEFX_API\n extern\t__checkReturn\tefx_rc_t\n efx_phy_led_set(\n", "prefixes": [ "04/36" ] }