Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/80058/?format=api
{ "id": 80058, "url": "http://patches.dpdk.org/api/patches/80058/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1602166620-46303-2-git-send-email-bingz@nvidia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1602166620-46303-2-git-send-email-bingz@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1602166620-46303-2-git-send-email-bingz@nvidia.com", "date": "2020-10-08T14:16:57", "name": "[1/4] net/mlx5: remove hairpin queue peer port checking", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "568bcaf57b66314314f36ab4484269a10e7e9966", "submitter": { "id": 1976, "url": "http://patches.dpdk.org/api/people/1976/?format=api", "name": "Bing Zhao", "email": "bingz@nvidia.com" }, "delegate": { "id": 3268, "url": "http://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1602166620-46303-2-git-send-email-bingz@nvidia.com/mbox/", "series": [ { "id": 12783, "url": "http://patches.dpdk.org/api/series/12783/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12783", "date": "2020-10-08T14:16:56", "name": "add two ports hairpin mode support in mlx5 PMD", "version": 1, "mbox": "http://patches.dpdk.org/series/12783/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/80058/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/80058/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E7B97A04BC;\n\tThu, 8 Oct 2020 16:17:32 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1EC1F1C121;\n\tThu, 8 Oct 2020 16:17:15 +0200 (CEST)", "from git-send-mailer.rdmz.labs.mlnx (unknown [37.142.13.130])\n by dpdk.org (Postfix) with ESMTP id 5C3F11C117\n for <dev@dpdk.org>; Thu, 8 Oct 2020 16:17:14 +0200 (CEST)" ], "From": "Bing Zhao <bingz@nvidia.com>", "To": "viacheslavo@mellanox.com,\n\tmatan@mellanox.com", "Cc": "dev@dpdk.org,\n\torika@nvidia.com,\n\trasland@nvidia.com", "Date": "Thu, 8 Oct 2020 22:16:57 +0800", "Message-Id": "<1602166620-46303-2-git-send-email-bingz@nvidia.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1602166620-46303-1-git-send-email-bingz@nvidia.com>", "References": "<1602166620-46303-1-git-send-email-bingz@nvidia.com>", "Subject": "[dpdk-dev] [PATCH 1/4] net/mlx5: remove hairpin queue peer port\n\tchecking", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "In the current implementation of single port mode hairpin, the peer\nqueue should belong to the same port of the current port. When two\nports hairpin mode is introduced, the checking should be removed to\nmake the hairpin queue setup execute successfully.\n\nSigned-off-by: Bing Zhao <bingz@nvidia.com>\n---\n drivers/net/mlx5/mlx5_rxq.c | 4 +---\n drivers/net/mlx5/mlx5_txq.c | 4 +---\n 2 files changed, 2 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c\nindex f1d8373..66abce7 100644\n--- a/drivers/net/mlx5/mlx5_rxq.c\n+++ b/drivers/net/mlx5/mlx5_rxq.c\n@@ -776,9 +776,7 @@\n \tres = mlx5_rx_queue_pre_setup(dev, idx, &desc);\n \tif (res)\n \t\treturn res;\n-\tif (hairpin_conf->peer_count != 1 ||\n-\t hairpin_conf->peers[0].port != dev->data->port_id ||\n-\t hairpin_conf->peers[0].queue >= priv->txqs_n) {\n+\tif (hairpin_conf->peer_count != 1) {\n \t\tDRV_LOG(ERR, \"port %u unable to setup hairpin queue index %u \"\n \t\t\t\" invalid hairpind configuration\", dev->data->port_id,\n \t\t\tidx);\ndiff --git a/drivers/net/mlx5/mlx5_txq.c b/drivers/net/mlx5/mlx5_txq.c\nindex af84f5f..17a9f5a 100644\n--- a/drivers/net/mlx5/mlx5_txq.c\n+++ b/drivers/net/mlx5/mlx5_txq.c\n@@ -421,9 +421,7 @@\n \tres = mlx5_tx_queue_pre_setup(dev, idx, &desc);\n \tif (res)\n \t\treturn res;\n-\tif (hairpin_conf->peer_count != 1 ||\n-\t hairpin_conf->peers[0].port != dev->data->port_id ||\n-\t hairpin_conf->peers[0].queue >= priv->rxqs_n) {\n+\tif (hairpin_conf->peer_count != 1) {\n \t\tDRV_LOG(ERR, \"port %u unable to setup hairpin queue index %u \"\n \t\t\t\" invalid hairpind configuration\", dev->data->port_id,\n \t\t\tidx);\n", "prefixes": [ "1/4" ] }