Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/79847/?format=api
{ "id": 79847, "url": "http://patches.dpdk.org/api/patches/79847/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1cad32e57c8081477a0f448b5b3d61711ef6b382.1602060933.git.wangyunjian@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1cad32e57c8081477a0f448b5b3d61711ef6b382.1602060933.git.wangyunjian@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1cad32e57c8081477a0f448b5b3d61711ef6b382.1602060933.git.wangyunjian@huawei.com", "date": "2020-10-07T09:03:38", "name": "baseband/turbo_sw: fix memory leak in error path", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "8fb2d3a5649a5e5f118f534a388188442195dde2", "submitter": { "id": 551, "url": "http://patches.dpdk.org/api/people/551/?format=api", "name": "Yunjian Wang", "email": "wangyunjian@huawei.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1cad32e57c8081477a0f448b5b3d61711ef6b382.1602060933.git.wangyunjian@huawei.com/mbox/", "series": [ { "id": 12739, "url": "http://patches.dpdk.org/api/series/12739/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12739", "date": "2020-10-07T09:03:38", "name": "baseband/turbo_sw: fix memory leak in error path", "version": 1, "mbox": "http://patches.dpdk.org/series/12739/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/79847/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/79847/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6A253A04BA;\n\tWed, 7 Oct 2020 11:03:54 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6D1B71B3C8;\n\tWed, 7 Oct 2020 11:03:52 +0200 (CEST)", "from huawei.com (szxga05-in.huawei.com [45.249.212.191])\n by dpdk.org (Postfix) with ESMTP id 0EC1E4C9D;\n Wed, 7 Oct 2020 11:03:50 +0200 (CEST)", "from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.59])\n by Forcepoint Email with ESMTP id 3CE5134EE7B42771500D;\n Wed, 7 Oct 2020 17:03:47 +0800 (CST)", "from localhost (10.174.187.156) by DGGEMS408-HUB.china.huawei.com\n (10.3.19.208) with Microsoft SMTP Server id 14.3.487.0; Wed, 7 Oct 2020\n 17:03:39 +0800" ], "From": "wangyunjian <wangyunjian@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<nicolas.chautru@intel.com>, <jerry.lilijun@huawei.com>,\n <xudingke@huawei.com>, Yunjian Wang <wangyunjian@huawei.com>,\n <stable@dpdk.org>", "Date": "Wed, 7 Oct 2020 17:03:38 +0800", "Message-ID": "\n <1cad32e57c8081477a0f448b5b3d61711ef6b382.1602060933.git.wangyunjian@huawei.com>", "X-Mailer": "git-send-email 1.9.5.msysgit.1", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.174.187.156]", "X-CFilter-Loop": "Reflected", "Subject": "[dpdk-dev] [PATCH] baseband/turbo_sw: fix memory leak in error path", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Yunjian Wang <wangyunjian@huawei.com>\n\nIn q_setup() allocated memory for the queue data, we should free\nit when error happens, otherwise it will lead to memory leak.\n\nFixes: b8cfe2c9aed2 (\"bb/turbo_sw: add software turbo driver\")\nCc: stable@dpdk.org\n\nSigned-off-by: Yunjian Wang <wangyunjian@huawei.com>\n---\n drivers/baseband/turbo_sw/bbdev_turbo_software.c | 16 ++++++++--------\n 1 file changed, 8 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/baseband/turbo_sw/bbdev_turbo_software.c b/drivers/baseband/turbo_sw/bbdev_turbo_software.c\nindex a36099e91..e55b32927 100644\n--- a/drivers/baseband/turbo_sw/bbdev_turbo_software.c\n+++ b/drivers/baseband/turbo_sw/bbdev_turbo_software.c\n@@ -302,7 +302,7 @@ q_setup(struct rte_bbdev *dev, uint16_t q_id,\n \t\trte_bbdev_log(ERR,\n \t\t\t\t\"Creating queue name for device %u queue %u failed\",\n \t\t\t\tdev->data->dev_id, q_id);\n-\t\treturn -ENAMETOOLONG;\n+\t\tgoto free_q;\n \t}\n \tq->enc_out = rte_zmalloc_socket(name,\n \t\t\t((RTE_BBDEV_TURBO_MAX_TB_SIZE >> 3) + 3) *\n@@ -322,7 +322,7 @@ q_setup(struct rte_bbdev *dev, uint16_t q_id,\n \t\trte_bbdev_log(ERR,\n \t\t\t\t\"Creating queue name for device %u queue %u failed\",\n \t\t\t\tdev->data->dev_id, q_id);\n-\t\treturn -ENAMETOOLONG;\n+\t\tgoto free_q;\n \t}\n \tq->enc_in = rte_zmalloc_socket(name,\n \t\t\t(RTE_BBDEV_LDPC_MAX_CB_SIZE >> 3) * sizeof(*q->enc_in),\n@@ -340,7 +340,7 @@ q_setup(struct rte_bbdev *dev, uint16_t q_id,\n \t\trte_bbdev_log(ERR,\n \t\t\t\t\"Creating queue name for device %u queue %u failed\",\n \t\t\t\tdev->data->dev_id, q_id);\n-\t\treturn -ENAMETOOLONG;\n+\t\tgoto free_q;\n \t}\n \tq->ag = rte_zmalloc_socket(name,\n \t\t\tRTE_BBDEV_TURBO_MAX_CB_SIZE * 10 * sizeof(*q->ag),\n@@ -358,7 +358,7 @@ q_setup(struct rte_bbdev *dev, uint16_t q_id,\n \t\trte_bbdev_log(ERR,\n \t\t\t\t\"Creating queue name for device %u queue %u failed\",\n \t\t\t\tdev->data->dev_id, q_id);\n-\t\treturn -ENAMETOOLONG;\n+\t\tgoto free_q;\n \t}\n \tq->code_block = rte_zmalloc_socket(name,\n \t\t\tRTE_BBDEV_TURBO_MAX_CB_SIZE * sizeof(*q->code_block),\n@@ -377,7 +377,7 @@ q_setup(struct rte_bbdev *dev, uint16_t q_id,\n \t\trte_bbdev_log(ERR,\n \t\t\t\t\"Creating queue name for device %u queue %u failed\",\n \t\t\t\tdev->data->dev_id, q_id);\n-\t\treturn -ENAMETOOLONG;\n+\t\tgoto free_q;\n \t}\n \tq->deint_input = rte_zmalloc_socket(name,\n \t\t\tDEINT_INPUT_BUF_SIZE * sizeof(*q->deint_input),\n@@ -396,7 +396,7 @@ q_setup(struct rte_bbdev *dev, uint16_t q_id,\n \t\trte_bbdev_log(ERR,\n \t\t\t\t\"Creating queue name for device %u queue %u failed\",\n \t\t\t\tdev->data->dev_id, q_id);\n-\t\treturn -ENAMETOOLONG;\n+\t\tgoto free_q;\n \t}\n \tq->deint_output = rte_zmalloc_socket(NULL,\n \t\t\tDEINT_OUTPUT_BUF_SIZE * sizeof(*q->deint_output),\n@@ -415,7 +415,7 @@ q_setup(struct rte_bbdev *dev, uint16_t q_id,\n \t\trte_bbdev_log(ERR,\n \t\t\t\t\"Creating queue name for device %u queue %u failed\",\n \t\t\t\tdev->data->dev_id, q_id);\n-\t\treturn -ENAMETOOLONG;\n+\t\tgoto free_q;\n \t}\n \tq->adapter_output = rte_zmalloc_socket(NULL,\n \t\t\tADAPTER_OUTPUT_BUF_SIZE * sizeof(*q->adapter_output),\n@@ -433,7 +433,7 @@ q_setup(struct rte_bbdev *dev, uint16_t q_id,\n \t\trte_bbdev_log(ERR,\n \t\t\t\t\"Creating queue name for device %u queue %u failed\",\n \t\t\t\tdev->data->dev_id, q_id);\n-\t\treturn -ENAMETOOLONG;\n+\t\tgoto free_q;\n \t}\n \tq->processed_pkts = rte_ring_create(name, queue_conf->queue_size,\n \t\t\tqueue_conf->socket, RING_F_SP_ENQ | RING_F_SC_DEQ);\n", "prefixes": [] }