Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/79555/?format=api
{ "id": 79555, "url": "http://patches.dpdk.org/api/patches/79555/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201002155855.622456-5-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201002155855.622456-5-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201002155855.622456-5-bruce.richardson@intel.com", "date": "2020-10-02T15:58:51", "name": "[RFC,v2,4/8] qat: build from common folder", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "023a7ad19f0316ba58951a814f8980e905b973e9", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201002155855.622456-5-bruce.richardson@intel.com/mbox/", "series": [ { "id": 12672, "url": "http://patches.dpdk.org/api/series/12672/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12672", "date": "2020-10-02T15:58:47", "name": "Rework build macros", "version": 2, "mbox": "http://patches.dpdk.org/series/12672/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/79555/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/79555/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A7868A04BA;\n\tFri, 2 Oct 2020 18:00:48 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 09F741DA75;\n\tFri, 2 Oct 2020 17:59:38 +0200 (CEST)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n by dpdk.org (Postfix) with ESMTP id 3C1E91D9FC\n for <dev@dpdk.org>; Fri, 2 Oct 2020 17:59:35 +0200 (CEST)", "from orsmga003.jf.intel.com ([10.7.209.27])\n by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 02 Oct 2020 08:59:34 -0700", "from silpixa00399126.ir.intel.com ([10.237.222.4])\n by orsmga003.jf.intel.com with ESMTP; 02 Oct 2020 08:59:33 -0700" ], "IronPort-SDR": [ "\n ey0GKNUS3NSIEEhdK9Ax9oaZF7YC/BnZmRwtvOfBL19BqneCP1mUCEQo66IrQY7F6nxUpTnFac\n cS381UYdD96g==", "\n ubwaFa7QQZkqr+tXZsQssn2b9qmOAx4yEgXgORDq88rYNhTxtvzggKBeKqD5sdqDtMt6arkXhk\n S5TBKemOCtFA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9762\"; a=\"163115264\"", "E=Sophos;i=\"5.77,328,1596524400\"; d=\"scan'208\";a=\"163115264\"", "E=Sophos;i=\"5.77,328,1596524400\"; d=\"scan'208\";a=\"309069010\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "david.marchand@redhat.com, arybchenko@solarflare.com,\n ferruh.yigit@intel.com, thomas@monjalon.net,\n Bruce Richardson <bruce.richardson@intel.com>", "Date": "Fri, 2 Oct 2020 16:58:51 +0100", "Message-Id": "<20201002155855.622456-5-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20201002155855.622456-1-bruce.richardson@intel.com>", "References": "<20200916164429.244847-1-bruce.richardson@intel.com>\n <20201002155855.622456-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [RFC PATCH v2 4/8] qat: build from common folder", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Since the drivers in the common directory can be processed out of order, in\nthis case following the \"bus\" directory, we can simplify somewhat the build\nof the QAT driver to be done entirely from the \"common/qat\" folder rather\nthan having it's build distributed across 3 folders.\n\nThis also opens up the possibility of building the QAT driver with crypto\nonly and the compression part disabled. It further allows more sensible\nnaming of the resulting shared library in case of standardizing library\nnames based on device class; i.e. common_qat is more descriptive for a\ncombined crypto/compression driver than either of the other two prefixes\nindividually.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n drivers/common/meson.build | 2 +-\n drivers/common/qat/meson.build | 69 ++++++++++++++++---\n .../qat/rte_common_qat_version.map} | 0\n drivers/compress/meson.build | 2 +-\n drivers/compress/qat/meson.build | 17 -----\n drivers/crypto/meson.build | 1 -\n drivers/crypto/qat/meson.build | 23 -------\n drivers/meson.build | 1 +\n 8 files changed, 63 insertions(+), 52 deletions(-)\n rename drivers/{compress/qat/rte_pmd_qat_version.map => common/qat/rte_common_qat_version.map} (100%)\n delete mode 100644 drivers/compress/qat/meson.build\n delete mode 100644 drivers/crypto/qat/meson.build", "diff": "diff --git a/drivers/common/meson.build b/drivers/common/meson.build\nindex 7ac1ca73a2..abb4f1529a 100644\n--- a/drivers/common/meson.build\n+++ b/drivers/common/meson.build\n@@ -6,6 +6,6 @@ if is_windows\n endif\n \n std_deps = ['eal']\n-drivers = ['cpt', 'dpaax', 'iavf', 'mvep', 'octeontx', 'octeontx2', 'qat', 'sfc_efx']\n+drivers = ['cpt', 'dpaax', 'iavf', 'mvep', 'octeontx', 'octeontx2', 'sfc_efx']\n config_flag_fmt = 'RTE_LIBRTE_@0@_COMMON'\n driver_name_fmt = 'rte_common_@0@'\ndiff --git a/drivers/common/qat/meson.build b/drivers/common/qat/meson.build\nindex 8de2492893..3409162d03 100644\n--- a/drivers/common/qat/meson.build\n+++ b/drivers/common/qat/meson.build\n@@ -1,15 +1,66 @@\n # SPDX-License-Identifier: BSD-3-Clause\n # Copyright(c) 2017-2018 Intel Corporation\n \n-# This does not build a driver, but instead holds common files for\n-# the crypto and compression drivers.\n-build = false\n-reason = '' # sentinal value to suppress printout\n-qat_deps = ['bus_pci']\n-qat_sources = files('qat_common.c',\n+config_flag_fmt = 'RTE_LIBRTE_@0@_COMMON'\n+driver_name_fmt = 'rte_common_@0@'\n+\n+qat_crypto = true\n+qat_crypto_path = 'crypto/qat'\n+qat_crypto_relpath = '../../' + qat_crypto_path\n+qat_compress = true\n+qat_compress_path = 'compress/qat'\n+qat_compress_relpath = '../../' + qat_compress_path\n+\n+if disabled_drivers.contains(qat_crypto_path)\n+\tqat_crypto = false\n+\tdpdk_drvs_disabled += qat_crypto_path\n+\tset_variable(qat_crypto_path.underscorify() + '_disable_reason',\n+\t\t\t'Explicitly disabled via build config')\n+endif\n+if disabled_drivers.contains(qat_compress_path)\n+\tqat_compress = false\n+\tdpdk_drvs_disabled += qat_compress_path\n+\tset_variable(qat_compress_path.underscorify() + '_disable_reason',\n+\t\t\t'Explicitly disabled via build config')\n+endif\n+\n+libcrypto = dependency('libcrypto', required: false)\n+if qat_crypto and not libcrypto.found()\n+\tqat_crypto = false\n+\tdpdk_drvs_disabled += qat_crypto_path\n+\tset_variable(qat_crypto_path.underscorify() + '_disable_reason',\n+\t\t\t'missing dependency, libcrypto')\n+endif\n+\n+# The driver should not build if both compression and crypto are disabled\n+#FIXME common code depends on compression files so check only compress!\n+if not qat_compress # and not qat_crypto\n+\tbuild = false\n+\treason = '' # rely on reason for compress/crypto above\n+\tsubdir_done()\n+endif\n+\n+deps += ['bus_pci', 'cryptodev', 'net', 'compressdev']\n+sources += files('qat_common.c',\n \t\t'qat_qp.c',\n \t\t'qat_device.c',\n \t\t'qat_logs.c')\n-qat_includes = [include_directories('.', 'qat_adf')]\n-qat_ext_deps = []\n-qat_cflags = []\n+includes += include_directories('qat_adf',\n+\t\tqat_crypto_relpath,\n+\t\tqat_compress_relpath)\n+\n+if qat_compress\n+\tforeach f: ['qat_comp_pmd.c', 'qat_comp.c']\n+\t\tsources += files(join_paths(qat_compress_relpath, f))\n+\tendforeach\n+endif\n+\n+if qat_crypto\n+\tforeach f: ['qat_sym_pmd.c', 'qat_sym.c', 'qat_sym_session.c',\n+\t\t\t'qat_asym_pmd.c', 'qat_asym.c']\n+\t\tsources += files(join_paths(qat_crypto_relpath, f))\n+\tendforeach\n+\tdeps += ['security']\n+\text_deps += libcrypto\n+\tcflags += ['-DBUILD_QAT_SYM', '-DBUILD_QAT_ASYM']\n+endif\ndiff --git a/drivers/compress/qat/rte_pmd_qat_version.map b/drivers/common/qat/rte_common_qat_version.map\nsimilarity index 100%\nrename from drivers/compress/qat/rte_pmd_qat_version.map\nrename to drivers/common/qat/rte_common_qat_version.map\ndiff --git a/drivers/compress/meson.build b/drivers/compress/meson.build\nindex bea1720a0b..3a4723c0ce 100644\n--- a/drivers/compress/meson.build\n+++ b/drivers/compress/meson.build\n@@ -5,7 +5,7 @@ if is_windows\n \tsubdir_done()\n endif\n \n-drivers = ['isal', 'octeontx', 'qat', 'zlib']\n+drivers = ['isal', 'octeontx', 'zlib']\n \n std_deps = ['compressdev'] # compressdev pulls in all other needed deps\n config_flag_fmt = 'RTE_LIBRTE_PMD_@0@'\ndiff --git a/drivers/compress/qat/meson.build b/drivers/compress/qat/meson.build\ndeleted file mode 100644\nindex a002469809..0000000000\n--- a/drivers/compress/qat/meson.build\n+++ /dev/null\n@@ -1,17 +0,0 @@\n-# SPDX-License-Identifier: BSD-3-Clause\n-# Copyright(c) 2017-2018 Intel Corporation\n-\n-\n-# Add our sources files to the list\n-qat_sources += files('qat_comp_pmd.c',\n-\t\t 'qat_comp.c')\n-qat_includes += include_directories('.')\n-qat_deps += 'compressdev'\n-qat_ext_deps += dep\n-\n-# build the whole driver\n-sources += qat_sources\n-cflags += qat_cflags\n-deps += qat_deps\n-ext_deps += qat_ext_deps\n-includes += qat_includes\ndiff --git a/drivers/crypto/meson.build b/drivers/crypto/meson.build\nindex 25b99c19cb..bd7a940e6d 100644\n--- a/drivers/crypto/meson.build\n+++ b/drivers/crypto/meson.build\n@@ -19,7 +19,6 @@ drivers = ['aesni_gcm',\n \t 'octeontx',\n \t 'octeontx2',\n \t 'openssl',\n-\t 'qat',\n \t 'scheduler',\n \t 'snow3g',\n \t 'virtio',\ndiff --git a/drivers/crypto/qat/meson.build b/drivers/crypto/qat/meson.build\ndeleted file mode 100644\nindex a225f374a6..0000000000\n--- a/drivers/crypto/qat/meson.build\n+++ /dev/null\n@@ -1,23 +0,0 @@\n-# SPDX-License-Identifier: BSD-3-Clause\n-# Copyright(c) 2017-2018 Intel Corporation\n-\n-# this does not build the QAT driver, instead that is done in the compression\n-# driver which comes later. Here we just add our sources files to the list\n-build = false\n-reason = '' # sentinal value to suppress printout\n-dep = dependency('libcrypto', required: false)\n-qat_includes += include_directories('.')\n-qat_deps += 'cryptodev'\n-qat_deps += 'net'\n-qat_deps += 'security'\n-if dep.found()\n-\t# Add our sources files to the list\n-\tqat_sources += files('qat_sym_pmd.c',\n-\t\t\t 'qat_sym.c',\n-\t\t\t 'qat_sym_session.c',\n-\t\t\t 'qat_asym_pmd.c',\n-\t\t\t 'qat_asym.c')\n-\tqat_ext_deps += dep\n-\tqat_cflags += '-DBUILD_QAT_SYM'\n-\tqat_cflags += '-DBUILD_QAT_ASYM'\n-endif\ndiff --git a/drivers/meson.build b/drivers/meson.build\nindex b5ac483d31..b95b005839 100644\n--- a/drivers/meson.build\n+++ b/drivers/meson.build\n@@ -6,6 +6,7 @@ subdirs = [\n \t'common',\n \t'bus',\n \t'common/mlx5', # depends on bus.\n+\t'common/qat', # depends on bus.\n \t'mempool', # depends on common and bus.\n \t'net', # depends on common, bus, mempool\n \t'raw', # depends on common, bus and net.\n", "prefixes": [ "RFC", "v2", "4/8" ] }