Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/79094/?format=api
{ "id": 79094, "url": "http://patches.dpdk.org/api/patches/79094/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200928231437.414489-29-thomas@monjalon.net/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200928231437.414489-29-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20200928231437.414489-29-thomas@monjalon.net", "date": "2020-09-28T23:14:36", "name": "[v3,28/29] ethdev: reset all when releasing a port", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "2b461a1cc271ef83c364df50e655fdee1d43b411", "submitter": { "id": 685, "url": "http://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200928231437.414489-29-thomas@monjalon.net/mbox/", "series": [ { "id": 12565, "url": "http://patches.dpdk.org/api/series/12565/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12565", "date": "2020-09-28T23:14:08", "name": "cleanup ethdev close operation", "version": 3, "mbox": "http://patches.dpdk.org/series/12565/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/79094/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/79094/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 126F5A04C0;\n\tTue, 29 Sep 2020 01:23:51 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 955AC1D923;\n\tTue, 29 Sep 2020 01:16:46 +0200 (CEST)", "from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com\n [66.111.4.224]) by dpdk.org (Postfix) with ESMTP id B9A3F1DA39\n for <dev@dpdk.org>; Tue, 29 Sep 2020 01:16:06 +0200 (CEST)", "from compute7.internal (compute7.nyi.internal [10.202.2.47])\n by mailnew.nyi.internal (Postfix) with ESMTP id 5B09C580790;\n Mon, 28 Sep 2020 19:16:05 -0400 (EDT)", "from mailfrontend2 ([10.202.2.163])\n by compute7.internal (MEProxy); Mon, 28 Sep 2020 19:16:05 -0400", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n by mail.messagingengine.com (Postfix) with ESMTPA id 12CD93064680;\n Mon, 28 Sep 2020 19:15:59 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding; s=fm2; bh=4HyhoCf0D+CKE\n 5k7i+eTSpNHIfewXflfxF+eU0bm5sw=; b=iBWo0X0mcGkOWHvnN2ht5DsRKO4P6\n heEBgVKLqtq0jZcWz/JcRwERthQ/5u/9N+0zA6XRn4axUMORQayP/LWlz9alZDMo\n Upvpa4DAn5LoJK1zcD7P8qkJGZTegJhNjj93rnLqRKrXFcyuJRXj7fJRucc8Myq9\n yXdmL8Weirh0VJ4xPqfWZ5Ojrr6YqAlJcQaRmdCICs9huNjOBd494Jec+w2p2KSH\n ZtLzxfNScVg8Lsneu1cdUJumJw3QMaoWUNLmKGgdc/uRnVoJIL/DQP5ZrkgwXeqM\n Z4SYbfDtwsQimJUgvw5J0JkZvFY2v+7cDHPuQ3QH/Uf2Tr2cx6v6YI6pQ==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:content-transfer-encoding:date:from\n :in-reply-to:message-id:mime-version:references:subject:to\n :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=\n fm3; bh=4HyhoCf0D+CKE5k7i+eTSpNHIfewXflfxF+eU0bm5sw=; b=mhoyfoBA\n 8XnmyhL3rjRSAvZ3nTr3arouNi0irbq3IYbl6I1M2WiI/RIA7lwGSK4diMeVuX2D\n Il0AhCXlL9w2M0B65323ixxH/3oYX72DsBl/QNI1g2Dw1Cy3Pd4DI60vKTlhRUyc\n /jss/oYGOV0qhEwUjnhuufp/xUaR8LdaOzVhawKRw/n/NxLRXgAn22S8OHoAh62C\n eZle3ysj8bdcZKwJUDcHDshz4k/XuxRMFEbIdPqTr7golWx7y5dRt6WXFEnDcvij\n fQ1qfiySb9DmoVg5d+uC6ANzNUv7oVMH/DSX63XZPi4i7h6R8cKCvuevKyC1+Xhs\n +8xnu+XSn41pYA==" ], "X-ME-Sender": "<xms:tG5yX3bV9L9zMHHNRlMgT6ifZZ-KTKPJW1AFK9ijjqD5AgssvpvZaw>\n <xme:tG5yX2YDxRdPeEK3awq6kE0UywPDBi-e1av_jpN0XsFZjh9kpvmQQIUvYFxgKr41X\n RdJRBxvWBurhhnc7Q>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgedujedrvdejgddulecutefuodetggdotefrodftvf\n curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu\n uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc\n fjughrpefhvffufffkofgjfhgggfestdekredtredttdenucfhrhhomhepvfhhohhmrghs\n ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf\n frrghtthgvrhhnpedvhefgiedvjeegtdevheefhfetleefgfeivefgffevfeejgedtgfeu\n tdehtdegveenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih\n iivgepvdelnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl\n ohhnrdhnvght", "X-ME-Proxy": "<xmx:tG5yX59uWK1E6fI1qo-P0MyhvPYT9PeXJExzb1EDcUtEFg10CtOz3Q>\n <xmx:tG5yX9pfgWOYpYFnaR5rvdHu3AVystD85GpwXJOqavc_PmGAUlHSYg>\n <xmx:tG5yXypwbz-5jhmGLfkooyn7USG9hd5tOQ5TF6Q6Tu0xyGS2YtBP3w>\n <xmx:tW5yX9EOjllmtWqYMfbie6ltrQCdLWtqdlLPijiIu9lczd0ueDGeFA>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com,\tarybchenko@solarflare.com,\n Shepard Siegel <shepard.siegel@atomicrules.com>,\n Ed Czeck <ed.czeck@atomicrules.com>,\n John Miller <john.miller@atomicrules.com>,\n Igor Russkikh <igor.russkikh@aquantia.com>,\n Pavel Belous <pavel.belous@aquantia.com>,\n Somalapuram Amaranath <asomalap@amd.com>,\n Ajit Khaparde <ajit.khaparde@broadcom.com>,\n Somnath Kotur <somnath.kotur@broadcom.com>, Chas Williams <chas3@att.com>,\n \"Wei Hu (Xavier)\" <xavier.huwei@huawei.com>,\n Hemant Agrawal <hemant.agrawal@nxp.com>,\n Sachin Saxena <sachin.saxena@oss.nxp.com>,\tJeff Guo <jia.guo@intel.com>,\n Haiyue Wang <haiyue.wang@intel.com>,\tMarcin Wojtas <mw@semihalf.com>,\n Michal Krawczyk <mk@semihalf.com>,\tGuy Tzalik <gtzalik@amazon.com>,\n Evgeny Schemeilin <evgenys@amazon.com>,\n Igor Chauskin <igorch@amazon.com>,\tQi Zhang <qi.z.zhang@intel.com>,\n Xiao Wang <xiao.w.wang@intel.com>,\tZiyang Xuan <xuanziyang2@huawei.com>,\n Xiaoyun Wang <cloud.wangxiaoyun@huawei.com>,\n Guoyang Zhou <zhouguoyang@huawei.com>,\n \"Min Hu (Connor)\" <humin29@huawei.com>,\n Yisen Zhuang <yisen.zhuang@huawei.com>,\n Beilei Xing <beilei.xing@intel.com>,\tJingjing Wu <jingjing.wu@intel.com>,\n Qiming Yang <qiming.yang@intel.com>,\n Alfredo Cardigliano <cardigliano@ntop.org>,\n Shijith Thotton <sthotton@marvell.com>,\n Srisivasubramanian Srinivasan <srinivasan@marvell.com>,\n Stephen Hemminger <sthemmin@microsoft.com>,\n \"K. Y. Srinivasan\" <kys@microsoft.com>,\n Haiyang Zhang <haiyangz@microsoft.com>,\tLong Li <longli@microsoft.com>,\n Harman Kalra <hkalra@marvell.com>,\tRasesh Mody <rmody@marvell.com>,\n Shahed Shaikh <shshaikh@marvell.com>, Keith Wiles <keith.wiles@intel.com>,\n Maxime Coquelin <maxime.coquelin@redhat.com>,\n Chenbo Xia <chenbo.xia@intel.com>,\tZhihong Wang <zhihong.wang@intel.com>,\n Yong Wang <yongwang@vmware.com>", "Date": "Tue, 29 Sep 2020 01:14:36 +0200", "Message-Id": "<20200928231437.414489-29-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20200928231437.414489-1-thomas@monjalon.net>", "References": "<20200913220711.3768597-1-thomas@monjalon.net>\n <20200928231437.414489-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 28/29] ethdev: reset all when releasing a port", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The function rte_eth_dev_release_port() was resetting partially\nthe struct rte_eth_dev. The drivers were completing it\nwith more pointers set to NULL in the close or remove operations.\n\nA full memset is done so most of those assignments become useless.\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\n---\n drivers/net/ark/ark_ethdev.c | 3 ---\n drivers/net/atlantic/atl_ethdev.c | 4 ----\n drivers/net/axgbe/axgbe_ethdev.c | 3 ---\n drivers/net/bnxt/bnxt_ethdev.c | 4 ----\n drivers/net/bnxt/bnxt_reps.c | 1 -\n drivers/net/bonding/rte_eth_bond_pmd.c | 4 ----\n drivers/net/dpaa/dpaa_ethdev.c | 4 ----\n drivers/net/dpaa2/dpaa2_ethdev.c | 4 ----\n drivers/net/e1000/em_ethdev.c | 4 ----\n drivers/net/e1000/igb_ethdev.c | 8 --------\n drivers/net/ena/ena_ethdev.c | 5 -----\n drivers/net/fm10k/fm10k_ethdev.c | 4 ----\n drivers/net/hinic/hinic_pmd_ethdev.c | 4 ----\n drivers/net/hns3/hns3_ethdev.c | 4 ----\n drivers/net/hns3/hns3_ethdev_vf.c | 5 -----\n drivers/net/i40e/i40e_ethdev.c | 4 ----\n drivers/net/i40e/i40e_ethdev_vf.c | 4 ----\n drivers/net/iavf/iavf_ethdev.c | 4 ----\n drivers/net/ice/ice_dcf_ethdev.c | 4 ----\n drivers/net/ice/ice_ethdev.c | 4 ----\n drivers/net/ionic/ionic_ethdev.c | 5 -----\n drivers/net/ixgbe/ixgbe_ethdev.c | 8 --------\n drivers/net/liquidio/lio_ethdev.c | 4 ----\n drivers/net/netvsc/hn_ethdev.c | 4 ----\n drivers/net/octeontx/octeontx_ethdev.c | 3 ---\n drivers/net/qede/qede_ethdev.c | 4 ----\n drivers/net/sfc/sfc_ethdev.c | 7 +------\n drivers/net/tap/rte_eth_tap.c | 1 -\n drivers/net/virtio/virtio_ethdev.c | 4 ----\n drivers/net/vmxnet3/vmxnet3_ethdev.c | 5 -----\n lib/librte_ethdev/rte_ethdev.c | 5 +----\n 31 files changed, 2 insertions(+), 129 deletions(-)", "diff": "diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c\nindex e3b1347769..cfcfe5c42f 100644\n--- a/drivers/net/ark/ark_ethdev.c\n+++ b/drivers/net/ark/ark_ethdev.c\n@@ -504,9 +504,6 @@ eth_ark_dev_uninit(struct rte_eth_dev *dev)\n \tark_pktgen_uninit(ark->pg);\n \tark_pktchkr_uninit(ark->pc);\n \n-\tdev->dev_ops = NULL;\n-\tdev->rx_pkt_burst = NULL;\n-\tdev->tx_pkt_burst = NULL;\n \treturn 0;\n }\n \ndiff --git a/drivers/net/atlantic/atl_ethdev.c b/drivers/net/atlantic/atl_ethdev.c\nindex 2217511ca0..5cc41c2b61 100644\n--- a/drivers/net/atlantic/atl_ethdev.c\n+++ b/drivers/net/atlantic/atl_ethdev.c\n@@ -701,10 +701,6 @@ atl_dev_close(struct rte_eth_dev *dev)\n \n \tatl_free_queues(dev);\n \n-\tdev->dev_ops = NULL;\n-\tdev->rx_pkt_burst = NULL;\n-\tdev->tx_pkt_burst = NULL;\n-\n \t/* disable uio intr before callback unregister */\n \trte_intr_disable(intr_handle);\n \trte_intr_callback_unregister(intr_handle,\ndiff --git a/drivers/net/axgbe/axgbe_ethdev.c b/drivers/net/axgbe/axgbe_ethdev.c\nindex cf085487cc..39087f36f0 100644\n--- a/drivers/net/axgbe/axgbe_ethdev.c\n+++ b/drivers/net/axgbe/axgbe_ethdev.c\n@@ -2134,9 +2134,6 @@ axgbe_dev_close(struct rte_eth_dev *eth_dev)\n \t\treturn 0;\n \n \tpci_dev = RTE_DEV_TO_PCI(eth_dev->device);\n-\teth_dev->dev_ops = NULL;\n-\teth_dev->rx_pkt_burst = NULL;\n-\teth_dev->tx_pkt_burst = NULL;\n \taxgbe_dev_clear_queues(eth_dev);\n \n \t/* disable uio intr before callback unregister */\ndiff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex d45347e8ca..e1c430b2cc 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -1382,10 +1382,6 @@ static int bnxt_dev_close_op(struct rte_eth_dev *eth_dev)\n \tbnxt_free_pf_info(bp);\n \tbnxt_free_parent_info(bp);\n \n-\teth_dev->dev_ops = NULL;\n-\teth_dev->rx_pkt_burst = NULL;\n-\teth_dev->tx_pkt_burst = NULL;\n-\n \trte_memzone_free((const struct rte_memzone *)bp->tx_mem_zone);\n \tbp->tx_mem_zone = NULL;\n \trte_memzone_free((const struct rte_memzone *)bp->rx_mem_zone);\ndiff --git a/drivers/net/bnxt/bnxt_reps.c b/drivers/net/bnxt/bnxt_reps.c\nindex c419fe63b8..d523c867eb 100644\n--- a/drivers/net/bnxt/bnxt_reps.c\n+++ b/drivers/net/bnxt/bnxt_reps.c\n@@ -225,7 +225,6 @@ int bnxt_vf_representor_uninit(struct rte_eth_dev *eth_dev)\n \n \tPMD_DRV_LOG(DEBUG, \"BNXT Port:%d VFR uninit\\n\", eth_dev->data->port_id);\n \teth_dev->data->mac_addrs = NULL;\n-\teth_dev->dev_ops = NULL;\n \n \tparent_bp = rep->parent_dev->data->dev_private;\n \tif (!parent_bp) {\ndiff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c\nindex 1f761c7c9e..ce8fe254af 100644\n--- a/drivers/net/bonding/rte_eth_bond_pmd.c\n+++ b/drivers/net/bonding/rte_eth_bond_pmd.c\n@@ -2130,10 +2130,6 @@ bond_ethdev_close(struct rte_eth_dev *dev)\n \t */\n \trte_mempool_free(internals->mode6.mempool);\n \n-\tdev->dev_ops = NULL;\n-\tdev->rx_pkt_burst = NULL;\n-\tdev->tx_pkt_burst = NULL;\n-\n \treturn 0;\n }\n \ndiff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c\nindex a01c8f3fc6..7e6a954d7b 100644\n--- a/drivers/net/dpaa/dpaa_ethdev.c\n+++ b/drivers/net/dpaa/dpaa_ethdev.c\n@@ -441,10 +441,6 @@ static int dpaa_eth_dev_close(struct rte_eth_dev *dev)\n \trte_free(dpaa_intf->tx_queues);\n \tdpaa_intf->tx_queues = NULL;\n \n-\tdev->dev_ops = NULL;\n-\tdev->rx_pkt_burst = NULL;\n-\tdev->tx_pkt_burst = NULL;\n-\n \treturn 0;\n }\n \ndiff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c\nindex d8624514df..ba99a524f9 100644\n--- a/drivers/net/dpaa2/dpaa2_ethdev.c\n+++ b/drivers/net/dpaa2/dpaa2_ethdev.c\n@@ -1284,10 +1284,6 @@ dpaa2_dev_close(struct rte_eth_dev *dev)\n \tif (priv->extract.qos_extract_param)\n \t\trte_free((void *)(size_t)priv->extract.qos_extract_param);\n \n-\tdev->dev_ops = NULL;\n-\tdev->rx_pkt_burst = NULL;\n-\tdev->tx_pkt_burst = NULL;\n-\n \tDPAA2_PMD_INFO(\"%s: netdev deleted\", dev->data->name);\n \treturn 0;\n }\ndiff --git a/drivers/net/e1000/em_ethdev.c b/drivers/net/e1000/em_ethdev.c\nindex d050eb478a..151b7543d8 100644\n--- a/drivers/net/e1000/em_ethdev.c\n+++ b/drivers/net/e1000/em_ethdev.c\n@@ -772,10 +772,6 @@ eth_em_close(struct rte_eth_dev *dev)\n \tem_release_manageability(hw);\n \tem_hw_control_release(hw);\n \n-\tdev->dev_ops = NULL;\n-\tdev->rx_pkt_burst = NULL;\n-\tdev->tx_pkt_burst = NULL;\n-\n \t/* disable uio intr before callback unregister */\n \trte_intr_disable(intr_handle);\n \trte_intr_callback_unregister(intr_handle,\ndiff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c\nindex cb3d97e2a3..a7fcbaf295 100644\n--- a/drivers/net/e1000/igb_ethdev.c\n+++ b/drivers/net/e1000/igb_ethdev.c\n@@ -1564,10 +1564,6 @@ eth_igb_close(struct rte_eth_dev *dev)\n \tmemset(&link, 0, sizeof(link));\n \trte_eth_linkstatus_set(dev, &link);\n \n-\tdev->dev_ops = NULL;\n-\tdev->rx_pkt_burst = NULL;\n-\tdev->tx_pkt_burst = NULL;\n-\n \t/* Reset any pending lock */\n \tigb_reset_swfw_lock(hw);\n \n@@ -3403,10 +3399,6 @@ igbvf_dev_close(struct rte_eth_dev *dev)\n \tmemset(&addr, 0, sizeof(addr));\n \tigbvf_default_mac_addr_set(dev, &addr);\n \n-\tdev->dev_ops = NULL;\n-\tdev->rx_pkt_burst = NULL;\n-\tdev->tx_pkt_burst = NULL;\n-\n \trte_intr_callback_unregister(&pci_dev->intr_handle,\n \t\t\t\t eth_igbvf_interrupt_handler,\n \t\t\t\t (void *)dev);\ndiff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c\nindex 07ae9bab32..b42f12b870 100644\n--- a/drivers/net/ena/ena_ethdev.c\n+++ b/drivers/net/ena/ena_ethdev.c\n@@ -1933,11 +1933,6 @@ static int eth_ena_dev_uninit(struct rte_eth_dev *eth_dev)\n \n \tena_destroy_device(eth_dev);\n \n-\teth_dev->dev_ops = NULL;\n-\teth_dev->rx_pkt_burst = NULL;\n-\teth_dev->tx_pkt_burst = NULL;\n-\teth_dev->tx_pkt_prepare = NULL;\n-\n \treturn 0;\n }\n \ndiff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c\nindex 17cf0328c6..2d51f50faa 100644\n--- a/drivers/net/fm10k/fm10k_ethdev.c\n+++ b/drivers/net/fm10k/fm10k_ethdev.c\n@@ -2801,10 +2801,6 @@ fm10k_dev_close(struct rte_eth_dev *dev)\n \tfm10k_dev_queue_release(dev);\n \tfm10k_stop_hw(hw);\n \n-\tdev->dev_ops = NULL;\n-\tdev->rx_pkt_burst = NULL;\n-\tdev->tx_pkt_burst = NULL;\n-\n \t/* disable uio/vfio intr */\n \trte_intr_disable(intr_handle);\n \ndiff --git a/drivers/net/hinic/hinic_pmd_ethdev.c b/drivers/net/hinic/hinic_pmd_ethdev.c\nindex c5b06fae73..57084e59c1 100644\n--- a/drivers/net/hinic/hinic_pmd_ethdev.c\n+++ b/drivers/net/hinic/hinic_pmd_ethdev.c\n@@ -3222,10 +3222,6 @@ static int hinic_dev_uninit(struct rte_eth_dev *dev)\n \n \thinic_dev_close(dev);\n \n-\tdev->dev_ops = NULL;\n-\tdev->rx_pkt_burst = NULL;\n-\tdev->tx_pkt_burst = NULL;\n-\n \trte_free(nic_dev->mc_list);\n \n \treturn HINIC_OK;\ndiff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c\nindex dd03bd62b2..ba40d489d6 100644\n--- a/drivers/net/hns3/hns3_ethdev.c\n+++ b/drivers/net/hns3/hns3_ethdev.c\n@@ -5721,10 +5721,6 @@ hns3_dev_uninit(struct rte_eth_dev *eth_dev)\n \tif (rte_eal_process_type() != RTE_PROC_PRIMARY)\n \t\treturn -EPERM;\n \n-\teth_dev->dev_ops = NULL;\n-\teth_dev->rx_pkt_burst = NULL;\n-\teth_dev->tx_pkt_burst = NULL;\n-\teth_dev->tx_pkt_prepare = NULL;\n \tif (hw->adapter_state < HNS3_NIC_CLOSING)\n \t\thns3_dev_close(eth_dev);\n \ndiff --git a/drivers/net/hns3/hns3_ethdev_vf.c b/drivers/net/hns3/hns3_ethdev_vf.c\nindex 436d864b5f..6a04cd9c2c 100644\n--- a/drivers/net/hns3/hns3_ethdev_vf.c\n+++ b/drivers/net/hns3/hns3_ethdev_vf.c\n@@ -2728,11 +2728,6 @@ hns3vf_dev_uninit(struct rte_eth_dev *eth_dev)\n \tif (rte_eal_process_type() != RTE_PROC_PRIMARY)\n \t\treturn -EPERM;\n \n-\teth_dev->dev_ops = NULL;\n-\teth_dev->rx_pkt_burst = NULL;\n-\teth_dev->tx_pkt_burst = NULL;\n-\teth_dev->tx_pkt_prepare = NULL;\n-\n \tif (hw->adapter_state < HNS3_NIC_CLOSING)\n \t\thns3vf_dev_close(eth_dev);\n \ndiff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c\nindex feeed2dec0..a05d29dcfc 100644\n--- a/drivers/net/i40e/i40e_ethdev.c\n+++ b/drivers/net/i40e/i40e_ethdev.c\n@@ -2692,10 +2692,6 @@ i40e_dev_close(struct rte_eth_dev *dev)\n \t\t\t(reg | I40E_PFGEN_CTRL_PFSWR_MASK));\n \tI40E_WRITE_FLUSH(hw);\n \n-\tdev->dev_ops = NULL;\n-\tdev->rx_pkt_burst = NULL;\n-\tdev->tx_pkt_burst = NULL;\n-\n \t/* Clear PXE mode */\n \ti40e_clear_pxe_mode(hw);\n \ndiff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c\nindex 4d6510d1ff..2001854ae6 100644\n--- a/drivers/net/i40e/i40e_ethdev_vf.c\n+++ b/drivers/net/i40e/i40e_ethdev_vf.c\n@@ -2421,10 +2421,6 @@ i40evf_dev_close(struct rte_eth_dev *dev)\n \ti40e_shutdown_adminq(hw);\n \ti40evf_disable_irq0(hw);\n \n-\tdev->dev_ops = NULL;\n-\tdev->rx_pkt_burst = NULL;\n-\tdev->tx_pkt_burst = NULL;\n-\n \trte_free(vf->vf_res);\n \tvf->vf_res = NULL;\n \trte_free(vf->aq_resp);\ndiff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c\nindex a5b1433306..02391acfd1 100644\n--- a/drivers/net/iavf/iavf_ethdev.c\n+++ b/drivers/net/iavf/iavf_ethdev.c\n@@ -1483,10 +1483,6 @@ iavf_dev_close(struct rte_eth_dev *dev)\n \t\t\t\t iavf_dev_interrupt_handler, dev);\n \tiavf_disable_irq0(hw);\n \n-\tdev->dev_ops = NULL;\n-\tdev->rx_pkt_burst = NULL;\n-\tdev->tx_pkt_burst = NULL;\n-\n \tif (vf->vf_res->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_RSS_PF) {\n \t\tif (vf->rss_lut) {\n \t\t\trte_free(vf->rss_lut);\ndiff --git a/drivers/net/ice/ice_dcf_ethdev.c b/drivers/net/ice/ice_dcf_ethdev.c\nindex 33dd0c44f2..f2056e2aba 100644\n--- a/drivers/net/ice/ice_dcf_ethdev.c\n+++ b/drivers/net/ice/ice_dcf_ethdev.c\n@@ -855,10 +855,6 @@ ice_dcf_dev_close(struct rte_eth_dev *dev)\n \tif (rte_eal_process_type() != RTE_PROC_PRIMARY)\n \t\treturn 0;\n \n-\tdev->dev_ops = NULL;\n-\tdev->rx_pkt_burst = NULL;\n-\tdev->tx_pkt_burst = NULL;\n-\n \tice_dcf_uninit_parent_adapter(dev);\n \tice_dcf_uninit_hw(dev, &adapter->real_hw);\n \ndiff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c\nindex 73af19ce81..4f977bd4c4 100644\n--- a/drivers/net/ice/ice_ethdev.c\n+++ b/drivers/net/ice/ice_ethdev.c\n@@ -2463,10 +2463,6 @@ ice_dev_close(struct rte_eth_dev *dev)\n \trte_free(pf->proto_xtr);\n \tpf->proto_xtr = NULL;\n \n-\tdev->dev_ops = NULL;\n-\tdev->rx_pkt_burst = NULL;\n-\tdev->tx_pkt_burst = NULL;\n-\n \t/* disable uio intr before callback unregister */\n \trte_intr_disable(intr_handle);\n \ndiff --git a/drivers/net/ionic/ionic_ethdev.c b/drivers/net/ionic/ionic_ethdev.c\nindex ef7d06e526..1387253dc8 100644\n--- a/drivers/net/ionic/ionic_ethdev.c\n+++ b/drivers/net/ionic/ionic_ethdev.c\n@@ -1065,11 +1065,6 @@ eth_ionic_dev_uninit(struct rte_eth_dev *eth_dev)\n \tionic_lif_deinit(lif);\n \tionic_lif_free(lif);\n \n-\teth_dev->dev_ops = NULL;\n-\teth_dev->rx_pkt_burst = NULL;\n-\teth_dev->tx_pkt_burst = NULL;\n-\teth_dev->tx_pkt_prepare = NULL;\n-\n \treturn 0;\n }\n \ndiff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c\nindex 84c1b0f7a1..be8a79009d 100644\n--- a/drivers/net/ixgbe/ixgbe_ethdev.c\n+++ b/drivers/net/ixgbe/ixgbe_ethdev.c\n@@ -3009,10 +3009,6 @@ ixgbe_dev_close(struct rte_eth_dev *dev)\n \t/* reprogram the RAR[0] in case user changed it. */\n \tixgbe_set_rar(hw, 0, hw->mac.addr, 0, IXGBE_RAH_AV);\n \n-\tdev->dev_ops = NULL;\n-\tdev->rx_pkt_burst = NULL;\n-\tdev->tx_pkt_burst = NULL;\n-\n \t/* Unlock any pending hardware semaphore */\n \tixgbe_swfw_lock_reset(hw);\n \n@@ -5460,10 +5456,6 @@ ixgbevf_dev_close(struct rte_eth_dev *dev)\n \t **/\n \tixgbevf_remove_mac_addr(dev, 0);\n \n-\tdev->dev_ops = NULL;\n-\tdev->rx_pkt_burst = NULL;\n-\tdev->tx_pkt_burst = NULL;\n-\n \trte_intr_disable(intr_handle);\n \trte_intr_callback_unregister(intr_handle,\n \t\t\t\t ixgbevf_dev_interrupt_handler, dev);\ndiff --git a/drivers/net/liquidio/lio_ethdev.c b/drivers/net/liquidio/lio_ethdev.c\nindex 1a41f27198..9c4da467eb 100644\n--- a/drivers/net/liquidio/lio_ethdev.c\n+++ b/drivers/net/liquidio/lio_ethdev.c\n@@ -2067,10 +2067,6 @@ lio_eth_dev_uninit(struct rte_eth_dev *eth_dev)\n \t/* lio_free_sc_buffer_pool */\n \tlio_free_sc_buffer_pool(lio_dev);\n \n-\teth_dev->dev_ops = NULL;\n-\teth_dev->rx_pkt_burst = NULL;\n-\teth_dev->tx_pkt_burst = NULL;\n-\n \treturn 0;\n }\n \ndiff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c\nindex 5ae2d469c8..9af64821a1 100644\n--- a/drivers/net/netvsc/hn_ethdev.c\n+++ b/drivers/net/netvsc/hn_ethdev.c\n@@ -1049,10 +1049,6 @@ eth_hn_dev_uninit(struct rte_eth_dev *eth_dev)\n \thn_dev_stop(eth_dev);\n \thn_dev_close(eth_dev);\n \n-\teth_dev->dev_ops = NULL;\n-\teth_dev->tx_pkt_burst = NULL;\n-\teth_dev->rx_pkt_burst = NULL;\n-\n \thn_detach(hv);\n \thn_chim_uninit(eth_dev);\n \trte_vmbus_chan_close(hv->primary->chan);\ndiff --git a/drivers/net/octeontx/octeontx_ethdev.c b/drivers/net/octeontx/octeontx_ethdev.c\nindex aa9ef3bb70..0ea6de448a 100644\n--- a/drivers/net/octeontx/octeontx_ethdev.c\n+++ b/drivers/net/octeontx/octeontx_ethdev.c\n@@ -513,9 +513,6 @@ octeontx_dev_close(struct rte_eth_dev *dev)\n \n \tocteontx_port_close(nic);\n \n-\tdev->tx_pkt_burst = NULL;\n-\tdev->rx_pkt_burst = NULL;\n-\n \treturn 0;\n }\n \ndiff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c\nindex cd578709fb..4055c74c2d 100644\n--- a/drivers/net/qede/qede_ethdev.c\n+++ b/drivers/net/qede/qede_ethdev.c\n@@ -1591,10 +1591,6 @@ static int qede_dev_close(struct rte_eth_dev *eth_dev)\n \tif (ECORE_IS_CMT(edev))\n \t\trte_eal_alarm_cancel(qede_poll_sp_sb_cb, (void *)eth_dev);\n \n-\teth_dev->dev_ops = NULL;\n-\teth_dev->rx_pkt_burst = NULL;\n-\teth_dev->tx_pkt_burst = NULL;\n-\n \treturn 0;\n }\n \ndiff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c\nindex 0558f1808d..9ee0b994eb 100644\n--- a/drivers/net/sfc/sfc_ethdev.c\n+++ b/drivers/net/sfc/sfc_ethdev.c\n@@ -322,11 +322,7 @@ static void\n sfc_eth_dev_secondary_clear_ops(struct rte_eth_dev *dev)\n {\n \tfree(dev->process_private);\n-\tdev->process_private = NULL;\n-\tdev->dev_ops = NULL;\n-\tdev->tx_pkt_prepare = NULL;\n-\tdev->tx_pkt_burst = NULL;\n-\tdev->rx_pkt_burst = NULL;\n+\trte_eth_dev_release_port(dev);\n }\n \n static int\n@@ -378,7 +374,6 @@ sfc_dev_close(struct rte_eth_dev *dev)\n \t/* Required for logging, so cleanup last */\n \tsa->eth_dev = NULL;\n \n-\tdev->process_private = NULL;\n \tfree(sa);\n \n \treturn 0;\ndiff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c\nindex b127ce62dc..0598de00ed 100644\n--- a/drivers/net/tap/rte_eth_tap.c\n+++ b/drivers/net/tap/rte_eth_tap.c\n@@ -1134,7 +1134,6 @@ tap_dev_close(struct rte_eth_dev *dev)\n \t\tinternals->ioctl_sock = -1;\n \t}\n \trte_free(dev->process_private);\n-\tdev->process_private = NULL;\n \tif (tap_devices_count == 1)\n \t\trte_mp_action_unregister(TAP_MP_KEY);\n \ttap_devices_count--;\ndiff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c\nindex f2117675b3..3b3b2f6a7e 100644\n--- a/drivers/net/virtio/virtio_ethdev.c\n+++ b/drivers/net/virtio/virtio_ethdev.c\n@@ -1995,10 +1995,6 @@ eth_virtio_dev_uninit(struct rte_eth_dev *eth_dev)\n \tvirtio_dev_stop(eth_dev);\n \tvirtio_dev_close(eth_dev);\n \n-\teth_dev->dev_ops = NULL;\n-\teth_dev->tx_pkt_burst = NULL;\n-\teth_dev->rx_pkt_burst = NULL;\n-\n \tPMD_INIT_LOG(DEBUG, \"dev_uninit completed\");\n \n \treturn 0;\ndiff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c\nindex fa950e1ba0..12a782d987 100644\n--- a/drivers/net/vmxnet3/vmxnet3_ethdev.c\n+++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c\n@@ -368,11 +368,6 @@ eth_vmxnet3_dev_uninit(struct rte_eth_dev *eth_dev)\n \t\treturn -EBUSY;\n \t}\n \n-\teth_dev->dev_ops = NULL;\n-\teth_dev->rx_pkt_burst = NULL;\n-\teth_dev->tx_pkt_burst = NULL;\n-\teth_dev->tx_pkt_prepare = NULL;\n-\n \treturn 0;\n }\n \ndiff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c\nindex 0b8e8e3e8d..e68943b461 100644\n--- a/lib/librte_ethdev/rte_ethdev.c\n+++ b/lib/librte_ethdev/rte_ethdev.c\n@@ -554,10 +554,6 @@ rte_eth_dev_release_port(struct rte_eth_dev *eth_dev)\n \n \trte_spinlock_lock(&rte_eth_dev_shared_data->ownership_lock);\n \n-\teth_dev->state = RTE_ETH_DEV_UNUSED;\n-\teth_dev->device = NULL;\n-\teth_dev->intr_handle = NULL;\n-\n \tif (rte_eal_process_type() == RTE_PROC_PRIMARY) {\n \t\trte_free(eth_dev->data->rx_queues);\n \t\trte_free(eth_dev->data->tx_queues);\n@@ -566,6 +562,7 @@ rte_eth_dev_release_port(struct rte_eth_dev *eth_dev)\n \t\trte_free(eth_dev->data->dev_private);\n \t\tmemset(eth_dev->data, 0, sizeof(struct rte_eth_dev_data));\n \t}\n+\tmemset(eth_dev, 0, sizeof(struct rte_eth_dev));\n \n \trte_spinlock_unlock(&rte_eth_dev_shared_data->ownership_lock);\n \n", "prefixes": [ "v3", "28/29" ] }