Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/78752/?format=api
{ "id": 78752, "url": "http://patches.dpdk.org/api/patches/78752/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1600955105-53176-2-git-send-email-oulijun@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1600955105-53176-2-git-send-email-oulijun@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1600955105-53176-2-git-send-email-oulijun@huawei.com", "date": "2020-09-24T13:45:05", "name": "[v4] app/testpmd: fix the default RSS key configuration", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "fdbcf2e7b4e90929f5d828fde583f3d4bc2b4164", "submitter": { "id": 1675, "url": "http://patches.dpdk.org/api/people/1675/?format=api", "name": "Lijun Ou", "email": "oulijun@huawei.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1600955105-53176-2-git-send-email-oulijun@huawei.com/mbox/", "series": [ { "id": 12479, "url": "http://patches.dpdk.org/api/series/12479/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12479", "date": "2020-09-24T13:45:05", "name": "[v4] app/testpmd: fix the default RSS key configuration", "version": 4, "mbox": "http://patches.dpdk.org/series/12479/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/78752/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/78752/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E8730A04B5;\n\tThu, 24 Sep 2020 15:47:46 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 807941DE9C;\n\tThu, 24 Sep 2020 15:47:46 +0200 (CEST)", "from huawei.com (szxga04-in.huawei.com [45.249.212.190])\n by dpdk.org (Postfix) with ESMTP id 513961DE9A\n for <dev@dpdk.org>; Thu, 24 Sep 2020 15:47:45 +0200 (CEST)", "from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.60])\n by Forcepoint Email with ESMTP id C457D46AD69529F9D619;\n Thu, 24 Sep 2020 21:47:41 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n DGGEMS401-HUB.china.huawei.com (10.3.19.201) with Microsoft SMTP Server id\n 14.3.487.0; Thu, 24 Sep 2020 21:47:35 +0800" ], "From": "Lijun Ou <oulijun@huawei.com>", "To": "<wenzhuo.lu@intel.com>, <beilei.xing@intel.com>,\n <adrien.mazarguil@6wind.com>, <ferruh.yigit@intel.com>", "CC": "<dev@dpdk.org>, <linuxarm@huawei.com>", "Date": "Thu, 24 Sep 2020 21:45:05 +0800", "Message-ID": "<1600955105-53176-2-git-send-email-oulijun@huawei.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1600955105-53176-1-git-send-email-oulijun@huawei.com>", "References": "<1599702678-11142-1-git-send-email-oulijun@huawei.com>\n <1600955105-53176-1-git-send-email-oulijun@huawei.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-CFilter-Loop": "Reflected", "Subject": "[dpdk-dev] [PATCH v4] app/testpmd: fix the default RSS key\n\tconfiguration", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "It use the NIC valid default RSS key instead of the testpmd\ndummy RSS key in the flow configuration when the RSS key is\nnot specified in the flow rule. If the NIC RSS key is\ninvalid, it will use testpmd dummy RSS key as the default\nkey.\n\nFixes: ac8d22de2394 (\"ethdev: flatten RSS configuration in flow API\")\nCc: stable@dpdk.org\n\nSigned-off-by: Lijun Ou <oulijun@huawei.com>\n---\nV3->V4:\n-fix checkpatch warning and shorter commit content.\n\nV2->V3:\n-fix checkpatch warning.\n\nV1->V2:\n-fix the commit.\n---\n app/test-pmd/cmdline_flow.c | 8 ++++++++\n 1 file changed, 8 insertions(+)", "diff": "diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c\nindex 6263d30..e6648da 100644\n--- a/app/test-pmd/cmdline_flow.c\n+++ b/app/test-pmd/cmdline_flow.c\n@@ -4312,6 +4312,7 @@ parse_vc_action_rss(struct context *ctx, const struct token *token,\n \t\taction_rss_data->queue[i] = i;\n \tif (!port_id_is_invalid(ctx->port, DISABLED_WARN) &&\n \t ctx->port != (portid_t)RTE_PORT_ALL) {\n+\t\tstruct rte_eth_rss_conf rss_conf = {0};\n \t\tstruct rte_eth_dev_info info;\n \t\tint ret2;\n \n@@ -4322,6 +4323,13 @@ parse_vc_action_rss(struct context *ctx, const struct token *token,\n \t\taction_rss_data->conf.key_len =\n \t\t\tRTE_MIN(sizeof(action_rss_data->key),\n \t\t\t\tinfo.hash_key_size);\n+\n+\t\trss_conf.rss_key_len = sizeof(action_rss_data->key);\n+\t\trss_conf.rss_key = action_rss_data->key;\n+\t\tret2 = rte_eth_dev_rss_hash_conf_get(ctx->port, &rss_conf);\n+\t\tif (ret2 != 0)\n+\t\t\treturn ret2;\n+\t\taction_rss_data->conf.key = rss_conf.rss_key;\n \t}\n \taction->conf = &action_rss_data->conf;\n \treturn ret;\n", "prefixes": [ "v4" ] }