Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/78260/?format=api
{ "id": 78260, "url": "http://patches.dpdk.org/api/patches/78260/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1600764594-14752-10-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1600764594-14752-10-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1600764594-14752-10-git-send-email-arybchenko@solarflare.com", "date": "2020-09-22T08:49:03", "name": "[09/60] common/sfc_efx/base: move 14b prefix check out of caps get", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "1b40dd1ea40a4618db8d71262a3b85fafbf6daaa", "submitter": { "id": 607, "url": "http://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1600764594-14752-10-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 12400, "url": "http://patches.dpdk.org/api/series/12400/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12400", "date": "2020-09-22T08:48:59", "name": "common/sfc_efx: support Riverhead NIC family", "version": 1, "mbox": "http://patches.dpdk.org/series/12400/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/78260/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/78260/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E2172A04E1;\n\tTue, 22 Sep 2020 10:51:59 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4FF821DAAB;\n\tTue, 22 Sep 2020 10:50:39 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 5987E1D6D4\n for <dev@dpdk.org>; Tue, 22 Sep 2020 10:50:16 +0200 (CEST)", "from mx1-us1.ppe-hosted.com (unknown [10.110.50.144])\n by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id\n 07F4520055 for <dev@dpdk.org>; Tue, 22 Sep 2020 08:50:16 +0000 (UTC)", "from us4-mdac16-22.at1.mdlocal (unknown [10.110.49.204])\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 07C66800A4\n for <dev@dpdk.org>; Tue, 22 Sep 2020 08:50:16 +0000 (UTC)", "from mx1-us1.ppe-hosted.com (unknown [10.110.50.8])\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 91D0A4004D\n for <dev@dpdk.org>; Tue, 22 Sep 2020 08:50:15 +0000 (UTC)", "from webmail.solarflare.com (uk.solarflare.com [193.34.186.16])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n (No client certificate requested)\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n 5B79D4C0059\n for <dev@dpdk.org>; Tue, 22 Sep 2020 08:50:15 +0000 (UTC)", "from ukex01.SolarFlarecom.com (10.17.10.4) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id\n 15.0.1497.2; Tue, 22 Sep 2020 09:50:09 +0100", "from opal.uk.solarflarecom.com (10.17.10.1) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server id\n 15.0.1497.2 via Frontend Transport; Tue, 22 Sep 2020 09:50:09 +0100", "from ukv-loginhost.uk.solarflarecom.com\n (ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id 08M8o9BA004609\n for <dev@dpdk.org>; Tue, 22 Sep 2020 09:50:09 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id 5EB931613BE\n for <dev@dpdk.org>; Tue, 22 Sep 2020 09:50:09 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "Date": "Tue, 22 Sep 2020 09:49:03 +0100", "Message-ID": "<1600764594-14752-10-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1600764594-14752-1-git-send-email-arybchenko@solarflare.com>", "References": "<1600764594-14752-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.6.1012-25674.003", "X-TM-AS-Result": "No-0.847100-8.000000-10", "X-TMASE-MatchedRID": "1e4GURu5ZSkjdXbalIVNEnYZxYoZm58FmU/t0AE6+TLmWHHSYEnI8WpA\n q14Ss3bZ06c72oPCTYcWsp6eJb7A2xt/FEV6QNBCPwKTD1v8YV5MkOX0UoduuV9QIc+ez/4+VQU\n 8VbWsRfgy4FX81Fzie3DWq7ntlL+KOzpEi4NJ5xPJ1E/nrJFEDwRryDXHx6oX90btya4ycShxxy\n XDegSmwtBworJRpz+6EOifd957UvIZxRzC/w7oVMjz0VPUnBA1uqgVqRoQsiC8NrbzjPvzJxUCx\n /X5xkUniG1Tff1Qo1d0swqakwEXcATsy5Ctk/ajngIgpj8eDcAZ1CdBJOsoY8RB0bsfrpPIcSqb\n xBgG0w5If/WxTqUl5WmZDG9VWb+AJmon39AneiVyn9i2B2Y2Mll6m5+gocjOZAPK6hI2Yoy6Kng\n aiopJexq3XxA0vCLSxeC+Jpt/jpsckqAQnqJUA6vLjyQveEhYEdOpeiiHeDfqJnMJKyS+5w==", "X-TM-AS-User-Approved-Sender": "Yes", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10--0.847100-8.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.6.1012-25674.003", "X-MDID": "1600764616-4DuxN611kMXT", "Subject": "[dpdk-dev] [PATCH 09/60] common/sfc_efx/base: move 14b prefix check\n\tout of caps get", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The function which gets capabilties from MC should simply fill in\nNIC configuration. Caller should decide if the configuration is\nsupported or not.\n\nThe change is required to prepare the function to be reused on\nRiverhead.\n\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\nReviewed-by: Andy Moreton <amoreton@xilinx.com>\n---\n drivers/common/sfc_efx/base/ef10_nic.c | 33 ++++++++++++++------------\n 1 file changed, 18 insertions(+), 15 deletions(-)", "diff": "diff --git a/drivers/common/sfc_efx/base/ef10_nic.c b/drivers/common/sfc_efx/base/ef10_nic.c\nindex 34fa45e8c1..bb5fd50eab 100644\n--- a/drivers/common/sfc_efx/base/ef10_nic.c\n+++ b/drivers/common/sfc_efx/base/ef10_nic.c\n@@ -1062,15 +1062,11 @@ ef10_get_datapath_caps(\n \t (MCDI_OUT_DWORD((_req), GET_CAPABILITIES_V2_OUT_FLAGS2) &\t\\\n \t (1u << (MC_CMD_GET_CAPABILITIES_V2_OUT_ ## _flag ## _LBN))))\n \n-\t/*\n-\t * Huntington RXDP firmware inserts a 0 or 14 byte prefix.\n-\t * We only support the 14 byte prefix here.\n-\t */\n-\tif (CAP_FLAGS1(req, RX_PREFIX_LEN_14) == 0) {\n-\t\trc = ENOTSUP;\n-\t\tgoto fail4;\n-\t}\n-\tencp->enc_rx_prefix_size = 14;\n+\t/* Check if RXDP firmware inserts 14 byte prefix */\n+\tif (CAP_FLAGS1(req, RX_PREFIX_LEN_14))\n+\t\tencp->enc_rx_prefix_size = 14;\n+\telse\n+\t\tencp->enc_rx_prefix_size = 0;\n \n #if EFSYS_OPT_RX_SCALE\n \t/* Check if the firmware supports additional RSS modes */\n@@ -1348,7 +1344,7 @@ ef10_get_datapath_caps(\n \n \t\tdefault:\n \t\t\trc = EINVAL;\n-\t\t\tgoto fail5;\n+\t\t\tgoto fail4;\n \t\t}\n \n \t\t/* Port numbers cannot contribute to the hash value */\n@@ -1397,11 +1393,9 @@ ef10_get_datapath_caps(\n \treturn (0);\n \n #if EFSYS_OPT_RX_SCALE\n-fail5:\n-\tEFSYS_PROBE(fail5);\n-#endif /* EFSYS_OPT_RX_SCALE */\n fail4:\n \tEFSYS_PROBE(fail4);\n+#endif /* EFSYS_OPT_RX_SCALE */\n fail3:\n \tEFSYS_PROBE(fail3);\n fail2:\n@@ -1932,6 +1926,15 @@ ef10_nic_board_cfg(\n \tif ((rc = ef10_get_datapath_caps(enp)) != 0)\n \t\tgoto fail8;\n \n+\t/*\n+\t * Huntington RXDP firmware inserts a 0 or 14 byte prefix.\n+\t * We only support the 14 byte prefix here.\n+\t */\n+\tif (encp->enc_rx_prefix_size != 14) {\n+\t\trc = ENOTSUP;\n+\t\tgoto fail9;\n+\t}\n+\n \t/* Alignment for WPTR updates */\n \tencp->enc_rx_push_align = EF10_RX_WPTR_ALIGN;\n \n@@ -1960,7 +1963,7 @@ ef10_nic_board_cfg(\n \t/* Get interrupt vector limits */\n \tif ((rc = efx_mcdi_get_vector_cfg(enp, &base, &nvec, NULL)) != 0) {\n \t\tif (EFX_PCI_FUNCTION_IS_PF(encp))\n-\t\t\tgoto fail9;\n+\t\t\tgoto fail10;\n \n \t\t/* Ignore error (cannot query vector limits from a VF). */\n \t\tbase = 0;\n@@ -1976,7 +1979,7 @@ ef10_nic_board_cfg(\n \t * can result in time-of-check/time-of-use bugs.\n \t */\n \tif ((rc = ef10_get_privilege_mask(enp, &mask)) != 0)\n-\t\tgoto fail10;\n+\t\tgoto fail11;\n \tencp->enc_privilege_mask = mask;\n \n \tif ((rc = ef10_set_workaround_bug26807(enp)) != 0)\n", "prefixes": [ "09/60" ] }