Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/77954/?format=api
{ "id": 77954, "url": "http://patches.dpdk.org/api/patches/77954/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1600319462-2053-2-git-send-email-lirongqing@baidu.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1600319462-2053-2-git-send-email-lirongqing@baidu.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1600319462-2053-2-git-send-email-lirongqing@baidu.com", "date": "2020-09-17T05:11:02", "name": "[2/2] af_xdp: avoid to unnecessary allocation and free mbuf", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": true, "hash": "2879b7cb116070b3bde82b7d6b6035faf25ae59e", "submitter": { "id": 1979, "url": "http://patches.dpdk.org/api/people/1979/?format=api", "name": "Li RongQing", "email": "lirongqing@baidu.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1600319462-2053-2-git-send-email-lirongqing@baidu.com/mbox/", "series": [ { "id": 12295, "url": "http://patches.dpdk.org/api/series/12295/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12295", "date": "2020-09-17T05:11:01", "name": "[1/2] af_xdp: not return a negative value in af_xdp_rx_zc", "version": 1, "mbox": "http://patches.dpdk.org/series/12295/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/77954/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/77954/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 26A5CA04B6;\n\tThu, 17 Sep 2020 07:11:13 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E9CF81C1A5;\n\tThu, 17 Sep 2020 07:11:07 +0200 (CEST)", "from tc-sys-mailedm02.tc.baidu.com (mx58.baidu.com [61.135.168.58])\n by dpdk.org (Postfix) with ESMTP id E0ECC1D50B\n for <dev@dpdk.org>; Thu, 17 Sep 2020 07:11:04 +0200 (CEST)", "from localhost (cp01-cos-dev01.cp01.baidu.com [10.92.119.46])\n by tc-sys-mailedm02.tc.baidu.com (Postfix) with ESMTP id 85DEF11C0061\n for <dev@dpdk.org>; Thu, 17 Sep 2020 13:11:02 +0800 (CST)" ], "From": "Li RongQing <lirongqing@baidu.com>", "To": "dev@dpdk.org", "Date": "Thu, 17 Sep 2020 13:11:02 +0800", "Message-Id": "<1600319462-2053-2-git-send-email-lirongqing@baidu.com>", "X-Mailer": "git-send-email 1.7.1", "In-Reply-To": "<1600319462-2053-1-git-send-email-lirongqing@baidu.com>", "References": "<1600319462-2053-1-git-send-email-lirongqing@baidu.com>", "Subject": "[dpdk-dev] [PATCH 2/2] af_xdp: avoid to unnecessary allocation and\n\tfree mbuf", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "optimize rx performance, by allocating mbuf based on result\nof xsk_ring_cons__peek, to avoid to redundancy allocation,\nand free mbuf when receive packets\n\nSigned-off-by: Li RongQing <lirongqing@baidu.com>\nSigned-off-by: Dongsheng Rong <rongdongsheng@baidu.com>\n---\n drivers/net/af_xdp/rte_eth_af_xdp.c | 64 ++++++++++++++++---------------------\n 1 file changed, 27 insertions(+), 37 deletions(-)", "diff": "diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c b/drivers/net/af_xdp/rte_eth_af_xdp.c\nindex 7ce4ad04a..48824050e 100644\n--- a/drivers/net/af_xdp/rte_eth_af_xdp.c\n+++ b/drivers/net/af_xdp/rte_eth_af_xdp.c\n@@ -229,28 +229,29 @@ af_xdp_rx_zc(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \tstruct xsk_umem_info *umem = rxq->umem;\n \tuint32_t idx_rx = 0;\n \tunsigned long rx_bytes = 0;\n-\tint rcvd, i;\n+\tint i;\n \tstruct rte_mbuf *fq_bufs[ETH_AF_XDP_RX_BATCH_SIZE];\n \n-\t/* allocate bufs for fill queue replenishment after rx */\n-\tif (rte_pktmbuf_alloc_bulk(umem->mb_pool, fq_bufs, nb_pkts)) {\n-\t\tAF_XDP_LOG(DEBUG,\n-\t\t\t\"Failed to get enough buffers for fq.\\n\");\n-\t\treturn 0;\n-\t}\n \n-\trcvd = xsk_ring_cons__peek(rx, nb_pkts, &idx_rx);\n+\tnb_pkts = xsk_ring_cons__peek(rx, nb_pkts, &idx_rx);\n \n-\tif (rcvd == 0) {\n+\tif (nb_pkts == 0) {\n #if defined(XDP_USE_NEED_WAKEUP)\n \t\tif (xsk_ring_prod__needs_wakeup(&umem->fq))\n \t\t\t(void)poll(rxq->fds, 1, 1000);\n #endif\n \n-\t\tgoto out;\n+\t\treturn 0;\n \t}\n \n-\tfor (i = 0; i < rcvd; i++) {\n+\t/* allocate bufs for fill queue replenishment after rx */\n+\tif (rte_pktmbuf_alloc_bulk(umem->mb_pool, fq_bufs, nb_pkts)) {\n+\t\tAF_XDP_LOG(DEBUG,\n+\t\t\t\"Failed to get enough buffers for fq.\\n\");\n+\t\treturn 0;\n+\t}\n+\n+\tfor (i = 0; i < nb_pkts; i++) {\n \t\tconst struct xdp_desc *desc;\n \t\tuint64_t addr;\n \t\tuint32_t len;\n@@ -275,20 +276,15 @@ af_xdp_rx_zc(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \t\trx_bytes += len;\n \t}\n \n-\txsk_ring_cons__release(rx, rcvd);\n+\txsk_ring_cons__release(rx, nb_pkts);\n \n-\t(void)reserve_fill_queue(umem, rcvd, fq_bufs);\n+\t(void)reserve_fill_queue(umem, nb_pkts, fq_bufs);\n \n \t/* statistics */\n-\trxq->stats.rx_pkts += rcvd;\n+\trxq->stats.rx_pkts += nb_pkts;\n \trxq->stats.rx_bytes += rx_bytes;\n \n-out:\n-\tif (rcvd != nb_pkts)\n-\t\trte_mempool_put_bulk(umem->mb_pool, (void **)&fq_bufs[rcvd],\n-\t\t\t\t nb_pkts - rcvd);\n-\n-\treturn rcvd;\n+\treturn nb_pkts;\n }\n #else\n static uint16_t\n@@ -300,27 +296,26 @@ af_xdp_rx_cp(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \tstruct xsk_ring_prod *fq = &umem->fq;\n \tuint32_t idx_rx = 0;\n \tunsigned long rx_bytes = 0;\n-\tint rcvd, i;\n+\tint i;\n \tuint32_t free_thresh = fq->size >> 1;\n \tstruct rte_mbuf *mbufs[ETH_AF_XDP_RX_BATCH_SIZE];\n \n-\tif (unlikely(rte_pktmbuf_alloc_bulk(rxq->mb_pool, mbufs, nb_pkts) != 0))\n-\t\treturn 0;\n-\n-\trcvd = xsk_ring_cons__peek(rx, nb_pkts, &idx_rx);\n-\tif (rcvd == 0) {\n+\tnb_pkts = xsk_ring_cons__peek(rx, nb_pkts, &idx_rx);\n+\tif (nb_pkts == 0) {\n #if defined(XDP_USE_NEED_WAKEUP)\n \t\tif (xsk_ring_prod__needs_wakeup(fq))\n \t\t\t(void)poll(rxq->fds, 1, 1000);\n #endif\n-\n-\t\tgoto out;\n+\t\treturn 0;\n \t}\n \n+\tif (unlikely(rte_pktmbuf_alloc_bulk(rxq->mb_pool, mbufs, nb_pkts) != 0))\n+\t\treturn 0;\n+\n \tif (xsk_prod_nb_free(fq, free_thresh) >= free_thresh)\n \t\t(void)reserve_fill_queue(umem, ETH_AF_XDP_RX_BATCH_SIZE, NULL);\n \n-\tfor (i = 0; i < rcvd; i++) {\n+\tfor (i = 0; i < nb_pkts; i++) {\n \t\tconst struct xdp_desc *desc;\n \t\tuint64_t addr;\n \t\tuint32_t len;\n@@ -339,18 +334,13 @@ af_xdp_rx_cp(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \t\tbufs[i] = mbufs[i];\n \t}\n \n-\txsk_ring_cons__release(rx, rcvd);\n+\txsk_ring_cons__release(rx, nb_pkts);\n \n \t/* statistics */\n-\trxq->stats.rx_pkts += rcvd;\n+\trxq->stats.rx_pkts += nb_pkts;\n \trxq->stats.rx_bytes += rx_bytes;\n \n-out:\n-\tif (rcvd != nb_pkts)\n-\t\trte_mempool_put_bulk(rxq->mb_pool, (void **)&mbufs[rcvd],\n-\t\t\t\t nb_pkts - rcvd);\n-\n-\treturn rcvd;\n+\treturn nb_pkts;\n }\n #endif\n \n", "prefixes": [ "2/2" ] }