Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/77915/?format=api
{ "id": 77915, "url": "http://patches.dpdk.org/api/patches/77915/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200916164429.244847-6-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200916164429.244847-6-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200916164429.244847-6-bruce.richardson@intel.com", "date": "2020-09-16T16:44:29", "name": "[RFC,5/5] build: replace use of old build macros", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "6679a646727fe7772d48f60c7631658cfdcf1634", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200916164429.244847-6-bruce.richardson@intel.com/mbox/", "series": [ { "id": 12283, "url": "http://patches.dpdk.org/api/series/12283/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12283", "date": "2020-09-16T16:44:24", "name": "rework feature enabling macros for compatibility", "version": 1, "mbox": "http://patches.dpdk.org/series/12283/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/77915/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/77915/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 56760A04B5;\n\tWed, 16 Sep 2020 18:45:32 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D04271D17A;\n\tWed, 16 Sep 2020 18:44:49 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n by dpdk.org (Postfix) with ESMTP id B217D1D161\n for <dev@dpdk.org>; Wed, 16 Sep 2020 18:44:46 +0200 (CEST)", "from orsmga005.jf.intel.com ([10.7.209.41])\n by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 16 Sep 2020 09:44:46 -0700", "from silpixa00399126.ir.intel.com ([10.237.222.27])\n by orsmga005.jf.intel.com with ESMTP; 16 Sep 2020 09:44:45 -0700" ], "IronPort-SDR": [ "\n b8hPDgmkznLKyGdF+ma+U61WtPDYI26m8s/uMGlTk8lxbSBKgc4Qt1uvvL+usY2FGWSAiAYORh\n FKuQBczBNk2Q==", "\n f/qY42nRuYQHvMFzXX7+j2bN80k3gJnTAqTuWzwxTlfhdHyY9kObMIhLKcu/gd9ngfD893/+rl\n buI06RRNSD0w==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9746\"; a=\"160441970\"", "E=Sophos;i=\"5.76,433,1592895600\"; d=\"scan'208\";a=\"160441970\"", "E=Sophos;i=\"5.76,433,1592895600\"; d=\"scan'208\";a=\"483381457\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "david.marchand@redhat.com", "Cc": "dev@dpdk.org,\n\tBruce Richardson <bruce.richardson@intel.com>", "Date": "Wed, 16 Sep 2020 17:44:29 +0100", "Message-Id": "<20200916164429.244847-6-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200916164429.244847-1-bruce.richardson@intel.com>", "References": "<20200916164429.244847-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [RFC PATCH 5/5] build: replace use of old build macros", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Use the newer macros defined by meson in all DPDK source code, to ensure\nthere are no errors when the old non-standard macros are removed.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\nNOTE: this patch is not suitable for backporting, but a new patch for this\nissue can be done for older releases if the other patches on this set are\naccepted and backported.\n---\n app/test-pmd/cmdline.c | 8 ++++----\n app/test-pmd/parameters.c | 12 ++++++------\n app/test-pmd/testpmd.c | 24 ++++++++++++------------\n app/test-pmd/testpmd.h | 4 ++--\n app/test/test_eal_flags.c | 4 ++--\n 5 files changed, 26 insertions(+), 26 deletions(-)", "diff": "diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c\nindex 0a6ed85f33..9ca052a1b9 100644\n--- a/app/test-pmd/cmdline.c\n+++ b/app/test-pmd/cmdline.c\n@@ -50,7 +50,7 @@\n #include <cmdline_parse_etheraddr.h>\n #include <cmdline_socket.h>\n #include <cmdline.h>\n-#ifdef RTE_LIBRTE_PMD_BOND\n+#ifdef RTE_LIBRTE_BOND_PMD\n #include <rte_eth_bond.h>\n #include <rte_eth_bond_8023ad.h>\n #endif\n@@ -597,7 +597,7 @@ static void cmd_help_long_parsed(void *parsed_result,\n \t\t\t\" Show the bypass configuration for a bypass enabled NIC\"\n \t\t\t\" using the lowest port on the NIC.\\n\\n\"\n \n-#ifdef RTE_LIBRTE_PMD_BOND\n+#ifdef RTE_LIBRTE_BOND_PMD\n \t\t\t\"create bonded device (mode) (socket)\\n\"\n \t\t\t\"\tCreate a new bonded device with specific bonding mode and socket.\\n\\n\"\n \n@@ -5732,7 +5732,7 @@ cmdline_parse_inst_t cmd_show_bypass_config = {\n \t},\n };\n \n-#ifdef RTE_LIBRTE_PMD_BOND\n+#ifdef RTE_LIBRTE_BOND_PMD\n /* *** SET BONDING MODE *** */\n struct cmd_set_bonding_mode_result {\n \tcmdline_fixed_string_t set;\n@@ -19430,7 +19430,7 @@ cmdline_parse_ctx_t main_ctx[] = {\n \t(cmdline_parse_inst_t *)&cmd_set_bypass_event,\n \t(cmdline_parse_inst_t *)&cmd_set_bypass_timeout,\n \t(cmdline_parse_inst_t *)&cmd_show_bypass_config,\n-#ifdef RTE_LIBRTE_PMD_BOND\n+#ifdef RTE_LIBRTE_BOND_PMD\n \t(cmdline_parse_inst_t *) &cmd_set_bonding_mode,\n \t(cmdline_parse_inst_t *) &cmd_show_bonding_config,\n \t(cmdline_parse_inst_t *) &cmd_set_bonding_primary,\ndiff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c\nindex 7cb0e3d6ec..4f6f6a34f1 100644\n--- a/app/test-pmd/parameters.c\n+++ b/app/test-pmd/parameters.c\n@@ -39,7 +39,7 @@\n #include <rte_ether.h>\n #include <rte_ethdev.h>\n #include <rte_string_fns.h>\n-#ifdef RTE_LIBRTE_PMD_BOND\n+#ifdef RTE_LIBRTE_BOND_PMD\n #include <rte_eth_bond.h>\n #endif\n #include <rte_flow.h>\n@@ -128,7 +128,7 @@ usage(char* progname)\n \t \"the packet will be enqueued into the rx drop-queue. \"\n \t \"If the drop-queue doesn't exist, the packet is dropped. \"\n \t \"By default drop-queue=127.\\n\");\n-#ifdef RTE_LIBRTE_LATENCY_STATS\n+#ifdef RTE_LIBRTE_LATENCYSTATS\n \tprintf(\" --latencystats=N: enable latency and jitter statistcs \"\n \t \"monitoring on forwarding lcore id N.\\n\");\n #endif\n@@ -610,10 +610,10 @@ launch_args_parse(int argc, char** argv)\n \t\t{ \"pkt-filter-report-hash\", 1, 0, 0 },\n \t\t{ \"pkt-filter-size\", 1, 0, 0 },\n \t\t{ \"pkt-filter-drop-queue\", 1, 0, 0 },\n-#ifdef RTE_LIBRTE_LATENCY_STATS\n+#ifdef RTE_LIBRTE_LATENCYSTATS\n \t\t{ \"latencystats\", 1, 0, 0 },\n #endif\n-#ifdef RTE_LIBRTE_BITRATE\n+#ifdef RTE_LIBRTE_BITRATESTATS\n \t\t{ \"bitrate-stats\", 1, 0, 0 },\n #endif\n \t\t{ \"disable-crc-strip\", 0, 0, 0 },\n@@ -973,7 +973,7 @@ launch_args_parse(int argc, char** argv)\n \t\t\t\t\t\t \"drop queue %d invalid - must\"\n \t\t\t\t\t\t \"be >= 0 \\n\", n);\n \t\t\t}\n-#ifdef RTE_LIBRTE_LATENCY_STATS\n+#ifdef RTE_LIBRTE_LATENCYSTATS\n \t\t\tif (!strcmp(lgopts[opt_idx].name,\n \t\t\t\t \"latencystats\")) {\n \t\t\t\tn = atoi(optarg);\n@@ -986,7 +986,7 @@ launch_args_parse(int argc, char** argv)\n \t\t\t\t\t\t \" must be >= 0\\n\", n);\n \t\t\t}\n #endif\n-#ifdef RTE_LIBRTE_BITRATE\n+#ifdef RTE_LIBRTE_BITRATESTATS\n \t\t\tif (!strcmp(lgopts[opt_idx].name, \"bitrate-stats\")) {\n \t\t\t\tn = atoi(optarg);\n \t\t\t\tif (n >= 0) {\ndiff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c\nindex 7842c3b781..68a6c979b6 100644\n--- a/app/test-pmd/testpmd.c\n+++ b/app/test-pmd/testpmd.c\n@@ -54,10 +54,10 @@\n #endif\n #include <rte_flow.h>\n #include <rte_metrics.h>\n-#ifdef RTE_LIBRTE_BITRATE\n+#ifdef RTE_LIBRTE_BITRATESTATS\n #include <rte_bitrate.h>\n #endif\n-#ifdef RTE_LIBRTE_LATENCY_STATS\n+#ifdef RTE_LIBRTE_LATENCYSTATS\n #include <rte_latencystats.h>\n #endif\n \n@@ -410,7 +410,7 @@ uint32_t bypass_timeout = RTE_PMD_IXGBE_BYPASS_TMT_OFF;\n #endif\n \n \n-#ifdef RTE_LIBRTE_LATENCY_STATS\n+#ifdef RTE_LIBRTE_LATENCYSTATS\n \n /*\n * Set when latency stats is enabled in the commandline\n@@ -478,7 +478,7 @@ uint8_t xstats_hide_zero;\n unsigned int num_sockets = 0;\n unsigned int socket_ids[RTE_MAX_NUMA_NODES];\n \n-#ifdef RTE_LIBRTE_BITRATE\n+#ifdef RTE_LIBRTE_BITRATESTATS\n /* Bitrate statistics */\n struct rte_stats_bitrates *bitrate_data;\n lcoreid_t bitrate_lcore_id;\n@@ -2063,7 +2063,7 @@ run_pkt_fwd_on_lcore(struct fwd_lcore *fc, packet_fwd_t pkt_fwd)\n \tstruct fwd_stream **fsm;\n \tstreamid_t nb_fs;\n \tstreamid_t sm_id;\n-#ifdef RTE_LIBRTE_BITRATE\n+#ifdef RTE_LIBRTE_BITRATESTATS\n \tuint64_t tics_per_1sec;\n \tuint64_t tics_datum;\n \tuint64_t tics_current;\n@@ -2078,7 +2078,7 @@ run_pkt_fwd_on_lcore(struct fwd_lcore *fc, packet_fwd_t pkt_fwd)\n \tdo {\n \t\tfor (sm_id = 0; sm_id < nb_fs; sm_id++)\n \t\t\t(*pkt_fwd)(fsm[sm_id]);\n-#ifdef RTE_LIBRTE_BITRATE\n+#ifdef RTE_LIBRTE_BITRATESTATS\n \t\tif (bitrate_enabled != 0 &&\n \t\t\t\tbitrate_lcore_id == rte_lcore_id()) {\n \t\t\ttics_current = rte_rdtsc();\n@@ -2091,7 +2091,7 @@ run_pkt_fwd_on_lcore(struct fwd_lcore *fc, packet_fwd_t pkt_fwd)\n \t\t\t}\n \t\t}\n #endif\n-#ifdef RTE_LIBRTE_LATENCY_STATS\n+#ifdef RTE_LIBRTE_LATENCYSTATS\n \t\tif (latencystats_enabled != 0 &&\n \t\t\t\tlatencystats_lcore_id == rte_lcore_id())\n \t\t\trte_latencystats_update();\n@@ -3641,7 +3641,7 @@ signal_handler(int signum)\n \t\t/* uninitialize packet capture framework */\n \t\trte_pdump_uninit();\n #endif\n-#ifdef RTE_LIBRTE_LATENCY_STATS\n+#ifdef RTE_LIBRTE_LATENCYSTATS\n \t\tif (latencystats_enabled != 0)\n \t\t\trte_latencystats_uninit();\n #endif\n@@ -3706,10 +3706,10 @@ main(int argc, char** argv)\n \t\t\t \"Check the core mask argument\\n\");\n \n \t/* Bitrate/latency stats disabled by default */\n-#ifdef RTE_LIBRTE_BITRATE\n+#ifdef RTE_LIBRTE_BITRATESTATS\n \tbitrate_enabled = 0;\n #endif\n-#ifdef RTE_LIBRTE_LATENCY_STATS\n+#ifdef RTE_LIBRTE_LATENCYSTATS\n \tlatencystats_enabled = 0;\n #endif\n \n@@ -3788,7 +3788,7 @@ main(int argc, char** argv)\n \t/* Init metrics library */\n \trte_metrics_init(rte_socket_id());\n \n-#ifdef RTE_LIBRTE_LATENCY_STATS\n+#ifdef RTE_LIBRTE_LATENCYSTATS\n \tif (latencystats_enabled != 0) {\n \t\tint ret = rte_latencystats_init(1, NULL);\n \t\tif (ret)\n@@ -3800,7 +3800,7 @@ main(int argc, char** argv)\n #endif\n \n \t/* Setup bitrate stats */\n-#ifdef RTE_LIBRTE_BITRATE\n+#ifdef RTE_LIBRTE_BITRATESTATS\n \tif (bitrate_enabled != 0) {\n \t\tbitrate_data = rte_stats_bitrate_create();\n \t\tif (bitrate_data == NULL)\ndiff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h\nindex 25a12b14f2..54d616ca75 100644\n--- a/app/test-pmd/testpmd.h\n+++ b/app/test-pmd/testpmd.h\n@@ -402,12 +402,12 @@ extern uint32_t param_total_num_mbufs;\n \n extern uint16_t stats_period;\n \n-#ifdef RTE_LIBRTE_LATENCY_STATS\n+#ifdef RTE_LIBRTE_LATENCYSTATS\n extern uint8_t latencystats_enabled;\n extern lcoreid_t latencystats_lcore_id;\n #endif\n \n-#ifdef RTE_LIBRTE_BITRATE\n+#ifdef RTE_LIBRTE_BITRATESTATS\n extern lcoreid_t bitrate_lcore_id;\n extern uint8_t bitrate_enabled;\n #endif\ndiff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c\nindex b019656b29..867b91bc24 100644\n--- a/app/test/test_eal_flags.c\n+++ b/app/test/test_eal_flags.c\n@@ -344,7 +344,7 @@ test_invalid_b_flag(void)\n static int\n test_invalid_vdev_flag(void)\n {\n-#ifdef RTE_LIBRTE_PMD_RING\n+#ifdef RTE_LIBRTE_RING_PMD\n #ifdef RTE_EXEC_ENV_FREEBSD\n \t/* BSD target doesn't support prefixes at this point, and we also need to\n \t * run another primary process here */\n@@ -1504,7 +1504,7 @@ test_eal_flags(void)\n \t\treturn ret;\n \t}\n \n-#ifdef RTE_LIBRTE_PMD_RING\n+#ifdef RTE_LIBRTE_RING_PMD\n \tret = test_invalid_vdev_flag();\n \tif (ret < 0) {\n \t\tprintf(\"Error in test_invalid_vdev_flag()\\n\");\n", "prefixes": [ "RFC", "5/5" ] }