Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/77913/?format=api
{ "id": 77913, "url": "http://patches.dpdk.org/api/patches/77913/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200916164429.244847-4-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200916164429.244847-4-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200916164429.244847-4-bruce.richardson@intel.com", "date": "2020-09-16T16:44:27", "name": "[RFC,3/5] meson: fix compatibility with make build defines", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a340bb9c964071c6eee3c71155ec2c339b9a7db9", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200916164429.244847-4-bruce.richardson@intel.com/mbox/", "series": [ { "id": 12283, "url": "http://patches.dpdk.org/api/series/12283/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12283", "date": "2020-09-16T16:44:24", "name": "rework feature enabling macros for compatibility", "version": 1, "mbox": "http://patches.dpdk.org/series/12283/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/77913/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/77913/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3EE8FA04B5;\n\tWed, 16 Sep 2020 18:45:11 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E96A41D170;\n\tWed, 16 Sep 2020 18:44:43 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n by dpdk.org (Postfix) with ESMTP id 477291D168;\n Wed, 16 Sep 2020 18:44:41 +0200 (CEST)", "from orsmga005.jf.intel.com ([10.7.209.41])\n by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 16 Sep 2020 09:44:41 -0700", "from silpixa00399126.ir.intel.com ([10.237.222.27])\n by orsmga005.jf.intel.com with ESMTP; 16 Sep 2020 09:44:39 -0700" ], "IronPort-SDR": [ "\n OXf/nwMJ+7aYakthd/8P52E7gQWNh+R4Qc8BEaP/Hee+hO0ZPnOOQvhIQ9hHB4Dh7eTmsE+Eex\n B4sNZOFdl5ig==", "\n SOE//fAQudU/kI4hfkecuhkr8tbwCH+c7dnfMxQoE+5NWmRLC3/it/8Nulwil2+us5nUNmcmFD\n wUetAdI5P6HA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9746\"; a=\"160441947\"", "E=Sophos;i=\"5.76,433,1592895600\"; d=\"scan'208\";a=\"160441947\"", "E=Sophos;i=\"5.76,433,1592895600\"; d=\"scan'208\";a=\"483381410\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "david.marchand@redhat.com", "Cc": "dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,\n stable@dpdk.org", "Date": "Wed, 16 Sep 2020 17:44:27 +0100", "Message-Id": "<20200916164429.244847-4-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200916164429.244847-1-bruce.richardson@intel.com>", "References": "<20200916164429.244847-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [RFC PATCH 3/5] meson: fix compatibility with make build\n\tdefines", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The defines used to indicate what crypto, compression and eventdev drivers\nwere being built were different to those used in the make build, with meson\ndefining them with \"_PMD\" at the end, while make defined them with \"_PMD\"\nin the middle and the specific driver name at the end. This might cause\ncompatibility issues for applications which used the older defines, which\nswitching to build against new DPDK releases.\n\nAs well as changing the default to match that of make, meson also\nspecial-cases the crypto/compression/event drivers to have both defines\nprovided, and puts in a deprecation notice to allow future removal of the\nmeson-original defines. This ensures compatibility for these macros with\nboth meson and make from older versions.\n\nFixes: dcadbbde8e61 (\"crypto/null: build with meson\")\nFixes: 3c32e89f68e1 (\"compress/isal: add skeleton ISA-L compression PMD\")\nFixes: eca504f318db (\"drivers/event: build skeleton and SW drivers with meson\")\n\nCc: stable@dpdk.org\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n doc/guides/rel_notes/deprecation.rst | 8 ++++++++\n drivers/compress/meson.build | 2 +-\n drivers/crypto/meson.build | 2 +-\n drivers/event/meson.build | 2 +-\n drivers/meson.build | 15 +++++++++++++++\n 5 files changed, 26 insertions(+), 3 deletions(-)", "diff": "diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst\nindex 52168f7751..5b5a52fa65 100644\n--- a/doc/guides/rel_notes/deprecation.rst\n+++ b/doc/guides/rel_notes/deprecation.rst\n@@ -11,6 +11,14 @@ here.\n Deprecation Notices\n -------------------\n \n+* build: The macros defined to indicate which crypto drivers, event drivers\n+ and which compression drivers have been\n+ included in the meson build are changing format from\n+ ``RTE_LIBRTE_<name>_PMD`` to ``RTE_LIBRTE_PMD_<name>`` to match those\n+ macros used for the drivers in the make build. Both sets of macros\n+ are present in this release, but those ending in ``_PMD`` will be removed\n+ in a future release, and should not be used.\n+\n * meson: The minimum supported version of meson for configuring and building\n DPDK will be increased to v0.47.1 (from 0.41) from DPDK 19.05 onwards. For\n those users with a version earlier than 0.47.1, an updated copy of meson\ndiff --git a/drivers/compress/meson.build b/drivers/compress/meson.build\nindex ee883c3f9f..bea1720a0b 100644\n--- a/drivers/compress/meson.build\n+++ b/drivers/compress/meson.build\n@@ -8,5 +8,5 @@ endif\n drivers = ['isal', 'octeontx', 'qat', 'zlib']\n \n std_deps = ['compressdev'] # compressdev pulls in all other needed deps\n-config_flag_fmt = 'RTE_LIBRTE_@0@_PMD'\n+config_flag_fmt = 'RTE_LIBRTE_PMD_@0@'\n driver_name_fmt = 'rte_pmd_@0@'\ndiff --git a/drivers/crypto/meson.build b/drivers/crypto/meson.build\nindex a2423507ad..25b99c19cb 100644\n--- a/drivers/crypto/meson.build\n+++ b/drivers/crypto/meson.build\n@@ -26,5 +26,5 @@ drivers = ['aesni_gcm',\n \t 'zuc']\n \n std_deps = ['cryptodev'] # cryptodev pulls in all other needed deps\n-config_flag_fmt = 'RTE_LIBRTE_@0@_PMD'\n+config_flag_fmt = 'RTE_LIBRTE_PMD_@0@'\n driver_name_fmt = 'rte_pmd_@0@'\ndiff --git a/drivers/event/meson.build b/drivers/event/meson.build\nindex ebe76a75c4..f2a3431472 100644\n--- a/drivers/event/meson.build\n+++ b/drivers/event/meson.build\n@@ -11,5 +11,5 @@ if not (toolchain == 'gcc' and cc.version().version_compare('<4.8.6') and\n \tdrivers += 'octeontx'\n endif\n std_deps = ['eventdev', 'kvargs']\n-config_flag_fmt = 'RTE_LIBRTE_@0@_EVENTDEV_PMD'\n+config_flag_fmt = 'RTE_LIBRTE_PMD_@0@_EVENTDEV'\n driver_name_fmt = 'rte_pmd_@0@_event'\ndiff --git a/drivers/meson.build b/drivers/meson.build\nindex 5f95265573..b5ac483d31 100644\n--- a/drivers/meson.build\n+++ b/drivers/meson.build\n@@ -117,6 +117,21 @@ foreach subpath:subdirs\n \t\t\t\tfmt_name = name\n \t\t\tendif\n \t\t\tdpdk_conf.set(config_flag_fmt.format(fmt_name.to_upper()),1)\n+\t\t\t# for driver compatibility, since we changed the\n+\t\t\t# default to match that of make. Remove in future release\n+\t\t\t# after following deprecation process\n+\t\t\tif config_flag_fmt.contains('_PMD_@0@') and (class == 'crypto'\n+\t\t\t\t\tor class == 'compress'\n+\t\t\t\t\tor class == 'event')\n+\t\t\t\talt_flag_fmt = '_@0@_PMD'.join(\n+\t\t\t\t\t\tconfig_flag_fmt.split('_PMD_@0@'))\n+\t\t\t\tif config_flag_fmt.contains('EVENTDEV')\n+\t\t\t\t\talt_flag_fmt = '_@0@_EVENTDEV_PMD'.join(\n+\t\t\t\t\t\tconfig_flag_fmt.split('_PMD_@0@_EVENTDEV'))\n+\t\t\t\tendif\n+\t\t\t\tdpdk_conf.set(alt_flag_fmt.format(\n+\t\t\t\t\t\tfmt_name.to_upper()), 1)\n+\t\t\tendif\n \t\t\tlib_name = driver_name_fmt.format(fmt_name)\n \n \t\t\tdpdk_extra_ldflags += pkgconfig_extra_libs\n", "prefixes": [ "RFC", "3/5" ] }