Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/77849/?format=api
{ "id": 77849, "url": "http://patches.dpdk.org/api/patches/77849/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200916042851.32914-21-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200916042851.32914-21-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200916042851.32914-21-ajit.khaparde@broadcom.com", "date": "2020-09-16T04:28:46", "name": "[v2,20/25] net/bnxt: fix out of bound access in bit handling", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ab5a4fc0abaff6fb64ba33f65d7907d9d36aeb32", "submitter": { "id": 501, "url": "http://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200916042851.32914-21-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 12255, "url": "http://patches.dpdk.org/api/series/12255/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12255", "date": "2020-09-16T04:28:26", "name": "patchset for bnxt", "version": 2, "mbox": "http://patches.dpdk.org/series/12255/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/77849/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/77849/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D52C6A04C7;\n\tWed, 16 Sep 2020 06:32:23 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id CC4791C202;\n\tWed, 16 Sep 2020 06:29:42 +0200 (CEST)", "from mail-pj1-f100.google.com (mail-pj1-f100.google.com\n [209.85.216.100]) by dpdk.org (Postfix) with ESMTP id 9D3FE1C1B7\n for <dev@dpdk.org>; Wed, 16 Sep 2020 06:29:18 +0200 (CEST)", "by mail-pj1-f100.google.com with SMTP id q4so900276pjh.5\n for <dev@dpdk.org>; Tue, 15 Sep 2020 21:29:18 -0700 (PDT)", "from localhost.localdomain ([192.19.223.252])\n by smtp-relay.gmail.com with ESMTPS id hk6sm132636pjb.6.2020.09.15.21.29.17\n (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n Tue, 15 Sep 2020 21:29:17 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com;\n s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=YeaT9EQ7tqM5dN0eVyHdarlpiiPRO+zM6/Zb3yBE2Bw=;\n b=N5qCQcDIBHQOiS6kZ8CexJkv05h/9pKEBl/BzswSmKfA0DoJc8THc+fmY0mampuhKI\n LeHGOFw8S234pqDS7ugPMZjhL9i7jLHMiMhXTqS2aa40/5LCugwkJhapEnL8QmU80/sK\n cSLaFkbdLywubef0xqAGUzczYbZ5WIyVIVzRQ=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=YeaT9EQ7tqM5dN0eVyHdarlpiiPRO+zM6/Zb3yBE2Bw=;\n b=ttugYQIyXqvVVuDiTVLYuLo5t0jMBf5KckruyxfI5kodX2mwC/xvQAF1m+bjgD12pJ\n Jc/dOx5xKTZWIcVTIvB9vmWPHdQf2MvxfsWcUCCLK/4t76q12hF4gtgNINBF36KKi6vr\n WlOViUrRHkaTTpWyHCxWBpnMy1YH69DAx5G5e05wjFA+WKs8oAGGq5PRVVVHh2OOd1pQ\n QgXQFu73t+gMBl6FEDogJ3grLjO5Gj5YvIQ3PNbrKdkew7nb1T+2YoBvJhB2RcmvR/HB\n 6j8zmG9A99MFJRCYLnLY7676XW4K6M31zuK4s/v5Ij1sxtFcqpi6meN+AHfTGmzzIIVu\n hXDQ==", "X-Gm-Message-State": "AOAM533ytrtG2CdQyYzHd1PAxSOfoxecG/h6g7+qAtGpAWeYfwIYG1oQ\n 7c1JhnJYx+0ZeWlrU3VBWjkOOyW+h4JyDwtOnoTqSPTyv7hBKEBHtfv8CVzGGLiLeox2RIIfNw9\n /Z8oF7ZWK+3anSeE+aVy/vpQ7AsqlD+HsSfizT6mAjez94LOlLKPIeDhzsOL7ElNvDbSzlftQ78\n Kd6w==", "X-Google-Smtp-Source": "\n ABdhPJymIOaSe/HjrFuglVHkRq89wav4X5UFYyBt6CKQCSfmbNduXidJDtddmDbv8Ru0YJHiVnX1piCvEdP5", "X-Received": "by 2002:a17:902:ba8a:b029:d1:e5e7:be70 with SMTP id\n k10-20020a170902ba8ab02900d1e5e7be70mr4649150pls.74.1600230557691;\n Tue, 15 Sep 2020 21:29:17 -0700 (PDT)", "X-Relaying-Domain": "broadcom.com", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "Kishore Padmanabha <kishore.padmanabha@broadcom.com>,\n Shahaji Bhosle <sbhosle@broadcom.com>,\n Mike Baucom <michael.baucom@broadcom.com>", "Date": "Tue, 15 Sep 2020 21:28:46 -0700", "Message-Id": "<20200916042851.32914-21-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.21.1 (Apple Git-122.3)", "In-Reply-To": "<20200916042851.32914-1-ajit.khaparde@broadcom.com>", "References": "<20200911015603.88359-1-ajit.khaparde@broadcom.com>\n <20200916042851.32914-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 20/25] net/bnxt: fix out of bound access in\n\tbit handling", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Kishore Padmanabha <kishore.padmanabha@broadcom.com>\n\nFix out of bounds access in action bit handling.\nThe act_val is changed to be array to resolve out of bound access issue.\n\nFixes: 52799debdf1c (\"net/bnxt: support action bitmap opcode\")\n\nSigned-off-by: Kishore Padmanabha <kishore.padmanabha@broadcom.com>\nReviewed-by: Shahaji Bhosle <sbhosle@broadcom.com>\nReviewed-by: Mike Baucom <michael.baucom@broadcom.com>\nReviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/tf_ulp/ulp_mapper.c | 11 +++++------\n 1 file changed, 5 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/tf_ulp/ulp_mapper.c b/drivers/net/bnxt/tf_ulp/ulp_mapper.c\nindex 15682673d..732141166 100644\n--- a/drivers/net/bnxt/tf_ulp/ulp_mapper.c\n+++ b/drivers/net/bnxt/tf_ulp/ulp_mapper.c\n@@ -782,7 +782,7 @@ ulp_mapper_result_field_process(struct bnxt_ulp_mapper_parms *parms,\n \tuint64_t regval;\n \tuint32_t val_size = 0, field_size = 0;\n \tuint64_t act_bit;\n-\tuint8_t act_val;\n+\tuint8_t act_val[16];\n \tuint64_t hdr_bit;\n \n \tswitch (fld->result_opcode) {\n@@ -824,19 +824,18 @@ ulp_mapper_result_field_process(struct bnxt_ulp_mapper_parms *parms,\n \t\t\treturn -EINVAL;\n \t\t}\n \t\tact_bit = tfp_be_to_cpu_64(act_bit);\n+\t\tmemset(act_val, 0, sizeof(act_val));\n \t\tif (ULP_BITMAP_ISSET(parms->act_bitmap->bits, act_bit))\n-\t\t\tact_val = 1;\n-\t\telse\n-\t\t\tact_val = 0;\n+\t\t\tact_val[0] = 1;\n \t\tif (fld->field_bit_size > ULP_BYTE_2_BITS(sizeof(act_val))) {\n \t\t\tBNXT_TF_DBG(ERR, \"%s field size is incorrect\\n\", name);\n \t\t\treturn -EINVAL;\n \t\t}\n-\t\tif (!ulp_blob_push(blob, &act_val, fld->field_bit_size)) {\n+\t\tif (!ulp_blob_push(blob, act_val, fld->field_bit_size)) {\n \t\t\tBNXT_TF_DBG(ERR, \"%s push field failed\\n\", name);\n \t\t\treturn -EINVAL;\n \t\t}\n-\t\tval = &act_val;\n+\t\tval = act_val;\n \t\tbreak;\n \tcase BNXT_ULP_MAPPER_OPC_SET_TO_ENCAP_ACT_PROP_SZ:\n \t\tif (!ulp_operand_read(fld->result_operand,\n", "prefixes": [ "v2", "20/25" ] }