Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/77572/?format=api
{ "id": 77572, "url": "http://patches.dpdk.org/api/patches/77572/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200913220711.3768597-17-thomas@monjalon.net/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200913220711.3768597-17-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20200913220711.3768597-17-thomas@monjalon.net", "date": "2020-09-13T22:07:07", "name": "[16/20] ethdev: remove old close behaviour", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "3837ef80a308d707792978f3c03f4e7611e22307", "submitter": { "id": 685, "url": "http://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200913220711.3768597-17-thomas@monjalon.net/mbox/", "series": [ { "id": 12173, "url": "http://patches.dpdk.org/api/series/12173/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12173", "date": "2020-09-13T22:06:51", "name": "cleanup ethdev close operation", "version": 1, "mbox": "http://patches.dpdk.org/series/12173/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/77572/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/77572/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id CB9AFA04C9;\n\tMon, 14 Sep 2020 00:10:38 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id EF52E1C11E;\n\tMon, 14 Sep 2020 00:10:21 +0200 (CEST)", "from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com\n [66.111.4.230]) by dpdk.org (Postfix) with ESMTP id 334DA1BE83\n for <dev@dpdk.org>; Mon, 14 Sep 2020 00:10:17 +0200 (CEST)", "from compute7.internal (compute7.nyi.internal [10.202.2.47])\n by mailnew.nyi.internal (Postfix) with ESMTP id 6CC875800D1;\n Sun, 13 Sep 2020 18:08:48 -0400 (EDT)", "from mailfrontend2 ([10.202.2.163])\n by compute7.internal (MEProxy); Sun, 13 Sep 2020 18:08:48 -0400", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n by mail.messagingengine.com (Postfix) with ESMTPA id ADB853064674;\n Sun, 13 Sep 2020 18:08:40 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding; s=fm2; bh=7UBbM3U+OMg92\n LDUxPlQ+RWPt4FCDBioPbMcYVM8+ss=; b=nTqP3IhhWgoAGofXk/33+1lMmECzs\n YyTOFpaVJymeF150y8jxvbgULxGFxQcGmXprkbg/Z+OjDnNoNqj109+lfz7ZNnoZ\n JCSZQ2wRVQ9YAJr0scTLDu9JN1g4fv4Y/Fj9ZxaaUjXWGLewQD0vs4i1iN20VThj\n a0x9xEq3kTZbm0x83ZgjuihjNdS8YqMPdo52Q0l3Mvg2qLdUCORdApncXfVj1YaW\n Z4RDKLX7BBgeeEmiHA0NfTtHas4ojfg15umJi4caYd9VBOkxNR8BhDdOO/t/52PC\n pLUZSgIE3MvYiU1+39I7Ld9zn925aaRKSx2QPu92+bRb5vOebsdET+hAA==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:content-transfer-encoding:date:from\n :in-reply-to:message-id:mime-version:references:subject:to\n :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=\n fm3; bh=7UBbM3U+OMg92LDUxPlQ+RWPt4FCDBioPbMcYVM8+ss=; b=J+fV8ADf\n uICHsRuCZXO/XjDL3veE79hmmyN1H+uasxU9o/Bo/1TxiyCyisc9VZ2MIEG2veRS\n l3/2oy8zkK0/zmrFTSS14Lux/LIdim9aL3AKDDvE8CBhcCgydQT8LuMxr8K+yyY+\n sFUL+rV7g5Pi3+iBiNXx1Pm+Gah3TkKzlaCRRuXDShOh51MYUv5mv+xxeIUNAhyV\n aypVRzU57eYF8PHr+eZSSzwr3Ci/RoK/AqJ4G31Hr1A/gjm6411WEOq5e5vPh6AN\n e/N+4N+nxxIzLztjGs/LrH26KShFCbqjGJ09LJMyQoFqwNhkqbDRueEHM1JKYtLH\n /cA1ARAFOlbllw==" ], "X-ME-Sender": "<xms:b5heX2g8-VAeo8gmbVDz-DwwWNJp8YUakKk4VDND3T2hQyD-nXSUYw>\n <xme:b5heX3BEOo7nFbO6pvbdOg7jdXcGlyCNoZKwtljU2EgDYe2agAUXOJD7sUgaQefW0\n t6oiUKYtutDA7IXow>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgeduiedrudeihedgtdehucetufdoteggodetrfdotf\n fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen\n uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne\n cujfgurhephffvufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefvhhhomhgr\n shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg\n ftrfgrthhtvghrnhephedtudeugfegkeevheeuiedtfefhvdekveetvdefiedvffduuedu\n heduteeivddunecuffhomhgrihhnpeguphgukhdrohhrghenucfkphepjeejrddufeegrd\n dvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhf\n rhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth", "X-ME-Proxy": "<xmx:b5heX-Eb7BZmIcE7RvRZde42uZ6XNNK7AsEo6MayNKxhVBDbc9aLyQ>\n <xmx:b5heX_Rw4_nhVgdVjdYbmfZYeMgwQJ7hjaE3VPaWxYRS-75N1jhnxQ>\n <xmx:b5heXzwUhrLC9OpJQciKL7DSCg7elK9C0VIavf4b9AupCAcQJTADFg>\n <xmx:cJheX7bb-U5DspT_vyxhrv8Uk7YljAEhbNsz_7q_M4xAq16JEay0JA>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com,\tarybchenko@solarflare.com,\n Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>,\n Rosen Xu <rosen.xu@intel.com>,\tShijith Thotton <sthotton@marvell.com>,\n Srisivasubramanian Srinivasan <srinivasan@marvell.com>,\n Rasesh Mody <rmody@marvell.com>,\tShahed Shaikh <shshaikh@marvell.com>,\n Heinrich Kuhn <heinrich.kuhn@netronome.com>,\n Hemant Agrawal <hemant.agrawal@nxp.com>,\n Sachin Saxena <sachin.saxena@nxp.com>,\tGagandeep Singh <g.singh@nxp.com>,\n Akhil Goyal <akhil.goyal@nxp.com>,\n Alfredo Cardigliano <cardigliano@ntop.org>,\tRay Kinsella <mdr@ashroe.eu>,\n Neil Horman <nhorman@tuxdriver.com>,\n John McNamara <john.mcnamara@intel.com>,\n Marko Kovacevic <marko.kovacevic@intel.com>,\n \"John W. Linville\" <linville@tuxdriver.com>,\n Ciara Loftus <ciara.loftus@intel.com>,\tQi Zhang <qi.z.zhang@intel.com>,\n Shepard Siegel <shepard.siegel@atomicrules.com>,\n Ed Czeck <ed.czeck@atomicrules.com>,\n John Miller <john.miller@atomicrules.com>,\n Igor Russkikh <igor.russkikh@aquantia.com>,\n Pavel Belous <pavel.belous@aquantia.com>,\n Steven Webster <steven.webster@windriver.com>,\n Matt Peters <matt.peters@windriver.com>,\n Somalapuram Amaranath <asomalap@amd.com>,\n Ajit Khaparde <ajit.khaparde@broadcom.com>,\n Somnath Kotur <somnath.kotur@broadcom.com>, Chas Williams <chas3@att.com>,\n \"Wei Hu (Xavier)\" <xavier.huwei@huawei.com>,\n Wei Zhao <wei.zhao1@intel.com>,\tJeff Guo <jia.guo@intel.com>,\n Marcin Wojtas <mw@semihalf.com>,\tMichal Krawczyk <mk@semihalf.com>,\n Guy Tzalik <gtzalik@amazon.com>,\tEvgeny Schemeilin <evgenys@amazon.com>,\n Igor Chauskin <igorch@amazon.com>,\tJohn Daley <johndale@cisco.com>,\n Hyong Youb Kim <hyonkim@cisco.com>,\tGaetan Rivet <grive@u256.net>,\n Xiao Wang <xiao.w.wang@intel.com>,\tZiyang Xuan <xuanziyang2@huawei.com>,\n Xiaoyun Wang <cloud.wangxiaoyun@huawei.com>,\n Guoyang Zhou <zhouguoyang@huawei.com>,\n \"Min Hu (Connor)\" <humin29@huawei.com>,\n Yisen Zhuang <yisen.zhuang@huawei.com>,\n Beilei Xing <beilei.xing@intel.com>,\tJingjing Wu <jingjing.wu@intel.com>,\n Qiming Yang <qiming.yang@intel.com>,\tJakub Grajciar <jgrajcia@cisco.com>,\n Matan Azrad <matan@mellanox.com>,\tShahaf Shuler <shahafs@mellanox.com>,\n Viacheslav Ovsiienko <viacheslavo@mellanox.com>,\n Zyta Szpak <zr@semihalf.com>,\tLiron Himi <lironh@marvell.com>,\n Stephen Hemminger <sthemmin@microsoft.com>,\n \"K. Y. Srinivasan\" <kys@microsoft.com>,\n Haiyang Zhang <haiyangz@microsoft.com>,\tLong Li <longli@microsoft.com>,\n Martin Spinler <spinler@cesnet.cz>,\tTetsuya Mukawa <mtetsuyah@gmail.com>,\n Harman Kalra <hkalra@marvell.com>,\tJerin Jacob <jerinj@marvell.com>,\n Nithin Dabilpuram <ndabilpuram@marvell.com>,\n Kiran Kumar K <kirankumark@marvell.com>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Jasvinder Singh <jasvinder.singh@intel.com>,\n Cristian Dumitrescu <cristian.dumitrescu@intel.com>,\n Keith Wiles <keith.wiles@intel.com>,\n Maxime Coquelin <maxime.coquelin@redhat.com>,\n Chenbo Xia <chenbo.xia@intel.com>,\tZhihong Wang <zhihong.wang@intel.com>,\n Yong Wang <yongwang@vmware.com>", "Date": "Mon, 14 Sep 2020 00:07:07 +0200", "Message-Id": "<20200913220711.3768597-17-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20200913220711.3768597-1-thomas@monjalon.net>", "References": "<20200913220711.3768597-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 16/20] ethdev: remove old close behaviour", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The temporary flag RTE_ETH_DEV_CLOSE_REMOVE is removed.\nIt was introduced in DPDK 18.11 in order to give time for PMDs to migrate.\n\nThe old behaviour was to free only queues when closing a port.\nThe new behaviour is calling rte_eth_dev_release_port() which does\nthree more tasks:\n\t- trigger event callback\n\t- reset state and few pointers\n\t- free all generic port resources\n\nThe private port resources must be released in the .dev_close callback.\n\nThe .remove callback should:\n\t- call .dev_close callback\n\t- call rte_eth_dev_release_port()\n\t- free multi-port device shared resources\n\nDespite waiting two years, some drivers have not migrated,\nso they may hit issues with the incompatible new behaviour.\nAfter sending emails, adding logs, and announcing the deprecation,\nthe only last solution is to declare these drivers as unmaintained:\n\tbnx2x, cxgbe, dpaa, dpaa2, enetc, ionic,\n\tipn3ke,\tliquidio, nfp, pfe, qede\nBelow is a summary of what to implement in those drivers.\n\n* The freeing of private port resources must be moved\nfrom the \".remove(device)\" function to the \".dev_close(port)\" function.\n\n* If a generic resource (.mac_addrs or .hash_mac_addrs) cannot be freed,\nit must be set to NULL in \".dev_close\" function to protect from\nsubsequent rte_eth_dev_release_port() freeing.\n\n* Note 1:\nThe generic resources are freed in rte_eth_dev_release_port(),\nafter \".dev_close\" is called in rte_eth_dev_close(), but not when\ncalling \".dev_close\" directly from the \".remove\" PMD function.\nThat's why rte_eth_dev_release_port() must still be called explicitly\nfrom \".remove(device)\" after calling the \".dev_close\" PMD function.\n\n* Note 2:\nIf a device can have multiple ports, the common resources must be freed\nonly in the \".remove(device)\" function.\n\n* Note 3:\nThe port is supposed to be in a stopped state when it is closed.\nIf it is not the case, it is free to the PMD implementation\nhow to react when trying to close a non-stopped port:\neither try to stop it automatically or just return an error.\n\nCc: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>\nCc: Rosen Xu <rosen.xu@intel.com>\nCc: Shijith Thotton <sthotton@marvell.com>\nCc: Srisivasubramanian Srinivasan <srinivasan@marvell.com>\nCc: Rasesh Mody <rmody@marvell.com>\nCc: Shahed Shaikh <shshaikh@marvell.com>\nCc: Heinrich Kuhn <heinrich.kuhn@netronome.com>\nCc: Hemant Agrawal <hemant.agrawal@nxp.com>\nCc: Sachin Saxena <sachin.saxena@nxp.com>\nCc: Gagandeep Singh <g.singh@nxp.com>\nCc: Akhil Goyal <akhil.goyal@nxp.com>\nCc: Alfredo Cardigliano <cardigliano@ntop.org>\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\n---\n MAINTAINERS | 22 +++++++++++-----------\n doc/guides/rel_notes/deprecation.rst | 6 ------\n drivers/net/af_packet/rte_eth_af_packet.c | 1 -\n drivers/net/af_xdp/rte_eth_af_xdp.c | 2 --\n drivers/net/ark/ark_ethdev.c | 2 --\n drivers/net/atlantic/atl_ethdev.c | 2 --\n drivers/net/avp/avp_ethdev.c | 2 --\n drivers/net/axgbe/axgbe_ethdev.c | 1 -\n drivers/net/bnxt/bnxt_ethdev.c | 5 -----\n drivers/net/bnxt/bnxt_reps.c | 4 ----\n drivers/net/bonding/rte_eth_bond_pmd.c | 1 -\n drivers/net/e1000/em_ethdev.c | 5 -----\n drivers/net/e1000/igb_ethdev.c | 10 ----------\n drivers/net/ena/ena_ethdev.c | 6 ------\n drivers/net/enic/enic_ethdev.c | 2 --\n drivers/net/failsafe/failsafe.c | 1 -\n drivers/net/fm10k/fm10k_ethdev.c | 5 -----\n drivers/net/hinic/hinic_pmd_ethdev.c | 6 ------\n drivers/net/hns3/hns3_ethdev.c | 5 -----\n drivers/net/hns3/hns3_ethdev_vf.c | 5 -----\n drivers/net/i40e/i40e_ethdev.c | 5 -----\n drivers/net/i40e/i40e_ethdev_vf.c | 5 -----\n drivers/net/iavf/iavf_ethdev.c | 5 -----\n drivers/net/ice/ice_dcf_ethdev.c | 2 --\n drivers/net/ice/ice_ethdev.c | 5 -----\n drivers/net/igc/igc_ethdev.c | 5 -----\n drivers/net/ixgbe/ixgbe_ethdev.c | 10 ----------\n drivers/net/kni/rte_eth_kni.c | 2 --\n drivers/net/memif/rte_eth_memif.c | 3 ---\n drivers/net/mlx4/mlx4.c | 1 -\n drivers/net/mlx5/linux/mlx5_os.c | 2 --\n drivers/net/mvneta/mvneta_ethdev.c | 3 ---\n drivers/net/mvpp2/mrvl_ethdev.c | 3 ---\n drivers/net/netvsc/hn_ethdev.c | 3 ---\n drivers/net/nfb/nfb_ethdev.c | 3 ---\n drivers/net/null/rte_eth_null.c | 1 -\n drivers/net/octeontx/octeontx_ethdev.c | 1 -\n drivers/net/octeontx2/otx2_ethdev.c | 1 -\n drivers/net/pcap/rte_eth_pcap.c | 1 -\n drivers/net/ring/rte_eth_ring.c | 1 -\n drivers/net/sfc/sfc_ethdev.c | 4 +---\n drivers/net/softnic/rte_eth_softnic.c | 1 -\n drivers/net/szedata2/rte_eth_szedata2.c | 3 ---\n drivers/net/tap/rte_eth_tap.c | 2 +-\n drivers/net/vhost/rte_eth_vhost.c | 2 +-\n drivers/net/virtio/virtio_ethdev.c | 5 -----\n drivers/net/vmxnet3/vmxnet3_ethdev.c | 3 ---\n lib/librte_ethdev/rte_ethdev.c | 17 +----------------\n lib/librte_ethdev/rte_ethdev.h | 8 +-------\n 49 files changed, 16 insertions(+), 184 deletions(-)", "diff": "diff --git a/MAINTAINERS b/MAINTAINERS\nindex 3b16d7a4b8..98aa24412e 100644\n--- a/MAINTAINERS\n+++ b/MAINTAINERS\n@@ -605,7 +605,7 @@ F: drivers/net/thunderx/\n F: doc/guides/nics/thunderx.rst\n F: doc/guides/nics/features/thunderx.ini\n \n-Cavium LiquidIO\n+Cavium LiquidIO - UNMAINTAINED\n M: Shijith Thotton <sthotton@marvell.com>\n M: Srisivasubramanian Srinivasan <srinivasan@marvell.com>\n T: git://dpdk.org/next/dpdk-next-net-mrvl\n@@ -622,7 +622,7 @@ F: drivers/net/octeontx/\n F: doc/guides/nics/octeontx.rst\n F: doc/guides/nics/features/octeontx.ini\n \n-Chelsio cxgbe\n+Chelsio cxgbe - UNMAINTAINED\n M: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>\n F: drivers/net/cxgbe/\n F: doc/guides/nics/cxgbe.rst\n@@ -711,7 +711,7 @@ F: drivers/net/igc/\n F: doc/guides/nics/igc.rst\n F: doc/guides/nics/features/igc.ini\n \n-Intel ipn3ke\n+Intel ipn3ke - UNMAINTAINED\n M: Rosen Xu <rosen.xu@intel.com>\n T: git://dpdk.org/next/dpdk-next-net-intel\n F: drivers/net/ipn3ke/\n@@ -794,13 +794,13 @@ F: drivers/net/nfb/\n F: doc/guides/nics/nfb.rst\n F: doc/guides/nics/features/nfb.ini\n \n-Netronome nfp\n+Netronome nfp - UNMAINTAINED\n M: Heinrich Kuhn <heinrich.kuhn@netronome.com>\n F: drivers/net/nfp/\n F: doc/guides/nics/nfp.rst\n F: doc/guides/nics/features/nfp*.ini\n \n-NXP dpaa\n+NXP dpaa - UNMAINTAINED\n M: Hemant Agrawal <hemant.agrawal@nxp.com>\n M: Sachin Saxena <sachin.saxena@nxp.com>\n F: drivers/mempool/dpaa/\n@@ -808,7 +808,7 @@ F: drivers/net/dpaa/\n F: doc/guides/nics/dpaa.rst\n F: doc/guides/nics/features/dpaa.ini\n \n-NXP dpaa2\n+NXP dpaa2 - UNMAINTAINED\n M: Hemant Agrawal <hemant.agrawal@nxp.com>\n M: Sachin Saxena <sachin.saxena@nxp.com>\n F: drivers/mempool/dpaa2/\n@@ -816,27 +816,27 @@ F: drivers/net/dpaa2/\n F: doc/guides/nics/dpaa2.rst\n F: doc/guides/nics/features/dpaa2.ini\n \n-NXP enetc\n+NXP enetc - UNMAINTAINED\n M: Gagandeep Singh <g.singh@nxp.com>\n M: Sachin Saxena <sachin.saxena@nxp.com>\n F: drivers/net/enetc/\n F: doc/guides/nics/enetc.rst\n F: doc/guides/nics/features/enetc.ini\n \n-NXP pfe\n+NXP pfe - UNMAINTAINED\n M: Gagandeep Singh <g.singh@nxp.com>\n M: Akhil Goyal <akhil.goyal@nxp.com>\n F: doc/guides/nics/pfe.rst\n F: drivers/net/pfe/\n F: doc/guides/nics/features/pfe.ini\n \n-Pensando ionic\n+Pensando ionic - UNMAINTAINED\n M: Alfredo Cardigliano <cardigliano@ntop.org>\n F: drivers/net/ionic/\n F: doc/guides/nics/ionic.rst\n F: doc/guides/nics/features/ionic.ini\n \n-QLogic bnx2x\n+QLogic bnx2x - UNMAINTAINED\n M: Rasesh Mody <rmody@marvell.com>\n M: Shahed Shaikh <shshaikh@marvell.com>\n T: git://dpdk.org/next/dpdk-next-net-mrvl\n@@ -844,7 +844,7 @@ F: drivers/net/bnx2x/\n F: doc/guides/nics/bnx2x.rst\n F: doc/guides/nics/features/bnx2x*.ini\n \n-QLogic qede PMD\n+QLogic qede PMD - UNMAINTAINED\n M: Rasesh Mody <rmody@marvell.com>\n M: Shahed Shaikh <shshaikh@marvell.com>\n T: git://dpdk.org/next/dpdk-next-net-mrvl\ndiff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst\nindex 88d7d07613..a9d937a43c 100644\n--- a/doc/guides/rel_notes/deprecation.rst\n+++ b/doc/guides/rel_notes/deprecation.rst\n@@ -189,12 +189,6 @@ Deprecation Notices\n - ``rte_eth_dev_stop``\n - ``rte_eth_dev_close``\n \n-* ethdev: The temporary flag RTE_ETH_DEV_CLOSE_REMOVE will be removed in 20.11.\n- As a consequence, the new behaviour introduced in 18.11 will be effective\n- for all drivers: generic port resources are freed on close operation.\n- Private resources are expected to be released in the ``dev_close`` callback.\n- More details in http://inbox.dpdk.org/dev/5248162.j6AOsuQRmx@thomas/\n-\n * ethdev: New offload flags ``DEV_RX_OFFLOAD_FLOW_MARK`` will be added in 19.11.\n This will allow application to enable or disable PMDs from updating\n ``rte_mbuf::hash::fdir``.\ndiff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c\nindex 3ab6f4d388..ff222c3dac 100644\n--- a/drivers/net/af_packet/rte_eth_af_packet.c\n+++ b/drivers/net/af_packet/rte_eth_af_packet.c\n@@ -859,7 +859,6 @@ rte_pmd_init_internals(struct rte_vdev_device *dev,\n \tdata->nb_tx_queues = (uint16_t)nb_queues;\n \tdata->dev_link = pmd_link;\n \tdata->mac_addrs = &(*internals)->eth_addr;\n-\tdata->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;\n \n \t(*eth_dev)->dev_ops = &ops;\n \ndiff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c b/drivers/net/af_xdp/rte_eth_af_xdp.c\nindex bac9729bf8..2eabc6437f 100644\n--- a/drivers/net/af_xdp/rte_eth_af_xdp.c\n+++ b/drivers/net/af_xdp/rte_eth_af_xdp.c\n@@ -1269,8 +1269,6 @@ init_internals(struct rte_vdev_device *dev, const char *if_name,\n \teth_dev->dev_ops = &ops;\n \teth_dev->rx_pkt_burst = eth_af_xdp_rx;\n \teth_dev->tx_pkt_burst = eth_af_xdp_tx;\n-\t/* Let rte_eth_dev_close() release the port resources. */\n-\teth_dev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;\n \n #if defined(XDP_UMEM_UNALIGNED_CHUNK_FLAG)\n \tAF_XDP_LOG(INFO, \"Zero copy between umem and mbuf enabled.\\n\");\ndiff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c\nindex 9e1f8218a8..8012af75ee 100644\n--- a/drivers/net/ark/ark_ethdev.c\n+++ b/drivers/net/ark/ark_ethdev.c\n@@ -261,8 +261,6 @@ eth_ark_dev_init(struct rte_eth_dev *dev)\n \t/* Use dummy function until setup */\n \tdev->rx_pkt_burst = ð_ark_recv_pkts_noop;\n \tdev->tx_pkt_burst = ð_ark_xmit_pkts_noop;\n-\t/* Let rte_eth_dev_close() release the port resources */\n-\tdev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;\n \n \tark->bar0 = (uint8_t *)pci_dev->mem_resource[0].addr;\n \tark->a_bar = (uint8_t *)pci_dev->mem_resource[2].addr;\ndiff --git a/drivers/net/atlantic/atl_ethdev.c b/drivers/net/atlantic/atl_ethdev.c\nindex 16721a011f..751c81b9c1 100644\n--- a/drivers/net/atlantic/atl_ethdev.c\n+++ b/drivers/net/atlantic/atl_ethdev.c\n@@ -379,8 +379,6 @@ eth_atl_dev_init(struct rte_eth_dev *eth_dev)\n \tif (rte_eal_process_type() != RTE_PROC_PRIMARY)\n \t\treturn 0;\n \n-\teth_dev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;\n-\n \t/* Vendor and Device ID need to be set before init of shared code */\n \thw->device_id = pci_dev->id.device_id;\n \thw->vendor_id = pci_dev->id.vendor_id;\ndiff --git a/drivers/net/avp/avp_ethdev.c b/drivers/net/avp/avp_ethdev.c\nindex 2eed6acc3f..c730b7ab86 100644\n--- a/drivers/net/avp/avp_ethdev.c\n+++ b/drivers/net/avp/avp_ethdev.c\n@@ -957,8 +957,6 @@ eth_avp_dev_init(struct rte_eth_dev *eth_dev)\n \teth_dev->dev_ops = &avp_eth_dev_ops;\n \teth_dev->rx_pkt_burst = &avp_recv_pkts;\n \teth_dev->tx_pkt_burst = &avp_xmit_pkts;\n-\t/* Let rte_eth_dev_close() release the port resources */\n-\teth_dev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;\n \n \tif (rte_eal_process_type() != RTE_PROC_PRIMARY) {\n \t\t/*\ndiff --git a/drivers/net/axgbe/axgbe_ethdev.c b/drivers/net/axgbe/axgbe_ethdev.c\nindex c5e70ea0a1..246e09016c 100644\n--- a/drivers/net/axgbe/axgbe_ethdev.c\n+++ b/drivers/net/axgbe/axgbe_ethdev.c\n@@ -1623,7 +1623,6 @@ eth_axgbe_dev_init(struct rte_eth_dev *eth_dev)\n \tint ret;\n \n \teth_dev->dev_ops = &axgbe_eth_dev_ops;\n-\teth_dev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;\n \n \t/*\n \t * For secondary processes, we don't initialise any further as primary\ndiff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex 02e53bf04d..c580aff96b 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -5744,11 +5744,6 @@ bnxt_dev_init(struct rte_eth_dev *eth_dev, void *params __rte_unused)\n \n \tbnxt_alloc_switch_domain(bp);\n \n-\t/* Pass the information to the rte_eth_dev_close() that it should also\n-\t * release the private port resources.\n-\t */\n-\teth_dev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;\n-\n \tPMD_DRV_LOG(INFO,\n \t\t DRV_MODULE_NAME \"found at mem %\" PRIX64 \", node addr %pM\\n\",\n \t\t pci_dev->mem_resource[0].phys_addr,\ndiff --git a/drivers/net/bnxt/bnxt_reps.c b/drivers/net/bnxt/bnxt_reps.c\nindex fa014125e3..ceb0604216 100644\n--- a/drivers/net/bnxt/bnxt_reps.c\n+++ b/drivers/net/bnxt/bnxt_reps.c\n@@ -186,10 +186,6 @@ int bnxt_vf_representor_init(struct rte_eth_dev *eth_dev, void *params)\n \tPMD_DRV_LOG(INFO, \"calling bnxt_print_link_info\\n\");\n \tbnxt_print_link_info(eth_dev);\n \n-\t/* Pass the information to the rte_eth_dev_close() that it should also\n-\t * release the private port resources.\n-\t */\n-\teth_dev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;\n \tPMD_DRV_LOG(INFO,\n \t\t \"Switch domain id %d: Representor Device %d init done\\n\",\n \t\t vf_rep_bp->switch_domain_id, vf_rep_bp->vf_id);\ndiff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c\nindex 726b47055b..f9603d16a5 100644\n--- a/drivers/net/bonding/rte_eth_bond_pmd.c\n+++ b/drivers/net/bonding/rte_eth_bond_pmd.c\n@@ -3209,7 +3209,6 @@ bond_alloc(struct rte_vdev_device *dev, uint8_t mode)\n \t}\n \n \tinternals = eth_dev->data->dev_private;\n-\teth_dev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;\n \teth_dev->data->nb_rx_queues = (uint16_t)1;\n \teth_dev->data->nb_tx_queues = (uint16_t)1;\n \ndiff --git a/drivers/net/e1000/em_ethdev.c b/drivers/net/e1000/em_ethdev.c\nindex 45d3949ff7..7d592e0313 100644\n--- a/drivers/net/e1000/em_ethdev.c\n+++ b/drivers/net/e1000/em_ethdev.c\n@@ -297,11 +297,6 @@ eth_em_dev_init(struct rte_eth_dev *eth_dev)\n \trte_ether_addr_copy((struct rte_ether_addr *)hw->mac.addr,\n \t\teth_dev->data->mac_addrs);\n \n-\t/* Pass the information to the rte_eth_dev_close() that it should also\n-\t * release the private port resources.\n-\t */\n-\teth_dev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;\n-\n \t/* initialize the vfta */\n \tmemset(shadow_vfta, 0, sizeof(*shadow_vfta));\n \ndiff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c\nindex 564216b0a4..c7b2244890 100644\n--- a/drivers/net/e1000/igb_ethdev.c\n+++ b/drivers/net/e1000/igb_ethdev.c\n@@ -844,11 +844,6 @@ eth_igb_dev_init(struct rte_eth_dev *eth_dev)\n \trte_ether_addr_copy((struct rte_ether_addr *)hw->mac.addr,\n \t\t\tð_dev->data->mac_addrs[0]);\n \n-\t/* Pass the information to the rte_eth_dev_close() that it should also\n-\t * release the private port resources.\n-\t */\n-\teth_dev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;\n-\n \t/* initialize the vfta */\n \tmemset(shadow_vfta, 0, sizeof(*shadow_vfta));\n \n@@ -997,11 +992,6 @@ eth_igbvf_dev_init(struct rte_eth_dev *eth_dev)\n \t\treturn -ENOMEM;\n \t}\n \n-\t/* Pass the information to the rte_eth_dev_close() that it should also\n-\t * release the private port resources.\n-\t */\n-\teth_dev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;\n-\n \t/* Generate a random MAC address, if none was assigned by PF. */\n \tif (rte_is_zero_ether_addr(perm_addr)) {\n \t\trte_eth_random_addr(perm_addr->addr_bytes);\ndiff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c\nindex ea979fddd1..9d91ff0708 100644\n--- a/drivers/net/ena/ena_ethdev.c\n+++ b/drivers/net/ena/ena_ethdev.c\n@@ -1863,12 +1863,6 @@ static int eth_ena_dev_init(struct rte_eth_dev *eth_dev)\n \t\t\tget_feat_ctx.dev_attr.mac_addr,\n \t\t\t(struct rte_ether_addr *)adapter->mac_addr);\n \n-\t/*\n-\t * Pass the information to the rte_eth_dev_close() that it should also\n-\t * release the private port resources.\n-\t */\n-\teth_dev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;\n-\n \tadapter->drv_stats = rte_zmalloc(\"adapter stats\",\n \t\t\t\t\t sizeof(*adapter->drv_stats),\n \t\t\t\t\t RTE_CACHE_LINE_SIZE);\ndiff --git a/drivers/net/enic/enic_ethdev.c b/drivers/net/enic/enic_ethdev.c\nindex b14ed00085..0674c668b4 100644\n--- a/drivers/net/enic/enic_ethdev.c\n+++ b/drivers/net/enic/enic_ethdev.c\n@@ -1293,8 +1293,6 @@ static int eth_enicpmd_dev_init(struct rte_eth_dev *eth_dev)\n \tenic->port_id = eth_dev->data->port_id;\n \tenic->rte_dev = eth_dev;\n \tenic->dev_data = eth_dev->data;\n-\t/* Let rte_eth_dev_close() release the port resources */\n-\teth_dev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;\n \n \tpdev = RTE_ETH_DEV_TO_PCI(eth_dev);\n \trte_eth_copy_pci_info(eth_dev, pdev);\ndiff --git a/drivers/net/failsafe/failsafe.c b/drivers/net/failsafe/failsafe.c\nindex 44d47e8f72..b921e101e6 100644\n--- a/drivers/net/failsafe/failsafe.c\n+++ b/drivers/net/failsafe/failsafe.c\n@@ -180,7 +180,6 @@ fs_eth_dev_create(struct rte_vdev_device *vdev)\n \t\tERROR(\"Unable to allocate rte_eth_dev\");\n \t\treturn -1;\n \t}\n-\tdev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;\n \tpriv = PRIV(dev);\n \tpriv->data = dev->data;\n \tpriv->rxp = FS_RX_PROXY_INIT;\ndiff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c\nindex 82f46cebf5..22e68be448 100644\n--- a/drivers/net/fm10k/fm10k_ethdev.c\n+++ b/drivers/net/fm10k/fm10k_ethdev.c\n@@ -3132,11 +3132,6 @@ eth_fm10k_dev_init(struct rte_eth_dev *dev)\n \t\t&dev->data->mac_addrs[0]);\n \t}\n \n-\t/* Pass the information to the rte_eth_dev_close() that it should also\n-\t * release the private port resources.\n-\t */\n-\tdev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;\n-\n \t/* Reset the hw statistics */\n \tdiag = fm10k_stats_reset(dev);\n \tif (diag != 0) {\ndiff --git a/drivers/net/hinic/hinic_pmd_ethdev.c b/drivers/net/hinic/hinic_pmd_ethdev.c\nindex 5f2e97d3bd..623534fda4 100644\n--- a/drivers/net/hinic/hinic_pmd_ethdev.c\n+++ b/drivers/net/hinic/hinic_pmd_ethdev.c\n@@ -3100,12 +3100,6 @@ static int hinic_func_init(struct rte_eth_dev *eth_dev)\n \t\tgoto mc_addr_fail;\n \t}\n \n-\t/*\n-\t * Pass the information to the rte_eth_dev_close() that it should also\n-\t * release the private port resources.\n-\t */\n-\teth_dev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;\n-\n \t/* create hardware nic_device */\n \trc = hinic_nic_dev_create(eth_dev);\n \tif (rc) {\ndiff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c\nindex 96806afd87..bc853c6a8f 100644\n--- a/drivers/net/hns3/hns3_ethdev.c\n+++ b/drivers/net/hns3/hns3_ethdev.c\n@@ -5528,11 +5528,6 @@ hns3_dev_init(struct rte_eth_dev *eth_dev)\n \t\t\t ð_dev->data->mac_addrs[0]);\n \n \thw->adapter_state = HNS3_NIC_INITIALIZED;\n-\t/*\n-\t * Pass the information to the rte_eth_dev_close() that it should also\n-\t * release the private port resources.\n-\t */\n-\teth_dev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;\n \n \tif (rte_atomic16_read(&hns->hw.reset.schedule) == SCHEDULE_PENDING) {\n \t\thns3_err(hw, \"Reschedule reset service after dev_init\");\ndiff --git a/drivers/net/hns3/hns3_ethdev_vf.c b/drivers/net/hns3/hns3_ethdev_vf.c\nindex b732bbc732..7b97259c5e 100644\n--- a/drivers/net/hns3/hns3_ethdev_vf.c\n+++ b/drivers/net/hns3/hns3_ethdev_vf.c\n@@ -2576,11 +2576,6 @@ hns3vf_dev_init(struct rte_eth_dev *eth_dev)\n \trte_ether_addr_copy((struct rte_ether_addr *)hw->mac.mac_addr,\n \t\t\t ð_dev->data->mac_addrs[0]);\n \thw->adapter_state = HNS3_NIC_INITIALIZED;\n-\t/*\n-\t * Pass the information to the rte_eth_dev_close() that it should also\n-\t * release the private port resources.\n-\t */\n-\teth_dev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;\n \n \tif (rte_atomic16_read(&hns->hw.reset.schedule) == SCHEDULE_PENDING) {\n \t\thns3_err(hw, \"Reschedule reset service after dev_init\");\ndiff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c\nindex 8dccb513d4..dd8214d7be 100644\n--- a/drivers/net/i40e/i40e_ethdev.c\n+++ b/drivers/net/i40e/i40e_ethdev.c\n@@ -1699,11 +1699,6 @@ eth_i40e_dev_init(struct rte_eth_dev *dev, void *init_params __rte_unused)\n \trte_ether_addr_copy((struct rte_ether_addr *)hw->mac.perm_addr,\n \t\t\t\t\t&dev->data->mac_addrs[0]);\n \n-\t/* Pass the information to the rte_eth_dev_close() that it should also\n-\t * release the private port resources.\n-\t */\n-\tdev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;\n-\n \t/* Init dcb to sw mode by default */\n \tret = i40e_dcb_init_configure(dev, TRUE);\n \tif (ret != I40E_SUCCESS) {\ndiff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c\nindex 104eef639d..63dcff841e 100644\n--- a/drivers/net/i40e/i40e_ethdev_vf.c\n+++ b/drivers/net/i40e/i40e_ethdev_vf.c\n@@ -1543,11 +1543,6 @@ i40evf_dev_init(struct rte_eth_dev *eth_dev)\n \thw->adapter_stopped = 1;\n \thw->adapter_closed = 0;\n \n-\t/* Pass the information to the rte_eth_dev_close() that it should also\n-\t * release the private port resources.\n-\t */\n-\teth_dev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;\n-\n \tif(i40evf_init_vf(eth_dev) != 0) {\n \t\tPMD_INIT_LOG(ERR, \"Init vf failed\");\n \t\treturn -1;\ndiff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c\nindex f7552f33db..2a64204689 100644\n--- a/drivers/net/iavf/iavf_ethdev.c\n+++ b/drivers/net/iavf/iavf_ethdev.c\n@@ -1362,11 +1362,6 @@ iavf_dev_init(struct rte_eth_dev *eth_dev)\n \tadapter->eth_dev = eth_dev;\n \tadapter->stopped = 1;\n \n-\t/* Pass the information to the rte_eth_dev_close() that it should also\n-\t * release the private port resources.\n-\t */\n-\teth_dev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;\n-\n \tif (iavf_init_vf(eth_dev) != 0) {\n \t\tPMD_INIT_LOG(ERR, \"Init vf failed\");\n \t\treturn -1;\ndiff --git a/drivers/net/ice/ice_dcf_ethdev.c b/drivers/net/ice/ice_dcf_ethdev.c\nindex 5b626cb641..33dd0c44f2 100644\n--- a/drivers/net/ice/ice_dcf_ethdev.c\n+++ b/drivers/net/ice/ice_dcf_ethdev.c\n@@ -908,8 +908,6 @@ ice_dcf_dev_init(struct rte_eth_dev *eth_dev)\n \tif (rte_eal_process_type() != RTE_PROC_PRIMARY)\n \t\treturn 0;\n \n-\teth_dev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;\n-\n \tadapter->real_hw.vc_event_msg_cb = ice_dcf_handle_pf_event_msg;\n \tif (ice_dcf_init_hw(eth_dev, &adapter->real_hw) != 0) {\n \t\tPMD_INIT_LOG(ERR, \"Failed to init DCF hardware\");\ndiff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c\nindex 042ee6def0..f0cb05cbc9 100644\n--- a/drivers/net/ice/ice_ethdev.c\n+++ b/drivers/net/ice/ice_ethdev.c\n@@ -2206,11 +2206,6 @@ ice_dev_init(struct rte_eth_dev *dev)\n \t\tgoto err_init_mac;\n \t}\n \n-\t/* Pass the information to the rte_eth_dev_close() that it should also\n-\t * release the private port resources.\n-\t */\n-\tdev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;\n-\n \tret = ice_res_pool_init(&pf->msix_pool, 1,\n \t\t\t\thw->func_caps.common_cap.num_msix_vectors - 1);\n \tif (ret) {\ndiff --git a/drivers/net/igc/igc_ethdev.c b/drivers/net/igc/igc_ethdev.c\nindex 99014a369c..a9dda1f781 100644\n--- a/drivers/net/igc/igc_ethdev.c\n+++ b/drivers/net/igc/igc_ethdev.c\n@@ -1324,11 +1324,6 @@ eth_igc_dev_init(struct rte_eth_dev *dev)\n \t\tgoto err_late;\n \t}\n \n-\t/* Pass the information to the rte_eth_dev_close() that it should also\n-\t * release the private port resources.\n-\t */\n-\tdev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;\n-\n \thw->mac.get_link_status = 1;\n \tigc->stopped = 0;\n \ndiff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c\nindex 5c12a575c2..195383ce1f 100644\n--- a/drivers/net/ixgbe/ixgbe_ethdev.c\n+++ b/drivers/net/ixgbe/ixgbe_ethdev.c\n@@ -1251,11 +1251,6 @@ eth_ixgbe_dev_init(struct rte_eth_dev *eth_dev, void *init_params __rte_unused)\n \t\treturn -ENOMEM;\n \t}\n \n-\t/* Pass the information to the rte_eth_dev_close() that it should also\n-\t * release the private port resources.\n-\t */\n-\teth_dev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;\n-\n \t/* initialize the vfta */\n \tmemset(shadow_vfta, 0, sizeof(*shadow_vfta));\n \n@@ -1663,11 +1658,6 @@ eth_ixgbevf_dev_init(struct rte_eth_dev *eth_dev)\n \t\treturn -ENOMEM;\n \t}\n \n-\t/* Pass the information to the rte_eth_dev_close() that it should also\n-\t * release the private port resources.\n-\t */\n-\teth_dev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;\n-\n \t/* Generate a random MAC address, if none was assigned by PF. */\n \tif (rte_is_zero_ether_addr(perm_addr)) {\n \t\tgenerate_random_mac_addr(perm_addr);\ndiff --git a/drivers/net/kni/rte_eth_kni.c b/drivers/net/kni/rte_eth_kni.c\nindex aa365a57de..45ab1b17a8 100644\n--- a/drivers/net/kni/rte_eth_kni.c\n+++ b/drivers/net/kni/rte_eth_kni.c\n@@ -387,8 +387,6 @@ eth_kni_create(struct rte_vdev_device *vdev,\n \tdata->promiscuous = 1;\n \tdata->all_multicast = 1;\n \n-\tdata->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;\n-\n \trte_eth_random_addr(internals->eth_addr.addr_bytes);\n \n \teth_dev->dev_ops = ð_kni_ops;\ndiff --git a/drivers/net/memif/rte_eth_memif.c b/drivers/net/memif/rte_eth_memif.c\nindex c00b9702a9..666dec77c6 100644\n--- a/drivers/net/memif/rte_eth_memif.c\n+++ b/drivers/net/memif/rte_eth_memif.c\n@@ -1512,9 +1512,6 @@ memif_create(struct rte_vdev_device *vdev, enum memif_role_t role,\n \t\teth_dev->tx_pkt_burst = eth_memif_tx;\n \t}\n \n-\n-\teth_dev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;\n-\n \trte_eth_dev_probing_finish(eth_dev);\n \n \treturn 0;\ndiff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c\nindex ad7c805d67..3e57875414 100644\n--- a/drivers/net/mlx4/mlx4.c\n+++ b/drivers/net/mlx4/mlx4.c\n@@ -1027,7 +1027,6 @@ mlx4_pci_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev)\n \t\t\tERROR(\"can not allocate rte ethdev\");\n \t\t\tgoto port_error;\n \t\t}\n-\t\teth_dev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;\n \t\teth_dev->data->dev_private = priv;\n \t\teth_dev->data->mac_addrs = priv->mac;\n \t\teth_dev->device = &pci_dev->device;\ndiff --git a/drivers/net/mlx5/linux/mlx5_os.c b/drivers/net/mlx5/linux/mlx5_os.c\nindex 69123e12c3..7fce24cafc 100644\n--- a/drivers/net/mlx5/linux/mlx5_os.c\n+++ b/drivers/net/mlx5/linux/mlx5_os.c\n@@ -1136,8 +1136,6 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev,\n \t\terr = ENOMEM;\n \t\tgoto error;\n \t}\n-\t/* Flag to call rte_eth_dev_release_port() in rte_eth_dev_close(). */\n-\teth_dev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;\n \tif (priv->representor) {\n \t\teth_dev->data->dev_flags |= RTE_ETH_DEV_REPRESENTOR;\n \t\teth_dev->data->representor_id = priv->representor_id;\ndiff --git a/drivers/net/mvneta/mvneta_ethdev.c b/drivers/net/mvneta/mvneta_ethdev.c\nindex b13e2c52f3..f0a52e29fd 100644\n--- a/drivers/net/mvneta/mvneta_ethdev.c\n+++ b/drivers/net/mvneta/mvneta_ethdev.c\n@@ -835,9 +835,6 @@ mvneta_eth_dev_create(struct rte_vdev_device *vdev, const char *name)\n \tmvneta_set_tx_function(eth_dev);\n \teth_dev->dev_ops = &mvneta_ops;\n \n-\t/* Flag to call rte_eth_dev_release_port() in rte_eth_dev_close(). */\n-\teth_dev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;\n-\n \trte_eth_dev_probing_finish(eth_dev);\n \treturn 0;\n out_free:\ndiff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethdev.c\nindex b40169daba..e115e7d0c1 100644\n--- a/drivers/net/mvpp2/mrvl_ethdev.c\n+++ b/drivers/net/mvpp2/mrvl_ethdev.c\n@@ -2864,9 +2864,6 @@ mrvl_eth_dev_create(struct rte_vdev_device *vdev, const char *name)\n \tmrvl_set_tx_function(eth_dev);\n \teth_dev->dev_ops = &mrvl_ops;\n \n-\t/* Flag to call rte_eth_dev_release_port() in rte_eth_dev_close(). */\n-\teth_dev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;\n-\n \trte_eth_dev_probing_finish(eth_dev);\n \treturn 0;\n out_free:\ndiff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c\nindex f02f546882..c4a2dd9f4a 100644\n--- a/drivers/net/netvsc/hn_ethdev.c\n+++ b/drivers/net/netvsc/hn_ethdev.c\n@@ -123,9 +123,6 @@ eth_dev_vmbus_allocate(struct rte_vmbus_device *dev, size_t private_data_size)\n \teth_dev->data->dev_flags |= RTE_ETH_DEV_INTR_LSC;\n \teth_dev->intr_handle = &dev->intr_handle;\n \n-\t/* allow ethdev to remove on close */\n-\teth_dev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;\n-\n \treturn eth_dev;\n }\n \ndiff --git a/drivers/net/nfb/nfb_ethdev.c b/drivers/net/nfb/nfb_ethdev.c\nindex c3c3d003f1..d937ac6922 100644\n--- a/drivers/net/nfb/nfb_ethdev.c\n+++ b/drivers/net/nfb/nfb_ethdev.c\n@@ -457,9 +457,6 @@ nfb_eth_dev_init(struct rte_eth_dev *dev)\n \t\trte_kvargs_free(kvlist);\n \t}\n \n-\t/* Let rte_eth_dev_close() release the port resources */\n-\tdev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;\n-\n \t/*\n \t * Get number of available DMA RX and TX queues, which is maximum\n \t * number of queues that can be created and store it in private device\ndiff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c\nindex 33997013e4..ab7ebe3ddc 100644\n--- a/drivers/net/null/rte_eth_null.c\n+++ b/drivers/net/null/rte_eth_null.c\n@@ -545,7 +545,6 @@ eth_dev_null_create(struct rte_vdev_device *dev, struct pmd_options *args)\n \tdata->mac_addrs = &internals->eth_addr;\n \tdata->promiscuous = 1;\n \tdata->all_multicast = 1;\n-\tdata->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;\n \n \teth_dev->dev_ops = &ops;\n \ndiff --git a/drivers/net/octeontx/octeontx_ethdev.c b/drivers/net/octeontx/octeontx_ethdev.c\nindex 6713c51504..328551b60f 100644\n--- a/drivers/net/octeontx/octeontx_ethdev.c\n+++ b/drivers/net/octeontx/octeontx_ethdev.c\n@@ -1375,7 +1375,6 @@ octeontx_create(struct rte_vdev_device *dev, int port, uint8_t evdev,\n \tdata->promiscuous = 0;\n \tdata->all_multicast = 0;\n \tdata->scattered_rx = 0;\n-\tdata->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;\n \n \t/* Get maximum number of supported MAC entries */\n \tmax_entries = octeontx_bgx_port_mac_entries_get(nic->port_id);\ndiff --git a/drivers/net/octeontx2/otx2_ethdev.c b/drivers/net/octeontx2/otx2_ethdev.c\nindex d9bcf004c6..ca320047f6 100644\n--- a/drivers/net/octeontx2/otx2_ethdev.c\n+++ b/drivers/net/octeontx2/otx2_ethdev.c\n@@ -2394,7 +2394,6 @@ otx2_eth_dev_init(struct rte_eth_dev *eth_dev)\n \tpci_dev = RTE_ETH_DEV_TO_PCI(eth_dev);\n \n \trte_eth_copy_pci_info(eth_dev, pci_dev);\n-\teth_dev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;\n \n \t/* Zero out everything after OTX2_DEV to allow proper dev_reset() */\n \tmemset(&dev->otx2_eth_dev_data_start, 0, sizeof(*dev) -\ndiff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c\nindex a946fa9a1a..fbbad5cbd1 100644\n--- a/drivers/net/pcap/rte_eth_pcap.c\n+++ b/drivers/net/pcap/rte_eth_pcap.c\n@@ -1334,7 +1334,6 @@ eth_from_pcaps(struct rte_vdev_device *vdev,\n \telse\n \t\teth_dev->tx_pkt_burst = eth_tx_drop;\n \n-\teth_dev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;\n \trte_eth_dev_probing_finish(eth_dev);\n \treturn 0;\n }\ndiff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c\nindex afe3ec46cc..8ed53c64af 100644\n--- a/drivers/net/ring/rte_eth_ring.c\n+++ b/drivers/net/ring/rte_eth_ring.c\n@@ -356,7 +356,6 @@ do_eth_dev_ring_create(const char *name,\n \teth_dev->dev_ops = &ops;\n \tdata->kdrv = RTE_KDRV_NONE;\n \tdata->numa_node = numa_node;\n-\tdata->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;\n \n \t/* finally assign rx and tx ops */\n \teth_dev->rx_pkt_burst = eth_ring_rx;\ndiff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c\nindex f1b857358c..b609d808d7 100644\n--- a/drivers/net/sfc/sfc_ethdev.c\n+++ b/drivers/net/sfc/sfc_ethdev.c\n@@ -343,7 +343,7 @@ sfc_dev_close(struct rte_eth_dev *dev)\n \t}\n \n \t/*\n-\t * Cleanup all resources in accordance with RTE_ETH_DEV_CLOSE_REMOVE.\n+\t * Cleanup all resources.\n \t * Rollback primary process sfc_eth_dev_init() below.\n \t */\n \n@@ -2179,8 +2179,6 @@ sfc_eth_dev_init(struct rte_eth_dev *dev)\n \n \tsfc_log_init(sa, \"entry\");\n \n-\tdev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;\n-\n \tdev->data->mac_addrs = rte_zmalloc(\"sfc\", RTE_ETHER_ADDR_LEN, 0);\n \tif (dev->data->mac_addrs == NULL) {\n \t\trc = ENOMEM;\ndiff --git a/drivers/net/softnic/rte_eth_softnic.c b/drivers/net/softnic/rte_eth_softnic.c\nindex 5b94e250d8..0e5ec0cdf0 100644\n--- a/drivers/net/softnic/rte_eth_softnic.c\n+++ b/drivers/net/softnic/rte_eth_softnic.c\n@@ -387,7 +387,6 @@ pmd_ethdev_register(struct rte_vdev_device *vdev,\n \tdev->device = &vdev->device;\n \n \t/* dev->data */\n-\tdev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;\n \tdev->data->dev_private = dev_private;\n \tdev->data->dev_link.link_speed = ETH_SPEED_NUM_100G;\n \tdev->data->dev_link.link_duplex = ETH_LINK_FULL_DUPLEX;\ndiff --git a/drivers/net/szedata2/rte_eth_szedata2.c b/drivers/net/szedata2/rte_eth_szedata2.c\nindex daa40cfd6c..4325b9a30d 100644\n--- a/drivers/net/szedata2/rte_eth_szedata2.c\n+++ b/drivers/net/szedata2/rte_eth_szedata2.c\n@@ -1488,9 +1488,6 @@ rte_szedata2_eth_dev_init(struct rte_eth_dev *dev, struct port_info *pi)\n \tPMD_INIT_LOG(INFO, \"Initializing eth_dev %s (driver %s)\", data->name,\n \t\t\tRTE_STR(RTE_SZEDATA2_DRIVER_NAME));\n \n-\t/* Let rte_eth_dev_close() release the port resources */\n-\tdev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;\n-\n \t/* Fill internal private structure. */\n \tinternals->dev = dev;\n \t/* Get index of szedata2 device file and create path to device file */\ndiff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c\nindex 2e325f55aa..99f6dc118c 100644\n--- a/drivers/net/tap/rte_eth_tap.c\n+++ b/drivers/net/tap/rte_eth_tap.c\n@@ -1876,7 +1876,7 @@ eth_dev_tap_create(struct rte_vdev_device *vdev, const char *tap_name,\n \t/* Setup some default values */\n \tdata = dev->data;\n \tdata->dev_private = pmd;\n-\tdata->dev_flags = RTE_ETH_DEV_INTR_LSC | RTE_ETH_DEV_CLOSE_REMOVE;\n+\tdata->dev_flags = RTE_ETH_DEV_INTR_LSC;\n \tdata->numa_node = numa_node;\n \n \tdata->dev_link = pmd_link;\ndiff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c\nindex fb3b9ce043..36baf8f881 100644\n--- a/drivers/net/vhost/rte_eth_vhost.c\n+++ b/drivers/net/vhost/rte_eth_vhost.c\n@@ -1444,7 +1444,7 @@ eth_dev_vhost_create(struct rte_vdev_device *dev, char *iface_name,\n \tinternal->flags = flags;\n \tinternal->disable_flags = disable_flags;\n \tdata->dev_link = pmd_link;\n-\tdata->dev_flags = RTE_ETH_DEV_INTR_LSC | RTE_ETH_DEV_CLOSE_REMOVE;\n+\tdata->dev_flags = RTE_ETH_DEV_INTR_LSC;\n \tdata->promiscuous = 1;\n \tdata->all_multicast = 1;\n \ndiff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c\nindex 1731fc6750..735c579a86 100644\n--- a/drivers/net/virtio/virtio_ethdev.c\n+++ b/drivers/net/virtio/virtio_ethdev.c\n@@ -1923,11 +1923,6 @@ eth_virtio_dev_init(struct rte_eth_dev *eth_dev)\n \tif (ret < 0)\n \t\treturn ret;\n \thw->speed = speed;\n-\t/*\n-\t * Pass the information to the rte_eth_dev_close() that it should also\n-\t * release the private port resources.\n-\t */\n-\teth_dev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;\n \n \t/* Allocate memory for storing MAC addresses */\n \teth_dev->data->mac_addrs = rte_zmalloc(\"virtio\",\ndiff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c\nindex 4efb48350c..221f771023 100644\n--- a/drivers/net/vmxnet3/vmxnet3_ethdev.c\n+++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c\n@@ -321,9 +321,6 @@ eth_vmxnet3_dev_init(struct rte_eth_dev *eth_dev)\n \t\t hw->perm_addr[0], hw->perm_addr[1], hw->perm_addr[2],\n \t\t hw->perm_addr[3], hw->perm_addr[4], hw->perm_addr[5]);\n \n-\t/* Flag to call rte_eth_dev_release_port() in rte_eth_dev_close(). */\n-\teth_dev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;\n-\n \t/* Put device in Quiesce Mode */\n \tVMXNET3_WRITE_BAR1_REG(hw, VMXNET3_REG_CMD, VMXNET3_CMD_QUIESCE_DEV);\n \ndiff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c\nindex 3617f39ca0..f1b0bdd3bc 100644\n--- a/lib/librte_ethdev/rte_ethdev.c\n+++ b/lib/librte_ethdev/rte_ethdev.c\n@@ -1720,22 +1720,7 @@ rte_eth_dev_close(uint16_t port_id)\n \t(*dev->dev_ops->dev_close)(dev);\n \n \trte_ethdev_trace_close(port_id);\n-\t/* check behaviour flag - temporary for PMD migration */\n-\tif ((dev->data->dev_flags & RTE_ETH_DEV_CLOSE_REMOVE) != 0) {\n-\t\t/* new behaviour: send event + reset state + free all data */\n-\t\trte_eth_dev_release_port(dev);\n-\t\treturn;\n-\t}\n-\tRTE_ETHDEV_LOG(DEBUG, \"Port closing is using an old behaviour.\\n\"\n-\t\t\t\"The driver %s should migrate to the new behaviour.\\n\",\n-\t\t\tdev->device->driver->name);\n-\t/* old behaviour: only free queue arrays */\n-\tdev->data->nb_rx_queues = 0;\n-\trte_free(dev->data->rx_queues);\n-\tdev->data->rx_queues = NULL;\n-\tdev->data->nb_tx_queues = 0;\n-\trte_free(dev->data->tx_queues);\n-\tdev->data->tx_queues = NULL;\n+\trte_eth_dev_release_port(dev);\n }\n \n int\ndiff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h\nindex 70295d7ab7..f9775c2524 100644\n--- a/lib/librte_ethdev/rte_ethdev.h\n+++ b/lib/librte_ethdev/rte_ethdev.h\n@@ -1621,11 +1621,6 @@ struct rte_eth_dev_owner {\n \tchar name[RTE_ETH_MAX_OWNER_NAME_LEN]; /**< The owner name. */\n };\n \n-/**\n- * Port is released (i.e. totally freed and data erased) on close.\n- * Temporary flag for PMD migration to new rte_eth_dev_close() behaviour.\n- */\n-#define RTE_ETH_DEV_CLOSE_REMOVE 0x0001\n /** Device supports link state interrupt */\n #define RTE_ETH_DEV_INTR_LSC 0x0002\n /** Device is a bonded slave */\n@@ -2250,8 +2245,7 @@ int rte_eth_dev_set_link_down(uint16_t port_id);\n \n /**\n * Close a stopped Ethernet device. The device cannot be restarted!\n- * The function frees all port resources if the driver supports\n- * the flag RTE_ETH_DEV_CLOSE_REMOVE.\n+ * The function frees all port resources.\n *\n * @param port_id\n * The port identifier of the Ethernet device.\n", "prefixes": [ "16/20" ] }