Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/77438/?format=api
{ "id": 77438, "url": "http://patches.dpdk.org/api/patches/77438/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200911152938.8019-3-steven.lariau@arm.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200911152938.8019-3-steven.lariau@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200911152938.8019-3-steven.lariau@arm.com", "date": "2020-09-11T15:29:35", "name": "[2/5] lib/stack: remove push acquire fence", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "d276be174241ddbba528de38f0114dda0aa006f5", "submitter": { "id": 1862, "url": "http://patches.dpdk.org/api/people/1862/?format=api", "name": "Steven Lariau", "email": "steven.lariau@arm.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200911152938.8019-3-steven.lariau@arm.com/mbox/", "series": [ { "id": 12150, "url": "http://patches.dpdk.org/api/series/12150/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12150", "date": "2020-09-11T15:29:33", "name": "lib/stack: improve lockfree C11 implementation", "version": 1, "mbox": "http://patches.dpdk.org/series/12150/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/77438/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/77438/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0FF75A04BB;\n\tFri, 11 Sep 2020 17:31:26 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0D7F21C0D7;\n\tFri, 11 Sep 2020 17:31:24 +0200 (CEST)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by dpdk.org (Postfix) with ESMTP id 632141C0D5\n for <dev@dpdk.org>; Fri, 11 Sep 2020 17:31:22 +0200 (CEST)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DDE201063;\n Fri, 11 Sep 2020 08:31:21 -0700 (PDT)", "from localhost.localdomain (unknown [10.57.10.210])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6097B3F73C;\n Fri, 11 Sep 2020 08:31:20 -0700 (PDT)" ], "From": "Steven Lariau <steven.lariau@arm.com>", "To": "Gage Eads <gage.eads@intel.com>,\n\tOlivier Matz <olivier.matz@6wind.com>", "Cc": "dev@dpdk.org, nd@arm.com, dharmik.thakkar@arm.com,\n Steven Lariau <steven.lariau@arm.com>", "Date": "Fri, 11 Sep 2020 16:29:35 +0100", "Message-Id": "<20200911152938.8019-3-steven.lariau@arm.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200911152938.8019-1-steven.lariau@arm.com>", "References": "<20200911152938.8019-1-steven.lariau@arm.com>", "Subject": "[dpdk-dev] [PATCH 2/5] lib/stack: remove push acquire fence", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "An acquire fence is used to make sure loads after the fence can observe\nall store operations before a specific store-release.\nBut push doesn't read any data, except for the head which is part of a\nCAS operation (the items on the list are not read).\nSo there is no need for the acquire barrier.\n\nSigned-off-by: Steven Lariau <steven.lariau@arm.com>\nReviewed-by: Dharmik Thakkar <dharmik.thakkar@arm.com>\nReviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>\n---\n lib/librte_stack/rte_stack_lf_c11.h | 6 ------\n 1 file changed, 6 deletions(-)", "diff": "diff --git a/lib/librte_stack/rte_stack_lf_c11.h b/lib/librte_stack/rte_stack_lf_c11.h\nindex 1e0ea0bef..82b7287f1 100644\n--- a/lib/librte_stack/rte_stack_lf_c11.h\n+++ b/lib/librte_stack/rte_stack_lf_c11.h\n@@ -44,12 +44,6 @@ __rte_stack_lf_push_elems(struct rte_stack_lf_list *list,\n \tdo {\n \t\tstruct rte_stack_lf_head new_head;\n \n-\t\t/* Use an acquire fence to establish a synchronized-with\n-\t\t * relationship between the list->head load and store-release\n-\t\t * operations (as part of the rte_atomic128_cmp_exchange()).\n-\t\t */\n-\t\t__atomic_thread_fence(__ATOMIC_ACQUIRE);\n-\n \t\t/* Swing the top pointer to the first element in the list and\n \t\t * make the last element point to the old top.\n \t\t */\n", "prefixes": [ "2/5" ] }