Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/77413/?format=api
{ "id": 77413, "url": "http://patches.dpdk.org/api/patches/77413/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200911131954.15999-27-qi.z.zhang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200911131954.15999-27-qi.z.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200911131954.15999-27-qi.z.zhang@intel.com", "date": "2020-09-11T13:19:40", "name": "[v2,26/40] net/ice/base: add check for failed acts allocation", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "aa045a6b4a983af8cf350bf9dd77cf9dee4088b1", "submitter": { "id": 504, "url": "http://patches.dpdk.org/api/people/504/?format=api", "name": "Qi Zhang", "email": "qi.z.zhang@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200911131954.15999-27-qi.z.zhang@intel.com/mbox/", "series": [ { "id": 12148, "url": "http://patches.dpdk.org/api/series/12148/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12148", "date": "2020-09-11T13:19:15", "name": "ice base code update", "version": 2, "mbox": "http://patches.dpdk.org/series/12148/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/77413/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/77413/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 22084A04B7;\n\tFri, 11 Sep 2020 15:21:23 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6CA671C214;\n\tFri, 11 Sep 2020 15:16:53 +0200 (CEST)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n by dpdk.org (Postfix) with ESMTP id 440061C1C9\n for <dev@dpdk.org>; Fri, 11 Sep 2020 15:16:39 +0200 (CEST)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 11 Sep 2020 06:16:38 -0700", "from dpdk51.sh.intel.com ([10.67.111.82])\n by FMSMGA003.fm.intel.com with ESMTP; 11 Sep 2020 06:16:37 -0700" ], "IronPort-SDR": [ "\n KKJURPCBqFKdPHrEK86PcftSWmbJPRWG4v/d8xCaEDGdutdUw3FjidmqPKNQWb74pYWJS+hj8o\n FGaGHfW7zL7w==", "\n +PMF6jRmO5dbdLh2vzyA5+UQHRvbTaJRoIZUFMO1vO629IUMZ9aN9bnLnr8DGYzw7yqzVFhkim\n pDMcY7x+D30Q==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9740\"; a=\"146482332\"", "E=Sophos;i=\"5.76,415,1592895600\"; d=\"scan'208\";a=\"146482332\"", "E=Sophos;i=\"5.76,415,1592895600\"; d=\"scan'208\";a=\"342296684\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Qi Zhang <qi.z.zhang@intel.com>", "To": "ferruh.yigit@intel.com", "Cc": "dev@dpdk.org, Qi Zhang <qi.z.zhang@intel.com>,\n Tony Nguyen <anthony.l.nguyen@intel.com>", "Date": "Fri, 11 Sep 2020 21:19:40 +0800", "Message-Id": "<20200911131954.15999-27-qi.z.zhang@intel.com>", "X-Mailer": "git-send-email 2.13.6", "In-Reply-To": "<20200911131954.15999-1-qi.z.zhang@intel.com>", "References": "<20200907112826.48493-1-qi.z.zhang@intel.com>\n <20200911131954.15999-1-qi.z.zhang@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 26/40] net/ice/base: add check for failed acts\n\tallocation", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "There is no check for failed allocation of 'acts'. Add a check and return\nif memory was not successfully allocated. Also, as all 'goto out' occur\nafter this check there is no need to perform a check for 'acts' as we will\nhave returned if it is not set.\n\nSigned-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\nAcked-by: Qiming Yang <qiming.yang@intel.com>\n---\n drivers/net/ice/base/ice_flow.c | 15 ++++++++-------\n 1 file changed, 8 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/ice/base/ice_flow.c b/drivers/net/ice/base/ice_flow.c\nindex 65ab2394f..d96bf169f 100644\n--- a/drivers/net/ice/base/ice_flow.c\n+++ b/drivers/net/ice/base/ice_flow.c\n@@ -1712,8 +1712,8 @@ ice_flow_acl_is_prof_in_use(struct ice_hw *hw, struct ice_flow_prof *prof,\n \t buf->pf_scenario_num[6] == ICE_ACL_INVALID_SCEN &&\n \t buf->pf_scenario_num[7] == ICE_ACL_INVALID_SCEN)\n \t\treturn ICE_SUCCESS;\n-\telse\n-\t\treturn ICE_ERR_IN_USE;\n+\n+\treturn ICE_ERR_IN_USE;\n }\n \n /**\n@@ -2861,7 +2861,6 @@ ice_flow_acl_add_scen_entry_sync(struct ice_hw *hw, struct ice_flow_prof *prof,\n \t */\n \texist = ice_flow_acl_find_scen_entry_cond(prof, e, &do_chg_action,\n \t\t\t\t\t\t &do_add_entry, &do_rem_entry);\n-\n \tif (do_rem_entry) {\n \t\tstatus = ice_flow_rem_entry_sync(hw, ICE_BLK_ACL, exist);\n \t\tif (status)\n@@ -2869,8 +2868,11 @@ ice_flow_acl_add_scen_entry_sync(struct ice_hw *hw, struct ice_flow_prof *prof,\n \t}\n \n \t/* Prepare the result action buffer */\n-\tacts = (struct ice_acl_act_entry *)ice_calloc\n-\t\t(hw, e->entry_sz, sizeof(struct ice_acl_act_entry));\n+\tacts = (struct ice_acl_act_entry *)\n+\t\tice_calloc(hw, e->entry_sz, sizeof(struct ice_acl_act_entry));\n+\tif (!acts)\n+\t\treturn ICE_ERR_NO_MEMORY;\n+\n \tfor (i = 0; i < e->acts_cnt; i++)\n \t\tice_memcpy(&acts[i], &e->acts[i].data.acl_act,\n \t\t\t sizeof(struct ice_acl_act_entry),\n@@ -2937,8 +2939,7 @@ ice_flow_acl_add_scen_entry_sync(struct ice_hw *hw, struct ice_flow_prof *prof,\n \t\t*(entry) = exist;\n \t}\n out:\n-\tif (acts)\n-\t\tice_free(hw, acts);\n+\tice_free(hw, acts);\n \n \treturn status;\n }\n", "prefixes": [ "v2", "26/40" ] }