Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 77382,
    "url": "http://patches.dpdk.org/api/patches/77382/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200911120818.2665269-2-pablo.de.lara.guarch@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20200911120818.2665269-2-pablo.de.lara.guarch@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20200911120818.2665269-2-pablo.de.lara.guarch@intel.com",
    "date": "2020-09-11T12:08:18",
    "name": "[2/2] test/crypto: add SGL tests for AES-GMAC",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "63cf1c2b19f90f258aea0b8ce13e0750ea156e52",
    "submitter": {
        "id": 9,
        "url": "http://patches.dpdk.org/api/people/9/?format=api",
        "name": "De Lara Guarch, Pablo",
        "email": "pablo.de.lara.guarch@intel.com"
    },
    "delegate": {
        "id": 6690,
        "url": "http://patches.dpdk.org/api/users/6690/?format=api",
        "username": "akhil",
        "first_name": "akhil",
        "last_name": "goyal",
        "email": "gakhil@marvell.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200911120818.2665269-2-pablo.de.lara.guarch@intel.com/mbox/",
    "series": [
        {
            "id": 12146,
            "url": "http://patches.dpdk.org/api/series/12146/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12146",
            "date": "2020-09-11T12:08:17",
            "name": "[1/2] crypto/aesni_gcm: support SGL on AES-GMAC",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/12146/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/77382/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/77382/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 38E12A04B5;\n\tFri, 11 Sep 2020 14:08:30 +0200 (CEST)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id CFD9F1C0D0;\n\tFri, 11 Sep 2020 14:08:26 +0200 (CEST)",
            "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n by dpdk.org (Postfix) with ESMTP id A3EA51C0CF\n for <dev@dpdk.org>; Fri, 11 Sep 2020 14:08:24 +0200 (CEST)",
            "from fmsmga004.fm.intel.com ([10.253.24.48])\n by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 11 Sep 2020 05:08:24 -0700",
            "from silpixa00399593.ir.intel.com (HELO\n silpixa00399593.ger.corp.intel.com) ([10.237.223.27])\n by fmsmga004.fm.intel.com with ESMTP; 11 Sep 2020 05:08:23 -0700"
        ],
        "IronPort-SDR": [
            "\n aESm/3bn+Jiam2Nr3Yp0sMeRGPm+MDK61CXah3e5FO6hsceyre5au67SFnNRiP4jN8yZgts3XF\n kk2E5JZQTiew==",
            "\n miZ6MJqcAgGVPKxF04UuU1376s6TA9tJcSms3CtNMGm6MzZVLpOQMf8Gk8NRrsYu6k4TB5oZpo\n Y+pRT5S4WN8A=="
        ],
        "X-IronPort-AV": [
            "E=McAfee;i=\"6000,8403,9740\"; a=\"146474276\"",
            "E=Sophos;i=\"5.76,415,1592895600\"; d=\"scan'208\";a=\"146474276\"",
            "E=Sophos;i=\"5.76,415,1592895600\"; d=\"scan'208\";a=\"329761373\""
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "From": "Pablo de Lara <pablo.de.lara.guarch@intel.com>",
        "To": "declan.doherty@intel.com",
        "Cc": "dev@dpdk.org,\n\tPablo de Lara <pablo.de.lara.guarch@intel.com>",
        "Date": "Fri, 11 Sep 2020 12:08:18 +0000",
        "Message-Id": "<20200911120818.2665269-2-pablo.de.lara.guarch@intel.com>",
        "X-Mailer": "git-send-email 2.25.1",
        "In-Reply-To": "<20200911120818.2665269-1-pablo.de.lara.guarch@intel.com>",
        "References": "<20200911120818.2665269-1-pablo.de.lara.guarch@intel.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH 2/2] test/crypto: add SGL tests for AES-GMAC",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Add Scatter-Gather List tests for AES-GMAC.\n\nSigned-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>\n---\n app/test/test_cryptodev.c | 220 +++++++++++++++++++++++++++++++++++++-\n 1 file changed, 218 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c\nindex 70bf6fe2c..1d61aaac7 100644\n--- a/app/test/test_cryptodev.c\n+++ b/app/test/test_cryptodev.c\n@@ -52,6 +52,8 @@\n #define IN_PLACE 0\n #define OUT_OF_PLACE 1\n \n+#define SGL_MAX_NO\t16\n+\n static int gbl_driver_id;\n \n static enum rte_security_session_action_type gbl_action_type =\n@@ -9995,6 +9997,53 @@ create_gmac_operation(enum rte_crypto_auth_operation op,\n \treturn 0;\n }\n \n+static int\n+create_gmac_operation_sgl(enum rte_crypto_auth_operation op,\n+\t\tconst struct gmac_test_data *tdata,\n+\t\tvoid *digest_mem, uint64_t digest_phys)\n+{\n+\tstruct crypto_testsuite_params *ts_params = &testsuite_params;\n+\tstruct crypto_unittest_params *ut_params = &unittest_params;\n+\tstruct rte_crypto_sym_op *sym_op;\n+\n+\t/* Generate Crypto op data structure */\n+\tut_params->op = rte_crypto_op_alloc(ts_params->op_mpool,\n+\t\t\tRTE_CRYPTO_OP_TYPE_SYMMETRIC);\n+\tTEST_ASSERT_NOT_NULL(ut_params->op,\n+\t\t\t\"Failed to allocate symmetric crypto operation struct\");\n+\n+\tsym_op = ut_params->op->sym;\n+\n+\tsym_op->auth.digest.data = digest_mem;\n+\tTEST_ASSERT_NOT_NULL(sym_op->auth.digest.data,\n+\t\t\t\"no room to append digest\");\n+\n+\tsym_op->auth.digest.phys_addr = digest_phys;\n+\n+\tif (op == RTE_CRYPTO_AUTH_OP_VERIFY) {\n+\t\trte_memcpy(sym_op->auth.digest.data, tdata->gmac_tag.data,\n+\t\t\t\ttdata->gmac_tag.len);\n+\t\tdebug_hexdump(stdout, \"digest:\",\n+\t\t\t\tsym_op->auth.digest.data,\n+\t\t\t\ttdata->gmac_tag.len);\n+\t}\n+\n+\tuint8_t *iv_ptr = rte_crypto_op_ctod_offset(ut_params->op,\n+\t\t\tuint8_t *, IV_OFFSET);\n+\n+\trte_memcpy(iv_ptr, tdata->iv.data, tdata->iv.len);\n+\n+\tdebug_hexdump(stdout, \"iv:\", iv_ptr, tdata->iv.len);\n+\n+\tsym_op->cipher.data.length = 0;\n+\tsym_op->cipher.data.offset = 0;\n+\n+\tsym_op->auth.data.offset = 0;\n+\tsym_op->auth.data.length = tdata->plaintext.len;\n+\n+\treturn 0;\n+}\n+\n static int create_gmac_session(uint8_t dev_id,\n \t\tconst struct gmac_test_data *tdata,\n \t\tenum rte_crypto_auth_operation auth_op)\n@@ -10251,6 +10300,167 @@ test_AES_GMAC_authentication_verify_test_case_4(void)\n \treturn test_AES_GMAC_authentication_verify(&gmac_test_case_4);\n }\n \n+static int\n+test_AES_GMAC_authentication_SGL(const struct gmac_test_data *tdata,\n+\t\t\t\tuint32_t fragsz)\n+{\n+\tstruct crypto_testsuite_params *ts_params = &testsuite_params;\n+\tstruct crypto_unittest_params *ut_params = &unittest_params;\n+\tstruct rte_cryptodev_info dev_info;\n+\tuint64_t feature_flags;\n+\tunsigned int trn_data = 0;\n+\tvoid *digest_mem = NULL;\n+\tuint32_t segs = 1;\n+\tunsigned int to_trn = 0;\n+\tstruct rte_mbuf *buf = NULL;\n+\tuint8_t *auth_tag, *plaintext;\n+\tint retval;\n+\n+\tTEST_ASSERT_NOT_EQUAL(tdata->gmac_tag.len, 0,\n+\t\t\t      \"No GMAC length in the source data\");\n+\n+\t/* Verify the capabilities */\n+\tstruct rte_cryptodev_sym_capability_idx cap_idx;\n+\n+\tcap_idx.type = RTE_CRYPTO_SYM_XFORM_AUTH;\n+\tcap_idx.algo.auth = RTE_CRYPTO_AUTH_AES_GMAC;\n+\tif (rte_cryptodev_sym_capability_get(ts_params->valid_devs[0],\n+\t\t\t&cap_idx) == NULL)\n+\t\treturn -ENOTSUP;\n+\n+\t/* Check for any input SGL support */\n+\trte_cryptodev_info_get(ts_params->valid_devs[0], &dev_info);\n+\tfeature_flags = dev_info.feature_flags;\n+\n+\tif ((!(feature_flags & RTE_CRYPTODEV_FF_IN_PLACE_SGL)) &&\n+\t\t\t(!(feature_flags & RTE_CRYPTODEV_FF_OOP_SGL_IN_LB_OUT)) &&\n+\t\t\t(!(feature_flags & RTE_CRYPTODEV_FF_OOP_SGL_IN_SGL_OUT)))\n+\t\treturn -ENOTSUP;\n+\n+\tif (fragsz > tdata->plaintext.len)\n+\t\tfragsz = tdata->plaintext.len;\n+\n+\tuint16_t plaintext_len = fragsz;\n+\n+\tretval = create_gmac_session(ts_params->valid_devs[0],\n+\t\t\ttdata, RTE_CRYPTO_AUTH_OP_GENERATE);\n+\n+\tif (retval < 0)\n+\t\treturn retval;\n+\n+\tut_params->ibuf = rte_pktmbuf_alloc(ts_params->mbuf_pool);\n+\tTEST_ASSERT_NOT_NULL(ut_params->ibuf,\n+\t\t\t\"Failed to allocate input buffer in mempool\");\n+\n+\tmemset(rte_pktmbuf_mtod(ut_params->ibuf, uint8_t *), 0,\n+\t\t\trte_pktmbuf_tailroom(ut_params->ibuf));\n+\n+\tplaintext = (uint8_t *)rte_pktmbuf_append(ut_params->ibuf,\n+\t\t\t\tplaintext_len);\n+\tTEST_ASSERT_NOT_NULL(plaintext, \"no room to append plaintext\");\n+\n+\tmemcpy(plaintext, tdata->plaintext.data, plaintext_len);\n+\n+\ttrn_data += plaintext_len;\n+\n+\tbuf = ut_params->ibuf;\n+\n+\t/*\n+\t * Loop until no more fragments\n+\t */\n+\n+\twhile (trn_data < tdata->plaintext.len) {\n+\t\t++segs;\n+\t\tto_trn = (tdata->plaintext.len - trn_data < fragsz) ?\n+\t\t\t\t(tdata->plaintext.len - trn_data) : fragsz;\n+\n+\t\tbuf->next = rte_pktmbuf_alloc(ts_params->mbuf_pool);\n+\t\tbuf = buf->next;\n+\n+\t\tmemset(rte_pktmbuf_mtod(buf, uint8_t *), 0,\n+\t\t\t\trte_pktmbuf_tailroom(buf));\n+\n+\t\tplaintext = (uint8_t *)rte_pktmbuf_append(buf,\n+\t\t\t\tto_trn);\n+\n+\t\tmemcpy(plaintext, tdata->plaintext.data + trn_data,\n+\t\t\t\tto_trn);\n+\t\ttrn_data += to_trn;\n+\t\tif (trn_data  == tdata->plaintext.len)\n+\t\t\tdigest_mem = (uint8_t *)rte_pktmbuf_append(buf,\n+\t\t\t\t\ttdata->gmac_tag.len);\n+\t}\n+\tut_params->ibuf->nb_segs = segs;\n+\n+\t/*\n+\t * Place digest at the end of the last buffer\n+\t */\n+\tuint64_t digest_phys = rte_pktmbuf_iova(buf) + to_trn;\n+\n+\tif (!digest_mem) {\n+\t\tdigest_mem = (uint8_t *)rte_pktmbuf_append(ut_params->ibuf,\n+\t\t\t\t+ tdata->gmac_tag.len);\n+\t\tdigest_phys = rte_pktmbuf_iova_offset(ut_params->ibuf,\n+\t\t\t\ttdata->plaintext.len);\n+\t}\n+\n+\tretval = create_gmac_operation_sgl(RTE_CRYPTO_AUTH_OP_GENERATE,\n+\t\t\ttdata, digest_mem, digest_phys);\n+\n+\tif (retval < 0)\n+\t\treturn retval;\n+\n+\trte_crypto_op_attach_sym_session(ut_params->op, ut_params->sess);\n+\n+\tut_params->op->sym->m_src = ut_params->ibuf;\n+\n+\tif (gbl_action_type == RTE_SECURITY_ACTION_TYPE_CPU_CRYPTO)\n+\t\treturn -ENOTSUP;\n+\n+\tTEST_ASSERT_NOT_NULL(\n+\t\tprocess_crypto_request(ts_params->valid_devs[0],\n+\t\tut_params->op), \"failed to process sym crypto op\");\n+\n+\tTEST_ASSERT_EQUAL(ut_params->op->status, RTE_CRYPTO_OP_STATUS_SUCCESS,\n+\t\t\t\"crypto op processing failed\");\n+\n+\tauth_tag = digest_mem;\n+\tdebug_hexdump(stdout, \"auth tag:\", auth_tag, tdata->gmac_tag.len);\n+\tTEST_ASSERT_BUFFERS_ARE_EQUAL(\n+\t\t\tauth_tag,\n+\t\t\ttdata->gmac_tag.data,\n+\t\t\ttdata->gmac_tag.len,\n+\t\t\t\"GMAC Generated auth tag not as expected\");\n+\n+\treturn 0;\n+}\n+\n+/* Segment size not multiple of block size (16B) */\n+static int\n+test_AES_GMAC_authentication_SGL_40B(void)\n+{\n+\treturn test_AES_GMAC_authentication_SGL(&gmac_test_case_1, 40);\n+}\n+\n+static int\n+test_AES_GMAC_authentication_SGL_80B(void)\n+{\n+\treturn test_AES_GMAC_authentication_SGL(&gmac_test_case_1, 80);\n+}\n+\n+static int\n+test_AES_GMAC_authentication_SGL_400B(void)\n+{\n+\treturn test_AES_GMAC_authentication_SGL(&gmac_test_case_4, 400);\n+}\n+\n+/* Segment size not multiple of block size (16B) */\n+static int\n+test_AES_GMAC_authentication_SGL_401B(void)\n+{\n+\treturn test_AES_GMAC_authentication_SGL(&gmac_test_case_4, 401);\n+}\n+\n struct test_crypto_vector {\n \tenum rte_crypto_cipher_algorithm crypto_algo;\n \tunsigned int cipher_offset;\n@@ -11245,8 +11455,6 @@ create_aead_operation_SGL(enum rte_crypto_aead_operation op,\n \treturn 0;\n }\n \n-#define SGL_MAX_NO\t16\n-\n static int\n test_authenticated_encryption_SGL(const struct aead_test_data *tdata,\n \t\tconst int oop, uint32_t fragsz, uint32_t fragsz_oop)\n@@ -12164,6 +12372,14 @@ static struct unit_test_suite cryptodev_testsuite  = {\n \t\t\ttest_AES_GMAC_authentication_test_case_4),\n \t\tTEST_CASE_ST(ut_setup, ut_teardown,\n \t\t\ttest_AES_GMAC_authentication_verify_test_case_4),\n+\t\tTEST_CASE_ST(ut_setup, ut_teardown,\n+\t\t\ttest_AES_GMAC_authentication_SGL_40B),\n+\t\tTEST_CASE_ST(ut_setup, ut_teardown,\n+\t\t\ttest_AES_GMAC_authentication_SGL_80B),\n+\t\tTEST_CASE_ST(ut_setup, ut_teardown,\n+\t\t\ttest_AES_GMAC_authentication_SGL_400B),\n+\t\tTEST_CASE_ST(ut_setup, ut_teardown,\n+\t\t\ttest_AES_GMAC_authentication_SGL_401B),\n \t\t/** Chacha20-Poly1305 */\n \t\tTEST_CASE_ST(ut_setup, ut_teardown,\n \t\t\ttest_chacha20_poly1305_encrypt_test_case_rfc8439),\n",
    "prefixes": [
        "2/2"
    ]
}