Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/77369/?format=api
{ "id": 77369, "url": "http://patches.dpdk.org/api/patches/77369/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200911091919.62167-1-harry.van.haaren@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200911091919.62167-1-harry.van.haaren@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200911091919.62167-1-harry.van.haaren@intel.com", "date": "2020-09-11T09:19:19", "name": "eal: add new prefetch0_write variant", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "fadb42e45789275815065801f6374023ac5ab412", "submitter": { "id": 317, "url": "http://patches.dpdk.org/api/people/317/?format=api", "name": "Van Haaren, Harry", "email": "harry.van.haaren@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200911091919.62167-1-harry.van.haaren@intel.com/mbox/", "series": [ { "id": 12139, "url": "http://patches.dpdk.org/api/series/12139/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12139", "date": "2020-09-11T09:19:19", "name": "eal: add new prefetch0_write variant", "version": 1, "mbox": "http://patches.dpdk.org/series/12139/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/77369/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/77369/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0E370A04B5;\n\tFri, 11 Sep 2020 11:18:07 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 634691BFCD;\n\tFri, 11 Sep 2020 11:18:06 +0200 (CEST)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n by dpdk.org (Postfix) with ESMTP id EFCD31BF90\n for <dev@dpdk.org>; Fri, 11 Sep 2020 11:18:04 +0200 (CEST)", "from orsmga003.jf.intel.com ([10.7.209.27])\n by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 11 Sep 2020 02:18:03 -0700", "from silpixa00399779.ir.intel.com (HELO\n silpixa00399779.ger.corp.intel.com) ([10.237.222.209])\n by orsmga003.jf.intel.com with ESMTP; 11 Sep 2020 02:18:02 -0700" ], "IronPort-SDR": [ "\n Lxu3LXCYp3THF+l4n+nf21aCW9Ls/Xr5MP7AHE2FBdGQT/1bVI66hGHdvw7L8z3TriZpydMZS0\n nUfFLsjtKUNg==", "\n YzA9iw/RSDhWE2TDeY0/fdhfFO87nA7EzW/Mh8InOml2z48+irEAhLp7sbWnO8VJUwoPzRGYUh\n +g/H7JgmL6xQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9740\"; a=\"156123284\"", "E=Sophos;i=\"5.76,414,1592895600\"; d=\"scan'208\";a=\"156123284\"", "E=Sophos;i=\"5.76,414,1592895600\"; d=\"scan'208\";a=\"300875657\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Harry van Haaren <harry.van.haaren@intel.com>", "To": "dev@dpdk.org", "Cc": "Harry van Haaren <harry.van.haaren@intel.com>", "Date": "Fri, 11 Sep 2020 10:19:19 +0100", "Message-Id": "<20200911091919.62167-1-harry.van.haaren@intel.com>", "X-Mailer": "git-send-email 2.17.1", "Subject": "[dpdk-dev] [PATCH] eal: add new prefetch0_write variant", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This commit adds a new rte_prefetch0_write() variant, suggests to the\ncompiler to use a prefetch instruction with intention to write. As a\ncompiler builtin, the compiler can choose based on compilation target\nwhat the best implementation for this instruction is.\n\nSigned-off-by: Harry van Haaren <harry.van.haaren@intel.com>\n\n---\n\nThe integer constants passed to the builtin are not available as\na #define value, and doing #defines just for this write variant\ndoes not seems a nice solution to me... particularly for those using\nIDEs where any #define value is auto-hinted for code-completion.\n\n---\n lib/librte_eal/include/generic/rte_prefetch.h | 16 ++++++++++++++++\n 1 file changed, 16 insertions(+)", "diff": "diff --git a/lib/librte_eal/include/generic/rte_prefetch.h b/lib/librte_eal/include/generic/rte_prefetch.h\nindex 6e47bdfbad..44e2e9abfc 100644\n--- a/lib/librte_eal/include/generic/rte_prefetch.h\n+++ b/lib/librte_eal/include/generic/rte_prefetch.h\n@@ -51,4 +51,20 @@ static inline void rte_prefetch2(const volatile void *p);\n */\n static inline void rte_prefetch_non_temporal(const volatile void *p);\n \n+/**\n+ * Prefetch a cache line into all cache levels, with intention to write. This\n+ * prefetch variant hints to the CPU that the program is expecting to write to\n+ * the cache line being prefetched.\n+ *\n+ * @param p Address to prefetch\n+ */\n+static inline void rte_prefetch0_write(const void *p)\n+{\n+\t/* 1 indicates intention to write, 3 sets target cache level to L1. See\n+\t * GCC docs where these integer constants are described in more detail:\n+\t * https://gcc.gnu.org/onlinedocs/gcc/Other-Builtins.html\n+\t */\n+\t__builtin_prefetch(p, 1, 3);\n+}\n+\n #endif /* _RTE_PREFETCH_H_ */\n", "prefixes": [] }