Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/77313/?format=api
{ "id": 77313, "url": "http://patches.dpdk.org/api/patches/77313/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1599794967-17500-2-git-send-email-phil.yang@arm.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1599794967-17500-2-git-send-email-phil.yang@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1599794967-17500-2-git-send-email-phil.yang@arm.com", "date": "2020-09-11T03:29:24", "name": "[1/4] eal: use C11 atomic builtins for already initialized check", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "7edafe9a6add50fd42c397cb80db81537790a9c6", "submitter": { "id": 833, "url": "http://patches.dpdk.org/api/people/833/?format=api", "name": "Phil Yang", "email": "phil.yang@arm.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1599794967-17500-2-git-send-email-phil.yang@arm.com/mbox/", "series": [ { "id": 12125, "url": "http://patches.dpdk.org/api/series/12125/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12125", "date": "2020-09-11T03:29:23", "name": "use C11 atomic builtins for libs", "version": 1, "mbox": "http://patches.dpdk.org/series/12125/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/77313/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/77313/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 98C58A04B5;\n\tFri, 11 Sep 2020 05:29:37 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 44B441C0CD;\n\tFri, 11 Sep 2020 05:29:33 +0200 (CEST)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by dpdk.org (Postfix) with ESMTP id 344351C0CC\n for <dev@dpdk.org>; Fri, 11 Sep 2020 05:29:32 +0200 (CEST)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7394A11B3;\n Thu, 10 Sep 2020 20:29:31 -0700 (PDT)", "from phil-VirtualBox.shanghai.arm.com\n (phil-VirtualBox.shanghai.arm.com [10.169.182.49])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 9B5723F73C;\n Thu, 10 Sep 2020 20:29:29 -0700 (PDT)" ], "From": "Phil Yang <phil.yang@arm.com>", "To": "dev@dpdk.org", "Cc": "Honnappa.Nagarahalli@arm.com, Ruifeng.Wang@arm.com, nd@arm.com,\n Bruce Richardson <bruce.richardson@intel.com>", "Date": "Fri, 11 Sep 2020 11:29:24 +0800", "Message-Id": "<1599794967-17500-2-git-send-email-phil.yang@arm.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1599794967-17500-1-git-send-email-phil.yang@arm.com>", "References": "<1599794967-17500-1-git-send-email-phil.yang@arm.com>", "Subject": "[dpdk-dev] [PATCH 1/4] eal: use C11 atomic builtins for already\n\tinitialized check", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Since rte_atomicXX APIs are not allowed to be used, use C11 builtins to\ncheck if EAL is already initialized.\n\nSigned-off-by: Phil Yang <phil.yang@arm.com>\nReviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>\nReviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>\n---\n lib/librte_eal/freebsd/eal.c | 18 ++++++++++--------\n lib/librte_eal/linux/eal.c | 20 +++++++++++---------\n 2 files changed, 21 insertions(+), 17 deletions(-)", "diff": "diff --git a/lib/librte_eal/freebsd/eal.c b/lib/librte_eal/freebsd/eal.c\nindex 798add0..9f4c7bb 100644\n--- a/lib/librte_eal/freebsd/eal.c\n+++ b/lib/librte_eal/freebsd/eal.c\n@@ -665,7 +665,8 @@ rte_eal_init(int argc, char **argv)\n {\n \tint i, fctret, ret;\n \tpthread_t thread_id;\n-\tstatic rte_atomic32_t run_once = RTE_ATOMIC32_INIT(0);\n+\tstatic uint32_t run_once;\n+\tuint32_t has_run = 0;\n \tchar cpuset[RTE_CPU_AFFINITY_STR_LEN];\n \tchar thread_name[RTE_MAX_THREAD_NAME_LEN];\n \tconst struct rte_config *config = rte_eal_get_configuration();\n@@ -679,7 +680,8 @@ rte_eal_init(int argc, char **argv)\n \t\treturn -1;\n \t}\n \n-\tif (!rte_atomic32_test_and_set(&run_once)) {\n+\tif (!__atomic_compare_exchange_n(&run_once, &has_run, 1, 0,\n+\t\t\t\t\t__ATOMIC_RELAXED, __ATOMIC_RELAXED)) {\n \t\trte_eal_init_alert(\"already called initialization.\");\n \t\trte_errno = EALREADY;\n \t\treturn -1;\n@@ -705,7 +707,7 @@ rte_eal_init(int argc, char **argv)\n \tif (fctret < 0) {\n \t\trte_eal_init_alert(\"Invalid 'command line' arguments.\");\n \t\trte_errno = EINVAL;\n-\t\trte_atomic32_clear(&run_once);\n+\t\t__atomic_store_n(&run_once, 0, __ATOMIC_RELAXED);\n \t\treturn -1;\n \t}\n \n@@ -715,20 +717,20 @@ rte_eal_init(int argc, char **argv)\n \tif (eal_plugins_init() < 0) {\n \t\trte_eal_init_alert(\"Cannot init plugins\");\n \t\trte_errno = EINVAL;\n-\t\trte_atomic32_clear(&run_once);\n+\t\t__atomic_store_n(&run_once, 0, __ATOMIC_RELAXED);\n \t\treturn -1;\n \t}\n \n \tif (eal_trace_init() < 0) {\n \t\trte_eal_init_alert(\"Cannot init trace\");\n \t\trte_errno = EFAULT;\n-\t\trte_atomic32_clear(&run_once);\n+\t\t__atomic_store_n(&run_once, 0, __ATOMIC_RELAXED);\n \t\treturn -1;\n \t}\n \n \tif (eal_option_device_parse()) {\n \t\trte_errno = ENODEV;\n-\t\trte_atomic32_clear(&run_once);\n+\t\t__atomic_store_n(&run_once, 0, __ATOMIC_RELAXED);\n \t\treturn -1;\n \t}\n \n@@ -762,7 +764,7 @@ rte_eal_init(int argc, char **argv)\n \tif (rte_bus_scan()) {\n \t\trte_eal_init_alert(\"Cannot scan the buses for devices\");\n \t\trte_errno = ENODEV;\n-\t\trte_atomic32_clear(&run_once);\n+\t\t__atomic_store_n(&run_once, 0, __ATOMIC_RELAXED);\n \t\treturn -1;\n \t}\n \n@@ -790,7 +792,7 @@ rte_eal_init(int argc, char **argv)\n \t\tif (ret < 0) {\n \t\t\trte_eal_init_alert(\"Cannot get hugepage information.\");\n \t\t\trte_errno = EACCES;\n-\t\t\trte_atomic32_clear(&run_once);\n+\t\t\t__atomic_store_n(&run_once, 0, __ATOMIC_RELAXED);\n \t\t\treturn -1;\n \t\t}\n \t}\ndiff --git a/lib/librte_eal/linux/eal.c b/lib/librte_eal/linux/eal.c\nindex 0960f01..82a73ed 100644\n--- a/lib/librte_eal/linux/eal.c\n+++ b/lib/librte_eal/linux/eal.c\n@@ -960,7 +960,8 @@ rte_eal_init(int argc, char **argv)\n {\n \tint i, fctret, ret;\n \tpthread_t thread_id;\n-\tstatic rte_atomic32_t run_once = RTE_ATOMIC32_INIT(0);\n+\tstatic uint32_t run_once;\n+\tuint32_t has_run = 0;\n \tconst char *p;\n \tstatic char logid[PATH_MAX];\n \tchar cpuset[RTE_CPU_AFFINITY_STR_LEN];\n@@ -977,7 +978,8 @@ rte_eal_init(int argc, char **argv)\n \t\treturn -1;\n \t}\n \n-\tif (!rte_atomic32_test_and_set(&run_once)) {\n+\tif (!__atomic_compare_exchange_n(&run_once, &has_run, 1, 0,\n+\t\t\t\t\t__ATOMIC_RELAXED, __ATOMIC_RELAXED)) {\n \t\trte_eal_init_alert(\"already called initialization.\");\n \t\trte_errno = EALREADY;\n \t\treturn -1;\n@@ -1005,14 +1007,14 @@ rte_eal_init(int argc, char **argv)\n \tif (fctret < 0) {\n \t\trte_eal_init_alert(\"Invalid 'command line' arguments.\");\n \t\trte_errno = EINVAL;\n-\t\trte_atomic32_clear(&run_once);\n+\t\t__atomic_store_n(&run_once, 0, __ATOMIC_RELAXED);\n \t\treturn -1;\n \t}\n \n \tif (eal_plugins_init() < 0) {\n \t\trte_eal_init_alert(\"Cannot init plugins\");\n \t\trte_errno = EINVAL;\n-\t\trte_atomic32_clear(&run_once);\n+\t\t__atomic_store_n(&run_once, 0, __ATOMIC_RELAXED);\n \t\treturn -1;\n \t}\n \n@@ -1024,7 +1026,7 @@ rte_eal_init(int argc, char **argv)\n \n \tif (eal_option_device_parse()) {\n \t\trte_errno = ENODEV;\n-\t\trte_atomic32_clear(&run_once);\n+\t\t__atomic_store_n(&run_once, 0, __ATOMIC_RELAXED);\n \t\treturn -1;\n \t}\n \n@@ -1064,7 +1066,7 @@ rte_eal_init(int argc, char **argv)\n \tif (rte_bus_scan()) {\n \t\trte_eal_init_alert(\"Cannot scan the buses for devices\");\n \t\trte_errno = ENODEV;\n-\t\trte_atomic32_clear(&run_once);\n+\t\t__atomic_store_n(&run_once, 0, __ATOMIC_RELAXED);\n \t\treturn -1;\n \t}\n \n@@ -1138,7 +1140,7 @@ rte_eal_init(int argc, char **argv)\n \t\tif (ret < 0) {\n \t\t\trte_eal_init_alert(\"Cannot get hugepage information.\");\n \t\t\trte_errno = EACCES;\n-\t\t\trte_atomic32_clear(&run_once);\n+\t\t\t__atomic_store_n(&run_once, 0, __ATOMIC_RELAXED);\n \t\t\treturn -1;\n \t\t}\n \t}\n@@ -1162,7 +1164,7 @@ rte_eal_init(int argc, char **argv)\n \tif (rte_eal_log_init(logid, internal_conf->syslog_facility) < 0) {\n \t\trte_eal_init_alert(\"Cannot init logging.\");\n \t\trte_errno = ENOMEM;\n-\t\trte_atomic32_clear(&run_once);\n+\t\t__atomic_store_n(&run_once, 0, __ATOMIC_RELAXED);\n \t\treturn -1;\n \t}\n \n@@ -1170,7 +1172,7 @@ rte_eal_init(int argc, char **argv)\n \tif (rte_eal_vfio_setup() < 0) {\n \t\trte_eal_init_alert(\"Cannot init VFIO\");\n \t\trte_errno = EAGAIN;\n-\t\trte_atomic32_clear(&run_once);\n+\t\t__atomic_store_n(&run_once, 0, __ATOMIC_RELAXED);\n \t\treturn -1;\n \t}\n #endif\n", "prefixes": [ "1/4" ] }