Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/77287/?format=api
{ "id": 77287, "url": "http://patches.dpdk.org/api/patches/77287/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200911015603.88359-26-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200911015603.88359-26-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200911015603.88359-26-ajit.khaparde@broadcom.com", "date": "2020-09-11T01:56:03", "name": "[25/25] net/bnxt: fix to have a separate mutex for FW health check", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "528b77be92d6ab7dc07d8a464294198a0fc0965e", "submitter": { "id": 501, "url": "http://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200911015603.88359-26-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 12116, "url": "http://patches.dpdk.org/api/series/12116/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12116", "date": "2020-09-11T01:55:38", "name": "patchset for bnxt", "version": 1, "mbox": "http://patches.dpdk.org/series/12116/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/77287/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/77287/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4AA13A04B5;\n\tFri, 11 Sep 2020 04:00:38 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0B6E81C1F3;\n\tFri, 11 Sep 2020 03:57:51 +0200 (CEST)", "from mail-pj1-f97.google.com (mail-pj1-f97.google.com\n [209.85.216.97]) by dpdk.org (Postfix) with ESMTP id 946001C1E5\n for <dev@dpdk.org>; Fri, 11 Sep 2020 03:57:48 +0200 (CEST)", "by mail-pj1-f97.google.com with SMTP id md22so1947382pjb.0\n for <dev@dpdk.org>; Thu, 10 Sep 2020 18:57:48 -0700 (PDT)", "from localhost.localdomain ([192.19.223.252])\n by smtp-relay.gmail.com with ESMTPS id cl6sm80986pjb.15.2020.09.10.18.57.44\n (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n Thu, 10 Sep 2020 18:57:47 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com;\n s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=T7Rtge64WGSwTz713sQcHn3W7k3xw0HZis2w4nP1GXA=;\n b=hfcMlBj4XhcdaJJSZaS0jIClMW1bSOioEoGWyhcCdyvCIA0TFbEN7kcg2LyW8iE6oq\n g1DsOH9xDcKFR774+G+f6v5fIIMzDcjLUfLBVOowb/vWygry/ga4hC0p/EdmpKfFJt9c\n JdZdgl+4sUyKwidhKaksaJHVoT5VpaV8YYR44=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=T7Rtge64WGSwTz713sQcHn3W7k3xw0HZis2w4nP1GXA=;\n b=IIEiJiG+Asw16f5XwpbrKMqvA/bTqlH4DClq6fmuMr2NodCS0VuBNaezKeqGtIN8Eh\n b0vS1abB9Qa5eempkGePF3tPGn/bbxwHAyb6ujiTpfVx6rD0nRpVbJkWUmdzmQjtqIki\n 7Zs0nROwPlcu09HbZ6FAaL6CjrYrAfU434TT+krObxZLPbFC8w08jaSO9NSfoTuHjCZv\n kGj+l5xRNjYplb8eVSPqbJ9zFpuifl22Wiik1aCUN/sjpQIIT+7lB9a3/B3scv45O3Xy\n 0EUvjxRoawpGzdyRac8FXYt9Bn5NY9TRBzrUILE6MvmP8FDNFXyvyyvnaa+uYjmiC623\n C/rw==", "X-Gm-Message-State": "AOAM530QPG57Jj8vpNJ7pMgLxd4Ly7Dtcc+gkMSmra6TiqMKXYKPkHBQ\n Dd1dgEorZhrYlSokkkZEbQ33v9ScmeQHQ+zbA0A9MM9d1Y2QRGXQVAK2vB44AeAfhcpER2OdS7Z\n e38tj4lbI4CwqRdJHGTkPko3CvcUC2yqv9U7SlmTOcKhhP5hh7X4DLOjQHei8MkEJEYqaD68wLW\n pbQQ==", "X-Google-Smtp-Source": "\n ABdhPJy6G74ucv1yW4Mv7JLzDJkZBM61mcWNh+E6orp8YKjftpRz3jbpTxNdZcaTDFSjG8dUecT9MDsjNszq", "X-Received": "by 2002:a17:90b:4b82:: with SMTP id\n lr2mr61726pjb.184.1599789467607;\n Thu, 10 Sep 2020 18:57:47 -0700 (PDT)", "X-Relaying-Domain": "broadcom.com", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "Somnath Kotur <somnath.kotur@broadcom.com>, stable@dpdk.org,\n Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>,\n Kalesh Anakkur Purayil <kalesh-anakkur.purayil@broadcom.com>", "Date": "Thu, 10 Sep 2020 18:56:03 -0700", "Message-Id": "<20200911015603.88359-26-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.21.1 (Apple Git-122.3)", "In-Reply-To": "<20200911015603.88359-1-ajit.khaparde@broadcom.com>", "References": "<20200911015603.88359-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 25/25] net/bnxt: fix to have a separate mutex for\n\tFW health check", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Somnath Kotur <somnath.kotur@broadcom.com>\n\ndef_cp_lock was added to sync race between dev_configure and\nint_handler. It should not be used to synchronize scheduling of FW\nhealth check between dev_start and async event handler as well,\nuse a separate mutex for the same.\n\nFixes: a73b8e939f10 (\"net/bnxt: fix race between start and interrupt handler\")\nCc: stable@dpdk.org\n\nSigned-off-by: Somnath Kotur <somnath.kotur@broadcom.com>\nReviewed-by: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>\nReviewed-by: Kalesh Anakkur Purayil <kalesh-anakkur.purayil@broadcom.com>\n---\n drivers/net/bnxt/bnxt.h | 1 +\n drivers/net/bnxt/bnxt_ethdev.c | 16 ++++++++++++----\n 2 files changed, 13 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h\nindex d2944aa74..5770f4b73 100644\n--- a/drivers/net/bnxt/bnxt.h\n+++ b/drivers/net/bnxt/bnxt.h\n@@ -713,6 +713,7 @@ struct bnxt {\n \trte_iova_t\t\t\thwrm_short_cmd_req_dma_addr;\n \trte_spinlock_t\t\t\thwrm_lock;\n \tpthread_mutex_t\t\t\tdef_cp_lock;\n+\tpthread_mutex_t\t\t\thealth_check_lock;\n \tuint16_t\t\t\tmax_req_len;\n \tuint16_t\t\t\tmax_resp_len;\n \tuint16_t hwrm_max_ext_req_len;\ndiff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex e77e45486..8128b246a 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -1252,9 +1252,7 @@ static int bnxt_dev_start_op(struct rte_eth_dev *eth_dev)\n \teth_dev->rx_pkt_burst = bnxt_receive_function(eth_dev);\n \teth_dev->tx_pkt_burst = bnxt_transmit_function(eth_dev);\n \n-\tpthread_mutex_lock(&bp->def_cp_lock);\n \tbnxt_schedule_fw_health_check(bp);\n-\tpthread_mutex_unlock(&bp->def_cp_lock);\n \n \treturn 0;\n \n@@ -4663,17 +4661,22 @@ void bnxt_schedule_fw_health_check(struct bnxt *bp)\n {\n \tuint32_t polling_freq;\n \n+\tpthread_mutex_lock(&bp->health_check_lock);\n+\n \tif (!bnxt_is_recovery_enabled(bp))\n-\t\treturn;\n+\t\tgoto done;\n \n \tif (bp->flags & BNXT_FLAG_FW_HEALTH_CHECK_SCHEDULED)\n-\t\treturn;\n+\t\tgoto done;\n \n \tpolling_freq = bp->recovery_info->driver_polling_freq;\n \n \trte_eal_alarm_set(US_PER_MS * polling_freq,\n \t\t\t bnxt_check_fw_health, (void *)bp);\n \tbp->flags |= BNXT_FLAG_FW_HEALTH_CHECK_SCHEDULED;\n+\n+done:\n+\tpthread_mutex_unlock(&bp->health_check_lock);\n }\n \n static void bnxt_cancel_fw_health_check(struct bnxt *bp)\n@@ -5461,6 +5464,10 @@ bnxt_init_locks(struct bnxt *bp)\n \terr = pthread_mutex_init(&bp->def_cp_lock, NULL);\n \tif (err)\n \t\tPMD_DRV_LOG(ERR, \"Unable to initialize def_cp_lock\\n\");\n+\n+\terr = pthread_mutex_init(&bp->health_check_lock, NULL);\n+\tif (err)\n+\t\tPMD_DRV_LOG(ERR, \"Unable to initialize health_check_lock\\n\");\n \treturn err;\n }\n \n@@ -5869,6 +5876,7 @@ bnxt_uninit_locks(struct bnxt *bp)\n {\n \tpthread_mutex_destroy(&bp->flow_lock);\n \tpthread_mutex_destroy(&bp->def_cp_lock);\n+\tpthread_mutex_destroy(&bp->health_check_lock);\n \tif (bp->rep_info) {\n \t\tpthread_mutex_destroy(&bp->rep_info->vfr_lock);\n \t\tpthread_mutex_destroy(&bp->rep_info->vfr_start_lock);\n", "prefixes": [ "25/25" ] }