Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 77274,
    "url": "http://patches.dpdk.org/api/patches/77274/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200911015603.88359-13-ajit.khaparde@broadcom.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20200911015603.88359-13-ajit.khaparde@broadcom.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20200911015603.88359-13-ajit.khaparde@broadcom.com",
    "date": "2020-09-11T01:55:50",
    "name": "[12/25] net/bnxt: fix to conditionally rollback added VF-rep ports",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "1ea0160d95e48665b7aa8b74eca4c7071590abd9",
    "submitter": {
        "id": 501,
        "url": "http://patches.dpdk.org/api/people/501/?format=api",
        "name": "Ajit Khaparde",
        "email": "ajit.khaparde@broadcom.com"
    },
    "delegate": {
        "id": 1766,
        "url": "http://patches.dpdk.org/api/users/1766/?format=api",
        "username": "ajitkhaparde",
        "first_name": "Ajit",
        "last_name": "Khaparde",
        "email": "ajit.khaparde@broadcom.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200911015603.88359-13-ajit.khaparde@broadcom.com/mbox/",
    "series": [
        {
            "id": 12116,
            "url": "http://patches.dpdk.org/api/series/12116/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12116",
            "date": "2020-09-11T01:55:38",
            "name": "patchset for bnxt",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/12116/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/77274/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/77274/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1CBAAA04B5;\n\tFri, 11 Sep 2020 03:58:30 +0200 (CEST)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A615F1C193;\n\tFri, 11 Sep 2020 03:57:09 +0200 (CEST)",
            "from mail-pf1-f225.google.com (mail-pf1-f225.google.com\n [209.85.210.225]) by dpdk.org (Postfix) with ESMTP id 326541B9B7\n for <dev@dpdk.org>; Fri, 11 Sep 2020 03:57:08 +0200 (CEST)",
            "by mail-pf1-f225.google.com with SMTP id z19so6017608pfn.8\n for <dev@dpdk.org>; Thu, 10 Sep 2020 18:57:08 -0700 (PDT)",
            "from localhost.localdomain ([192.19.223.252])\n by smtp-relay.gmail.com with ESMTPS id cl6sm80986pjb.15.2020.09.10.18.57.00\n (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n Thu, 10 Sep 2020 18:57:07 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com;\n s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=eHzF503ya9oXL6uGTtibh3QOaBKT3+Tt8EKdD4alB3E=;\n b=Q/R/e2jpcXyU/+8Q8i99OomaUlbpoL8TXiOmkqhB87n91WAj3BwEnEm5no3Qlpc0CO\n tzl4fE3R7Q+Yd5wSpMrG3Y1oWfoXMCR6HyhmwQJII6nm6H/xz2oSepnUKjYrdnyWC8JM\n IwwjXnBylJI4PfuXVQWM9QYcEKFcZ6vXqj69Q=",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=eHzF503ya9oXL6uGTtibh3QOaBKT3+Tt8EKdD4alB3E=;\n b=odjiFHtWyZeUlSoxIeib7a2eLft71USs0si0755qMQ4+e36X6uzS0EgSrUJytjAIqU\n uyz/zq1pe1yY6cp3qM9wBo6cUGqHOmz3187T7nG2ReBhXdIj2iVfFM8Y5C9Km/blQrNv\n FU+KLTXrnaewlPOa2Fq6MyPiv8DoxBAk0sSyATuBvLuNK7ryoR5ikizRMaQB7Xsb3lwz\n DfGTcS+2+0nITKZyxMsvM2wbLwjXVKaWD+12wRZjSsQYSyQZ8gIYSrfW/O6ygGoVAiDt\n EBGyyV0tzDduhs/EaIhRZ5jrIeSI2Tz3xb882SkYJFzYN+ZOqYv5tWEnU5FaQ3FjJu7s\n PW3g==",
        "X-Gm-Message-State": "AOAM533wYrLqj+KXyLIrnZ4TaigyyJ7Pvn7I7MJUJBvzEXZwhQ4BKQWj\n UbTtBxDTtNqAUfiFSVMJhcfVRSDwveEyc/5xjopJ9iWq9nHRFn/hngabEU8r53kUefo97ZSlFy0\n lcK2igk7cxk6AKbqtfwI6CSaglqLc/CLy9zRcsNNarhRAxWmEpBvqFGf2z1Dv5sFjGKdSDRxXYt\n 3Iew==",
        "X-Google-Smtp-Source": "\n ABdhPJwqfi/uqqnzoPr617uoJd/q0Kx2szSvetkX+n2b1zPKXLuxsz1SJqnNv0jQy5VKMv0TJLr9ZjAD/bEx",
        "X-Received": "by 2002:a63:a23:: with SMTP id 35mr5279438pgk.333.1599789427129;\n Thu, 10 Sep 2020 18:57:07 -0700 (PDT)",
        "X-Relaying-Domain": "broadcom.com",
        "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>",
        "To": "dev@dpdk.org",
        "Cc": "Somnath Kotur <somnath.kotur@broadcom.com>,\n Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>",
        "Date": "Thu, 10 Sep 2020 18:55:50 -0700",
        "Message-Id": "<20200911015603.88359-13-ajit.khaparde@broadcom.com>",
        "X-Mailer": "git-send-email 2.21.1 (Apple Git-122.3)",
        "In-Reply-To": "<20200911015603.88359-1-ajit.khaparde@broadcom.com>",
        "References": "<20200911015603.88359-1-ajit.khaparde@broadcom.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH 12/25] net/bnxt: fix to conditionally rollback\n\tadded VF-rep ports",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "From: Somnath Kotur <somnath.kotur@broadcom.com>\n\nIf VF-rep port add fails for some reason, code was rolling back\nall ports added so far. With OVS-DPDK particularly, there is no need\nto do that, just log failure message for the VF rep port add and continue.\nAlso include RTE_MAX_ETH_PORTS value in the bounds check as one port\nwill be taken by the uplink port anyway\n\nFixes: 6dc83230b43b (\"net/bnxt: support port representor data path\")\n\nSigned-off-by: Somnath Kotur <somnath.kotur@broadcom.com>\nReviewed-by: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>\n---\n drivers/net/bnxt/bnxt_ethdev.c | 44 ++++++++++++++++++++--------------\n 1 file changed, 26 insertions(+), 18 deletions(-)",
    "diff": "diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex ea81ff149..043637db6 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -5999,7 +5999,7 @@ static int bnxt_rep_port_probe(struct rte_pci_device *pci_dev,\n \t\treturn -EINVAL;\n \t}\n \n-\tif (num_rep > RTE_MAX_ETHPORTS) {\n+\tif (num_rep >= RTE_MAX_ETHPORTS) {\n \t\tPMD_DRV_LOG(ERR,\n \t\t\t    \"nb_representor_ports = %d > %d MAX ETHPORTS\\n\",\n \t\t\t    num_rep, RTE_MAX_ETHPORTS);\n@@ -6042,28 +6042,36 @@ static int bnxt_rep_port_probe(struct rte_pci_device *pci_dev,\n \t\t\t\t\t NULL, NULL,\n \t\t\t\t\t bnxt_vf_representor_init,\n \t\t\t\t\t &representor);\n-\n-\t\tif (!ret) {\n-\t\t\tvf_rep_eth_dev = rte_eth_dev_allocated(name);\n-\t\t\tif (!vf_rep_eth_dev) {\n-\t\t\t\tPMD_DRV_LOG(ERR, \"Failed to find the eth_dev\"\n-\t\t\t\t\t    \" for VF-Rep: %s.\", name);\n-\t\t\t\tbnxt_pci_remove_dev_with_reps(backing_eth_dev);\n-\t\t\t\tret = -ENODEV;\n-\t\t\t\treturn ret;\n-\t\t\t}\n-\t\t\tPMD_DRV_LOG(DEBUG, \"BNXT Port:%d VFR pci probe\\n\",\n-\t\t\t\t    backing_eth_dev->data->port_id);\n-\t\t\tbacking_bp->rep_info[representor.vf_id].vfr_eth_dev =\n-\t\t\t\tvf_rep_eth_dev;\n-\t\t\tbacking_bp->num_reps++;\n-\t\t} else {\n+\t\tif (ret) {\n \t\t\tPMD_DRV_LOG(ERR, \"failed to create bnxt vf \"\n \t\t\t\t    \"representor %s.\", name);\n-\t\t\tbnxt_pci_remove_dev_with_reps(backing_eth_dev);\n+\t\t\tgoto err;\n \t\t}\n+\n+\t\tvf_rep_eth_dev = rte_eth_dev_allocated(name);\n+\t\tif (!vf_rep_eth_dev) {\n+\t\t\tPMD_DRV_LOG(ERR, \"Failed to find the eth_dev\"\n+\t\t\t\t    \" for VF-Rep: %s.\", name);\n+\t\t\tret = -ENODEV;\n+\t\t\tgoto err;\n+\t\t}\n+\n+\t\tPMD_DRV_LOG(DEBUG, \"BNXT Port:%d VFR pci probe\\n\",\n+\t\t\t\tbacking_eth_dev->data->port_id);\n+\t\tbacking_bp->rep_info[representor.vf_id].vfr_eth_dev =\n+\t\t\t\t\t\t\t vf_rep_eth_dev;\n+\t\tbacking_bp->num_reps++;\n \t}\n \n+\treturn 0;\n+\n+err:\n+\t/* If num_rep > 1, then rollback already created\n+\t * ports, since we'll be failing the probe anyway\n+\t */\n+\tif (num_rep > 1)\n+\t\tbnxt_pci_remove_dev_with_reps(backing_eth_dev);\n+\n \treturn ret;\n }\n \n",
    "prefixes": [
        "12/25"
    ]
}