Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/77157/?format=api
{ "id": 77157, "url": "http://patches.dpdk.org/api/patches/77157/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200910143609.986696-4-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200910143609.986696-4-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200910143609.986696-4-bruce.richardson@intel.com", "date": "2020-09-10T14:36:05", "name": "[v3,3/7] rawdev: add private data length parameter to config fn", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "313ef373b696cb4c2536f3498d2e976d37fe5933", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200910143609.986696-4-bruce.richardson@intel.com/mbox/", "series": [ { "id": 12105, "url": "http://patches.dpdk.org/api/series/12105/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12105", "date": "2020-09-10T14:36:02", "name": "Enhance rawdev APIs", "version": 3, "mbox": "http://patches.dpdk.org/series/12105/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/77157/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/77157/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 43EB8A04B5;\n\tThu, 10 Sep 2020 16:37:28 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B600B1C10C;\n\tThu, 10 Sep 2020 16:37:15 +0200 (CEST)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n by dpdk.org (Postfix) with ESMTP id 25D331C0B9\n for <dev@dpdk.org>; Thu, 10 Sep 2020 16:37:11 +0200 (CEST)", "from orsmga006.jf.intel.com ([10.7.209.51])\n by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 10 Sep 2020 07:37:05 -0700", "from silpixa00399126.ir.intel.com ([10.237.222.27])\n by orsmga006.jf.intel.com with ESMTP; 10 Sep 2020 07:36:59 -0700" ], "IronPort-SDR": [ "\n 91/rekOiDmg7OWIivtc3UGcchyMUO+S5I67ozBOPilgVGi6Vox0ndmj5xZVqRbvZNlHBTgz7Ch\n fN9ayPIq/kqQ==", "\n f2GQE7WZ2ypy5o/doORRfVkyQZCGfd6KKrlyQlD0Az8BXIz+0EBoE03BsBhCW0ZW9UEmZuutiF\n 3gX1gffu9ubg==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9739\"; a=\"146263387\"", "E=Sophos;i=\"5.76,413,1592895600\"; d=\"scan'208\";a=\"146263387\"", "E=Sophos;i=\"5.76,413,1592895600\"; d=\"scan'208\";a=\"304900363\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, Bruce Richardson <bruce.richardson@intel.com>,\n Rosen Xu <rosen.xu@intel.com>, Nipun Gupta <nipun.gupta@nxp.com>,\n John McNamara <john.mcnamara@intel.com>,\n Marko Kovacevic <marko.kovacevic@intel.com>,\n Satha Rao <skoteshwar@marvell.com>, Mahipal Challa <mchalla@marvell.com>,\n Tianfei zhang <tianfei.zhang@intel.com>, Xiaoyun Li <xiaoyun.li@intel.com>,\n Jingjing Wu <jingjing.wu@intel.com>,\n Hemant Agrawal <hemant.agrawal@nxp.com>", "Date": "Thu, 10 Sep 2020 15:36:05 +0100", "Message-Id": "<20200910143609.986696-4-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200910143609.986696-1-bruce.richardson@intel.com>", "References": "<20200709152047.167730-1-bruce.richardson@intel.com>\n <20200910143609.986696-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 3/7] rawdev: add private data length parameter\n\tto config fn", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Currently with the rawdev API there is no way to check that the structure\npassed in via the dev_private pointer in the structure passed to configure\nAPI is of the correct type - it's just checked that it is non-NULL. Adding\nin the length of the expected structure provides a measure of typechecking,\nand can also be used for ABI compatibility in future, since ABI changes\ninvolving structs almost always involve a change in size.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\nReviewed-by: Rosen Xu <rosen.xu@intel.com>\nAcked-by: Nipun Gupta <nipun.gupta@nxp.com>\n\n---\nV3: fixed doxygen comment.\n add release note update\n---\n doc/guides/rawdevs/ioat.rst | 2 +-\n doc/guides/rawdevs/octeontx2_dma.rst | 2 +-\n doc/guides/rawdevs/octeontx2_ep.rst | 3 ++-\n doc/guides/rel_notes/release_20_11.rst | 4 ++--\n doc/guides/sample_app_ug/ioat.rst | 2 +-\n drivers/raw/ifpga/ifpga_rawdev.c | 3 ++-\n drivers/raw/ioat/ioat_rawdev.c | 5 +++--\n drivers/raw/ioat/ioat_rawdev_test.c | 2 +-\n drivers/raw/ntb/ntb.c | 6 +++++-\n drivers/raw/octeontx2_dma/otx2_dpi_rawdev.c | 7 ++++---\n drivers/raw/octeontx2_dma/otx2_dpi_test.c | 3 ++-\n drivers/raw/octeontx2_ep/otx2_ep_rawdev.c | 7 ++++---\n drivers/raw/octeontx2_ep/otx2_ep_test.c | 2 +-\n drivers/raw/skeleton/skeleton_rawdev.c | 5 +++--\n drivers/raw/skeleton/skeleton_rawdev_test.c | 5 +++--\n examples/ioat/ioatfwd.c | 2 +-\n examples/ntb/ntb_fwd.c | 2 +-\n lib/librte_rawdev/rte_rawdev.c | 6 ++++--\n lib/librte_rawdev/rte_rawdev.h | 8 +++++++-\n lib/librte_rawdev/rte_rawdev_pmd.h | 3 ++-\n 20 files changed, 50 insertions(+), 29 deletions(-)", "diff": "diff --git a/doc/guides/rawdevs/ioat.rst b/doc/guides/rawdevs/ioat.rst\nindex dac52fabf1..c46460ff45 100644\n--- a/doc/guides/rawdevs/ioat.rst\n+++ b/doc/guides/rawdevs/ioat.rst\n@@ -142,7 +142,7 @@ The following code shows how the device is configured in\n /* ... */\n \n p.ring_size = IOAT_TEST_RINGSIZE;\n- if (rte_rawdev_configure(dev_id, &info) != 0) {\n+ if (rte_rawdev_configure(dev_id, &info, sizeof(p)) != 0) {\n printf(\"Error with rte_rawdev_configure()\\n\");\n return -1;\n }\ndiff --git a/doc/guides/rawdevs/octeontx2_dma.rst b/doc/guides/rawdevs/octeontx2_dma.rst\nindex 1e1dfbe931..4a9794489e 100644\n--- a/doc/guides/rawdevs/octeontx2_dma.rst\n+++ b/doc/guides/rawdevs/octeontx2_dma.rst\n@@ -92,7 +92,7 @@ The following code shows how the device is configured\n rte_mempool_set_ops_byname(conf.chunk_pool, rte_mbuf_platform_mempool_ops(), NULL);\n rte_mempool_populate_default(conf.chunk_pool);\n \n- rte_rawdev_configure(dev_id, (rte_rawdev_obj_t)&rdev_info);\n+ rte_rawdev_configure(dev_id, (rte_rawdev_obj_t)&rdev_info, sizeof(conf));\n \n Performing Data Transfer\n ------------------------\ndiff --git a/doc/guides/rawdevs/octeontx2_ep.rst b/doc/guides/rawdevs/octeontx2_ep.rst\nindex bbcf530a45..b03fcf789a 100644\n--- a/doc/guides/rawdevs/octeontx2_ep.rst\n+++ b/doc/guides/rawdevs/octeontx2_ep.rst\n@@ -66,7 +66,8 @@ The following code shows how the device is configured\n struct rte_rawdev_info rdev_info = {.dev_private = &config};\n config.enqdeq_mpool = (void *)rte_mempool_create(...);\n \n- rte_rawdev_configure(dev_id, (rte_rawdev_obj_t)&rdev_info);\n+ rte_rawdev_configure(dev_id, (rte_rawdev_obj_t)&rdev_info,\n+ sizeof(config));\n \n Performing Data Transfer\n ------------------------\ndiff --git a/doc/guides/rel_notes/release_20_11.rst b/doc/guides/rel_notes/release_20_11.rst\nindex 6431efe56b..9543e7e98b 100644\n--- a/doc/guides/rel_notes/release_20_11.rst\n+++ b/doc/guides/rel_notes/release_20_11.rst\n@@ -84,8 +84,8 @@ API Changes\n Also, make sure to start the actual text at the margin.\n =======================================================\n \n-* rawdev: Added a structure size parameter to the function\n- ``rte_rawdev_info_get()``,\n+* rawdev: Added a structure size parameter to the functions\n+ ``rte_rawdev_info_get()`` and ``rte_rawdev_configure()``,\n allowing limited driver type-checking and ABI compatibility.\n \n * rawdev: Changed the return type of the function ``rte_dev_info_get()``\ndiff --git a/doc/guides/sample_app_ug/ioat.rst b/doc/guides/sample_app_ug/ioat.rst\nindex b5188220ba..3f7d5c34a6 100644\n--- a/doc/guides/sample_app_ug/ioat.rst\n+++ b/doc/guides/sample_app_ug/ioat.rst\n@@ -296,7 +296,7 @@ is done in ``configure_rawdev_queue()``.\n struct rte_ioat_rawdev_config dev_config = { .ring_size = ring_size };\n struct rte_rawdev_info info = { .dev_private = &dev_config };\n \n- if (rte_rawdev_configure(dev_id, &info) != 0) {\n+ if (rte_rawdev_configure(dev_id, &info, sizeof(dev_config)) != 0) {\n rte_exit(EXIT_FAILURE,\n \"Error with rte_rawdev_configure()\\n\");\n }\ndiff --git a/drivers/raw/ifpga/ifpga_rawdev.c b/drivers/raw/ifpga/ifpga_rawdev.c\nindex 32a2b96c90..a50173264c 100644\n--- a/drivers/raw/ifpga/ifpga_rawdev.c\n+++ b/drivers/raw/ifpga/ifpga_rawdev.c\n@@ -684,7 +684,8 @@ ifpga_rawdev_info_get(struct rte_rawdev *dev,\n \n static int\n ifpga_rawdev_configure(const struct rte_rawdev *dev,\n-\t\trte_rawdev_obj_t config)\n+\t\trte_rawdev_obj_t config,\n+\t\tsize_t config_size __rte_unused)\n {\n \tIFPGA_RAWDEV_PMD_FUNC_TRACE();\n \ndiff --git a/drivers/raw/ioat/ioat_rawdev.c b/drivers/raw/ioat/ioat_rawdev.c\nindex e2fc787263..7f1a154360 100644\n--- a/drivers/raw/ioat/ioat_rawdev.c\n+++ b/drivers/raw/ioat/ioat_rawdev.c\n@@ -39,7 +39,8 @@ RTE_LOG_REGISTER(ioat_pmd_logtype, rawdev.ioat, INFO);\n #define COMPLETION_SZ sizeof(__m128i)\n \n static int\n-ioat_dev_configure(const struct rte_rawdev *dev, rte_rawdev_obj_t config)\n+ioat_dev_configure(const struct rte_rawdev *dev, rte_rawdev_obj_t config,\n+\t\tsize_t config_size)\n {\n \tstruct rte_ioat_rawdev_config *params = config;\n \tstruct rte_ioat_rawdev *ioat = dev->dev_private;\n@@ -49,7 +50,7 @@ ioat_dev_configure(const struct rte_rawdev *dev, rte_rawdev_obj_t config)\n \tif (dev->started)\n \t\treturn -EBUSY;\n \n-\tif (params == NULL)\n+\tif (params == NULL || config_size != sizeof(*params))\n \t\treturn -EINVAL;\n \n \tif (params->ring_size > 4096 || params->ring_size < 64 ||\ndiff --git a/drivers/raw/ioat/ioat_rawdev_test.c b/drivers/raw/ioat/ioat_rawdev_test.c\nindex 2b40222eb4..c463a82ad6 100644\n--- a/drivers/raw/ioat/ioat_rawdev_test.c\n+++ b/drivers/raw/ioat/ioat_rawdev_test.c\n@@ -156,7 +156,7 @@ ioat_rawdev_test(uint16_t dev_id)\n \t}\n \n \tp.ring_size = IOAT_TEST_RINGSIZE;\n-\tif (rte_rawdev_configure(dev_id, &info) != 0) {\n+\tif (rte_rawdev_configure(dev_id, &info, sizeof(p)) != 0) {\n \t\tprintf(\"Error with rte_rawdev_configure()\\n\");\n \t\treturn -1;\n \t}\ndiff --git a/drivers/raw/ntb/ntb.c b/drivers/raw/ntb/ntb.c\nindex ced5b6d624..7f6b835a4b 100644\n--- a/drivers/raw/ntb/ntb.c\n+++ b/drivers/raw/ntb/ntb.c\n@@ -837,13 +837,17 @@ ntb_dev_info_get(struct rte_rawdev *dev, rte_rawdev_obj_t dev_info,\n }\n \n static int\n-ntb_dev_configure(const struct rte_rawdev *dev, rte_rawdev_obj_t config)\n+ntb_dev_configure(const struct rte_rawdev *dev, rte_rawdev_obj_t config,\n+\t\tsize_t config_size)\n {\n \tstruct ntb_dev_config *conf = config;\n \tstruct ntb_hw *hw = dev->dev_private;\n \tuint32_t xstats_num;\n \tint ret;\n \n+\tif (conf == NULL || config_size != sizeof(*conf))\n+\t\treturn -EINVAL;\n+\n \thw->queue_pairs\t= conf->num_queues;\n \thw->queue_size = conf->queue_size;\n \thw->used_mw_num = conf->mz_num;\ndiff --git a/drivers/raw/octeontx2_dma/otx2_dpi_rawdev.c b/drivers/raw/octeontx2_dma/otx2_dpi_rawdev.c\nindex e398abb75b..5b496446ca 100644\n--- a/drivers/raw/octeontx2_dma/otx2_dpi_rawdev.c\n+++ b/drivers/raw/octeontx2_dma/otx2_dpi_rawdev.c\n@@ -294,7 +294,8 @@ otx2_dpi_rawdev_reset(struct rte_rawdev *dev)\n }\n \n static int\n-otx2_dpi_rawdev_configure(const struct rte_rawdev *dev, rte_rawdev_obj_t config)\n+otx2_dpi_rawdev_configure(const struct rte_rawdev *dev, rte_rawdev_obj_t config,\n+\t\tsize_t config_size)\n {\n \tstruct dpi_rawdev_conf_s *conf = config;\n \tstruct dpi_vf_s *dpivf = NULL;\n@@ -302,8 +303,8 @@ otx2_dpi_rawdev_configure(const struct rte_rawdev *dev, rte_rawdev_obj_t config)\n \tuintptr_t pool;\n \tuint32_t gaura;\n \n-\tif (conf == NULL) {\n-\t\totx2_dpi_dbg(\"NULL configuration\");\n+\tif (conf == NULL || config_size != sizeof(*conf)) {\n+\t\totx2_dpi_dbg(\"NULL or invalid configuration\");\n \t\treturn -EINVAL;\n \t}\n \tdpivf = (struct dpi_vf_s *)dev->dev_private;\ndiff --git a/drivers/raw/octeontx2_dma/otx2_dpi_test.c b/drivers/raw/octeontx2_dma/otx2_dpi_test.c\nindex 276658af07..cec6ca91b0 100644\n--- a/drivers/raw/octeontx2_dma/otx2_dpi_test.c\n+++ b/drivers/raw/octeontx2_dma/otx2_dpi_test.c\n@@ -182,7 +182,8 @@ test_otx2_dma_rawdev(uint16_t val)\n \t/* Configure rawdev ports */\n \tconf.chunk_pool = dpi_create_mempool();\n \trdev_info.dev_private = &conf;\n-\tret = rte_rawdev_configure(i, (rte_rawdev_obj_t)&rdev_info);\n+\tret = rte_rawdev_configure(i, (rte_rawdev_obj_t)&rdev_info,\n+\t\t\tsizeof(conf));\n \tif (ret) {\n \t\totx2_dpi_dbg(\"Unable to configure DPIVF %d\", i);\n \t\treturn -ENODEV;\ndiff --git a/drivers/raw/octeontx2_ep/otx2_ep_rawdev.c b/drivers/raw/octeontx2_ep/otx2_ep_rawdev.c\nindex 0778603d5b..2b78a7941d 100644\n--- a/drivers/raw/octeontx2_ep/otx2_ep_rawdev.c\n+++ b/drivers/raw/octeontx2_ep/otx2_ep_rawdev.c\n@@ -224,13 +224,14 @@ sdp_rawdev_close(struct rte_rawdev *dev)\n }\n \n static int\n-sdp_rawdev_configure(const struct rte_rawdev *dev, rte_rawdev_obj_t config)\n+sdp_rawdev_configure(const struct rte_rawdev *dev, rte_rawdev_obj_t config,\n+\t\tsize_t config_size)\n {\n \tstruct sdp_rawdev_info *app_info = (struct sdp_rawdev_info *)config;\n \tstruct sdp_device *sdpvf;\n \n-\tif (app_info == NULL) {\n-\t\totx2_err(\"Application config info [NULL]\");\n+\tif (app_info == NULL || config_size != sizeof(*app_info)) {\n+\t\totx2_err(\"Application config info [NULL] or incorrect size\");\n \t\treturn -EINVAL;\n \t}\n \ndiff --git a/drivers/raw/octeontx2_ep/otx2_ep_test.c b/drivers/raw/octeontx2_ep/otx2_ep_test.c\nindex 091f1827c7..b876275f7a 100644\n--- a/drivers/raw/octeontx2_ep/otx2_ep_test.c\n+++ b/drivers/raw/octeontx2_ep/otx2_ep_test.c\n@@ -108,7 +108,7 @@ sdp_rawdev_selftest(uint16_t dev_id)\n \n \tdev_info.dev_private = &app_info;\n \n-\tret = rte_rawdev_configure(dev_id, &dev_info);\n+\tret = rte_rawdev_configure(dev_id, &dev_info, sizeof(app_info));\n \tif (ret) {\n \t\totx2_err(\"Unable to configure SDP_VF %d\", dev_id);\n \t\trte_mempool_free(ioq_mpool);\ndiff --git a/drivers/raw/skeleton/skeleton_rawdev.c b/drivers/raw/skeleton/skeleton_rawdev.c\nindex dce300c358..531d0450c8 100644\n--- a/drivers/raw/skeleton/skeleton_rawdev.c\n+++ b/drivers/raw/skeleton/skeleton_rawdev.c\n@@ -68,7 +68,8 @@ static int skeleton_rawdev_info_get(struct rte_rawdev *dev,\n }\n \n static int skeleton_rawdev_configure(const struct rte_rawdev *dev,\n-\t\t\t\t rte_rawdev_obj_t config)\n+\t\t\t\t rte_rawdev_obj_t config,\n+\t\t\t\t size_t config_size)\n {\n \tstruct skeleton_rawdev *skeldev;\n \tstruct skeleton_rawdev_conf *skeldev_conf;\n@@ -77,7 +78,7 @@ static int skeleton_rawdev_configure(const struct rte_rawdev *dev,\n \n \tRTE_FUNC_PTR_OR_ERR_RET(dev, -EINVAL);\n \n-\tif (!config) {\n+\tif (config == NULL || config_size != sizeof(*skeldev_conf)) {\n \t\tSKELETON_PMD_ERR(\"Invalid configuration\");\n \t\treturn -EINVAL;\n \t}\ndiff --git a/drivers/raw/skeleton/skeleton_rawdev_test.c b/drivers/raw/skeleton/skeleton_rawdev_test.c\nindex 9b8390dfb7..7dc7c76847 100644\n--- a/drivers/raw/skeleton/skeleton_rawdev_test.c\n+++ b/drivers/raw/skeleton/skeleton_rawdev_test.c\n@@ -126,7 +126,7 @@ test_rawdev_configure(void)\n \tstruct skeleton_rawdev_conf rdev_conf_get = {0};\n \n \t/* Check invalid configuration */\n-\tret = rte_rawdev_configure(test_dev_id, NULL);\n+\tret = rte_rawdev_configure(test_dev_id, NULL, 0);\n \tRTE_TEST_ASSERT(ret == -EINVAL,\n \t\t\t\"Null configure; Expected -EINVAL, got %d\", ret);\n \n@@ -137,7 +137,8 @@ test_rawdev_configure(void)\n \n \trdev_info.dev_private = &rdev_conf_set;\n \tret = rte_rawdev_configure(test_dev_id,\n-\t\t\t\t (rte_rawdev_obj_t)&rdev_info);\n+\t\t\t\t (rte_rawdev_obj_t)&rdev_info,\n+\t\t\t\t sizeof(rdev_conf_set));\n \tRTE_TEST_ASSERT_SUCCESS(ret, \"Failed to configure rawdev (%d)\", ret);\n \n \trdev_info.dev_private = &rdev_conf_get;\ndiff --git a/examples/ioat/ioatfwd.c b/examples/ioat/ioatfwd.c\nindex 76932d3dd2..43a19843ee 100644\n--- a/examples/ioat/ioatfwd.c\n+++ b/examples/ioat/ioatfwd.c\n@@ -734,7 +734,7 @@ configure_rawdev_queue(uint32_t dev_id)\n \tstruct rte_ioat_rawdev_config dev_config = { .ring_size = ring_size };\n \tstruct rte_rawdev_info info = { .dev_private = &dev_config };\n \n-\tif (rte_rawdev_configure(dev_id, &info) != 0) {\n+\tif (rte_rawdev_configure(dev_id, &info, sizeof(dev_config)) != 0) {\n \t\trte_exit(EXIT_FAILURE,\n \t\t\t\"Error with rte_rawdev_configure()\\n\");\n \t}\ndiff --git a/examples/ntb/ntb_fwd.c b/examples/ntb/ntb_fwd.c\nindex 11e224451c..656f736594 100644\n--- a/examples/ntb/ntb_fwd.c\n+++ b/examples/ntb/ntb_fwd.c\n@@ -1401,7 +1401,7 @@ main(int argc, char **argv)\n \tntb_conf.num_queues = num_queues;\n \tntb_conf.queue_size = nb_desc;\n \tntb_rawdev_conf.dev_private = (rte_rawdev_obj_t)(&ntb_conf);\n-\tret = rte_rawdev_configure(dev_id, &ntb_rawdev_conf);\n+\tret = rte_rawdev_configure(dev_id, &ntb_rawdev_conf, sizeof(ntb_conf));\n \tif (ret)\n \t\trte_exit(EXIT_FAILURE, \"Can't config ntb dev: err=%d, \"\n \t\t\t\"port=%u\\n\", ret, dev_id);\ndiff --git a/lib/librte_rawdev/rte_rawdev.c b/lib/librte_rawdev/rte_rawdev.c\nindex bde33763ee..6c4d783cc5 100644\n--- a/lib/librte_rawdev/rte_rawdev.c\n+++ b/lib/librte_rawdev/rte_rawdev.c\n@@ -104,7 +104,8 @@ rte_rawdev_info_get(uint16_t dev_id, struct rte_rawdev_info *dev_info,\n }\n \n int\n-rte_rawdev_configure(uint16_t dev_id, struct rte_rawdev_info *dev_conf)\n+rte_rawdev_configure(uint16_t dev_id, struct rte_rawdev_info *dev_conf,\n+\t\tsize_t dev_private_size)\n {\n \tstruct rte_rawdev *dev;\n \tint diag;\n@@ -123,7 +124,8 @@ rte_rawdev_configure(uint16_t dev_id, struct rte_rawdev_info *dev_conf)\n \t}\n \n \t/* Configure the device */\n-\tdiag = (*dev->dev_ops->dev_configure)(dev, dev_conf->dev_private);\n+\tdiag = (*dev->dev_ops->dev_configure)(dev, dev_conf->dev_private,\n+\t\t\tdev_private_size);\n \tif (diag != 0)\n \t\tRTE_RDEV_ERR(\"dev%d dev_configure = %d\", dev_id, diag);\n \telse\ndiff --git a/lib/librte_rawdev/rte_rawdev.h b/lib/librte_rawdev/rte_rawdev.h\nindex cf6acfd261..1720f1dd6b 100644\n--- a/lib/librte_rawdev/rte_rawdev.h\n+++ b/lib/librte_rawdev/rte_rawdev.h\n@@ -116,13 +116,19 @@ rte_rawdev_info_get(uint16_t dev_id, struct rte_rawdev_info *dev_info,\n * driver/implementation can use to configure the device. It is also assumed\n * that once the configuration is done, a `queue_id` type field can be used\n * to refer to some arbitrary internal representation of a queue.\n+ * @param dev_private_size\n+ * The length of the memory space pointed to by dev_private in dev_info.\n+ * This should be set to the size of the expected private structure to be\n+ * used by the driver, and may be checked by drivers to ensure the expected\n+ * struct type is provided.\n *\n * @return\n * - 0: Success, device configured.\n * - <0: Error code returned by the driver configuration function.\n */\n int\n-rte_rawdev_configure(uint16_t dev_id, struct rte_rawdev_info *dev_conf);\n+rte_rawdev_configure(uint16_t dev_id, struct rte_rawdev_info *dev_conf,\n+\t\tsize_t dev_private_size);\n \n \n /**\ndiff --git a/lib/librte_rawdev/rte_rawdev_pmd.h b/lib/librte_rawdev/rte_rawdev_pmd.h\nindex 89e46412a3..050f8b0292 100644\n--- a/lib/librte_rawdev/rte_rawdev_pmd.h\n+++ b/lib/librte_rawdev/rte_rawdev_pmd.h\n@@ -160,7 +160,8 @@ typedef int (*rawdev_info_get_t)(struct rte_rawdev *dev,\n * Returns 0 on success\n */\n typedef int (*rawdev_configure_t)(const struct rte_rawdev *dev,\n-\t\t\t\t rte_rawdev_obj_t config);\n+\t\t\t\t rte_rawdev_obj_t config,\n+\t\t\t\t size_t config_size);\n \n /**\n * Start a configured device.\n", "prefixes": [ "v3", "3/7" ] }