Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/77154/?format=api
{ "id": 77154, "url": "http://patches.dpdk.org/api/patches/77154/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200910143609.986696-2-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200910143609.986696-2-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200910143609.986696-2-bruce.richardson@intel.com", "date": "2020-09-10T14:36:03", "name": "[v3,1/7] rawdev: add private data length parameter to info fn", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "e7dbed81ff46a44d2a20721358363bdc6f58ace6", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200910143609.986696-2-bruce.richardson@intel.com/mbox/", "series": [ { "id": 12105, "url": "http://patches.dpdk.org/api/series/12105/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12105", "date": "2020-09-10T14:36:02", "name": "Enhance rawdev APIs", "version": 3, "mbox": "http://patches.dpdk.org/series/12105/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/77154/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/77154/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B7D2AA04B5;\n\tThu, 10 Sep 2020 16:36:57 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 960E31C0CC;\n\tThu, 10 Sep 2020 16:36:57 +0200 (CEST)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n by dpdk.org (Postfix) with ESMTP id 9842B1BF8D\n for <dev@dpdk.org>; Thu, 10 Sep 2020 16:36:55 +0200 (CEST)", "from orsmga006.jf.intel.com ([10.7.209.51])\n by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 10 Sep 2020 07:36:54 -0700", "from silpixa00399126.ir.intel.com ([10.237.222.27])\n by orsmga006.jf.intel.com with ESMTP; 10 Sep 2020 07:36:50 -0700" ], "IronPort-SDR": [ "\n ApMWtN3lZM11jWSUaiK4h/rgd70gGe2hl0NQSsiZLvPxzG8CL2CltBkZ8Z4QRt+2X2xrA3STvn\n sUhI/G+KaDcg==", "\n dtnG3qKNNqx918njRqz6D7r7xljTZQTt1c6YM7sZus0DXijxmjxH0boKDj+64Waq3ilZ0+Ddzs\n MkN0Mvyt/D4A==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9739\"; a=\"138573545\"", "E=Sophos;i=\"5.76,413,1592895600\"; d=\"scan'208\";a=\"138573545\"", "E=Sophos;i=\"5.76,413,1592895600\"; d=\"scan'208\";a=\"304900308\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, Bruce Richardson <bruce.richardson@intel.com>,\n Rosen Xu <rosen.xu@intel.com>, Nipun Gupta <nipun.gupta@nxp.com>,\n Hemant Agrawal <hemant.agrawal@nxp.com>,\n John McNamara <john.mcnamara@intel.com>,\n Marko Kovacevic <marko.kovacevic@intel.com>,\n Tianfei zhang <tianfei.zhang@intel.com>, Xiaoyun Li <xiaoyun.li@intel.com>,\n Jingjing Wu <jingjing.wu@intel.com>", "Date": "Thu, 10 Sep 2020 15:36:03 +0100", "Message-Id": "<20200910143609.986696-2-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200910143609.986696-1-bruce.richardson@intel.com>", "References": "<20200709152047.167730-1-bruce.richardson@intel.com>\n <20200910143609.986696-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 1/7] rawdev: add private data length parameter\n\tto info fn", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Currently with the rawdev API there is no way to check that the structure\npassed in via the dev_private pointer in the dev_info structure is of the\ncorrect type - it's just checked that it is non-NULL. Adding in the length\nof the expected structure provides a measure of typechecking, and can also\nbe used for ABI compatibility in future, since ABI changes involving\nstructs almost always involve a change in size.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\nReviewed-by: Rosen Xu <rosen.xu@intel.com>\nAcked-by: Rosen Xu <rosen.xu@intel.com>\nAcked-by: Nipun Gupta <nipun.gupta@nxp.com>\n\n---\nV3: Added short release-note item describing the change.\n---\n app/test/test_rawdev.c | 2 +-\n doc/guides/rawdevs/ioat.rst | 2 +-\n doc/guides/rel_notes/release_20_11.rst | 4 ++++\n doc/guides/sample_app_ug/ioat.rst | 2 +-\n drivers/bus/ifpga/ifpga_bus.c | 2 +-\n drivers/raw/ifpga/ifpga_rawdev.c | 5 +++--\n drivers/raw/ioat/ioat_rawdev.c | 5 +++--\n drivers/raw/ioat/ioat_rawdev_test.c | 4 ++--\n drivers/raw/ntb/ntb.c | 8 +++++++-\n drivers/raw/skeleton/skeleton_rawdev.c | 5 +++--\n drivers/raw/skeleton/skeleton_rawdev_test.c | 19 ++++++++++++-------\n examples/ioat/ioatfwd.c | 2 +-\n examples/ntb/ntb_fwd.c | 2 +-\n lib/librte_rawdev/rte_rawdev.c | 6 ++++--\n lib/librte_rawdev/rte_rawdev.h | 9 ++++++++-\n lib/librte_rawdev/rte_rawdev_pmd.h | 5 ++++-\n 16 files changed, 56 insertions(+), 26 deletions(-)", "diff": "diff --git a/app/test/test_rawdev.c b/app/test/test_rawdev.c\nindex 524a9d5f3b..d8d9595be1 100644\n--- a/app/test/test_rawdev.c\n+++ b/app/test/test_rawdev.c\n@@ -34,7 +34,7 @@ test_rawdev_selftest_ioat(void)\n \n \tfor (i = 0; i < count; i++) {\n \t\tstruct rte_rawdev_info info = { .dev_private = NULL };\n-\t\tif (rte_rawdev_info_get(i, &info) == 0 &&\n+\t\tif (rte_rawdev_info_get(i, &info, 0) == 0 &&\n \t\t\t\tstrstr(info.driver_name, \"ioat\") != NULL)\n \t\t\treturn rte_rawdev_selftest(i) == 0 ?\n \t\t\t\t\tTEST_SUCCESS : TEST_FAILED;\ndiff --git a/doc/guides/rawdevs/ioat.rst b/doc/guides/rawdevs/ioat.rst\nindex d0eee5e237..dac52fabf1 100644\n--- a/doc/guides/rawdevs/ioat.rst\n+++ b/doc/guides/rawdevs/ioat.rst\n@@ -107,7 +107,7 @@ rawdev device for use by an application:\n \n for (i = 0; i < count && !found; i++) {\n struct rte_rawdev_info info = { .dev_private = NULL };\n- found = (rte_rawdev_info_get(i, &info) == 0 &&\n+ found = (rte_rawdev_info_get(i, &info, 0) == 0 &&\n strcmp(info.driver_name,\n IOAT_PMD_RAWDEV_NAME_STR) == 0);\n }\ndiff --git a/doc/guides/rel_notes/release_20_11.rst b/doc/guides/rel_notes/release_20_11.rst\nindex df227a1773..a931dc0bff 100644\n--- a/doc/guides/rel_notes/release_20_11.rst\n+++ b/doc/guides/rel_notes/release_20_11.rst\n@@ -84,6 +84,10 @@ API Changes\n Also, make sure to start the actual text at the margin.\n =======================================================\n \n+* rawdev: Added a structure size parameter to the function\n+ ``rte_rawdev_info_get()``,\n+ allowing limited driver type-checking and ABI compatibility.\n+\n \n ABI Changes\n -----------\ndiff --git a/doc/guides/sample_app_ug/ioat.rst b/doc/guides/sample_app_ug/ioat.rst\nindex bab7654b8d..b5188220ba 100644\n--- a/doc/guides/sample_app_ug/ioat.rst\n+++ b/doc/guides/sample_app_ug/ioat.rst\n@@ -265,7 +265,7 @@ functions:\n do {\n if (rdev_id == rte_rawdev_count())\n goto end;\n- rte_rawdev_info_get(rdev_id++, &rdev_info);\n+ rte_rawdev_info_get(rdev_id++, &rdev_info, 0);\n } while (strcmp(rdev_info.driver_name,\n IOAT_PMD_RAWDEV_NAME_STR) != 0);\n \ndiff --git a/drivers/bus/ifpga/ifpga_bus.c b/drivers/bus/ifpga/ifpga_bus.c\nindex 6b16a20bb6..bb8b3dcfb9 100644\n--- a/drivers/bus/ifpga/ifpga_bus.c\n+++ b/drivers/bus/ifpga/ifpga_bus.c\n@@ -162,7 +162,7 @@ ifpga_scan_one(struct rte_rawdev *rawdev,\n \tafu_dev->id.port = afu_pr_conf.afu_id.port;\n \n \tif (rawdev->dev_ops && rawdev->dev_ops->dev_info_get)\n-\t\trawdev->dev_ops->dev_info_get(rawdev, afu_dev);\n+\t\trawdev->dev_ops->dev_info_get(rawdev, afu_dev, sizeof(*afu_dev));\n \n \tif (rawdev->dev_ops &&\n \t\trawdev->dev_ops->dev_start &&\ndiff --git a/drivers/raw/ifpga/ifpga_rawdev.c b/drivers/raw/ifpga/ifpga_rawdev.c\nindex cc25c662bc..47cfa38778 100644\n--- a/drivers/raw/ifpga/ifpga_rawdev.c\n+++ b/drivers/raw/ifpga/ifpga_rawdev.c\n@@ -605,7 +605,8 @@ ifpga_fill_afu_dev(struct opae_accelerator *acc,\n \n static void\n ifpga_rawdev_info_get(struct rte_rawdev *dev,\n-\t\t\t\t rte_rawdev_obj_t dev_info)\n+\t\t rte_rawdev_obj_t dev_info,\n+\t\t size_t dev_info_size)\n {\n \tstruct opae_adapter *adapter;\n \tstruct opae_accelerator *acc;\n@@ -617,7 +618,7 @@ ifpga_rawdev_info_get(struct rte_rawdev *dev,\n \n \tIFPGA_RAWDEV_PMD_FUNC_TRACE();\n \n-\tif (!dev_info) {\n+\tif (!dev_info || dev_info_size != sizeof(*afu_dev)) {\n \t\tIFPGA_RAWDEV_PMD_ERR(\"Invalid request\");\n \t\treturn;\n \t}\ndiff --git a/drivers/raw/ioat/ioat_rawdev.c b/drivers/raw/ioat/ioat_rawdev.c\nindex 87fd088aac..a5c0452d7e 100644\n--- a/drivers/raw/ioat/ioat_rawdev.c\n+++ b/drivers/raw/ioat/ioat_rawdev.c\n@@ -111,12 +111,13 @@ ioat_dev_stop(struct rte_rawdev *dev)\n }\n \n static void\n-ioat_dev_info_get(struct rte_rawdev *dev, rte_rawdev_obj_t dev_info)\n+ioat_dev_info_get(struct rte_rawdev *dev, rte_rawdev_obj_t dev_info,\n+\t\tsize_t dev_info_size)\n {\n \tstruct rte_ioat_rawdev_config *cfg = dev_info;\n \tstruct rte_ioat_rawdev *ioat = dev->dev_private;\n \n-\tif (cfg != NULL)\n+\tif (cfg != NULL && dev_info_size == sizeof(*cfg))\n \t\tcfg->ring_size = ioat->ring_size;\n }\n \ndiff --git a/drivers/raw/ioat/ioat_rawdev_test.c b/drivers/raw/ioat/ioat_rawdev_test.c\nindex c37351af2d..2b40222eb4 100644\n--- a/drivers/raw/ioat/ioat_rawdev_test.c\n+++ b/drivers/raw/ioat/ioat_rawdev_test.c\n@@ -148,7 +148,7 @@ ioat_rawdev_test(uint16_t dev_id)\n \tunsigned int nb_xstats;\n \tunsigned int i;\n \n-\trte_rawdev_info_get(dev_id, &info);\n+\trte_rawdev_info_get(dev_id, &info, sizeof(p));\n \tif (p.ring_size != expected_ring_size) {\n \t\tprintf(\"Error, initial ring size is not as expected (Actual: %d, Expected: %d)\\n\",\n \t\t\t\t(int)p.ring_size, expected_ring_size);\n@@ -160,7 +160,7 @@ ioat_rawdev_test(uint16_t dev_id)\n \t\tprintf(\"Error with rte_rawdev_configure()\\n\");\n \t\treturn -1;\n \t}\n-\trte_rawdev_info_get(dev_id, &info);\n+\trte_rawdev_info_get(dev_id, &info, sizeof(p));\n \tif (p.ring_size != IOAT_TEST_RINGSIZE) {\n \t\tprintf(\"Error, ring size is not %d (%d)\\n\",\n \t\t\t\tIOAT_TEST_RINGSIZE, (int)p.ring_size);\ndiff --git a/drivers/raw/ntb/ntb.c b/drivers/raw/ntb/ntb.c\nindex e40412bb7e..c890c43a32 100644\n--- a/drivers/raw/ntb/ntb.c\n+++ b/drivers/raw/ntb/ntb.c\n@@ -801,11 +801,17 @@ ntb_dequeue_bufs(struct rte_rawdev *dev,\n }\n \n static void\n-ntb_dev_info_get(struct rte_rawdev *dev, rte_rawdev_obj_t dev_info)\n+ntb_dev_info_get(struct rte_rawdev *dev, rte_rawdev_obj_t dev_info,\n+\t\tsize_t dev_info_size)\n {\n \tstruct ntb_hw *hw = dev->dev_private;\n \tstruct ntb_dev_info *info = dev_info;\n \n+\tif (dev_info_size != sizeof(*info)) {\n+\t\tNTB_LOG(ERR, \"Invalid size parameter to %s\", __func__);\n+\t\treturn;\n+\t}\n+\n \tinfo->mw_cnt = hw->mw_cnt;\n \tinfo->mw_size = hw->mw_size;\n \ndiff --git a/drivers/raw/skeleton/skeleton_rawdev.c b/drivers/raw/skeleton/skeleton_rawdev.c\nindex 72ece887af..dc05f3ecf8 100644\n--- a/drivers/raw/skeleton/skeleton_rawdev.c\n+++ b/drivers/raw/skeleton/skeleton_rawdev.c\n@@ -42,14 +42,15 @@ static struct queue_buffers queue_buf[SKELETON_MAX_QUEUES] = {};\n static void clear_queue_bufs(int queue_id);\n \n static void skeleton_rawdev_info_get(struct rte_rawdev *dev,\n-\t\t\t\t rte_rawdev_obj_t dev_info)\n+\t\t\t\t rte_rawdev_obj_t dev_info,\n+\t\t\t\t size_t dev_info_size)\n {\n \tstruct skeleton_rawdev *skeldev;\n \tstruct skeleton_rawdev_conf *skeldev_conf;\n \n \tSKELETON_PMD_FUNC_TRACE();\n \n-\tif (!dev_info) {\n+\tif (!dev_info || dev_info_size != sizeof(*skeldev_conf)) {\n \t\tSKELETON_PMD_ERR(\"Invalid request\");\n \t\treturn;\n \t}\ndiff --git a/drivers/raw/skeleton/skeleton_rawdev_test.c b/drivers/raw/skeleton/skeleton_rawdev_test.c\nindex 9ecfdee818..9b8390dfb7 100644\n--- a/drivers/raw/skeleton/skeleton_rawdev_test.c\n+++ b/drivers/raw/skeleton/skeleton_rawdev_test.c\n@@ -106,12 +106,12 @@ test_rawdev_info_get(void)\n \tstruct rte_rawdev_info rdev_info = {0};\n \tstruct skeleton_rawdev_conf skel_conf = {0};\n \n-\tret = rte_rawdev_info_get(test_dev_id, NULL);\n+\tret = rte_rawdev_info_get(test_dev_id, NULL, 0);\n \tRTE_TEST_ASSERT(ret == -EINVAL, \"Expected -EINVAL, %d\", ret);\n \n \trdev_info.dev_private = &skel_conf;\n \n-\tret = rte_rawdev_info_get(test_dev_id, &rdev_info);\n+\tret = rte_rawdev_info_get(test_dev_id, &rdev_info, sizeof(skel_conf));\n \tRTE_TEST_ASSERT_SUCCESS(ret, \"Failed to get raw dev info\");\n \n \treturn TEST_SUCCESS;\n@@ -142,7 +142,8 @@ test_rawdev_configure(void)\n \n \trdev_info.dev_private = &rdev_conf_get;\n \tret = rte_rawdev_info_get(test_dev_id,\n-\t\t\t\t (rte_rawdev_obj_t)&rdev_info);\n+\t\t\t\t (rte_rawdev_obj_t)&rdev_info,\n+\t\t\t\t sizeof(rdev_conf_get));\n \tRTE_TEST_ASSERT_SUCCESS(ret,\n \t\t\t\t\"Failed to obtain rawdev configuration (%d)\",\n \t\t\t\tret);\n@@ -170,7 +171,8 @@ test_rawdev_queue_default_conf_get(void)\n \t/* Get the current configuration */\n \trdev_info.dev_private = &rdev_conf_get;\n \tret = rte_rawdev_info_get(test_dev_id,\n-\t\t\t\t (rte_rawdev_obj_t)&rdev_info);\n+\t\t\t\t (rte_rawdev_obj_t)&rdev_info,\n+\t\t\t\t sizeof(rdev_conf_get));\n \tRTE_TEST_ASSERT_SUCCESS(ret, \"Failed to obtain rawdev configuration (%d)\",\n \t\t\t\tret);\n \n@@ -218,7 +220,8 @@ test_rawdev_queue_setup(void)\n \t/* Get the current configuration */\n \trdev_info.dev_private = &rdev_conf_get;\n \tret = rte_rawdev_info_get(test_dev_id,\n-\t\t\t\t (rte_rawdev_obj_t)&rdev_info);\n+\t\t\t\t (rte_rawdev_obj_t)&rdev_info,\n+\t\t\t\t sizeof(rdev_conf_get));\n \tRTE_TEST_ASSERT_SUCCESS(ret,\n \t\t\t\t\"Failed to obtain rawdev configuration (%d)\",\n \t\t\t\tret);\n@@ -327,7 +330,8 @@ test_rawdev_start_stop(void)\n \tdummy_firmware = NULL;\n \n \trte_rawdev_start(test_dev_id);\n-\tret = rte_rawdev_info_get(test_dev_id, (rte_rawdev_obj_t)&rdev_info);\n+\tret = rte_rawdev_info_get(test_dev_id, (rte_rawdev_obj_t)&rdev_info,\n+\t\t\tsizeof(rdev_conf_get));\n \tRTE_TEST_ASSERT_SUCCESS(ret,\n \t\t\t\t\"Failed to obtain rawdev configuration (%d)\",\n \t\t\t\tret);\n@@ -336,7 +340,8 @@ test_rawdev_start_stop(void)\n \t\t\t rdev_conf_get.device_state);\n \n \trte_rawdev_stop(test_dev_id);\n-\tret = rte_rawdev_info_get(test_dev_id, (rte_rawdev_obj_t)&rdev_info);\n+\tret = rte_rawdev_info_get(test_dev_id, (rte_rawdev_obj_t)&rdev_info,\n+\t\t\tsizeof(rdev_conf_get));\n \tRTE_TEST_ASSERT_SUCCESS(ret,\n \t\t\t\t\"Failed to obtain rawdev configuration (%d)\",\n \t\t\t\tret);\ndiff --git a/examples/ioat/ioatfwd.c b/examples/ioat/ioatfwd.c\nindex 75d8d5b9fe..76932d3dd2 100644\n--- a/examples/ioat/ioatfwd.c\n+++ b/examples/ioat/ioatfwd.c\n@@ -757,7 +757,7 @@ assign_rawdevs(void)\n \t\t\tdo {\n \t\t\t\tif (rdev_id == rte_rawdev_count())\n \t\t\t\t\tgoto end;\n-\t\t\t\trte_rawdev_info_get(rdev_id++, &rdev_info);\n+\t\t\t\trte_rawdev_info_get(rdev_id++, &rdev_info, 0);\n \t\t\t} while (rdev_info.driver_name == NULL ||\n \t\t\t\t\tstrcmp(rdev_info.driver_name,\n \t\t\t\t\t\tIOAT_PMD_RAWDEV_NAME_STR) != 0);\ndiff --git a/examples/ntb/ntb_fwd.c b/examples/ntb/ntb_fwd.c\nindex eba8ebf9fa..11e224451c 100644\n--- a/examples/ntb/ntb_fwd.c\n+++ b/examples/ntb/ntb_fwd.c\n@@ -1389,7 +1389,7 @@ main(int argc, char **argv)\n \trte_rawdev_set_attr(dev_id, NTB_QUEUE_NUM_NAME, num_queues);\n \tprintf(\"Set queue number as %u.\\n\", num_queues);\n \tntb_rawdev_info.dev_private = (rte_rawdev_obj_t)(&ntb_info);\n-\trte_rawdev_info_get(dev_id, &ntb_rawdev_info);\n+\trte_rawdev_info_get(dev_id, &ntb_rawdev_info, sizeof(ntb_info));\n \n \tnb_mbuf = nb_desc * num_queues * 2 * 2 + rte_lcore_count() *\n \t\t MEMPOOL_CACHE_SIZE;\ndiff --git a/lib/librte_rawdev/rte_rawdev.c b/lib/librte_rawdev/rte_rawdev.c\nindex 8f84d0b228..a576890356 100644\n--- a/lib/librte_rawdev/rte_rawdev.c\n+++ b/lib/librte_rawdev/rte_rawdev.c\n@@ -78,7 +78,8 @@ rte_rawdev_socket_id(uint16_t dev_id)\n }\n \n int\n-rte_rawdev_info_get(uint16_t dev_id, struct rte_rawdev_info *dev_info)\n+rte_rawdev_info_get(uint16_t dev_id, struct rte_rawdev_info *dev_info,\n+\t\tsize_t dev_private_size)\n {\n \tstruct rte_rawdev *rawdev;\n \n@@ -89,7 +90,8 @@ rte_rawdev_info_get(uint16_t dev_id, struct rte_rawdev_info *dev_info)\n \n \tif (dev_info->dev_private != NULL) {\n \t\tRTE_FUNC_PTR_OR_ERR_RET(*rawdev->dev_ops->dev_info_get, -ENOTSUP);\n-\t\t(*rawdev->dev_ops->dev_info_get)(rawdev, dev_info->dev_private);\n+\t\t(*rawdev->dev_ops->dev_info_get)(rawdev, dev_info->dev_private,\n+\t\t\t\tdev_private_size);\n \t}\n \n \tdev_info->driver_name = rawdev->driver_name;\ndiff --git a/lib/librte_rawdev/rte_rawdev.h b/lib/librte_rawdev/rte_rawdev.h\nindex 32f6b8bb03..cf6acfd261 100644\n--- a/lib/librte_rawdev/rte_rawdev.h\n+++ b/lib/librte_rawdev/rte_rawdev.h\n@@ -82,13 +82,20 @@ struct rte_rawdev_info;\n * will be returned. This can be used to safely query the type of a rawdev\n * instance without needing to know the size of the private data to return.\n *\n+ * @param dev_private_size\n+ * The length of the memory space pointed to by dev_private in dev_info.\n+ * This should be set to the size of the expected private structure to be\n+ * returned, and may be checked by drivers to ensure the expected struct\n+ * type is provided.\n+ *\n * @return\n * - 0: Success, driver updates the contextual information of the raw device\n * - <0: Error code returned by the driver info get function.\n *\n */\n int\n-rte_rawdev_info_get(uint16_t dev_id, struct rte_rawdev_info *dev_info);\n+rte_rawdev_info_get(uint16_t dev_id, struct rte_rawdev_info *dev_info,\n+\t\tsize_t dev_private_size);\n \n /**\n * Configure a raw device.\ndiff --git a/lib/librte_rawdev/rte_rawdev_pmd.h b/lib/librte_rawdev/rte_rawdev_pmd.h\nindex 4395a2182d..0e72a92058 100644\n--- a/lib/librte_rawdev/rte_rawdev_pmd.h\n+++ b/lib/librte_rawdev/rte_rawdev_pmd.h\n@@ -138,12 +138,15 @@ rte_rawdev_pmd_is_valid_dev(uint8_t dev_id)\n * Raw device pointer\n * @param dev_info\n * Raw device information structure\n+ * @param dev_private_size\n+ * The size of the structure pointed to by dev_info->dev_private\n *\n * @return\n * Returns 0 on success\n */\n typedef void (*rawdev_info_get_t)(struct rte_rawdev *dev,\n-\t\t\t\t rte_rawdev_obj_t dev_info);\n+\t\t\t\t rte_rawdev_obj_t dev_info,\n+\t\t\t\t size_t dev_private_size);\n \n /**\n * Configure a device.\n", "prefixes": [ "v3", "1/7" ] }