Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/77063/?format=api
{ "id": 77063, "url": "http://patches.dpdk.org/api/patches/77063/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1599662474-44882-2-git-send-email-erik.g.carrillo@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1599662474-44882-2-git-send-email-erik.g.carrillo@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1599662474-44882-2-git-send-email-erik.g.carrillo@intel.com", "date": "2020-09-09T14:41:14", "name": "[1/1] timer: add limitation note for sync stop and reset", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "a122a0eebc90a60d959935e6d51251ae911d0a43", "submitter": { "id": 762, "url": "http://patches.dpdk.org/api/people/762/?format=api", "name": "Carrillo, Erik G", "email": "erik.g.carrillo@intel.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1599662474-44882-2-git-send-email-erik.g.carrillo@intel.com/mbox/", "series": [ { "id": 12059, "url": "http://patches.dpdk.org/api/series/12059/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12059", "date": "2020-09-09T14:41:13", "name": "timer: add limitation note for sync stop and reset", "version": 1, "mbox": "http://patches.dpdk.org/series/12059/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/77063/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/77063/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C2C71A04B5;\n\tWed, 9 Sep 2020 16:41:32 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 93D621C0CF;\n\tWed, 9 Sep 2020 16:41:27 +0200 (CEST)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n by dpdk.org (Postfix) with ESMTP id 2B7601BF8E;\n Wed, 9 Sep 2020 16:41:24 +0200 (CEST)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 09 Sep 2020 07:41:21 -0700", "from wcpqa1.an.intel.com ([10.123.72.207])\n by fmsmga005.fm.intel.com with ESMTP; 09 Sep 2020 07:41:21 -0700" ], "IronPort-SDR": [ "\n BCALKb7php2UiM5osDaa0UAAYjvjSnjYIh1WKlrt7brcKWQLLMbudR8NpfsgwBG90c98xA28cE\n YgRh1VswUwmg==", "\n 6uSiJR6R8Qc/EBLq382AGoUg27tuuWT1P+hhyaGSz8MXksfl7hkqccIox8zJ4W/Uy5s7ZEbW17\n JRvhvtz0Bs9g==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9738\"; a=\"138377364\"", "E=Sophos;i=\"5.76,409,1592895600\"; d=\"scan'208\";a=\"138377364\"", "E=Sophos;i=\"5.76,409,1592895600\"; d=\"scan'208\";a=\"505473908\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Erik Gabriel Carrillo <erik.g.carrillo@intel.com>", "To": "dev@dpdk.org", "Cc": "stable@dpdk.org", "Date": "Wed, 9 Sep 2020 09:41:14 -0500", "Message-Id": "<1599662474-44882-2-git-send-email-erik.g.carrillo@intel.com>", "X-Mailer": "git-send-email 1.7.10", "In-Reply-To": "<1599662474-44882-1-git-send-email-erik.g.carrillo@intel.com>", "References": "<1599662474-44882-1-git-send-email-erik.g.carrillo@intel.com>", "Subject": "[dpdk-dev] [PATCH 1/1] timer: add limitation note for sync stop and\n\treset", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "If a timer's callback function calls rte_timer_reset_sync() or\nrte_timer_stop_sync() on another timer that is in the RUNNING state and\nowned by the current lcore, the *_sync() calls will loop indefinitely.\n\nRelatedly, if a timer's callback function calls *_sync() on another\ntimer that is in the RUNNING state and is owned by a different lcore,\nbut a timer callback function runs on that different lcore and calls\n*_sync() on a timer that is in the RUNNING state and owned by the\ncurrent lcore, the two lcores will loop indefinitely.\n\nAdd a note in the rte_timer_stop_sync and rte_timer_reset_sync\ndocumentation that indicates that these APIs should not be used inside\ntimer callback functions in order to avoid the hangs described above,\nand suggests an alternative.\n\nBugzilla ID: 491\nCc: stable@dpdk.org\n\nSigned-off-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>\n---\n lib/librte_timer/rte_timer.h | 12 ++++++++++++\n 1 file changed, 12 insertions(+)", "diff": "diff --git a/lib/librte_timer/rte_timer.h b/lib/librte_timer/rte_timer.h\nindex c6b3d45..d7c3e03 100644\n--- a/lib/librte_timer/rte_timer.h\n+++ b/lib/librte_timer/rte_timer.h\n@@ -274,6 +274,12 @@ int rte_timer_reset(struct rte_timer *tim, uint64_t ticks,\n * The callback function of the timer.\n * @param arg\n * The user argument of the callback function.\n+ *\n+ * @note\n+ * This API should not be called inside a timer's callback function to\n+ * reset another timer; doing so could hang in certain scenarios. Instead,\n+ * the rte_timer_reset() API can be called directly and its return code\n+ * can be checked for success or failure.\n */\n void\n rte_timer_reset_sync(struct rte_timer *tim, uint64_t ticks,\n@@ -313,6 +319,12 @@ int rte_timer_stop(struct rte_timer *tim);\n *\n * @param tim\n * The timer handle.\n+ *\n+ * @note\n+ * This API should not be called inside a timer's callback function to\n+ * stop another timer; doing so could hang in certain scenarios. Instead, the\n+ * rte_timer_stop() API can be called directly and its return code can\n+ * be checked for success or failure.\n */\n void rte_timer_stop_sync(struct rte_timer *tim);\n \n", "prefixes": [ "1/1" ] }