Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/77060/?format=api
{ "id": 77060, "url": "http://patches.dpdk.org/api/patches/77060/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200909140006.23788-5-hyonkim@cisco.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200909140006.23788-5-hyonkim@cisco.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200909140006.23788-5-hyonkim@cisco.com", "date": "2020-09-09T14:00:04", "name": "[4/6] net/enic: ignore vlan inner type when it is zero", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "1c2560b74ce48f4c1bff9a2618e68e1ee9ff76c9", "submitter": { "id": 948, "url": "http://patches.dpdk.org/api/people/948/?format=api", "name": "Hyong Youb Kim (hyonkim)", "email": "hyonkim@cisco.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200909140006.23788-5-hyonkim@cisco.com/mbox/", "series": [ { "id": 12058, "url": "http://patches.dpdk.org/api/series/12058/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12058", "date": "2020-09-09T14:00:00", "name": "net/enic: minor updates to flow implementation", "version": 1, "mbox": "http://patches.dpdk.org/series/12058/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/77060/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/77060/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 228DFA04B5;\n\tWed, 9 Sep 2020 16:02:14 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 74C031C0CF;\n\tWed, 9 Sep 2020 16:02:12 +0200 (CEST)", "from rcdn-iport-6.cisco.com (rcdn-iport-6.cisco.com [173.37.86.77])\n by dpdk.org (Postfix) with ESMTP id 2624A1C0C9;\n Wed, 9 Sep 2020 16:02:10 +0200 (CEST)", "from rcdn-core-5.cisco.com ([173.37.93.156])\n by rcdn-iport-6.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA;\n 09 Sep 2020 14:01:40 +0000", "from cisco.com (savbu-usnic-a.cisco.com [10.193.184.48])\n by rcdn-core-5.cisco.com (8.15.2/8.15.2) with ESMTP id 089E1d7N010427;\n Wed, 9 Sep 2020 14:01:40 GMT", "by cisco.com (Postfix, from userid 508933)\n id 79BAE20F2005; Wed, 9 Sep 2020 07:01:39 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=cisco.com; i=@cisco.com; l=2464; q=dns/txt; s=iport;\n t=1599660131; x=1600869731;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=COCBbWzT2qOqvw7ujjZb8YzIHUj3bkcIgN1KZ6/pETc=;\n b=T9sVqGJwVOe94AIZRt81yQlZGx8iDf3OmV3afIGebMTSOHtp+5oA5tfE\n RyBXrWKQVstTjK41VbhWFLlOAxoerxE6n8eF+V41A/CFteSxbypfbcxL2\n fW4VmfHqyv00OZIuiNnOfTjGrYxPDXkhB8lIKyddrxFhf2MTvifspg5rv I=;", "X-IronPort-AV": "E=Sophos;i=\"5.76,409,1592870400\"; d=\"scan'208\";a=\"825414301\"", "From": "Hyong Youb Kim <hyonkim@cisco.com>", "To": "Ferruh Yigit <ferruh.yigit@intel.com>", "Cc": "dev@dpdk.org, Hyong Youb Kim <hyonkim@cisco.com>, stable@dpdk.org,\n John Daley <johndale@cisco.com>", "Date": "Wed, 9 Sep 2020 07:00:04 -0700", "Message-Id": "<20200909140006.23788-5-hyonkim@cisco.com>", "X-Mailer": "git-send-email 2.26.2", "In-Reply-To": "<20200909140006.23788-1-hyonkim@cisco.com>", "References": "<20200909140006.23788-1-hyonkim@cisco.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Outbound-SMTP-Client": "10.193.184.48, savbu-usnic-a.cisco.com", "X-Outbound-Node": "rcdn-core-5.cisco.com", "Subject": "[dpdk-dev] [PATCH 4/6] net/enic: ignore vlan inner type when it is\n\tzero", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When a VLAN pattern is present, the flow handler always copies its\ninner_type to the match buffer regardless of its value (i.e. HW\nmatches inner_type against packet's inner ethertype). When inner_type\nspec and mask are both 0, adding it to the match buffer is usually\nharmless but breaks the following pattern used in some applications\nlike OVS-DPDK.\n\nflow create 0 ingress ... pattern eth ... type is 0x0800 / vlan tci spec 0x2 \\\ntci mask 0xefff / ipv4 / end actions count / of_pop_vlan / ...\n\nThe VLAN pattern's inner_type is 0. And the outer eth pattern's type\nactually specifies the inner ethertype. The outer ethertype (0x0800)\nis first copied to the match buffer. Then, the driver copies\ninner_type (0) to the match buffer, which overwrites the existing\n0x0800 with 0 and breaks the app usage above.\n\nSimply ignore inner_type when it is 0, which is the correct\nbehavior. As a byproduct, the driver can support the usage like the\nabove.\n\nFixes: ea7768b5bba8 (\"net/enic: add flow implementation based on Flow Manager API\")\nCc: stable@dpdk.org\n\nSigned-off-by: Hyong Youb Kim <hyonkim@cisco.com>\nReviewed-by: John Daley <johndale@cisco.com>\n---\n drivers/net/enic/enic_fm_flow.c | 13 +++++++++----\n 1 file changed, 9 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/enic/enic_fm_flow.c b/drivers/net/enic/enic_fm_flow.c\nindex 5f22f2a32..a350b29a3 100644\n--- a/drivers/net/enic/enic_fm_flow.c\n+++ b/drivers/net/enic/enic_fm_flow.c\n@@ -392,8 +392,11 @@ enic_fm_copy_item_vlan(struct copy_item_args *arg)\n \teth_mask = (void *)&fm_mask->l2.eth;\n \teth_val = (void *)&fm_data->l2.eth;\n \n-\t/* Outer TPID cannot be matched */\n-\tif (eth_mask->ether_type)\n+\t/*\n+\t * Outer TPID cannot be matched. If inner_type is 0, use what is\n+\t * in the eth header.\n+\t */\n+\tif (eth_mask->ether_type && mask->inner_type)\n \t\treturn -ENOTSUP;\n \n \t/*\n@@ -401,8 +404,10 @@ enic_fm_copy_item_vlan(struct copy_item_args *arg)\n \t * L2, regardless of vlan stripping settings. So, the inner type\n \t * from vlan becomes the ether type of the eth header.\n \t */\n-\teth_mask->ether_type = mask->inner_type;\n-\teth_val->ether_type = spec->inner_type;\n+\tif (mask->inner_type) {\n+\t\teth_mask->ether_type = mask->inner_type;\n+\t\teth_val->ether_type = spec->inner_type;\n+\t}\n \tfm_data->fk_header_select |= FKH_ETHER | FKH_QTAG;\n \tfm_mask->fk_header_select |= FKH_ETHER | FKH_QTAG;\n \tfm_data->fk_vlan = rte_be_to_cpu_16(spec->tci);\n", "prefixes": [ "4/6" ] }