Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/76891/?format=api
{ "id": 76891, "url": "http://patches.dpdk.org/api/patches/76891/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1599556475-27820-15-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1599556475-27820-15-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1599556475-27820-15-git-send-email-arybchenko@solarflare.com", "date": "2020-09-08T09:14:34", "name": "[13/14] net/sfc: use MCDI control structure as libefx ops context", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "7d25669db5bfbf2d26d1a3bf47fedbf83161ce14", "submitter": { "id": 607, "url": "http://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1599556475-27820-15-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 12014, "url": "http://patches.dpdk.org/api/series/12014/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12014", "date": "2020-09-08T09:14:20", "name": "net/sfc: factor out common driver library", "version": 1, "mbox": "http://patches.dpdk.org/series/12014/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/76891/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/76891/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 44EC6A04AA;\n\tTue, 8 Sep 2020 11:16:53 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 786081C132;\n\tTue, 8 Sep 2020 11:15:54 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 5A05A1C11E\n for <dev@dpdk.org>; Tue, 8 Sep 2020 11:15:51 +0200 (CEST)", "from mx1-us1.ppe-hosted.com (unknown [10.110.50.150])\n by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id\n E5547200C3 for <dev@dpdk.org>; Tue, 8 Sep 2020 09:15:50 +0000 (UTC)", "from us4-mdac16-30.at1.mdlocal (unknown [10.110.49.214])\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 2E334800D6\n for <dev@dpdk.org>; Tue, 8 Sep 2020 09:15:50 +0000 (UTC)", "from mx1-us1.ppe-hosted.com (unknown [10.110.50.12])\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n 3109610010C\n for <dev@dpdk.org>; Tue, 8 Sep 2020 09:14:56 +0000 (UTC)", "from webmail.solarflare.com (uk.solarflare.com [193.34.186.16])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n (No client certificate requested)\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id EEB3040059\n for <dev@dpdk.org>; Tue, 8 Sep 2020 09:14:55 +0000 (UTC)", "from ukex01.SolarFlarecom.com (10.17.10.4) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id\n 15.0.1497.2; Tue, 8 Sep 2020 10:14:50 +0100", "from opal.uk.solarflarecom.com (10.17.10.1) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server id\n 15.0.1497.2 via Frontend Transport; Tue, 8 Sep 2020 10:14:49 +0100", "from ukv-loginhost.uk.solarflarecom.com\n (ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id 0889EnmU032444\n for <dev@dpdk.org>; Tue, 8 Sep 2020 10:14:49 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id C487B1613A9\n for <dev@dpdk.org>; Tue, 8 Sep 2020 10:14:49 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "Date": "Tue, 8 Sep 2020 10:14:34 +0100", "Message-ID": "<1599556475-27820-15-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1599556475-27820-1-git-send-email-arybchenko@solarflare.com>", "References": "<1599556475-27820-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.6.1012-25652.003", "X-TM-AS-Result": "No-12.951100-8.000000-10", "X-TMASE-MatchedRID": "51SE6p2SBt+bX4K/DqV0NS2416nc3bQleouvej40T4gd0WOKRkwsh0Ac\n 6DyoS2rICNLuPteRDHcI+r1sul2OdnI/MxNRI7Uk66G2abPj6tjgXnxE81iyseMjEVIO/sdOdr6\n 6ANUOe/73OF0UjQGruresUpDYXvDYuVKcazUH+Z1C4WIP7GtYLFBijjE0XjY+OF0RIPSotdNT/4\n 0CMa1mSBkeVHs6jcMzJijtN0Yu2hFeFCVeyol8eRSceev8ZtpPMHi1Ydy2WEhHZg0gWH5yUbuKY\n ngtsWipqNfMRWfjbpalVflGDTl0k9vJMiGALwMaiuSat/QiCL99LQinZ4QefPcjNeVeWlqY+gtH\n j7OwNO0f/PIv6AGqLC8xrR8gzvMWsi2j+X+GYPYDrV+OTVs4TxzJZFa6wEQp", "X-TM-AS-User-Approved-Sender": "Yes", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10--12.951100-8.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.6.1012-25652.003", "X-MDID": "1599556550-5PGtEfA5dMrM", "Subject": "[dpdk-dev] [PATCH 13/14] net/sfc: use MCDI control structure as\n\tlibefx ops context", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Now MCDI helpers interface is independent from network driver and\nmay be moved into common driver.\n\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\nReviewed-by: Andy Moreton <amoreton@xilinx.com>\n---\n drivers/net/sfc/sfc_mcdi.c | 47 +++++++++++++++-----------------------\n 1 file changed, 19 insertions(+), 28 deletions(-)", "diff": "diff --git a/drivers/net/sfc/sfc_mcdi.c b/drivers/net/sfc/sfc_mcdi.c\nindex fa9160f6d3..ff2bc14c5d 100644\n--- a/drivers/net/sfc/sfc_mcdi.c\n+++ b/drivers/net/sfc/sfc_mcdi.c\n@@ -52,10 +52,8 @@\n \tsfc_efx_mcdi_log(mcdi, SFC_EFX_LOG_LEVEL_MCDI, __VA_ARGS__)\n \n static void\n-sfc_efx_mcdi_timeout(struct sfc_adapter *sa)\n+sfc_efx_mcdi_timeout(struct sfc_efx_mcdi *mcdi)\n {\n-\tstruct sfc_efx_mcdi *mcdi = &sa->mcdi;\n-\n \tsfc_efx_mcdi_warn(mcdi, \"MC TIMEOUT\");\n \n \tmcdi->state = SFC_EFX_MCDI_DEAD;\n@@ -64,10 +62,8 @@ sfc_efx_mcdi_timeout(struct sfc_adapter *sa)\n }\n \n static inline boolean_t\n-sfc_efx_mcdi_proxy_event_available(struct sfc_adapter *sa)\n+sfc_efx_mcdi_proxy_event_available(struct sfc_efx_mcdi *mcdi)\n {\n-\tstruct sfc_efx_mcdi *mcdi = &sa->mcdi;\n-\n \tmcdi->proxy_handle = 0;\n \tmcdi->proxy_result = ETIMEDOUT;\n \tmcdi->ops->mgmt_evq_poll(mcdi->ops_cookie);\n@@ -78,9 +74,8 @@ sfc_efx_mcdi_proxy_event_available(struct sfc_adapter *sa)\n }\n \n static void\n-sfc_efx_mcdi_poll(struct sfc_adapter *sa, boolean_t proxy)\n+sfc_efx_mcdi_poll(struct sfc_efx_mcdi *mcdi, boolean_t proxy)\n {\n-\tstruct sfc_efx_mcdi *mcdi = &sa->mcdi;\n \tefx_nic_t *enp;\n \tunsigned int delay_total;\n \tunsigned int delay_us;\n@@ -93,8 +88,9 @@ sfc_efx_mcdi_poll(struct sfc_adapter *sa, boolean_t proxy)\n \tdo {\n \t\tboolean_t poll_completed;\n \n-\t\tpoll_completed = (proxy) ? sfc_efx_mcdi_proxy_event_available(sa) :\n-\t\t\t\t\t efx_mcdi_request_poll(enp);\n+\t\tpoll_completed = (proxy) ?\n+\t\t\t\tsfc_efx_mcdi_proxy_event_available(mcdi) :\n+\t\t\t\tefx_mcdi_request_poll(enp);\n \t\tif (poll_completed)\n \t\t\treturn;\n \n@@ -102,7 +98,7 @@ sfc_efx_mcdi_poll(struct sfc_adapter *sa, boolean_t proxy)\n \t\t\tif (!proxy) {\n \t\t\t\taborted = efx_mcdi_request_abort(enp);\n \t\t\t\tSFC_ASSERT(aborted);\n-\t\t\t\tsfc_efx_mcdi_timeout(sa);\n+\t\t\t\tsfc_efx_mcdi_timeout(mcdi);\n \t\t\t}\n \n \t\t\treturn;\n@@ -125,8 +121,7 @@ sfc_efx_mcdi_poll(struct sfc_adapter *sa, boolean_t proxy)\n static void\n sfc_efx_mcdi_execute(void *arg, efx_mcdi_req_t *emrp)\n {\n-\tstruct sfc_adapter *sa = (struct sfc_adapter *)arg;\n-\tstruct sfc_efx_mcdi *mcdi = &sa->mcdi;\n+\tstruct sfc_efx_mcdi *mcdi = (struct sfc_efx_mcdi *)arg;\n \tuint32_t proxy_handle;\n \n \tif (mcdi->state == SFC_EFX_MCDI_DEAD) {\n@@ -139,7 +134,7 @@ sfc_efx_mcdi_execute(void *arg, efx_mcdi_req_t *emrp)\n \tSFC_ASSERT(mcdi->state == SFC_EFX_MCDI_INITIALIZED);\n \n \tefx_mcdi_request_start(mcdi->nic, emrp, B_FALSE);\n-\tsfc_efx_mcdi_poll(sa, B_FALSE);\n+\tsfc_efx_mcdi_poll(mcdi, B_FALSE);\n \n \tif (efx_mcdi_get_proxy_handle(mcdi->nic, emrp, &proxy_handle) == 0) {\n \t\t/*\n@@ -148,7 +143,7 @@ sfc_efx_mcdi_execute(void *arg, efx_mcdi_req_t *emrp)\n \t\t * a non-zero proxy handle (should be the same as\n \t\t * the value obtained above) and operation status\n \t\t */\n-\t\tsfc_efx_mcdi_poll(sa, B_TRUE);\n+\t\tsfc_efx_mcdi_poll(mcdi, B_TRUE);\n \n \t\tif ((mcdi->proxy_handle != 0) &&\n \t\t (mcdi->proxy_handle != proxy_handle)) {\n@@ -160,7 +155,7 @@ sfc_efx_mcdi_execute(void *arg, efx_mcdi_req_t *emrp)\n \t\t\t * request and poll for an ordinary MCDI response\n \t\t\t */\n \t\t\tefx_mcdi_request_start(mcdi->nic, emrp, B_FALSE);\n-\t\t\tsfc_efx_mcdi_poll(sa, B_FALSE);\n+\t\t\tsfc_efx_mcdi_poll(mcdi, B_FALSE);\n \t\t} else {\n \t\t\temrp->emr_rc = mcdi->proxy_result;\n \t\t\tsfc_efx_mcdi_err(mcdi,\n@@ -175,10 +170,9 @@ sfc_efx_mcdi_execute(void *arg, efx_mcdi_req_t *emrp)\n static void\n sfc_efx_mcdi_ev_cpl(void *arg)\n {\n-\tstruct sfc_adapter *sa = (struct sfc_adapter *)arg;\n-\tstruct sfc_efx_mcdi *mcdi __rte_unused;\n+\tstruct sfc_efx_mcdi *mcdi = (struct sfc_efx_mcdi *)arg;\n \n-\tmcdi = &sa->mcdi;\n+\tRTE_SET_USED(mcdi);\n \tSFC_ASSERT(mcdi->state == SFC_EFX_MCDI_INITIALIZED);\n \n \t/* MCDI is polled, completions are not expected */\n@@ -188,8 +182,7 @@ sfc_efx_mcdi_ev_cpl(void *arg)\n static void\n sfc_efx_mcdi_exception(void *arg, efx_mcdi_exception_t eme)\n {\n-\tstruct sfc_adapter *sa = (struct sfc_adapter *)arg;\n-\tstruct sfc_efx_mcdi *mcdi = &sa->mcdi;\n+\tstruct sfc_efx_mcdi *mcdi = (struct sfc_efx_mcdi *)arg;\n \n \tsfc_efx_mcdi_warn(mcdi, \"MC %s\",\n \t (eme == EFX_MCDI_EXCEPTION_MC_REBOOT) ? \"REBOOT\" :\n@@ -234,8 +227,7 @@ sfc_efx_mcdi_logger(void *arg, efx_log_msg_t type,\n \t\tvoid *header, size_t header_size,\n \t\tvoid *data, size_t data_size)\n {\n-\tstruct sfc_adapter *sa = (struct sfc_adapter *)arg;\n-\tstruct sfc_efx_mcdi *mcdi = &sa->mcdi;\n+\tstruct sfc_efx_mcdi *mcdi = (struct sfc_efx_mcdi *)arg;\n \tchar buffer[SFC_MCDI_LOG_BUF_SIZE];\n \tsize_t pfxsize;\n \tsize_t start;\n@@ -269,15 +261,14 @@ sfc_efx_mcdi_logger(void *arg, efx_log_msg_t type,\n static void\n sfc_efx_mcdi_ev_proxy_response(void *arg, uint32_t handle, efx_rc_t result)\n {\n-\tstruct sfc_adapter *sa = (struct sfc_adapter *)arg;\n-\tstruct sfc_efx_mcdi *mcdi = &sa->mcdi;\n+\tstruct sfc_efx_mcdi *mcdi = (struct sfc_efx_mcdi *)arg;\n \n \tmcdi->proxy_handle = handle;\n \tmcdi->proxy_result = result;\n }\n \n static int\n-sfc_efx_mcdi_init(struct sfc_adapter *sa, struct sfc_efx_mcdi *mcdi,\n+sfc_efx_mcdi_init(struct sfc_efx_mcdi *mcdi,\n \t\t uint32_t logtype, const char *log_prefix, efx_nic_t *nic,\n \t\t const struct sfc_efx_mcdi_ops *ops, void *ops_cookie)\n {\n@@ -308,7 +299,7 @@ sfc_efx_mcdi_init(struct sfc_adapter *sa, struct sfc_efx_mcdi *mcdi,\n \t\tgoto fail_dma_alloc;\n \n \temtp = &mcdi->transport;\n-\temtp->emt_context = sa;\n+\temtp->emt_context = mcdi;\n \temtp->emt_dma_mem = &mcdi->mem;\n \temtp->emt_execute = sfc_efx_mcdi_execute;\n \temtp->emt_ev_cpl = sfc_efx_mcdi_ev_cpl;\n@@ -409,7 +400,7 @@ sfc_mcdi_init(struct sfc_adapter *sa)\n \t\t\t\t SFC_LOGTYPE_MCDI_STR,\n \t\t\t\t RTE_LOG_NOTICE);\n \n-\treturn sfc_efx_mcdi_init(sa, &sa->mcdi, logtype,\n+\treturn sfc_efx_mcdi_init(&sa->mcdi, logtype,\n \t\t\t\t sa->priv.shared->log_prefix, sa->nic,\n \t\t\t\t &sfc_mcdi_ops, sa);\n }\n", "prefixes": [ "13/14" ] }