Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/76890/?format=api
{ "id": 76890, "url": "http://patches.dpdk.org/api/patches/76890/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1599556475-27820-10-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1599556475-27820-10-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1599556475-27820-10-git-send-email-arybchenko@solarflare.com", "date": "2020-09-08T09:14:29", "name": "[08/14] net/sfc: avoid usage of NIC pointer from adapter context", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "aedde077226f4f23eadab777cd0dd44a6cbe0cf4", "submitter": { "id": 607, "url": "http://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1599556475-27820-10-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 12014, "url": "http://patches.dpdk.org/api/series/12014/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12014", "date": "2020-09-08T09:14:20", "name": "net/sfc: factor out common driver library", "version": 1, "mbox": "http://patches.dpdk.org/series/12014/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/76890/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/76890/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id AF127A04AA;\n\tTue, 8 Sep 2020 11:16:44 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 42E061C12B;\n\tTue, 8 Sep 2020 11:15:53 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 28B211C11A\n for <dev@dpdk.org>; Tue, 8 Sep 2020 11:15:51 +0200 (CEST)", "from mx1-us1.ppe-hosted.com (unknown [10.110.50.150])\n by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id\n C0C01200B5 for <dev@dpdk.org>; Tue, 8 Sep 2020 09:15:50 +0000 (UTC)", "from us4-mdac16-47.at1.mdlocal (unknown [10.110.50.130])\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 2E2CB800D5\n for <dev@dpdk.org>; Tue, 8 Sep 2020 09:15:50 +0000 (UTC)", "from mx1-us1.ppe-hosted.com (unknown [10.110.50.12])\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n E3BEC10010B\n for <dev@dpdk.org>; Tue, 8 Sep 2020 09:14:55 +0000 (UTC)", "from webmail.solarflare.com (uk.solarflare.com [193.34.186.16])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n (No client certificate requested)\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id AC01340076\n for <dev@dpdk.org>; Tue, 8 Sep 2020 09:14:55 +0000 (UTC)", "from ukex01.SolarFlarecom.com (10.17.10.4) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id\n 15.0.1497.2; Tue, 8 Sep 2020 10:14:49 +0100", "from opal.uk.solarflarecom.com (10.17.10.1) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server id\n 15.0.1497.2 via Frontend Transport; Tue, 8 Sep 2020 10:14:49 +0100", "from ukv-loginhost.uk.solarflarecom.com\n (ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id 0889Ents032425\n for <dev@dpdk.org>; Tue, 8 Sep 2020 10:14:49 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id 8A5501613AB\n for <dev@dpdk.org>; Tue, 8 Sep 2020 10:14:49 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "Date": "Tue, 8 Sep 2020 10:14:29 +0100", "Message-ID": "<1599556475-27820-10-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1599556475-27820-1-git-send-email-arybchenko@solarflare.com>", "References": "<1599556475-27820-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.6.1012-25652.003", "X-TM-AS-Result": "No-11.388300-8.000000-10", "X-TMASE-MatchedRID": "8KqAZX9NEj5ITqtSH9SWSS2416nc3bQleouvej40T4gd0WOKRkwsh3Io\n zGa69omdrdoLblq9S5qas0rFUiAJUTtLCZHM0q2+LTHwnYOikQ3YuVu0X/rOkC4mS5ZcbgykHdp\n aAe/6URkgIEX6WzwOdHy8wrTvkWOE1u/Sx2voIm8zL6MySEJ0VhpxmKWTfsQI5ucVak1fUMG7im\n J4LbFoqRfb/g6/AVAtG+8CgnzENLtC4oGQR0QDTH9EwA0OW8QlE3EgF0+MVuCfJbh3pMo2kKPFj\n JEFr+olwXCBO/GKkVqOhzOa6g8KrZXab56lxlwcDwkFyw4VU4CgCbvlZFwA6dS5yfl5JZAhJjZF\n ot2mO34=", "X-TM-AS-User-Approved-Sender": "Yes", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10--11.388300-8.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.6.1012-25652.003", "X-MDID": "1599556550-XQVrWwetubjr", "Subject": "[dpdk-dev] [PATCH 08/14] net/sfc: avoid usage of NIC pointer from\n\tadapter context", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Prepare to avoid usage of the adapter context in common MCDI helpers.\n\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\nReviewed-by: Andy Moreton <amoreton@xilinx.com>\n---\n drivers/net/sfc/sfc_mcdi.c | 19 +++++++++++--------\n drivers/net/sfc/sfc_mcdi.h | 1 +\n 2 files changed, 12 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/sfc/sfc_mcdi.c b/drivers/net/sfc/sfc_mcdi.c\nindex 5f6ad0a4aa..8f446e8bc8 100644\n--- a/drivers/net/sfc/sfc_mcdi.c\n+++ b/drivers/net/sfc/sfc_mcdi.c\n@@ -75,6 +75,7 @@ sfc_efx_mcdi_proxy_event_available(struct sfc_adapter *sa)\n static void\n sfc_efx_mcdi_poll(struct sfc_adapter *sa, boolean_t proxy)\n {\n+\tstruct sfc_efx_mcdi *mcdi = &sa->mcdi;\n \tefx_nic_t *enp;\n \tunsigned int delay_total;\n \tunsigned int delay_us;\n@@ -82,7 +83,7 @@ sfc_efx_mcdi_poll(struct sfc_adapter *sa, boolean_t proxy)\n \n \tdelay_total = 0;\n \tdelay_us = SFC_EFX_MCDI_POLL_INTERVAL_MIN_US;\n-\tenp = sa->nic;\n+\tenp = mcdi->nic;\n \n \tdo {\n \t\tboolean_t poll_completed;\n@@ -127,10 +128,10 @@ sfc_efx_mcdi_execute(void *arg, efx_mcdi_req_t *emrp)\n \n \tSFC_ASSERT(mcdi->state == SFC_EFX_MCDI_INITIALIZED);\n \n-\tefx_mcdi_request_start(sa->nic, emrp, B_FALSE);\n+\tefx_mcdi_request_start(mcdi->nic, emrp, B_FALSE);\n \tsfc_efx_mcdi_poll(sa, B_FALSE);\n \n-\tif (efx_mcdi_get_proxy_handle(sa->nic, emrp, &proxy_handle) == 0) {\n+\tif (efx_mcdi_get_proxy_handle(mcdi->nic, emrp, &proxy_handle) == 0) {\n \t\t/*\n \t\t * Authorization is required for the MCDI request;\n \t\t * wait for an MCDI proxy response event to bring\n@@ -148,7 +149,7 @@ sfc_efx_mcdi_execute(void *arg, efx_mcdi_req_t *emrp)\n \t\t\t * Authorization succeeded; re-issue the original\n \t\t\t * request and poll for an ordinary MCDI response\n \t\t\t */\n-\t\t\tefx_mcdi_request_start(sa->nic, emrp, B_FALSE);\n+\t\t\tefx_mcdi_request_start(mcdi->nic, emrp, B_FALSE);\n \t\t\tsfc_efx_mcdi_poll(sa, B_FALSE);\n \t\t} else {\n \t\t\temrp->emr_rc = mcdi->proxy_result;\n@@ -267,7 +268,7 @@ sfc_efx_mcdi_ev_proxy_response(void *arg, uint32_t handle, efx_rc_t result)\n \n static int\n sfc_efx_mcdi_init(struct sfc_adapter *sa, struct sfc_efx_mcdi *mcdi,\n-\t\t uint32_t logtype, const char *log_prefix)\n+\t\t uint32_t logtype, const char *log_prefix, efx_nic_t *nic)\n {\n \tsize_t max_msg_size;\n \tefx_mcdi_transport_t *emtp;\n@@ -277,6 +278,8 @@ sfc_efx_mcdi_init(struct sfc_adapter *sa, struct sfc_efx_mcdi *mcdi,\n \n \trte_spinlock_init(&mcdi->lock);\n \n+\tmcdi->nic = nic;\n+\n \tmcdi->state = SFC_EFX_MCDI_INITIALIZED;\n \n \tmcdi->logtype = logtype;\n@@ -298,7 +301,7 @@ sfc_efx_mcdi_init(struct sfc_adapter *sa, struct sfc_efx_mcdi *mcdi,\n \temtp->emt_ev_proxy_response = sfc_efx_mcdi_ev_proxy_response;\n \n \tsfc_efx_mcdi_info(mcdi, \"init MCDI\");\n-\trc = efx_mcdi_init(sa->nic, emtp);\n+\trc = efx_mcdi_init(mcdi->nic, emtp);\n \tif (rc != 0)\n \t\tgoto fail_mcdi_init;\n \n@@ -326,7 +329,7 @@ sfc_efx_mcdi_fini(struct sfc_adapter *sa, struct sfc_efx_mcdi *mcdi)\n \tmcdi->state = SFC_EFX_MCDI_UNINITIALIZED;\n \n \tsfc_efx_mcdi_info(mcdi, \"fini MCDI\");\n-\tefx_mcdi_fini(sa->nic);\n+\tefx_mcdi_fini(mcdi->nic);\n \tmemset(emtp, 0, sizeof(*emtp));\n \n \trte_spinlock_unlock(&mcdi->lock);\n@@ -346,7 +349,7 @@ sfc_mcdi_init(struct sfc_adapter *sa)\n \t\t\t\t RTE_LOG_NOTICE);\n \n \treturn sfc_efx_mcdi_init(sa, &sa->mcdi, logtype,\n-\t\t\t\t sa->priv.shared->log_prefix);\n+\t\t\t\t sa->priv.shared->log_prefix, sa->nic);\n }\n \n void\ndiff --git a/drivers/net/sfc/sfc_mcdi.h b/drivers/net/sfc/sfc_mcdi.h\nindex 0194825bfa..e2105364ad 100644\n--- a/drivers/net/sfc/sfc_mcdi.h\n+++ b/drivers/net/sfc/sfc_mcdi.h\n@@ -33,6 +33,7 @@ enum sfc_efx_mcdi_state {\n \n struct sfc_efx_mcdi {\n \trte_spinlock_t\t\t\tlock;\n+\tefx_nic_t\t\t\t*nic;\n \tefsys_mem_t\t\t\tmem;\n \tenum sfc_efx_mcdi_state\t\tstate;\n \tefx_mcdi_transport_t\t\ttransport;\n", "prefixes": [ "08/14" ] }