Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/76659/?format=api
{ "id": 76659, "url": "http://patches.dpdk.org/api/patches/76659/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200907090825.1761-8-huwei013@chinasoftinc.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200907090825.1761-8-huwei013@chinasoftinc.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200907090825.1761-8-huwei013@chinasoftinc.com", "date": "2020-09-07T09:08:24", "name": "[7/8] net/hns3: add restriction on setting VF MTU", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "6dd300a904ed198cc9f5a0e1b8ace81410764d76", "submitter": { "id": 1537, "url": "http://patches.dpdk.org/api/people/1537/?format=api", "name": "Wei Hu (Xavier)", "email": "huwei013@chinasoftinc.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200907090825.1761-8-huwei013@chinasoftinc.com/mbox/", "series": [ { "id": 11986, "url": "http://patches.dpdk.org/api/series/11986/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11986", "date": "2020-09-07T09:08:17", "name": "net/hns3: updates for Rx Tx", "version": 1, "mbox": "http://patches.dpdk.org/series/11986/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/76659/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/76659/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 27DFEA04B9;\n\tMon, 7 Sep 2020 11:10:14 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 7A2761C11A;\n\tMon, 7 Sep 2020 11:09:24 +0200 (CEST)", "from mail.chinasoftinc.com (unknown [114.113.233.8])\n by dpdk.org (Postfix) with ESMTP id 04F341C122\n for <dev@dpdk.org>; Mon, 7 Sep 2020 11:09:21 +0200 (CEST)", "from localhost.localdomain (65.49.108.226) by INCCAS002.ito.icss\n (10.168.0.60) with Microsoft SMTP Server id 14.3.487.0; Mon, 7 Sep 2020\n 17:09:18 +0800" ], "From": "\"Wei Hu (Xavier)\" <huwei013@chinasoftinc.com>", "To": "<dev@dpdk.org>", "CC": "<xavier.huwei@huawei.com>", "Date": "Mon, 7 Sep 2020 17:08:24 +0800", "Message-ID": "<20200907090825.1761-8-huwei013@chinasoftinc.com>", "X-Mailer": "git-send-email 2.9.5", "In-Reply-To": "<20200907090825.1761-1-huwei013@chinasoftinc.com>", "References": "<20200907090825.1761-1-huwei013@chinasoftinc.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[65.49.108.226]", "Subject": "[dpdk-dev] [PATCH 7/8] net/hns3: add restriction on setting VF MTU", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: \"Wei Hu (Xavier)\" <xavier.huwei@huawei.com>\n\nwhen Rx of scattered packets is off, we have some possibility of using\nvector Rx process function or simple Rx functions in hns3 PMD driver.\nIf the input MTU is increased and the maximum length of received packets\nis greater than the length of a buffer for Rx packets, the hardware network\nengine needs to use multiple BDs and buffers to store these packets. This\nwill cause problems when still using vector Rx process function or simple\nRx function to receiving packets. So, when Rx of scattered packets is off\nand device is started, it is not permitted to increase MTU so that the\nmaximum length of Rx packets is greater than Rx buffer length.\n\nSigned-off-by: Chengwen Feng <fengchengwen@huawei.com>\nSigned-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>\n---\n drivers/net/hns3/hns3_ethdev_vf.c | 19 +++++++++++++++++++\n 1 file changed, 19 insertions(+)", "diff": "diff --git a/drivers/net/hns3/hns3_ethdev_vf.c b/drivers/net/hns3/hns3_ethdev_vf.c\nindex 93f2c93..44e51b5 100644\n--- a/drivers/net/hns3/hns3_ethdev_vf.c\n+++ b/drivers/net/hns3/hns3_ethdev_vf.c\n@@ -871,6 +871,25 @@ hns3vf_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)\n \t\treturn -EIO;\n \t}\n \n+\t/*\n+\t * when Rx of scattered packets is off, we have some possibility of\n+\t * using vector Rx process function or simple Rx functions in hns3 PMD\n+\t * driver. If the input MTU is increased and the maximum length of\n+\t * received packets is greater than the length of a buffer for Rx\n+\t * packet, the hardware network engine needs to use multiple BDs and\n+\t * buffers to store these packets. This will cause problems when still\n+\t * using vector Rx process function or simple Rx function to receiving\n+\t * packets. So, when Rx of scattered packets is off and device is\n+\t * started, it is not permitted to increase MTU so that the maximum\n+\t * length of Rx packets is greater than Rx buffer length.\n+\t */\n+\tif (dev->data->dev_started && !dev->data->scattered_rx &&\n+\t frame_size > hw->rx_buf_len) {\n+\t\thns3_err(hw, \"failed to set mtu because current is \"\n+\t\t\t\"not scattered rx mode\");\n+\t\treturn -EOPNOTSUPP;\n+\t}\n+\n \trte_spinlock_lock(&hw->lock);\n \tret = hns3vf_config_mtu(hw, mtu);\n \tif (ret) {\n", "prefixes": [ "7/8" ] }