Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/76619/?format=api
{ "id": 76619, "url": "http://patches.dpdk.org/api/patches/76619/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200906013133.26360-7-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200906013133.26360-7-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20200906013133.26360-7-stephen@networkplumber.org", "date": "2020-09-06T01:31:28", "name": "[06/11] dpdk-pmdinfo: replace is False and is True", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "252e26561e7c3d142ce3f4d4e082ccd7d25fe7c4", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200906013133.26360-7-stephen@networkplumber.org/mbox/", "series": [ { "id": 11970, "url": "http://patches.dpdk.org/api/series/11970/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11970", "date": "2020-09-06T01:31:22", "name": "Python script updates", "version": 1, "mbox": "http://patches.dpdk.org/series/11970/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/76619/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/76619/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 11AA7A04C5;\n\tSun, 6 Sep 2020 03:32:45 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 653EC1C126;\n\tSun, 6 Sep 2020 03:31:53 +0200 (CEST)", "from mail-pg1-f176.google.com (mail-pg1-f176.google.com\n [209.85.215.176]) by dpdk.org (Postfix) with ESMTP id 2FA581C0CD\n for <dev@dpdk.org>; Sun, 6 Sep 2020 03:31:49 +0200 (CEST)", "by mail-pg1-f176.google.com with SMTP id 31so6263046pgy.13\n for <dev@dpdk.org>; Sat, 05 Sep 2020 18:31:49 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n by smtp.gmail.com with ESMTPSA id n127sm10731863pfn.155.2020.09.05.18.31.47\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sat, 05 Sep 2020 18:31:47 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=aRa6qQxtPXReZzHu42y98tv9PIL+dbM+384ha1rUngw=;\n b=n8YBASWAL976+O4bMyfeSrvYUczyJ/R4HrwAL7TRP4q3prbkwNRnVJ/r4xwKWz8L5z\n c231B3lUJ4UxpiCZmi24kuj4tJl0wP83hyvzn7Q8iQXnhi/EyuPQrjWjToHkb6Azr8FX\n SOnmRyg5W7QC4FjvGydiyYmQ9JQSlBX0RFhewQuPieS8K8yGCD6NS6f3imTF0g7C2vr/\n t9A4t6ClqLzioYJEBgoOudMxo/Ty+0bLbLagFquXhwgA+zH3mmljsqJ5daTN+cDPflt1\n eYp9oPMpSP8WzwfBAqyDByYT48c4oiDcuQnjNyLEGqVSF1+I0XG/chG5V/ziK0mehxrv\n UO4Q==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=aRa6qQxtPXReZzHu42y98tv9PIL+dbM+384ha1rUngw=;\n b=Vr7S/4UeJnEjtxhgwwWiHD9BaDfONWGoeG3RIzWPFt32aAARWVj2EsjxFbcXyO6pi6\n yRCFLT2u7UvHhh1jcWGOZde3+NoViEW8qxHbqYq/qScCHdAreN34HZ+pyHsnudBZQ4D/\n GdbLj2EAd+a+Z/9tVJZTGx2WpL2veuGRUWphty3j3pl2Gc2IymXI5sl0UWdItBX7lWyu\n TENvxIMzV4vVtfTitbyyeRpVTDtDj76BWNf4xojK4pS5HRky3mB0/DCvQ4Yysp3nTnaH\n m5A3wiSnvR/szZLKnk5HulFo7Vwr4JrejPNWVqliZaAXwYluGtKhCnwUo2JfFFp/BJ9g\n sp/Q==", "X-Gm-Message-State": "AOAM531vJm2+zB+oLTF5gWoEXcQS5GwsRI1QuZFSubSjfAgRcG/agHbF\n YIeMk0Ya3rghZmdNwBAbQrJzBri9zOwN3Q==", "X-Google-Smtp-Source": "\n ABdhPJykHW147q/i17vIfg9/NLRyb6Wgh8F8EaeZLZDLqyqw6Hns9n1zN0JFDns7Gfl3E6AtaDcugA==", "X-Received": "by 2002:a63:4746:: with SMTP id w6mr12460848pgk.412.1599355908003;\n Sat, 05 Sep 2020 18:31:48 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Date": "Sat, 5 Sep 2020 18:31:28 -0700", "Message-Id": "<20200906013133.26360-7-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200906013133.26360-1-stephen@networkplumber.org>", "References": "<20200906013133.26360-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 06/11] dpdk-pmdinfo: replace is False and is True", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Code reads better if unnecessary comparison with False and True\nis not used.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n usertools/dpdk-pmdinfo.py | 24 ++++++++++++------------\n 1 file changed, 12 insertions(+), 12 deletions(-)", "diff": "diff --git a/usertools/dpdk-pmdinfo.py b/usertools/dpdk-pmdinfo.py\nindex 32f8a82519fb..7c27a91182e4 100755\n--- a/usertools/dpdk-pmdinfo.py\n+++ b/usertools/dpdk-pmdinfo.py\n@@ -367,7 +367,7 @@ def search_for_autoload_path(self):\n \":/usr/lib64:/lib64:/usr/lib:/lib\")\n if library is None:\n return (None, None)\n- if raw_output is False:\n+ if not raw_output:\n print(\"Scanning for autoload path in %s\" % library)\n scanfile = open(library, 'rb')\n scanelf = ReadElf(scanfile, sys.stdout)\n@@ -443,7 +443,7 @@ def process_dt_needed_entries(self):\n runpath + \":\" + ldlibpath +\n \":/usr/lib64:/lib64:/usr/lib:/lib\")\n if library is not None:\n- if raw_output is False:\n+ if not raw_output:\n print(\"Scanning %s for pmd information\" % library)\n with open(library, 'rb') as file:\n try:\n@@ -473,7 +473,7 @@ def force_bytes(s):\n def scan_autoload_path(autoload_path):\n global raw_output\n \n- if os.path.exists(autoload_path) is False:\n+ if not os.path.exists(autoload_path):\n return\n \n try:\n@@ -497,7 +497,7 @@ def scan_autoload_path(autoload_path):\n # No permission to read the file, skip it\n continue\n \n- if raw_output is False:\n+ if not raw_output:\n print(\"Hw Support for library %s\" % d)\n readelf.display_pmd_info_strings(\".rodata\")\n file.close()\n@@ -510,8 +510,8 @@ def scan_for_autoload_pmds(dpdk_path):\n \"\"\"\n global raw_output\n \n- if os.path.isfile(dpdk_path) is False:\n- if raw_output is False:\n+ if not os.path.isfile(dpdk_path):\n+ if not raw_output:\n print(\"Must specify a file name\")\n return\n \n@@ -519,22 +519,22 @@ def scan_for_autoload_pmds(dpdk_path):\n try:\n readelf = ReadElf(file, sys.stdout)\n except ElfError:\n- if raw_output is False:\n+ if not raw_output:\n print(\"Unable to parse %s\" % file)\n return\n \n (autoload_path, scannedfile) = readelf.search_for_autoload_path()\n if not autoload_path:\n- if raw_output is False:\n+ if not raw_output:\n print(\"No autoload path configured in %s\" % dpdk_path)\n return\n- if raw_output is False:\n+ if not raw_output:\n if scannedfile is None:\n scannedfile = dpdk_path\n print(\"Found autoload path %s in %s\" % (autoload_path, scannedfile))\n \n file.close()\n- if raw_output is False:\n+ if not raw_output:\n print(\"Discovered Autoload HW Support:\")\n scan_autoload_path(autoload_path)\n return\n@@ -593,14 +593,14 @@ def main(stream=None):\n optparser.print_usage()\n exit(1)\n \n- if options.pdir is True:\n+ if options.pdir:\n exit(scan_for_autoload_pmds(args[0]))\n \n ldlibpath = os.environ.get('LD_LIBRARY_PATH')\n if ldlibpath is None:\n ldlibpath = \"\"\n \n- if os.path.exists(args[0]) is True:\n+ if os.path.exists(args[0]):\n myelffile = args[0]\n else:\n myelffile = search_file(\n", "prefixes": [ "06/11" ] }