Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/76614/?format=api
{ "id": 76614, "url": "http://patches.dpdk.org/api/patches/76614/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200906013133.26360-2-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200906013133.26360-2-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20200906013133.26360-2-stephen@networkplumber.org", "date": "2020-09-06T01:31:23", "name": "[01/11] cpu_layout: refactor to meet python standards", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "9f08ab9bb0bd96b63b9247d5a045192ac38b4148", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200906013133.26360-2-stephen@networkplumber.org/mbox/", "series": [ { "id": 11970, "url": "http://patches.dpdk.org/api/series/11970/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11970", "date": "2020-09-06T01:31:22", "name": "Python script updates", "version": 1, "mbox": "http://patches.dpdk.org/series/11970/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/76614/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/76614/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 70D7AA04C5;\n\tSun, 6 Sep 2020 03:31:57 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id CBF791C0D2;\n\tSun, 6 Sep 2020 03:31:46 +0200 (CEST)", "from mail-pj1-f65.google.com (mail-pj1-f65.google.com\n [209.85.216.65]) by dpdk.org (Postfix) with ESMTP id 9FDED2BAB\n for <dev@dpdk.org>; Sun, 6 Sep 2020 03:31:43 +0200 (CEST)", "by mail-pj1-f65.google.com with SMTP id b16so4944467pjp.0\n for <dev@dpdk.org>; Sat, 05 Sep 2020 18:31:43 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n by smtp.gmail.com with ESMTPSA id n127sm10731863pfn.155.2020.09.05.18.31.41\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sat, 05 Sep 2020 18:31:41 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=ciLvjNOIsfeYXD5MxG0NqKGDF/Q594uMpv3G9vdvQyE=;\n b=va9dZJwp54rz0Z1c4Ws4PXQClBBb47q/nmu7XOEmF15xR/GDsPpX6GN6s/m8gpk9E8\n rkOBHs13EwyfyWxoDD7FzGfvWIEv6S5XVbPuHnVNrnGnnbv39NfKgOXHe5QHpJJNyOip\n WR29luOUG6pRonXTwOFZjdTsnkMILwuupT21IjjCJtCLrlgVw58J9Ngqpr2zOR/wm7u1\n 4JqHQ7KcUbMmhUG+NH3thlYXramXlQh1TH7Y/UJ8SgY0ZLy0ulqFcrHQrDzsfHcAvtd9\n NUjgQqvwqWs4Kh3KichIF43PWY5NBbawEf54pBS40hrGAUztCY/ZH7x+4JOkKKWA/PKy\n jNbw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=ciLvjNOIsfeYXD5MxG0NqKGDF/Q594uMpv3G9vdvQyE=;\n b=lVYkF/v4cmiv1AudwMfOKaAIIMVpKZN0bqMWrWB0y9y4LYRuE5L8fioTFIyHHVlaF5\n CL5jPsIla8a6nUs+n30WjFxW0rWhIdexCEPkV9CXyWw7Iwsy/XoG7QGRgXdcdAkvfkDJ\n /k9Wd7URgY/NjsKs2TWo9eHOMPGE8o2brkXgmHnjxW8ztLhOvAybBdtA3DVooEC7/ZCj\n wOj1/qlJDqMkPF3Nz98/91x5lGRVFvJz/mxVboaF1jChqod1yjGs2p0wEhPw0XyUPdD3\n vVuAibAYEiNhroI3/wsto8nio+9YslP1BM9mtitsbto3YYW2nDqrYnYZkGJGIZyJNotP\n /zFg==", "X-Gm-Message-State": "AOAM531ESH9PpaYXzgLP9cXaLEnvLCZ6Zp6HiwtPIEwr5pXyLu3T4o1J\n kza61XqGEJ2DiYIwNoGWn63xjo1kj0LrLw==", "X-Google-Smtp-Source": "\n ABdhPJwPwl7Cleq2HjYPLPgSJUMIc7vyJdjhMshRyGKxCWKGnchsc/9uzxeUA3KGGry5wMIJU4iRqg==", "X-Received": "by 2002:a17:902:6ac3:: with SMTP id\n i3mr14263892plt.21.1599355902498;\n Sat, 05 Sep 2020 18:31:42 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Date": "Sat, 5 Sep 2020 18:31:23 -0700", "Message-Id": "<20200906013133.26360-2-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200906013133.26360-1-stephen@networkplumber.org>", "References": "<20200906013133.26360-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 01/11] cpu_layout: refactor to meet python\n\tstandards", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Rearrange code to make it pass python lint.\nThis includes add a main function, docstring, and some\nvariable name changes.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n usertools/cpu_layout.py | 145 +++++++++++++++++++++++-----------------\n 1 file changed, 85 insertions(+), 60 deletions(-)", "diff": "diff --git a/usertools/cpu_layout.py b/usertools/cpu_layout.py\nindex 89a48cec463e..1e4577143ac5 100755\n--- a/usertools/cpu_layout.py\n+++ b/usertools/cpu_layout.py\n@@ -2,67 +2,92 @@\n # SPDX-License-Identifier: BSD-3-Clause\n # Copyright(c) 2010-2014 Intel Corporation\n # Copyright(c) 2017 Cavium, Inc. All rights reserved.\n+\"\"\"\n+Show CPU layout\n+\"\"\"\n+SYS_DEVICES_CPU = \"/sys/devices/system/cpu\"\n \n-import sys\n-\n-sockets = []\n-cores = []\n-core_map = {}\n-base_path = \"/sys/devices/system/cpu\"\n-fd = open(\"{}/kernel_max\".format(base_path))\n-max_cpus = int(fd.read())\n-fd.close()\n-for cpu in range(max_cpus + 1):\n- try:\n- fd = open(\"{}/cpu{}/topology/core_id\".format(base_path, cpu))\n- except IOError:\n- continue\n- except:\n- break\n- core = int(fd.read())\n- fd.close()\n- fd = open(\"{}/cpu{}/topology/physical_package_id\".format(base_path, cpu))\n- socket = int(fd.read())\n- fd.close()\n- if core not in cores:\n- cores.append(core)\n- if socket not in sockets:\n- sockets.append(socket)\n- key = (socket, core)\n- if key not in core_map:\n- core_map[key] = []\n- core_map[key].append(cpu)\n-\n-print(format(\"=\" * (47 + len(base_path))))\n-print(\"Core and Socket Information (as reported by '{}')\".format(base_path))\n-print(\"{}\\n\".format(\"=\" * (47 + len(base_path))))\n-print(\"cores = \", cores)\n-print(\"sockets = \", sockets)\n-print(\"\")\n-\n-max_processor_len = len(str(len(cores) * len(sockets) * 2 - 1))\n-max_thread_count = len(list(core_map.values())[0])\n-max_core_map_len = (max_processor_len * max_thread_count) \\\n+\n+def print_coremap(sockets, cores, core_map):\n+ '''print core, thread, socket mapping'''\n+ max_processor_len = len(str(len(cores) * len(sockets) * 2 - 1))\n+ max_thread_count = len(list(core_map.values())[0])\n+ max_core_map_len = (max_processor_len * max_thread_count) \\\n + len(\", \") * (max_thread_count - 1) \\\n + len('[]') + len('Socket ')\n-max_core_id_len = len(str(max(cores)))\n-\n-output = \" \".ljust(max_core_id_len + len('Core '))\n-for s in sockets:\n- output += \" Socket %s\" % str(s).ljust(max_core_map_len - len('Socket '))\n-print(output)\n-\n-output = \" \".ljust(max_core_id_len + len('Core '))\n-for s in sockets:\n- output += \" --------\".ljust(max_core_map_len)\n- output += \" \"\n-print(output)\n-\n-for c in cores:\n- output = \"Core %s\" % str(c).ljust(max_core_id_len)\n- for s in sockets:\n- if (s,c) in core_map:\n- output += \" \" + str(core_map[(s, c)]).ljust(max_core_map_len)\n- else:\n- output += \" \" * (max_core_map_len + 1)\n+\n+ max_core_id_len = len(str(max(cores)))\n+\n+ output = \" \".ljust(max_core_id_len + len('Core '))\n+ for socket in sockets:\n+ output += \" Socket %s\" % str(socket).ljust(max_core_map_len -\n+ len('Socket '))\n+ print(output)\n+\n+ output = \" \".ljust(max_core_id_len + len('Core '))\n+ for socket in sockets:\n+ output += \" --------\".ljust(max_core_map_len)\n+ output += \" \"\n print(output)\n+\n+ for core in cores:\n+ output = \"Core %s\" % str(core).ljust(max_core_id_len)\n+ for socket in sockets:\n+ if (socket, core) in core_map:\n+ output += \" \" + str(core_map[(socket,\n+ core)]).ljust(max_core_map_len)\n+ else:\n+ output += \" \" * (max_core_map_len + 1)\n+ print(output)\n+\n+\n+def print_header(sockets, cores):\n+ '''print the core socket information header'''\n+ header_len = 47 + len(SYS_DEVICES_CPU)\n+ print(format(\"=\" * header_len))\n+ print(\"Core and Socket Information (as reported by '{}')\".format(\n+ SYS_DEVICES_CPU))\n+ print(\"{}\\n\".format(\"=\" * header_len))\n+ print(\"cores = \", cores)\n+ print(\"sockets = \", sockets)\n+ print(\"\")\n+\n+\n+def main():\n+ '''program main function'''\n+\n+ with open(\"{}/kernel_max\".format(SYS_DEVICES_CPU)) as kernel_max:\n+ max_cpus = int(kernel_max.read())\n+\n+ core_map = {}\n+ sockets = []\n+ cores = []\n+\n+ for cpu in range(max_cpus + 1):\n+ topo_path = \"{}/cpu{}/topology/\".format(SYS_DEVICES_CPU, cpu)\n+ try:\n+ with open(topo_path + \"core_id\") as core_id:\n+ core = int(core_id.read())\n+ except FileNotFoundError:\n+ break\n+ except IOError:\n+ continue\n+\n+ with open(topo_path + \"physical_package_id\") as package_id:\n+ socket = int(package_id.read())\n+\n+ if core not in cores:\n+ cores.append(core)\n+ if socket not in sockets:\n+ sockets.append(socket)\n+ key = (socket, core)\n+ if key not in core_map:\n+ core_map[key] = []\n+ core_map[key].append(cpu)\n+\n+ print_header(sockets, cores)\n+ print_coremap(sockets, cores, core_map)\n+\n+\n+if __name__ == \"__main__\":\n+ main()\n", "prefixes": [ "01/11" ] }