Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/76408/?format=api
{ "id": 76408, "url": "http://patches.dpdk.org/api/patches/76408/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200903144942.671870-2-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200903144942.671870-2-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200903144942.671870-2-bruce.richardson@intel.com", "date": "2020-09-03T14:49:40", "name": "[v2,1/3] config: remove explicit undefinition of unset values", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": true, "hash": "808cabb46bced366ce42d2f3cf3f4604aa302784", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200903144942.671870-2-bruce.richardson@intel.com/mbox/", "series": [ { "id": 11928, "url": "http://patches.dpdk.org/api/series/11928/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11928", "date": "2020-09-03T14:49:39", "name": "Allow overriding of build-time constants", "version": 2, "mbox": "http://patches.dpdk.org/series/11928/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/76408/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/76408/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 16DE5A04BF;\n\tThu, 3 Sep 2020 16:50:03 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 667C61C0BC;\n\tThu, 3 Sep 2020 16:49:56 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n by dpdk.org (Postfix) with ESMTP id AD345DE0\n for <dev@dpdk.org>; Thu, 3 Sep 2020 16:49:53 +0200 (CEST)", "from orsmga004.jf.intel.com ([10.7.209.38])\n by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 03 Sep 2020 07:49:53 -0700", "from silpixa00399126.ir.intel.com ([10.237.222.27])\n by orsmga004.jf.intel.com with ESMTP; 03 Sep 2020 07:49:51 -0700" ], "IronPort-SDR": [ "\n /UlXnPdkvFl/Zt+QXow74IhtO9wmHA2t3NBHPsyruproSuchuSfyFHsiSEKOenlu2eUNUyWLEy\n YUd8Z78j5Dhg==", "\n Iox/LzIUXkrEp8WQmvjDb6VRrcETQ0d1TVGofPi6QxlQtqJFNLpRrksIxGk4FsWDLiT8LYm9GR\n 1Iwg0RhDVhEw==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9733\"; a=\"242403439\"", "E=Sophos;i=\"5.76,387,1592895600\"; d=\"scan'208\";a=\"242403439\"", "E=Sophos;i=\"5.76,387,1592895600\"; d=\"scan'208\";a=\"446930278\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Ma Lihong <lihongx.ma@intel.com>, Hemant Agrawal <hemant.agrawal@nxp.com>,\n Bruce Richardson <bruce.richardson@intel.com>", "Date": "Thu, 3 Sep 2020 15:49:40 +0100", "Message-Id": "<20200903144942.671870-2-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200903144942.671870-1-bruce.richardson@intel.com>", "References": "<20200825114447.135030-1-bruce.richardson@intel.com>\n <20200903144942.671870-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 1/3] config: remove explicit undefinition of\n\tunset values", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Rather than explicitly clearing any setting of undefined values in our\nrte_config.h file, it's better to instead just add a comment that the value\nis not set. Using a comment allows the user to set the value using CFLAGS\nor similar mechanism without the config file clearing the value again.\n\nThe text used \"<VALUE> is not set\" is modelled after the kernel approach of\ndoing the same thing.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n\nAlthough DPDK coding convention forbids use of \"//\" for comments, using\nregular C comment style makes the config settings less clear, as they can\nbe confused with regular comments in the file. Using \"//\" makes them stand\nout better, so I prefer it. However, if others feel strongly, they can be\nchanged to standard.\n---\n config/rte_config.h | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/config/rte_config.h b/config/rte_config.h\nindex 9bb915347..1c5a86d6a 100644\n--- a/config/rte_config.h\n+++ b/config/rte_config.h\n@@ -85,17 +85,17 @@\n \n /* ip_fragmentation defines */\n #define RTE_LIBRTE_IP_FRAG_MAX_FRAG 4\n-#undef RTE_LIBRTE_IP_FRAG_TBL_STAT\n+// RTE_LIBRTE_IP_FRAG_TBL_STAT is not set\n \n /* rte_power defines */\n #define RTE_MAX_LCORE_FREQS 64\n \n /* rte_sched defines */\n-#undef RTE_SCHED_RED\n-#undef RTE_SCHED_COLLECT_STATS\n-#undef RTE_SCHED_SUBPORT_TC_OV\n+// RTE_SCHED_RED is not set\n+// RTE_SCHED_COLLECT_STATS is not set\n+// RTE_SCHED_SUBPORT_TC_OV is not set\n #define RTE_SCHED_PORT_N_GRINDERS 8\n-#undef RTE_SCHED_VECTOR\n+// RTE_SCHED_VECTOR is not set\n \n /* KNI defines */\n #define RTE_KNI_PREEMPT_DEFAULT 1\n@@ -123,7 +123,7 @@\n \n /* i40e defines */\n #define RTE_LIBRTE_I40E_RX_ALLOW_BULK_ALLOC 1\n-#undef RTE_LIBRTE_I40E_16BYTE_RX_DESC\n+// RTE_LIBRTE_I40E_16BYTE_RX_DESC is not set\n #define RTE_LIBRTE_I40E_QUEUE_NUM_PER_PF 64\n #define RTE_LIBRTE_I40E_QUEUE_NUM_PER_VF 4\n #define RTE_LIBRTE_I40E_QUEUE_NUM_PER_VM 4\n", "prefixes": [ "v2", "1/3" ] }