Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/76397/?format=api
{ "id": 76397, "url": "http://patches.dpdk.org/api/patches/76397/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1599128029-2092-15-git-send-email-michaelba@nvidia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1599128029-2092-15-git-send-email-michaelba@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1599128029-2092-15-git-send-email-michaelba@nvidia.com", "date": "2020-09-03T10:13:45", "name": "[v1,14/18] net/mlx5: remove indirection table type field", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "bf790c6b5e5549a3082dede03b6e50096ae885bd", "submitter": { "id": 1949, "url": "http://patches.dpdk.org/api/people/1949/?format=api", "name": "Michael Baum", "email": "michaelba@nvidia.com" }, "delegate": { "id": 3268, "url": "http://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1599128029-2092-15-git-send-email-michaelba@nvidia.com/mbox/", "series": [ { "id": 11924, "url": "http://patches.dpdk.org/api/series/11924/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11924", "date": "2020-09-03T10:13:31", "name": "mlx5 Rx DevX/Verbs separation", "version": 1, "mbox": "http://patches.dpdk.org/series/11924/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/76397/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/76397/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A63DAA04DB;\n\tThu, 3 Sep 2020 12:17:09 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id AD82A1C0C0;\n\tThu, 3 Sep 2020 12:15:11 +0200 (CEST)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by dpdk.org (Postfix) with ESMTP id 26B0B1C0AE\n for <dev@dpdk.org>; Thu, 3 Sep 2020 12:15:10 +0200 (CEST)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n michaelba@nvidia.com) with SMTP; 3 Sep 2020 13:15:05 +0300", "from nvidia.com (pegasus07.mtr.labs.mlnx [10.210.16.112])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 083AEP9C031645;\n Thu, 3 Sep 2020 13:15:05 +0300" ], "From": "Michael Baum <michaelba@nvidia.com>", "To": "dev@dpdk.org", "Cc": "Matan Azrad <matan@nvidia.com>, Raslan Darawsheh <rasland@nvidia.com>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>", "Date": "Thu, 3 Sep 2020 10:13:45 +0000", "Message-Id": "<1599128029-2092-15-git-send-email-michaelba@nvidia.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1599128029-2092-1-git-send-email-michaelba@nvidia.com>", "References": "<1599128029-2092-1-git-send-email-michaelba@nvidia.com>", "Subject": "[dpdk-dev] [PATCH v1 14/18] net/mlx5: remove indirection table type\n\tfield", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Once the separation between Verbs and DevX is done using function\npointers, the type field of the indirection table structure becomes\nredundant and no more code is used.\nRemove the unnecessary field from the structure.\n\nSigned-off-by: Michael Baum <michaelba@nvidia.com>\nAcked-by: Matan Azrad <matan@nvidia.com>\n---\n drivers/net/mlx5/linux/mlx5_verbs.c | 1 -\n drivers/net/mlx5/mlx5.h | 6 ------\n drivers/net/mlx5/mlx5_devx.c | 1 -\n 3 files changed, 8 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/linux/mlx5_verbs.c b/drivers/net/mlx5/linux/mlx5_verbs.c\nindex d92dd48..6eef85e 100644\n--- a/drivers/net/mlx5/linux/mlx5_verbs.c\n+++ b/drivers/net/mlx5/linux/mlx5_verbs.c\n@@ -471,7 +471,6 @@\n \t\trte_errno = ENOMEM;\n \t\treturn NULL;\n \t}\n-\tind_tbl->type = MLX5_IND_TBL_TYPE_IBV;\n \tfor (i = 0; i != queues_n; ++i) {\n \t\tstruct mlx5_rxq_ctrl *rxq = mlx5_rxq_get(dev, queues[i]);\n \t\tif (!rxq)\ndiff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h\nindex 9fc4639..9594856 100644\n--- a/drivers/net/mlx5/mlx5.h\n+++ b/drivers/net/mlx5/mlx5.h\n@@ -704,16 +704,10 @@ struct mlx5_rxq_obj {\n \t};\n };\n \n-enum mlx5_ind_tbl_type {\n-\tMLX5_IND_TBL_TYPE_IBV,\n-\tMLX5_IND_TBL_TYPE_DEVX,\n-};\n-\n /* Indirection table. */\n struct mlx5_ind_table_obj {\n \tLIST_ENTRY(mlx5_ind_table_obj) next; /* Pointer to the next element. */\n \trte_atomic32_t refcnt; /* Reference counter. */\n-\tenum mlx5_ind_tbl_type type;\n \tRTE_STD_C11\n \tunion {\n \t\tvoid *ind_table; /**< Indirection table. */\ndiff --git a/drivers/net/mlx5/mlx5_devx.c b/drivers/net/mlx5/mlx5_devx.c\nindex b1b3037..5fa41f1 100644\n--- a/drivers/net/mlx5/mlx5_devx.c\n+++ b/drivers/net/mlx5/mlx5_devx.c\n@@ -639,7 +639,6 @@\n \t\trte_errno = ENOMEM;\n \t\treturn NULL;\n \t}\n-\tind_tbl->type = MLX5_IND_TBL_TYPE_DEVX;\n \trqt_attr = mlx5_malloc(MLX5_MEM_ZERO, sizeof(*rqt_attr) +\n \t\t\t rqt_n * sizeof(uint32_t), 0, SOCKET_ID_ANY);\n \tif (!rqt_attr) {\n", "prefixes": [ "v1", "14/18" ] }