Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/76394/?format=api
{ "id": 76394, "url": "http://patches.dpdk.org/api/patches/76394/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1599128029-2092-11-git-send-email-michaelba@nvidia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1599128029-2092-11-git-send-email-michaelba@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1599128029-2092-11-git-send-email-michaelba@nvidia.com", "date": "2020-09-03T10:13:41", "name": "[v1,10/18] net/mlx5: separate Rx queue object modification", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "d46c4039c015f58bbb550204604a3abaa69ea560", "submitter": { "id": 1949, "url": "http://patches.dpdk.org/api/people/1949/?format=api", "name": "Michael Baum", "email": "michaelba@nvidia.com" }, "delegate": { "id": 3268, "url": "http://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1599128029-2092-11-git-send-email-michaelba@nvidia.com/mbox/", "series": [ { "id": 11924, "url": "http://patches.dpdk.org/api/series/11924/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11924", "date": "2020-09-03T10:13:31", "name": "mlx5 Rx DevX/Verbs separation", "version": 1, "mbox": "http://patches.dpdk.org/series/11924/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/76394/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/76394/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A8FE9A04DB;\n\tThu, 3 Sep 2020 12:16:36 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 454941C0B9;\n\tThu, 3 Sep 2020 12:15:02 +0200 (CEST)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by dpdk.org (Postfix) with ESMTP id 14A111C13B\n for <dev@dpdk.org>; Thu, 3 Sep 2020 12:15:00 +0200 (CEST)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n michaelba@nvidia.com) with SMTP; 3 Sep 2020 13:14:55 +0300", "from nvidia.com (pegasus07.mtr.labs.mlnx [10.210.16.112])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 083AEP98031645;\n Thu, 3 Sep 2020 13:14:55 +0300" ], "From": "Michael Baum <michaelba@nvidia.com>", "To": "dev@dpdk.org", "Cc": "Matan Azrad <matan@nvidia.com>, Raslan Darawsheh <rasland@nvidia.com>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>", "Date": "Thu, 3 Sep 2020 10:13:41 +0000", "Message-Id": "<1599128029-2092-11-git-send-email-michaelba@nvidia.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1599128029-2092-1-git-send-email-michaelba@nvidia.com>", "References": "<1599128029-2092-1-git-send-email-michaelba@nvidia.com>", "Subject": "[dpdk-dev] [PATCH v1 10/18] net/mlx5: separate Rx queue object\n\tmodification", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Separate Rx object modification to the Verbs and DevX modules.\n\nSigned-off-by: Michael Baum <michaelba@nvidia.com>\nAcked-by: Matan Azrad <matan@nvidia.com>\n---\n drivers/net/mlx5/linux/mlx5_verbs.c | 22 ++++++++++++++++++++++\n drivers/net/mlx5/mlx5.h | 1 +\n drivers/net/mlx5/mlx5_devx.c | 27 +++++++++++++++++++++++++++\n drivers/net/mlx5/mlx5_rxq.c | 32 ++------------------------------\n 4 files changed, 52 insertions(+), 30 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/linux/mlx5_verbs.c b/drivers/net/mlx5/linux/mlx5_verbs.c\nindex d9cf911..7d623c8 100644\n--- a/drivers/net/mlx5/linux/mlx5_verbs.c\n+++ b/drivers/net/mlx5/linux/mlx5_verbs.c\n@@ -4,6 +4,7 @@\n \n #include <stddef.h>\n #include <errno.h>\n+#include <stdbool.h>\n #include <string.h>\n #include <stdint.h>\n #include <unistd.h>\n@@ -423,9 +424,30 @@\n \treturn -rte_errno;\n }\n \n+/**\n+ * Modifies the attributes for the specified WQ.\n+ *\n+ * @param rxq_obj\n+ * Verbs Rx queue object.\n+ *\n+ * @return\n+ * 0 on success, a negative errno value otherwise and rte_errno is set.\n+ */\n+static int\n+mlx5_ibv_modify_wq(struct mlx5_rxq_obj *rxq_obj, bool is_start)\n+{\n+\tstruct ibv_wq_attr mod = {\n+\t\t.attr_mask = IBV_WQ_ATTR_STATE,\n+\t\t.wq_state = is_start ? IBV_WQS_RDY : IBV_WQS_RESET,\n+\t};\n+\n+\treturn mlx5_glue->modify_wq(rxq_obj->wq, &mod);\n+}\n+\n struct mlx5_obj_ops ibv_obj_ops = {\n \t.rxq_obj_modify_vlan_strip = mlx5_rxq_obj_modify_wq_vlan_strip,\n \t.rxq_obj_new = mlx5_rxq_ibv_obj_new,\n \t.rxq_event_get = mlx5_rx_ibv_get_event,\n+\t.rxq_obj_modify = mlx5_ibv_modify_wq,\n \t.rxq_obj_release = mlx5_rxq_ibv_obj_release,\n };\ndiff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h\nindex 5131a47..a51c88f 100644\n--- a/drivers/net/mlx5/mlx5.h\n+++ b/drivers/net/mlx5/mlx5.h\n@@ -709,6 +709,7 @@ struct mlx5_obj_ops {\n \tint (*rxq_obj_modify_vlan_strip)(struct mlx5_rxq_obj *rxq_obj, int on);\n \tint (*rxq_obj_new)(struct rte_eth_dev *dev, uint16_t idx);\n \tint (*rxq_event_get)(struct mlx5_rxq_obj *rxq_obj);\n+\tint (*rxq_obj_modify)(struct mlx5_rxq_obj *rxq_obj, bool is_start);\n \tvoid (*rxq_obj_release)(struct mlx5_rxq_obj *rxq_obj);\n };\n \ndiff --git a/drivers/net/mlx5/mlx5_devx.c b/drivers/net/mlx5/mlx5_devx.c\nindex 8bbc664..e577e38 100644\n--- a/drivers/net/mlx5/mlx5_devx.c\n+++ b/drivers/net/mlx5/mlx5_devx.c\n@@ -4,6 +4,7 @@\n \n #include <stddef.h>\n #include <errno.h>\n+#include <stdbool.h>\n #include <string.h>\n #include <stdint.h>\n #include <sys/queue.h>\n@@ -143,6 +144,31 @@\n }\n \n /**\n+ * Modify RQ using DevX API.\n+ *\n+ * @param rxq_obj\n+ * DevX Rx queue object.\n+ *\n+ * @return\n+ * 0 on success, a negative errno value otherwise and rte_errno is set.\n+ */\n+static int\n+mlx5_devx_modify_rq(struct mlx5_rxq_obj *rxq_obj, bool is_start)\n+{\n+\tstruct mlx5_devx_modify_rq_attr rq_attr;\n+\n+\tmemset(&rq_attr, 0, sizeof(rq_attr));\n+\tif (is_start) {\n+\t\trq_attr.rq_state = MLX5_RQC_STATE_RST;\n+\t\trq_attr.state = MLX5_RQC_STATE_RDY;\n+\t} else {\n+\t\trq_attr.rq_state = MLX5_RQC_STATE_RDY;\n+\t\trq_attr.state = MLX5_RQC_STATE_RST;\n+\t}\n+\treturn mlx5_devx_cmd_modify_rq(rxq_obj->rq, &rq_attr);\n+}\n+\n+/**\n * Get event for an Rx DevX queue object.\n *\n * @param rxq_obj\n@@ -605,5 +631,6 @@ struct mlx5_obj_ops devx_obj_ops = {\n \t.rxq_obj_modify_vlan_strip = mlx5_rxq_obj_modify_rq_vlan_strip,\n \t.rxq_obj_new = mlx5_rxq_devx_obj_new,\n \t.rxq_event_get = mlx5_rx_devx_get_event,\n+\t.rxq_obj_modify = mlx5_devx_modify_rq,\n \t.rxq_obj_release = mlx5_rxq_devx_obj_release,\n };\ndiff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c\nindex 3115f5a..c18610d 100644\n--- a/drivers/net/mlx5/mlx5_rxq.c\n+++ b/drivers/net/mlx5/mlx5_rxq.c\n@@ -516,21 +516,7 @@\n \tint ret;\n \n \tMLX5_ASSERT(rte_eal_process_type() == RTE_PROC_PRIMARY);\n-\tif (rxq_ctrl->obj->type == MLX5_RXQ_OBJ_TYPE_IBV) {\n-\t\tstruct ibv_wq_attr mod = {\n-\t\t\t.attr_mask = IBV_WQ_ATTR_STATE,\n-\t\t\t.wq_state = IBV_WQS_RESET,\n-\t\t};\n-\n-\t\tret = mlx5_glue->modify_wq(rxq_ctrl->obj->wq, &mod);\n-\t} else { /* rxq_ctrl->obj->type == MLX5_RXQ_OBJ_TYPE_DEVX_RQ. */\n-\t\tstruct mlx5_devx_modify_rq_attr rq_attr;\n-\n-\t\tmemset(&rq_attr, 0, sizeof(rq_attr));\n-\t\trq_attr.rq_state = MLX5_RQC_STATE_RDY;\n-\t\trq_attr.state = MLX5_RQC_STATE_RST;\n-\t\tret = mlx5_devx_cmd_modify_rq(rxq_ctrl->obj->rq, &rq_attr);\n-\t}\n+\tret = priv->obj_ops->rxq_obj_modify(rxq_ctrl->obj, false);\n \tif (ret) {\n \t\tDRV_LOG(ERR, \"Cannot change Rx WQ state to RESET: %s\",\n \t\t\tstrerror(errno));\n@@ -629,21 +615,7 @@\n \t/* Reset RQ consumer before moving queue to READY state. */\n \t*rxq->rq_db = rte_cpu_to_be_32(0);\n \trte_cio_wmb();\n-\tif (rxq_ctrl->obj->type == MLX5_RXQ_OBJ_TYPE_IBV) {\n-\t\tstruct ibv_wq_attr mod = {\n-\t\t\t.attr_mask = IBV_WQ_ATTR_STATE,\n-\t\t\t.wq_state = IBV_WQS_RDY,\n-\t\t};\n-\n-\t\tret = mlx5_glue->modify_wq(rxq_ctrl->obj->wq, &mod);\n-\t} else { /* rxq_ctrl->obj->type == MLX5_RXQ_OBJ_TYPE_DEVX_RQ. */\n-\t\tstruct mlx5_devx_modify_rq_attr rq_attr;\n-\n-\t\tmemset(&rq_attr, 0, sizeof(rq_attr));\n-\t\trq_attr.rq_state = MLX5_RQC_STATE_RST;\n-\t\trq_attr.state = MLX5_RQC_STATE_RDY;\n-\t\tret = mlx5_devx_cmd_modify_rq(rxq_ctrl->obj->rq, &rq_attr);\n-\t}\n+\tret = priv->obj_ops->rxq_obj_modify(rxq_ctrl->obj, true);\n \tif (ret) {\n \t\tDRV_LOG(ERR, \"Cannot change Rx WQ state to READY: %s\",\n \t\t\tstrerror(errno));\n", "prefixes": [ "v1", "10/18" ] }