Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/76393/?format=api
{ "id": 76393, "url": "http://patches.dpdk.org/api/patches/76393/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1599128029-2092-12-git-send-email-michaelba@nvidia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1599128029-2092-12-git-send-email-michaelba@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1599128029-2092-12-git-send-email-michaelba@nvidia.com", "date": "2020-09-03T10:13:42", "name": "[v1,11/18] net/mlx5: share Rx queue object modification", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "36fa0fa2ac27c6e6e20dba040710ebb5c193bc32", "submitter": { "id": 1949, "url": "http://patches.dpdk.org/api/people/1949/?format=api", "name": "Michael Baum", "email": "michaelba@nvidia.com" }, "delegate": { "id": 3268, "url": "http://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1599128029-2092-12-git-send-email-michaelba@nvidia.com/mbox/", "series": [ { "id": 11924, "url": "http://patches.dpdk.org/api/series/11924/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11924", "date": "2020-09-03T10:13:31", "name": "mlx5 Rx DevX/Verbs separation", "version": 1, "mbox": "http://patches.dpdk.org/series/11924/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/76393/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/76393/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EFDB1A04DB;\n\tThu, 3 Sep 2020 12:16:27 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id EAD681C195;\n\tThu, 3 Sep 2020 12:15:00 +0200 (CEST)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by dpdk.org (Postfix) with ESMTP id 151141C195\n for <dev@dpdk.org>; Thu, 3 Sep 2020 12:15:00 +0200 (CEST)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n michaelba@nvidia.com) with SMTP; 3 Sep 2020 13:14:58 +0300", "from nvidia.com (pegasus07.mtr.labs.mlnx [10.210.16.112])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 083AEP99031645;\n Thu, 3 Sep 2020 13:14:58 +0300" ], "From": "Michael Baum <michaelba@nvidia.com>", "To": "dev@dpdk.org", "Cc": "Matan Azrad <matan@nvidia.com>, Raslan Darawsheh <rasland@nvidia.com>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>", "Date": "Thu, 3 Sep 2020 10:13:42 +0000", "Message-Id": "<1599128029-2092-12-git-send-email-michaelba@nvidia.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1599128029-2092-1-git-send-email-michaelba@nvidia.com>", "References": "<1599128029-2092-1-git-send-email-michaelba@nvidia.com>", "Subject": "[dpdk-dev] [PATCH v1 11/18] net/mlx5: share Rx queue object\n\tmodification", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Use new modify_wq functions for Rx object creation in DevX and Verbs\nmodules.\n\nSigned-off-by: Michael Baum <michaelba@nvidia.com>\nAcked-by: Matan Azrad <matan@nvidia.com>\n---\n drivers/net/mlx5/linux/mlx5_verbs.c | 48 +++++++++++------------\n drivers/net/mlx5/mlx5_devx.c | 76 ++++++++++++++-----------------------\n 2 files changed, 50 insertions(+), 74 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/linux/mlx5_verbs.c b/drivers/net/mlx5/linux/mlx5_verbs.c\nindex 7d623c8..5eb556e 100644\n--- a/drivers/net/mlx5/linux/mlx5_verbs.c\n+++ b/drivers/net/mlx5/linux/mlx5_verbs.c\n@@ -89,6 +89,27 @@\n \t\t.flags_mask = IBV_WQ_FLAGS_CVLAN_STRIPPING,\n \t\t.flags = vlan_offloads,\n \t};\n+\n+\treturn mlx5_glue->modify_wq(rxq_obj->wq, &mod);\n+}\n+\n+/**\n+ * Modifies the attributes for the specified WQ.\n+ *\n+ * @param rxq_obj\n+ * Verbs Rx queue object.\n+ *\n+ * @return\n+ * 0 on success, a negative errno value otherwise and rte_errno is set.\n+ */\n+static int\n+mlx5_ibv_modify_wq(struct mlx5_rxq_obj *rxq_obj, bool is_start)\n+{\n+\tstruct ibv_wq_attr mod = {\n+\t\t.attr_mask = IBV_WQ_ATTR_STATE,\n+\t\t.wq_state = is_start ? IBV_WQS_RDY : IBV_WQS_RESET,\n+\t};\n+\n \treturn mlx5_glue->modify_wq(rxq_obj->wq, &mod);\n }\n \n@@ -273,7 +294,6 @@\n \tstruct mlx5_rxq_data *rxq_data = (*priv->rxqs)[idx];\n \tstruct mlx5_rxq_ctrl *rxq_ctrl =\n \t\tcontainer_of(rxq_data, struct mlx5_rxq_ctrl, rxq);\n-\tstruct ibv_wq_attr mod;\n \tstruct mlx5_rxq_obj *tmpl = rxq_ctrl->obj;\n \tstruct mlx5dv_cq cq_info;\n \tstruct mlx5dv_rwq rwq;\n@@ -335,11 +355,7 @@\n \t\tgoto error;\n \t}\n \t/* Change queue state to ready. */\n-\tmod = (struct ibv_wq_attr){\n-\t\t.attr_mask = IBV_WQ_ATTR_STATE,\n-\t\t.wq_state = IBV_WQS_RDY,\n-\t};\n-\tret = mlx5_glue->modify_wq(tmpl->wq, &mod);\n+\tret = mlx5_ibv_modify_wq(tmpl, true);\n \tif (ret) {\n \t\tDRV_LOG(ERR,\n \t\t\t\"Port %u Rx queue %u WQ state to IBV_WQS_RDY failed.\",\n@@ -424,26 +440,6 @@\n \treturn -rte_errno;\n }\n \n-/**\n- * Modifies the attributes for the specified WQ.\n- *\n- * @param rxq_obj\n- * Verbs Rx queue object.\n- *\n- * @return\n- * 0 on success, a negative errno value otherwise and rte_errno is set.\n- */\n-static int\n-mlx5_ibv_modify_wq(struct mlx5_rxq_obj *rxq_obj, bool is_start)\n-{\n-\tstruct ibv_wq_attr mod = {\n-\t\t.attr_mask = IBV_WQ_ATTR_STATE,\n-\t\t.wq_state = is_start ? IBV_WQS_RDY : IBV_WQS_RESET,\n-\t};\n-\n-\treturn mlx5_glue->modify_wq(rxq_obj->wq, &mod);\n-}\n-\n struct mlx5_obj_ops ibv_obj_ops = {\n \t.rxq_obj_modify_vlan_strip = mlx5_rxq_obj_modify_wq_vlan_strip,\n \t.rxq_obj_new = mlx5_rxq_ibv_obj_new,\ndiff --git a/drivers/net/mlx5/mlx5_devx.c b/drivers/net/mlx5/mlx5_devx.c\nindex e577e38..07922c2 100644\n--- a/drivers/net/mlx5/mlx5_devx.c\n+++ b/drivers/net/mlx5/mlx5_devx.c\n@@ -47,6 +47,31 @@\n }\n \n /**\n+ * Modify RQ using DevX API.\n+ *\n+ * @param rxq_obj\n+ * DevX Rx queue object.\n+ *\n+ * @return\n+ * 0 on success, a negative errno value otherwise and rte_errno is set.\n+ */\n+static int\n+mlx5_devx_modify_rq(struct mlx5_rxq_obj *rxq_obj, bool is_start)\n+{\n+\tstruct mlx5_devx_modify_rq_attr rq_attr;\n+\n+\tmemset(&rq_attr, 0, sizeof(rq_attr));\n+\tif (is_start) {\n+\t\trq_attr.rq_state = MLX5_RQC_STATE_RST;\n+\t\trq_attr.state = MLX5_RQC_STATE_RDY;\n+\t} else {\n+\t\trq_attr.rq_state = MLX5_RQC_STATE_RDY;\n+\t\trq_attr.state = MLX5_RQC_STATE_RST;\n+\t}\n+\treturn mlx5_devx_cmd_modify_rq(rxq_obj->rq, &rq_attr);\n+}\n+\n+/**\n * Release the resources allocated for an RQ DevX object.\n *\n * @param rxq_ctrl\n@@ -101,24 +126,6 @@\n }\n \n /**\n- * Release an Rx hairpin related resources.\n- *\n- * @param rxq_obj\n- * Hairpin Rx queue object.\n- */\n-static void\n-mlx5_rxq_obj_hairpin_release(struct mlx5_rxq_obj *rxq_obj)\n-{\n-\tstruct mlx5_devx_modify_rq_attr rq_attr = { 0 };\n-\n-\tMLX5_ASSERT(rxq_obj);\n-\trq_attr.state = MLX5_RQC_STATE_RST;\n-\trq_attr.rq_state = MLX5_RQC_STATE_RDY;\n-\tmlx5_devx_cmd_modify_rq(rxq_obj->rq, &rq_attr);\n-\tclaim_zero(mlx5_devx_cmd_destroy(rxq_obj->rq));\n-}\n-\n-/**\n * Release an Rx DevX queue object.\n *\n * @param rxq_obj\n@@ -130,7 +137,8 @@\n \tMLX5_ASSERT(rxq_obj);\n \tMLX5_ASSERT(rxq_obj->rq);\n \tif (rxq_obj->type == MLX5_RXQ_OBJ_TYPE_DEVX_HAIRPIN) {\n-\t\tmlx5_rxq_obj_hairpin_release(rxq_obj);\n+\t\tmlx5_devx_modify_rq(rxq_obj, false);\n+\t\tclaim_zero(mlx5_devx_cmd_destroy(rxq_obj->rq));\n \t} else {\n \t\tMLX5_ASSERT(rxq_obj->devx_cq);\n \t\tclaim_zero(mlx5_devx_cmd_destroy(rxq_obj->rq));\n@@ -144,31 +152,6 @@\n }\n \n /**\n- * Modify RQ using DevX API.\n- *\n- * @param rxq_obj\n- * DevX Rx queue object.\n- *\n- * @return\n- * 0 on success, a negative errno value otherwise and rte_errno is set.\n- */\n-static int\n-mlx5_devx_modify_rq(struct mlx5_rxq_obj *rxq_obj, bool is_start)\n-{\n-\tstruct mlx5_devx_modify_rq_attr rq_attr;\n-\n-\tmemset(&rq_attr, 0, sizeof(rq_attr));\n-\tif (is_start) {\n-\t\trq_attr.rq_state = MLX5_RQC_STATE_RST;\n-\t\trq_attr.state = MLX5_RQC_STATE_RDY;\n-\t} else {\n-\t\trq_attr.rq_state = MLX5_RQC_STATE_RDY;\n-\t\trq_attr.state = MLX5_RQC_STATE_RST;\n-\t}\n-\treturn mlx5_devx_cmd_modify_rq(rxq_obj->rq, &rq_attr);\n-}\n-\n-/**\n * Get event for an Rx DevX queue object.\n *\n * @param rxq_obj\n@@ -563,7 +546,6 @@\n \tstruct mlx5_rxq_ctrl *rxq_ctrl =\n \t\tcontainer_of(rxq_data, struct mlx5_rxq_ctrl, rxq);\n \tstruct mlx5_rxq_obj *tmpl = rxq_ctrl->obj;\n-\tstruct mlx5_devx_modify_rq_attr rq_attr = { 0 };\n \tint ret = 0;\n \n \tMLX5_ASSERT(rxq_data);\n@@ -602,9 +584,7 @@\n \t\tgoto error;\n \t}\n \t/* Change queue state to ready. */\n-\trq_attr.rq_state = MLX5_RQC_STATE_RST;\n-\trq_attr.state = MLX5_RQC_STATE_RDY;\n-\tret = mlx5_devx_cmd_modify_rq(tmpl->rq, &rq_attr);\n+\tret = mlx5_devx_modify_rq(tmpl, true);\n \tif (ret)\n \t\tgoto error;\n \trxq_data->cq_arm_sn = 0;\n", "prefixes": [ "v1", "11/18" ] }