Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/76120/?format=api
{ "id": 76120, "url": "http://patches.dpdk.org/api/patches/76120/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200828050112.19482-4-kalesh-anakkur.purayil@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200828050112.19482-4-kalesh-anakkur.purayil@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200828050112.19482-4-kalesh-anakkur.purayil@broadcom.com", "date": "2020-08-28T05:01:09", "name": "[3/6] net/bnxt: fix to initialize structure variable", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "fcb9ea045fe165c70caa017cea04ce2a7eb5a263", "submitter": { "id": 1479, "url": "http://patches.dpdk.org/api/people/1479/?format=api", "name": "Kalesh A P", "email": "kalesh-anakkur.purayil@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200828050112.19482-4-kalesh-anakkur.purayil@broadcom.com/mbox/", "series": [ { "id": 11835, "url": "http://patches.dpdk.org/api/series/11835/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11835", "date": "2020-08-28T05:01:06", "name": "bnxt bug fixes", "version": 1, "mbox": "http://patches.dpdk.org/series/11835/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/76120/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/76120/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 98728A04B1;\n\tFri, 28 Aug 2020 06:46:43 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id DF8AB1C0AE;\n\tFri, 28 Aug 2020 06:46:21 +0200 (CEST)", "from relay.smtp.broadcom.com (unknown [192.19.211.62])\n by dpdk.org (Postfix) with ESMTP id B47B51F1C\n for <dev@dpdk.org>; Fri, 28 Aug 2020 06:46:16 +0200 (CEST)", "from dhcp-10-123-153-22.dhcp.broadcom.net\n (bgccx-dev-host-lnx2.bec.broadcom.net [10.123.153.22])\n by relay.smtp.broadcom.com (Postfix) with ESMTP id 8021829D651;\n Thu, 27 Aug 2020 21:46:15 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 relay.smtp.broadcom.com 8021829D651", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1598589975;\n bh=FEEFK0JOoeu/5st4LSjkksdKPPORz2IAVh93rW01AJU=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=fbytRd3OsQF1A8yZOTA+lFm3kuHTJUsu3kfvsqZbNydF6US/s6NRYXXsUIp5blC0O\n mN2+tijOMukXXBrRjnaB0zqF7M7dBUT4d1tmc95M2/wss2xfM4Oo2bp3XjpRhwmMjg\n dqxD5gTkYtiLlB1mABDbNd1YbIeiAxW8oacfqpLc=", "From": "Kalesh A P <kalesh-anakkur.purayil@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com,\n\tajit.khaparde@broadcom.com", "Date": "Fri, 28 Aug 2020 10:31:09 +0530", "Message-Id": "<20200828050112.19482-4-kalesh-anakkur.purayil@broadcom.com>", "X-Mailer": "git-send-email 2.10.1", "In-Reply-To": "<20200828050112.19482-1-kalesh-anakkur.purayil@broadcom.com>", "References": "<20200828050112.19482-1-kalesh-anakkur.purayil@broadcom.com>", "Subject": "[dpdk-dev] [PATCH 3/6] net/bnxt: fix to initialize structure\n\tvariable", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\n\nDuring port start if bnxt_alloc_all_hwrm_stat_ctxs() fails,\nin the cleanup path we do see errors like below:\n\nbnxt_hwrm_ring_free(): hwrm_ring_free cp failed. rc:2\nbnxt_hwrm_ring_free(): hwrm_ring_free rx failed. rc:2\n\nThe reason for this is in bnxt_free_all_hwrm_rings(), the check\nis made against \"ring->fw_ring_id != INVALID_HW_RING_ID\" which\nalways return true as ring->fw_ring_id is not set to INVALID_HW_RING_ID\nwhile initialising the ring structs.\n\nFixes: 6eb3cc2294fd (\"net/bnxt: add initial Tx code\")\nFixes: 2eb53b134aae (\"net/bnxt: add initial Rx code\")\nCc: stable@dpdk.org\n\nSigned-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\nReviewed-by: Lance Richardson <lance.richardson@broadcom.com>\nReviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt_ring.c | 1 +\n drivers/net/bnxt/bnxt_rxr.c | 3 +++\n drivers/net/bnxt/bnxt_txr.c | 2 ++\n 3 files changed, 6 insertions(+)", "diff": "diff --git a/drivers/net/bnxt/bnxt_ring.c b/drivers/net/bnxt/bnxt_ring.c\nindex 54f6547..8f2296b 100644\n--- a/drivers/net/bnxt/bnxt_ring.c\n+++ b/drivers/net/bnxt/bnxt_ring.c\n@@ -451,6 +451,7 @@ int bnxt_alloc_rxtx_nq_ring(struct bnxt *bp)\n \tring->ring_mask = ring->ring_size - 1;\n \tring->vmem_size = 0;\n \tring->vmem = NULL;\n+\tring->fw_ring_id = INVALID_HW_RING_ID;\n \n \tnqr->cp_ring_struct = ring;\n \trc = bnxt_alloc_rings(bp, 0, NULL, NULL, nqr, NULL, \"l2_nqr\");\ndiff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c\nindex 43b1256..b086898 100644\n--- a/drivers/net/bnxt/bnxt_rxr.c\n+++ b/drivers/net/bnxt/bnxt_rxr.c\n@@ -962,6 +962,7 @@ int bnxt_init_rx_ring_struct(struct bnxt_rx_queue *rxq, unsigned int socket_id)\n \tring->bd_dma = rxr->rx_desc_mapping;\n \tring->vmem_size = ring->ring_size * sizeof(struct bnxt_sw_rx_bd);\n \tring->vmem = (void **)&rxr->rx_buf_ring;\n+\tring->fw_ring_id = INVALID_HW_RING_ID;\n \n \tcpr = rte_zmalloc_socket(\"bnxt_rx_ring\",\n \t\t\t\t sizeof(struct bnxt_cp_ring_info),\n@@ -983,6 +984,7 @@ int bnxt_init_rx_ring_struct(struct bnxt_rx_queue *rxq, unsigned int socket_id)\n \tring->bd_dma = cpr->cp_desc_mapping;\n \tring->vmem_size = 0;\n \tring->vmem = NULL;\n+\tring->fw_ring_id = INVALID_HW_RING_ID;\n \n \t/* Allocate Aggregator rings */\n \tring = rte_zmalloc_socket(\"bnxt_rx_ring_struct\",\n@@ -998,6 +1000,7 @@ int bnxt_init_rx_ring_struct(struct bnxt_rx_queue *rxq, unsigned int socket_id)\n \tring->bd_dma = rxr->ag_desc_mapping;\n \tring->vmem_size = ring->ring_size * sizeof(struct bnxt_sw_rx_bd);\n \tring->vmem = (void **)&rxr->ag_buf_ring;\n+\tring->fw_ring_id = INVALID_HW_RING_ID;\n \n \treturn 0;\n }\ndiff --git a/drivers/net/bnxt/bnxt_txr.c b/drivers/net/bnxt/bnxt_txr.c\nindex c7a2de6..2068331 100644\n--- a/drivers/net/bnxt/bnxt_txr.c\n+++ b/drivers/net/bnxt/bnxt_txr.c\n@@ -78,6 +78,7 @@ int bnxt_init_tx_ring_struct(struct bnxt_tx_queue *txq, unsigned int socket_id)\n \tring->bd_dma = txr->tx_desc_mapping;\n \tring->vmem_size = ring->ring_size * sizeof(struct bnxt_sw_tx_bd);\n \tring->vmem = (void **)&txr->tx_buf_ring;\n+\tring->fw_ring_id = INVALID_HW_RING_ID;\n \n \tcpr = rte_zmalloc_socket(\"bnxt_tx_ring\",\n \t\t\t\t sizeof(struct bnxt_cp_ring_info),\n@@ -98,6 +99,7 @@ int bnxt_init_tx_ring_struct(struct bnxt_tx_queue *txq, unsigned int socket_id)\n \tring->bd_dma = cpr->cp_desc_mapping;\n \tring->vmem_size = 0;\n \tring->vmem = NULL;\n+\tring->fw_ring_id = INVALID_HW_RING_ID;\n \n \treturn 0;\n }\n", "prefixes": [ "3/6" ] }