Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/76079/?format=api
{ "id": 76079, "url": "http://patches.dpdk.org/api/patches/76079/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200827101008.76906-2-jia.guo@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200827101008.76906-2-jia.guo@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200827101008.76906-2-jia.guo@intel.com", "date": "2020-08-27T10:10:04", "name": "[v2,1/5] net/ixgbe: maximize vector rx burst for ixgbe", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "80d608f9cd8bb4c7296581003ed649b12f20c749", "submitter": { "id": 507, "url": "http://patches.dpdk.org/api/people/507/?format=api", "name": "Guo, Jia", "email": "jia.guo@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200827101008.76906-2-jia.guo@intel.com/mbox/", "series": [ { "id": 11826, "url": "http://patches.dpdk.org/api/series/11826/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11826", "date": "2020-08-27T10:10:03", "name": "maximize vector rx burst for PMDs", "version": 2, "mbox": "http://patches.dpdk.org/series/11826/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/76079/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/76079/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5EEB1A04B1;\n\tThu, 27 Aug 2020 12:13:19 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 411BD1C199;\n\tThu, 27 Aug 2020 12:13:13 +0200 (CEST)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n by dpdk.org (Postfix) with ESMTP id D36981C191\n for <dev@dpdk.org>; Thu, 27 Aug 2020 12:13:11 +0200 (CEST)", "from orsmga005.jf.intel.com ([10.7.209.41])\n by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 27 Aug 2020 03:13:11 -0700", "from npg-dpdk-cvl-jeffguo-01.sh.intel.com ([10.67.111.128])\n by orsmga005.jf.intel.com with ESMTP; 27 Aug 2020 03:13:08 -0700" ], "IronPort-SDR": [ "\n yEKuNWj+V+2VLOOEeOCoPSy1lcyMk1lwwPeEuMbVfAENsvuG0mVLP3Spb3gxzbGmzL1xQvxgLM\n 1ROFssoSbUaw==", "\n mHWvMNyrIW8CX0KqPsB3rCiDrFcAzW9z83aSNT1QZX9tCqDqchLMcJMnErCtFX9FbO8buWgdYY\n uezaANz0Z6lQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9725\"; a=\"155712651\"", "E=Sophos;i=\"5.76,359,1592895600\"; d=\"scan'208\";a=\"155712651\"", "E=Sophos;i=\"5.76,359,1592895600\"; d=\"scan'208\";a=\"475150440\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Jeff Guo <jia.guo@intel.com>", "To": "qiming.yang@intel.com, beilei.xing@intel.com, wei.zhao1@intel.com,\n qi.z.zhang@intel.com, jingjing.wu@intel.com", "Cc": "bruce.richardson@intel.com, dev@dpdk.org, jia.guo@intel.com,\n helin.zhang@intel.com, mb@smartsharesystems.com, ferruh.yigit@intel.com,\n barbette@kth.se", "Date": "Thu, 27 Aug 2020 18:10:04 +0800", "Message-Id": "<20200827101008.76906-2-jia.guo@intel.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200827101008.76906-1-jia.guo@intel.com>", "References": "<20200827101008.76906-1-jia.guo@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 1/5] net/ixgbe: maximize vector rx burst for\n\tixgbe", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The limitation of burst size in vector rx was removed, since it should\nretrieve as much received packets as possible. And also the scattered\nreceive path should use a wrapper function to achieve the goal of\nburst maximizing.\n\nSigned-off-by: Jeff Guo <jia.guo@intel.com>\n---\n drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c | 72 +++++++++++++------------\n drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c | 56 ++++++++++---------\n 2 files changed, 68 insertions(+), 60 deletions(-)", "diff": "diff --git a/drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c b/drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c\nindex aa27ee177..580a5ed12 100644\n--- a/drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c\n+++ b/drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c\n@@ -130,17 +130,6 @@ desc_to_olflags_v(uint8x16x2_t sterr_tmp1, uint8x16x2_t sterr_tmp2,\n \trx_pkts[3]->ol_flags = vol.e[3];\n }\n \n-/*\n- * vPMD raw receive routine, only accept(nb_pkts >= RTE_IXGBE_DESCS_PER_LOOP)\n- *\n- * Notice:\n- * - nb_pkts < RTE_IXGBE_DESCS_PER_LOOP, just return no packet\n- * - nb_pkts > RTE_IXGBE_MAX_RX_BURST, only scan RTE_IXGBE_MAX_RX_BURST\n- * numbers of DD bit\n- * - floor align nb_pkts to a RTE_IXGBE_DESC_PER_LOOP power-of-two\n- * - don't support ol_flags for rss and csum err\n- */\n-\n #define IXGBE_VPMD_DESC_EOP_MASK\t0x02020202\n #define IXGBE_UINT8_BIT\t\t\t(CHAR_BIT * sizeof(uint8_t))\n \n@@ -206,6 +195,13 @@ desc_to_ptype_v(uint64x2_t descs[4], uint16_t pkt_type_mask,\n \t\t\t\tvgetq_lane_u32(tunnel_check, 3));\n }\n \n+/**\n+ * vPMD raw receive routine, only accept(nb_pkts >= RTE_IXGBE_DESCS_PER_LOOP)\n+ *\n+ * Notice:\n+ * - nb_pkts < RTE_IXGBE_DESCS_PER_LOOP, just return no packet\n+ * - floor align nb_pkts to a RTE_IXGBE_DESC_PER_LOOP power-of-two\n+ */\n static inline uint16_t\n _recv_raw_pkts_vec(struct ixgbe_rx_queue *rxq, struct rte_mbuf **rx_pkts,\n \t\t uint16_t nb_pkts, uint8_t *split_packet)\n@@ -226,9 +222,6 @@ _recv_raw_pkts_vec(struct ixgbe_rx_queue *rxq, struct rte_mbuf **rx_pkts,\n \tuint16x8_t crc_adjust = {0, 0, rxq->crc_len, 0,\n \t\t\t\t rxq->crc_len, 0, 0, 0};\n \n-\t/* nb_pkts shall be less equal than RTE_IXGBE_MAX_RX_BURST */\n-\tnb_pkts = RTE_MIN(nb_pkts, RTE_IXGBE_MAX_RX_BURST);\n-\n \t/* nb_pkts has to be floor-aligned to RTE_IXGBE_DESCS_PER_LOOP */\n \tnb_pkts = RTE_ALIGN_FLOOR(nb_pkts, RTE_IXGBE_DESCS_PER_LOOP);\n \n@@ -382,16 +375,6 @@ _recv_raw_pkts_vec(struct ixgbe_rx_queue *rxq, struct rte_mbuf **rx_pkts,\n \treturn nb_pkts_recd;\n }\n \n-/*\n- * vPMD receive routine, only accept(nb_pkts >= RTE_IXGBE_DESCS_PER_LOOP)\n- *\n- * Notice:\n- * - nb_pkts < RTE_IXGBE_DESCS_PER_LOOP, just return no packet\n- * - nb_pkts > RTE_IXGBE_MAX_RX_BURST, only scan RTE_IXGBE_MAX_RX_BURST\n- * numbers of DD bit\n- * - floor align nb_pkts to a RTE_IXGBE_DESC_PER_LOOP power-of-two\n- * - don't support ol_flags for rss and csum err\n- */\n uint16_t\n ixgbe_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,\n \t\tuint16_t nb_pkts)\n@@ -399,19 +382,12 @@ ixgbe_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,\n \treturn _recv_raw_pkts_vec(rx_queue, rx_pkts, nb_pkts, NULL);\n }\n \n-/*\n+/**\n * vPMD receive routine that reassembles scattered packets\n- *\n- * Notice:\n- * - don't support ol_flags for rss and csum err\n- * - nb_pkts < RTE_IXGBE_DESCS_PER_LOOP, just return no packet\n- * - nb_pkts > RTE_IXGBE_MAX_RX_BURST, only scan RTE_IXGBE_MAX_RX_BURST\n- * numbers of DD bit\n- * - floor align nb_pkts to a RTE_IXGBE_DESC_PER_LOOP power-of-two\n */\n-uint16_t\n-ixgbe_recv_scattered_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,\n-\t\tuint16_t nb_pkts)\n+static uint16_t\n+ixgbe_recv_scattered_burst_vec(void *rx_queue, struct rte_mbuf **rx_pkts,\n+\t\t\t uint16_t nb_pkts)\n {\n \tstruct ixgbe_rx_queue *rxq = rx_queue;\n \tuint8_t split_flags[RTE_IXGBE_MAX_RX_BURST] = {0};\n@@ -443,6 +419,32 @@ ixgbe_recv_scattered_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,\n \t\t&split_flags[i]);\n }\n \n+/**\n+ * vPMD receive routine that reassembles scattered packets.\n+ */\n+uint16_t\n+ixgbe_recv_scattered_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,\n+\t\t\t uint16_t nb_pkts)\n+{\n+\tuint16_t retval = 0;\n+\n+\twhile (nb_pkts > RTE_IXGBE_MAX_RX_BURST) {\n+\t\tuint16_t burst;\n+\n+\t\tburst = ixgbe_recv_scattered_burst_vec(rx_queue,\n+\t\t\t\t\t\t rx_pkts + retval,\n+\t\t\t\t\t\t RTE_IXGBE_MAX_RX_BURST);\n+\t\tretval += burst;\n+\t\tnb_pkts -= burst;\n+\t\tif (burst < RTE_IXGBE_MAX_RX_BURST)\n+\t\t\treturn retval;\n+\t}\n+\n+\treturn retval + ixgbe_recv_scattered_burst_vec(rx_queue,\n+\t\t\t\t\t\t rx_pkts + retval,\n+\t\t\t\t\t\t nb_pkts);\n+}\n+\n static inline void\n vtx1(volatile union ixgbe_adv_tx_desc *txdp,\n \t\tstruct rte_mbuf *pkt, uint64_t flags)\ndiff --git a/drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c b/drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c\nindex 517ca3166..fb381ca04 100644\n--- a/drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c\n+++ b/drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c\n@@ -302,13 +302,11 @@ desc_to_ptype_v(__m128i descs[4], uint16_t pkt_type_mask,\n \t\tget_packet_type(3, pkt_info, etqf_check, tunnel_check);\n }\n \n-/*\n+/**\n * vPMD raw receive routine, only accept(nb_pkts >= RTE_IXGBE_DESCS_PER_LOOP)\n *\n * Notice:\n * - nb_pkts < RTE_IXGBE_DESCS_PER_LOOP, just return no packet\n- * - nb_pkts > RTE_IXGBE_MAX_RX_BURST, only scan RTE_IXGBE_MAX_RX_BURST\n- * numbers of DD bit\n * - floor align nb_pkts to a RTE_IXGBE_DESC_PER_LOOP power-of-two\n */\n static inline uint16_t\n@@ -344,9 +342,6 @@ _recv_raw_pkts_vec(struct ixgbe_rx_queue *rxq, struct rte_mbuf **rx_pkts,\n \t__m128i mbuf_init;\n \tuint8_t vlan_flags;\n \n-\t/* nb_pkts shall be less equal than RTE_IXGBE_MAX_RX_BURST */\n-\tnb_pkts = RTE_MIN(nb_pkts, RTE_IXGBE_MAX_RX_BURST);\n-\n \t/* nb_pkts has to be floor-aligned to RTE_IXGBE_DESCS_PER_LOOP */\n \tnb_pkts = RTE_ALIGN_FLOOR(nb_pkts, RTE_IXGBE_DESCS_PER_LOOP);\n \n@@ -556,15 +551,6 @@ _recv_raw_pkts_vec(struct ixgbe_rx_queue *rxq, struct rte_mbuf **rx_pkts,\n \treturn nb_pkts_recd;\n }\n \n-/*\n- * vPMD receive routine, only accept(nb_pkts >= RTE_IXGBE_DESCS_PER_LOOP)\n- *\n- * Notice:\n- * - nb_pkts < RTE_IXGBE_DESCS_PER_LOOP, just return no packet\n- * - nb_pkts > RTE_IXGBE_MAX_RX_BURST, only scan RTE_IXGBE_MAX_RX_BURST\n- * numbers of DD bit\n- * - floor align nb_pkts to a RTE_IXGBE_DESC_PER_LOOP power-of-two\n- */\n uint16_t\n ixgbe_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,\n \t\tuint16_t nb_pkts)\n@@ -572,18 +558,12 @@ ixgbe_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,\n \treturn _recv_raw_pkts_vec(rx_queue, rx_pkts, nb_pkts, NULL);\n }\n \n-/*\n+/**\n * vPMD receive routine that reassembles scattered packets\n- *\n- * Notice:\n- * - nb_pkts < RTE_IXGBE_DESCS_PER_LOOP, just return no packet\n- * - nb_pkts > RTE_IXGBE_MAX_RX_BURST, only scan RTE_IXGBE_MAX_RX_BURST\n- * numbers of DD bit\n- * - floor align nb_pkts to a RTE_IXGBE_DESC_PER_LOOP power-of-two\n */\n-uint16_t\n-ixgbe_recv_scattered_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,\n-\t\tuint16_t nb_pkts)\n+static uint16_t\n+ixgbe_recv_scattered_burst_vec(void *rx_queue, struct rte_mbuf **rx_pkts,\n+\t\t\t uint16_t nb_pkts)\n {\n \tstruct ixgbe_rx_queue *rxq = rx_queue;\n \tuint8_t split_flags[RTE_IXGBE_MAX_RX_BURST] = {0};\n@@ -615,6 +595,32 @@ ixgbe_recv_scattered_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,\n \t\t&split_flags[i]);\n }\n \n+/**\n+ * vPMD receive routine that reassembles scattered packets.\n+ */\n+uint16_t\n+ixgbe_recv_scattered_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,\n+\t\t\t uint16_t nb_pkts)\n+{\n+\tuint16_t retval = 0;\n+\n+\twhile (nb_pkts > RTE_IXGBE_MAX_RX_BURST) {\n+\t\tuint16_t burst;\n+\n+\t\tburst = ixgbe_recv_scattered_burst_vec(rx_queue,\n+\t\t\t\t\t\t rx_pkts + retval,\n+\t\t\t\t\t\t RTE_IXGBE_MAX_RX_BURST);\n+\t\tretval += burst;\n+\t\tnb_pkts -= burst;\n+\t\tif (burst < RTE_IXGBE_MAX_RX_BURST)\n+\t\t\treturn retval;\n+\t}\n+\n+\treturn retval + ixgbe_recv_scattered_burst_vec(rx_queue,\n+\t\t\t\t\t\t rx_pkts + retval,\n+\t\t\t\t\t\t nb_pkts);\n+}\n+\n static inline void\n vtx1(volatile union ixgbe_adv_tx_desc *txdp,\n \t\tstruct rte_mbuf *pkt, uint64_t flags)\n", "prefixes": [ "v2", "1/5" ] }