Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/75617/?format=api
{ "id": 75617, "url": "http://patches.dpdk.org/api/patches/75617/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200818120254.72792-3-huwei013@chinasoftinc.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200818120254.72792-3-huwei013@chinasoftinc.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200818120254.72792-3-huwei013@chinasoftinc.com", "date": "2020-08-18T12:02:52", "name": "[2/4] app/testpmd: fix VLAN offload configuration when config fail", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f4cb1b255246206b3e3735bc16d56fa2fc8efe14", "submitter": { "id": 1537, "url": "http://patches.dpdk.org/api/people/1537/?format=api", "name": "Wei Hu (Xavier)", "email": "huwei013@chinasoftinc.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200818120254.72792-3-huwei013@chinasoftinc.com/mbox/", "series": [ { "id": 11684, "url": "http://patches.dpdk.org/api/series/11684/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11684", "date": "2020-08-18T12:02:50", "name": "minor fixes for testpmd", "version": 1, "mbox": "http://patches.dpdk.org/series/11684/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/75617/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/75617/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 02730A034C;\n\tTue, 18 Aug 2020 14:03:31 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 7D2961C0B1;\n\tTue, 18 Aug 2020 14:03:16 +0200 (CEST)", "from mail.chinasoftinc.com (unknown [114.113.233.8])\n by dpdk.org (Postfix) with ESMTP id 16C471C014\n for <dev@dpdk.org>; Tue, 18 Aug 2020 14:03:11 +0200 (CEST)", "from localhost.localdomain (120.133.139.157) by INCCAS001.ito.icss\n (10.168.0.60) with Microsoft SMTP Server id 14.3.487.0; Tue, 18 Aug 2020\n 20:03:01 +0800" ], "From": "\"Wei Hu (Xavier)\" <huwei013@chinasoftinc.com>", "To": "Wenzhuo Lu <wenzhuo.lu@intel.com>, Beilei Xing <beilei.xing@intel.com>,\n Bernard Iremonger <bernard.iremonger@intel.com>, Shahaf Shuler\n <shahafs@mellanox.com>", "CC": "<dev@dpdk.org>, <xavier.huwei@huawei.com>", "Date": "Tue, 18 Aug 2020 20:02:52 +0800", "Message-ID": "<20200818120254.72792-3-huwei013@chinasoftinc.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200818120254.72792-1-huwei013@chinasoftinc.com>", "References": "<20200818120254.72792-1-huwei013@chinasoftinc.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[120.133.139.157]", "Subject": "[dpdk-dev] [PATCH 2/4] app/testpmd: fix VLAN offload configuration\n\twhen config fail", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Chengchang Tang <tangchengchang@huawei.com>\n\nWhen failing to configure VLAN offloads after the port was started, there\nis no need to update the port configuration. Currently, when user\nconfigure an unsupported VLAN offloads and fails, and then restart the\nport, it will fails since the configuration has been refreshed.\n\nThis patch makes the function return directly insead of refreshing the\nconfiguration when execution fails.\n\nFixes: 384161e00627 (\"app/testpmd: adjust on the fly VLAN configuration\")\nCc: stable@dpdk.org\n\nSigned-off-by: Chengchang Tang <tangchengchang@huawei.com>\nSigned-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>\n---\n app/test-pmd/config.c | 16 ++++++++++++----\n 1 file changed, 12 insertions(+), 4 deletions(-)", "diff": "diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c\nindex 30bee3324..6e8e05ab1 100644\n--- a/app/test-pmd/config.c\n+++ b/app/test-pmd/config.c\n@@ -3390,9 +3390,11 @@ vlan_extend_set(portid_t port_id, int on)\n \t}\n \n \tdiag = rte_eth_dev_set_vlan_offload(port_id, vlan_offload);\n-\tif (diag < 0)\n+\tif (diag < 0) {\n \t\tprintf(\"rx_vlan_extend_set(port_pi=%d, on=%d) failed \"\n \t \"diag=%d\\n\", port_id, on, diag);\n+\t\treturn;\n+\t}\n \tports[port_id].dev_conf.rxmode.offloads = port_rx_offloads;\n }\n \n@@ -3417,9 +3419,11 @@ rx_vlan_strip_set(portid_t port_id, int on)\n \t}\n \n \tdiag = rte_eth_dev_set_vlan_offload(port_id, vlan_offload);\n-\tif (diag < 0)\n+\tif (diag < 0) {\n \t\tprintf(\"rx_vlan_strip_set(port_pi=%d, on=%d) failed \"\n \t \"diag=%d\\n\", port_id, on, diag);\n+\t\treturn;\n+\t}\n \tports[port_id].dev_conf.rxmode.offloads = port_rx_offloads;\n }\n \n@@ -3458,9 +3462,11 @@ rx_vlan_filter_set(portid_t port_id, int on)\n \t}\n \n \tdiag = rte_eth_dev_set_vlan_offload(port_id, vlan_offload);\n-\tif (diag < 0)\n+\tif (diag < 0) {\n \t\tprintf(\"rx_vlan_filter_set(port_pi=%d, on=%d) failed \"\n \t \"diag=%d\\n\", port_id, on, diag);\n+\t\treturn;\n+\t}\n \tports[port_id].dev_conf.rxmode.offloads = port_rx_offloads;\n }\n \n@@ -3485,9 +3491,11 @@ rx_vlan_qinq_strip_set(portid_t port_id, int on)\n \t}\n \n \tdiag = rte_eth_dev_set_vlan_offload(port_id, vlan_offload);\n-\tif (diag < 0)\n+\tif (diag < 0) {\n \t\tprintf(\"%s(port_pi=%d, on=%d) failed \"\n \t \"diag=%d\\n\", __func__, port_id, on, diag);\n+\t\treturn;\n+\t}\n \tports[port_id].dev_conf.rxmode.offloads = port_rx_offloads;\n }\n \n", "prefixes": [ "2/4" ] }