Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/75616/?format=api
{ "id": 75616, "url": "http://patches.dpdk.org/api/patches/75616/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200818120254.72792-2-huwei013@chinasoftinc.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200818120254.72792-2-huwei013@chinasoftinc.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200818120254.72792-2-huwei013@chinasoftinc.com", "date": "2020-08-18T12:02:51", "name": "[1/4] app/testpmd: fix missing verification of port id", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "55916063087c780cccc26bc2708e5fce4660bea8", "submitter": { "id": 1537, "url": "http://patches.dpdk.org/api/people/1537/?format=api", "name": "Wei Hu (Xavier)", "email": "huwei013@chinasoftinc.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200818120254.72792-2-huwei013@chinasoftinc.com/mbox/", "series": [ { "id": 11684, "url": "http://patches.dpdk.org/api/series/11684/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11684", "date": "2020-08-18T12:02:50", "name": "minor fixes for testpmd", "version": 1, "mbox": "http://patches.dpdk.org/series/11684/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/75616/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/75616/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 781C8A034C;\n\tTue, 18 Aug 2020 14:03:20 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4E1CE1C025;\n\tTue, 18 Aug 2020 14:03:11 +0200 (CEST)", "from mail.chinasoftinc.com (unknown [114.113.233.8])\n by dpdk.org (Postfix) with ESMTP id 3B3F01C014\n for <dev@dpdk.org>; Tue, 18 Aug 2020 14:03:07 +0200 (CEST)", "from localhost.localdomain (120.133.139.157) by INCCAS001.ito.icss\n (10.168.0.60) with Microsoft SMTP Server id 14.3.487.0; Tue, 18 Aug 2020\n 20:03:01 +0800" ], "From": "\"Wei Hu (Xavier)\" <huwei013@chinasoftinc.com>", "To": "Wenzhuo Lu <wenzhuo.lu@intel.com>, Beilei Xing <beilei.xing@intel.com>,\n Bernard Iremonger <bernard.iremonger@intel.com>, Shahaf Shuler\n <shahafs@mellanox.com>", "CC": "<dev@dpdk.org>, <xavier.huwei@huawei.com>", "Date": "Tue, 18 Aug 2020 20:02:51 +0800", "Message-ID": "<20200818120254.72792-2-huwei013@chinasoftinc.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200818120254.72792-1-huwei013@chinasoftinc.com>", "References": "<20200818120254.72792-1-huwei013@chinasoftinc.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[120.133.139.157]", "Subject": "[dpdk-dev] [PATCH 1/4] app/testpmd: fix missing verification of\n\tport id", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Chengchang Tang <tangchengchang@huawei.com>\n\nTo set Tx vlan offloads, it is required to stop port firstly. But before\nchecking whether the port is stopped, the port id entered by the user\nis not checked for validity. When the port id is illegal, it would lead\nto a segmentation fault since it attempts to access a member of\nnon-existent port.\n\nThis patch adds verification of port id in tx vlan offloads.\n\nFixes: 597f9fafe13b (\"app/testpmd: convert to new Tx offloads API\")\nCc: stable@dpdk.org\n\nSigned-off-by: Chengchang Tang <tangchengchang@huawei.com>\nSigned-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>\n---\n app/test-pmd/cmdline.c | 9 +++++++++\n 1 file changed, 9 insertions(+)", "diff": "diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c\nindex 0a6ed85f3..8377f8401 100644\n--- a/app/test-pmd/cmdline.c\n+++ b/app/test-pmd/cmdline.c\n@@ -4268,6 +4268,9 @@ cmd_tx_vlan_set_parsed(void *parsed_result,\n {\n \tstruct cmd_tx_vlan_set_result *res = parsed_result;\n \n+\tif (port_id_is_invalid(res->port_id, ENABLED_WARN))\n+\t\treturn;\n+\n \tif (!port_is_stopped(res->port_id)) {\n \t\tprintf(\"Please stop port %d first\\n\", res->port_id);\n \t\treturn;\n@@ -4322,6 +4325,9 @@ cmd_tx_vlan_set_qinq_parsed(void *parsed_result,\n {\n \tstruct cmd_tx_vlan_set_qinq_result *res = parsed_result;\n \n+\tif (port_id_is_invalid(res->port_id, ENABLED_WARN))\n+\t\treturn;\n+\n \tif (!port_is_stopped(res->port_id)) {\n \t\tprintf(\"Please stop port %d first\\n\", res->port_id);\n \t\treturn;\n@@ -4435,6 +4441,9 @@ cmd_tx_vlan_reset_parsed(void *parsed_result,\n {\n \tstruct cmd_tx_vlan_reset_result *res = parsed_result;\n \n+\tif (port_id_is_invalid(res->port_id, ENABLED_WARN))\n+\t\treturn;\n+\n \tif (!port_is_stopped(res->port_id)) {\n \t\tprintf(\"Please stop port %d first\\n\", res->port_id);\n \t\treturn;\n", "prefixes": [ "1/4" ] }