Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/75562/?format=api
{ "id": 75562, "url": "http://patches.dpdk.org/api/patches/75562/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200814110045.217724-5-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200814110045.217724-5-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200814110045.217724-5-bruce.richardson@intel.com", "date": "2020-08-14T11:00:45", "name": "[4/4] examples/mp_server: clear string truncation warning", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "416bb7f21c05b0b4771af7bd17374eaa08c6c387", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200814110045.217724-5-bruce.richardson@intel.com/mbox/", "series": [ { "id": 11655, "url": "http://patches.dpdk.org/api/series/11655/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11655", "date": "2020-08-14T11:00:41", "name": "fixes for example app builds", "version": 1, "mbox": "http://patches.dpdk.org/series/11655/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/75562/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/75562/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DBD56A04B0;\n\tFri, 14 Aug 2020 13:01:47 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 14CC51C10F;\n\tFri, 14 Aug 2020 13:01:34 +0200 (CEST)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n by dpdk.org (Postfix) with ESMTP id 7C18C1C023;\n Fri, 14 Aug 2020 13:01:32 +0200 (CEST)", "from orsmga005.jf.intel.com ([10.7.209.41])\n by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 14 Aug 2020 04:01:31 -0700", "from silpixa00399126.ir.intel.com ([10.237.222.56])\n by orsmga005.jf.intel.com with ESMTP; 14 Aug 2020 04:01:30 -0700" ], "IronPort-SDR": [ "\n Z89c6FwfwAociSHRh6F4awaloIHkhMBwMEhYBiOD45gqENnc7BRm/jLgbkfUNHYLLJvgnwO350\n FzuCgGCk4xng==", "\n vDvGOM3Bj/cWr0Pe7dfmgTNqdT3a5E8nHZJK58ZaEQp3E+QQY6y52eGNVLCv23/4vOUZIgbxmy\n YApVvXfKtTJg==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9712\"; a=\"154349839\"", "E=Sophos;i=\"5.76,312,1592895600\"; d=\"scan'208\";a=\"154349839\"", "E=Sophos;i=\"5.76,312,1592895600\"; d=\"scan'208\";a=\"470553597\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>, stable@dpdk.org,\n Anatoly Burakov <anatoly.burakov@intel.com>", "Date": "Fri, 14 Aug 2020 12:00:45 +0100", "Message-Id": "<20200814110045.217724-5-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200814110045.217724-1-bruce.richardson@intel.com>", "References": "<20200814110045.217724-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 4/4] examples/mp_server: clear string truncation\n\twarning", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Compiling with GCC 9.3 on Ubuntu 20.04 gives a warning about possible\nstring truncation when getting the RX queue name:\n\nIn file included from init.c:36:\ninit.c: In function ‘init’:\n../shared/common.h:38:28: warning: ‘%u’ directive output may be truncated writing between 1 and 10 bytes into a region of size 8 [-Wformat-truncation=]\n 38 | #define MP_CLIENT_RXQ_NAME \"MProc_Client_%u_RX\"\n | ^~~~~~~~~~~~~~~~~~~~\n../shared/common.h:52:35: note: in expansion of macro ‘MP_CLIENT_RXQ_NAME’\n 52 | snprintf(buffer, sizeof(buffer), MP_CLIENT_RXQ_NAME, id);\n | ^~~~~~~~~~~~~~~~~~\n\nThis is a false positive, as the value of the \"id\" is limited to 255, being\nstored in the app as a uint8_t value, removing the possibility of the %u\nbeing replaced by anything other then 3 characters max (rather than up to\n10 as thought by the compiler). Therefore, the warning can be easily\nremoved by changing the type of the \"id\" parameter to the local function\nfrom \"unsigned\" to \"uint8_t\" also, ensuring the compiler is aware of the\nrange limit.\n\nCc: stable@dpdk.org\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n examples/multi_process/client_server_mp/shared/common.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/examples/multi_process/client_server_mp/shared/common.h b/examples/multi_process/client_server_mp/shared/common.h\nindex 6dd43fcac2..76beca0101 100644\n--- a/examples/multi_process/client_server_mp/shared/common.h\n+++ b/examples/multi_process/client_server_mp/shared/common.h\n@@ -43,7 +43,7 @@ struct port_info {\n * Given the rx queue name template above, get the queue name\n */\n static inline const char *\n-get_rx_queue_name(unsigned id)\n+get_rx_queue_name(uint8_t id)\n {\n \t/* buffer for return value. Size calculated by %u being replaced\n \t * by maximum 3 digits (plus an extra byte for safety) */\n", "prefixes": [ "4/4" ] }