Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/75561/?format=api
{ "id": 75561, "url": "http://patches.dpdk.org/api/patches/75561/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200814110045.217724-4-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200814110045.217724-4-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200814110045.217724-4-bruce.richardson@intel.com", "date": "2020-08-14T11:00:44", "name": "[3/4] examples/mp_server: fix snprintf overflow", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "b03bc90d3931255635e66f261b871ef64285b0ae", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200814110045.217724-4-bruce.richardson@intel.com/mbox/", "series": [ { "id": 11655, "url": "http://patches.dpdk.org/api/series/11655/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11655", "date": "2020-08-14T11:00:41", "name": "fixes for example app builds", "version": 1, "mbox": "http://patches.dpdk.org/series/11655/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/75561/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/75561/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6ACBEA04B0;\n\tFri, 14 Aug 2020 13:01:37 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id EFEF01C11F;\n\tFri, 14 Aug 2020 13:01:25 +0200 (CEST)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n by dpdk.org (Postfix) with ESMTP id 55B0D1C10A;\n Fri, 14 Aug 2020 13:01:24 +0200 (CEST)", "from orsmga005.jf.intel.com ([10.7.209.41])\n by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 14 Aug 2020 04:01:23 -0700", "from silpixa00399126.ir.intel.com ([10.237.222.56])\n by orsmga005.jf.intel.com with ESMTP; 14 Aug 2020 04:01:22 -0700" ], "IronPort-SDR": [ "\n 0Bnajj8OL0HQP5mfr95Nt+RGX1IDRg0kzJZKsoNKkyBZ9+g+Vk2+spDXza4FSP7R69bcbsivb6\n 3hjKL6O5E2DA==", "\n n7e97rRV1U+qcowaYSJEdEc/QhqTUqmDoEs5X3+CQ6nDeTiRrkRkJ8l8hPmz+vFaOvp2bSIQgG\n 8UtyiyyI/dDA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9712\"; a=\"215912182\"", "E=Sophos;i=\"5.76,312,1592895600\"; d=\"scan'208\";a=\"215912182\"", "E=Sophos;i=\"5.76,312,1592895600\"; d=\"scan'208\";a=\"470553543\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>, stable@dpdk.org,\n Anatoly Burakov <anatoly.burakov@intel.com>", "Date": "Fri, 14 Aug 2020 12:00:44 +0100", "Message-Id": "<20200814110045.217724-4-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200814110045.217724-1-bruce.richardson@intel.com>", "References": "<20200814110045.217724-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 3/4] examples/mp_server: fix snprintf overflow", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When producing a printable mac address the buffer was appropriately sized\nfor holding the mac address exactly, but the actual snprintf included a\n'\\n' character at the end, which means that the snprintf technically is\ngetting truncated i.e. the \\n would not be added due to lack of space.\nThis gets flagged as a problem by modern versions of gcc, e.g. on Ubuntu\n20.04.\n\nmain.c:77:37: warning: ‘__builtin___snprintf_chk’ output truncated before the last format character [-Wformat-truncation=]\n 77 | \"%02x:%02x:%02x:%02x:%02x:%02x\\n\",\n | ^\n\nSince the \\n is getting stripped anyway, we can fix the issue by just\nremoving it from the printf string.\n\nFixes: af75078fece3 (\"first public release\")\nCc: stable@dpdk.org\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n examples/multi_process/client_server_mp/mp_server/main.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/examples/multi_process/client_server_mp/mp_server/main.c b/examples/multi_process/client_server_mp/mp_server/main.c\nindex 280dab8672..af5af672c3 100644\n--- a/examples/multi_process/client_server_mp/mp_server/main.c\n+++ b/examples/multi_process/client_server_mp/mp_server/main.c\n@@ -74,7 +74,7 @@ get_printable_mac_addr(uint16_t port)\n \t\t\treturn err_address;\n \t\t}\n \t\tsnprintf(addresses[port], sizeof(addresses[port]),\n-\t\t\t\t\"%02x:%02x:%02x:%02x:%02x:%02x\\n\",\n+\t\t\t\t\"%02x:%02x:%02x:%02x:%02x:%02x\",\n \t\t\t\tmac.addr_bytes[0], mac.addr_bytes[1], mac.addr_bytes[2],\n \t\t\t\tmac.addr_bytes[3], mac.addr_bytes[4], mac.addr_bytes[5]);\n \t}\n", "prefixes": [ "3/4" ] }