Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/75530/?format=api
{ "id": 75530, "url": "http://patches.dpdk.org/api/patches/75530/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1597360905-74106-10-git-send-email-navasile@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1597360905-74106-10-git-send-email-navasile@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1597360905-74106-10-git-send-email-navasile@linux.microsoft.com", "date": "2020-08-13T23:21:32", "name": "[09/22] doc: remove embedded buffer from Windows UIO ioctl", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "e19bc9892f32878ba52571bcfc2d6db321eab864", "submitter": { "id": 1668, "url": "http://patches.dpdk.org/api/people/1668/?format=api", "name": "Narcisa Ana Maria Vasile", "email": "navasile@linux.microsoft.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1597360905-74106-10-git-send-email-navasile@linux.microsoft.com/mbox/", "series": [ { "id": 11644, "url": "http://patches.dpdk.org/api/series/11644/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11644", "date": "2020-08-13T23:21:23", "name": "windows/netuio: add netuio driver for Windows", "version": 1, "mbox": "http://patches.dpdk.org/series/11644/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/75530/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/75530/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 86E55A04B1;\n\tFri, 14 Aug 2020 01:24:30 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 8B1CA1C19C;\n\tFri, 14 Aug 2020 01:23:00 +0200 (CEST)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by dpdk.org (Postfix) with ESMTP id EA8DF1C0D0\n for <dev@dpdk.org>; Fri, 14 Aug 2020 01:22:44 +0200 (CEST)", "by linux.microsoft.com (Postfix, from userid 1059)\n id D99EF20B491D; Thu, 13 Aug 2020 16:22:43 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com D99EF20B491D", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1597360963;\n bh=WJ6ntCn+Z/sRLYQUG9e/b5N02EjyVfEmm9nSeJMvyfA=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=ETZEdMN8rU2DQmZBIbgUg5e/+2LnvXEcwXjiv0rvxxGGCeWBlOsVbYNmRG77wbv0m\n x8GzfgX4WByxgg0mJy7KKwPwB/NU8J148V7sR5wqey3482o55qheH8jrj2WNY7aeS1\n 0UGlnF/7/WXFng1G3cBI5tmFBuPqiIZXW/k9UIEg=", "From": "Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>", "To": "dev@dpdk.org, thomas@monjalon.net, haramakr@linux.microsoft.com,\n ocardona@microsoft.com, pallavi.kadam@intel.com, dmitry.kozliuk@gmail.com", "Cc": "ranjit.menon@intel.com, dmitrym@microsoft.com,\n Harini Ramakrishnan <haramakr@microsoft.com>", "Date": "Thu, 13 Aug 2020 16:21:32 -0700", "Message-Id": "<1597360905-74106-10-git-send-email-navasile@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1597360905-74106-1-git-send-email-navasile@linux.microsoft.com>", "References": "<1597360905-74106-1-git-send-email-navasile@linux.microsoft.com>", "Subject": "[dpdk-dev] [PATCH 09/22] doc: remove embedded buffer from Windows\n\tUIO ioctl", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Harini Ramakrishnan <haramakr@microsoft.com>\n\n---\n kernel/windows/netuio/netuio_interface.h | 9 ++++-\n kernel/windows/netuio/netuio_queue.c | 43 ++++++++++++++++++------\n 2 files changed, 40 insertions(+), 12 deletions(-)", "diff": "diff --git a/kernel/windows/netuio/netuio_interface.h b/kernel/windows/netuio/netuio_interface.h\nindex b86bf5d3f..f84ee895c 100644\n--- a/kernel/windows/netuio/netuio_interface.h\n+++ b/kernel/windows/netuio/netuio_interface.h\n@@ -59,9 +59,16 @@ struct dpdk_private_info\n struct dpdk_pci_config_io\n {\n struct dev_addr dev_addr;\n- PVOID buf;\n UINT32 offset;\n enum pci_io op;\n+ UINT32 access_size; // 1, 2, 4, or 8 bytes\n+\n+ union dpdk_pci_config_io_data {\n+ UINT8\t\t\tu8;\n+ UINT16\t\t\tu16;\n+ UINT32\t\t\tu32;\n+ UINT64\t\t\tu64;\n+ } data;\n };\n \n #pragma pack(pop)\ndiff --git a/kernel/windows/netuio/netuio_queue.c b/kernel/windows/netuio/netuio_queue.c\nindex 312d4b682..929192880 100644\n--- a/kernel/windows/netuio/netuio_queue.c\n+++ b/kernel/windows/netuio/netuio_queue.c\n@@ -11,22 +11,23 @@\n #pragma alloc_text (PAGE, netuio_queue_initialize)\n #endif\n \n-VOID netuio_read_PCI_config(PNETUIO_CONTEXT_DATA netuio_contextdata, ULONG offset, PVOID buffer)\n+VOID netuio_read_PCI_config(PNETUIO_CONTEXT_DATA netuio_contextdata, ULONG offset, UINT32 access_size, _Out_ UINT64 *output)\n {\n+ *output = 0;\n netuio_contextdata->bus_interface.GetBusData(netuio_contextdata->bus_interface.Context,\n PCI_WHICHSPACE_CONFIG,\n- buffer,\n+ output,\n offset,\n- sizeof(UINT32));\n+ access_size);\n }\n \n-VOID netuio_write_PCI_config(PNETUIO_CONTEXT_DATA netuio_contextdata, ULONG offset, PVOID buffer)\n+VOID netuio_write_PCI_config(PNETUIO_CONTEXT_DATA netuio_contextdata, ULONG offset, UINT32 access_size, union dpdk_pci_config_io_data const *input)\n {\n netuio_contextdata->bus_interface.SetBusData(netuio_contextdata->bus_interface.Context,\n PCI_WHICHSPACE_CONFIG,\n- buffer,\n+ (PVOID)input,\n offset,\n- sizeof(UINT32));\n+ access_size);\n }\n \n static NTSTATUS\n@@ -180,6 +181,15 @@ netuio_evt_IO_device_control(_In_ WDFQUEUE Queue, _In_ WDFREQUEST Request,\n }\n \n struct dpdk_pci_config_io *dpdk_pci_io_input = (struct dpdk_pci_config_io *)input_buf;\n+\n+ if (dpdk_pci_io_input->access_size != 1 &&\n+ dpdk_pci_io_input->access_size != 2 &&\n+ dpdk_pci_io_input->access_size != 4 &&\n+ dpdk_pci_io_input->access_size != 8) {\n+ status = STATUS_INVALID_PARAMETER;\n+ break;\n+ }\n+\n // Ensure that the B:D:F match - otherwise, fail the IOCTL\n if ((netuio_contextdata->addr.bus_num != dpdk_pci_io_input->dev_addr.bus_num) ||\n (netuio_contextdata->addr.dev_num != dpdk_pci_io_input->dev_addr.dev_num) ||\n@@ -188,7 +198,7 @@ netuio_evt_IO_device_control(_In_ WDFQUEUE Queue, _In_ WDFREQUEST Request,\n break;\n }\n // Retrieve output buffer\n- status = WdfRequestRetrieveOutputBuffer(Request, sizeof(UINT32), &output_buf, &output_buf_size);\n+ status = WdfRequestRetrieveOutputBuffer(Request, sizeof(UINT64), &output_buf, &output_buf_size);\n if (!NT_SUCCESS(status)) {\n status = STATUS_INVALID_BUFFER_SIZE;\n break;\n@@ -196,13 +206,24 @@ netuio_evt_IO_device_control(_In_ WDFQUEUE Queue, _In_ WDFREQUEST Request,\n ASSERT(output_buf_size == OutputBufferLength);\n \n if (dpdk_pci_io_input->op == PCI_IO_READ) {\n- netuio_read_PCI_config(netuio_contextdata, dpdk_pci_io_input->offset, output_buf);\n- bytes_returned = output_buf_size;\n+ netuio_read_PCI_config(netuio_contextdata,\n+ dpdk_pci_io_input->offset,\n+ dpdk_pci_io_input->access_size,\n+ (UINT64*)output_buf);\n+ \n+ bytes_returned = sizeof(UINT64);\n }\n- else {\n- netuio_write_PCI_config(netuio_contextdata, dpdk_pci_io_input->offset, dpdk_pci_io_input->buf);\n+ else if (dpdk_pci_io_input->op == PCI_IO_WRITE) {\n+ netuio_write_PCI_config(netuio_contextdata,\n+ dpdk_pci_io_input->offset,\n+ dpdk_pci_io_input->access_size,\n+ &dpdk_pci_io_input->data);\n bytes_returned = 0;\n }\n+ else {\n+ status = STATUS_INVALID_PARAMETER;\n+ break;\n+ }\n \n break;\n \n", "prefixes": [ "09/22" ] }