Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/75389/?format=api
{ "id": 75389, "url": "http://patches.dpdk.org/api/patches/75389/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200811085246.28735-4-i.dyukov@samsung.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200811085246.28735-4-i.dyukov@samsung.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200811085246.28735-4-i.dyukov@samsung.com", "date": "2020-08-11T08:52:22", "name": "[v9,03/24] app: UNKNOWN link speed print", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "1b588486d666730bb070d599aa38766884925a80", "submitter": { "id": 783, "url": "http://patches.dpdk.org/api/people/783/?format=api", "name": "Ivan Dyukov", "email": "i.dyukov@samsung.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200811085246.28735-4-i.dyukov@samsung.com/mbox/", "series": [ { "id": 11591, "url": "http://patches.dpdk.org/api/series/11591/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11591", "date": "2020-08-11T08:52:19", "name": "ethdev: allow unknown link speed", "version": 9, "mbox": "http://patches.dpdk.org/series/11591/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/75389/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/75389/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BB488A04AF;\n\tTue, 11 Aug 2020 10:53:47 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id DB3C31C0B8;\n\tTue, 11 Aug 2020 10:53:10 +0200 (CEST)", "from mailout1.w1.samsung.com (mailout1.w1.samsung.com\n [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 9C34C1C07D\n for <dev@dpdk.org>; Tue, 11 Aug 2020 10:53:07 +0200 (CEST)", "from eucas1p1.samsung.com (unknown [182.198.249.206])\n by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id\n 20200811085307euoutp01ea190603586ad734e478421b5bf76b4a~qKrfynGT-0892608926euoutp01E;\n Tue, 11 Aug 2020 08:53:07 +0000 (GMT)", "from eusmges2new.samsung.com (unknown [203.254.199.244]) by\n eucas1p1.samsung.com (KnoxPortal) with ESMTP id\n 20200811085307eucas1p134aece58dc4de4db87cd497976b86cc5~qKrfmcV_01584815848eucas1p1i;\n Tue, 11 Aug 2020 08:53:07 +0000 (GMT)", "from eucas1p1.samsung.com ( [182.198.249.206]) by\n eusmges2new.samsung.com (EUCPMTA) with SMTP id 21.1C.05997.37C523F5; Tue, 11\n Aug 2020 09:53:07 +0100 (BST)", "from eusmtrp1.samsung.com (unknown [182.198.249.138]) by\n eucas1p2.samsung.com (KnoxPortal) with ESMTPA id\n 20200811085306eucas1p2028e8b747d3a1b5d659e1e554a4aca84~qKrfKk7_v3145931459eucas1p20;\n Tue, 11 Aug 2020 08:53:06 +0000 (GMT)", "from eusmgms2.samsung.com (unknown [182.198.249.180]) by\n eusmtrp1.samsung.com (KnoxPortal) with ESMTP id\n 20200811085306eusmtrp16c5bc19c51767d6fe2b1bb3c525fc0c3~qKrfJp3TC1606216062eusmtrp1B;\n Tue, 11 Aug 2020 08:53:06 +0000 (GMT)", "from eusmtip1.samsung.com ( [203.254.199.221]) by\n eusmgms2.samsung.com (EUCPMTA) with SMTP id 21.4D.06017.27C523F5; Tue, 11\n Aug 2020 09:53:06 +0100 (BST)", "from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by\n eusmtip1.samsung.com (KnoxPortal) with ESMTPA id\n 20200811085304eusmtip14073110d4a3a4567c33d352a704d85f8~qKrdY9lq-1792217922eusmtip1I;\n Tue, 11 Aug 2020 08:53:04 +0000 (GMT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com\n 20200811085307euoutp01ea190603586ad734e478421b5bf76b4a~qKrfynGT-0892608926euoutp01E", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com;\n s=mail20170921; t=1597135987;\n bh=dI+oiTsEKRnvivBB04vQNjKvj/2HACon7g1KeTDyHHI=;\n h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From;\n b=Pz4RrXKPbN4/M2c9tr05Yk8NtguSaSbUzo6xA+d9R3uRziZZBlCKis3pRKlXmTEHZ\n JmOJ8UlF0U4tObriumalQ3KzAljE0ZXjaVcDmJ1DIs4KptrKHRr4o7Q3vbXKKcFO98\n SVriL8E6sZbXbchVUL7+nYitMQpTGtXMiAXD2Aag=", "X-AuditID": "cbfec7f4-65dff7000000176d-8e-5f325c733453", "From": "Ivan Dyukov <i.dyukov@samsung.com>", "To": "dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com,\n thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com,\n arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com,\n beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com,\n mb@smartsharesystems.com, stephen@networkplumber.org,\n nicolas.chautru@intel.com, bruce.richardson@intel.com,\n konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com,\n radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com,\n skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com,\n kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com,\n xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com,\n jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com", "Date": "Tue, 11 Aug 2020 11:52:22 +0300", "Message-Id": "<20200811085246.28735-4-i.dyukov@samsung.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200811085246.28735-1-i.dyukov@samsung.com>", "X-Brightmail-Tracker": [ "\n H4sIAAAAAAAAA0WSf0yUdRzH93me557n4fLs8XTjM3OyzunKFMFqfjSLdK6eP2w526o5la54\n htRxsHtAo7XJriI9LkIkKmmIUEl31Gked4SacCWnHUiyDDEQxmqXdAjiMeI6KI4H13+v94/v\n 9/PZd1+RNX7ELxVzrAWKzWq2mHg952ufurJW3b0+M63PpyNPRw3Q0M16lgYr+3kqHXuXoeuu\n DDrn/0xHFQPFDJVV3GHI3+DgKTJo5+j2uJ+hvvMhgY512wUaD4QF+qCrGigcH2bp09q7QF01\n TTqaamvhaTRex1FZ7BrQh95LQEHnHY4qv2sGKnFINPbVSYHq+5bT+OAljkK9ZwRqnLjKUlPH\n NNCRoAeos+Rf3dMPyrHaL3Ry/blbjHz0xFVWbu+tEmTn5RpGPn27mZFHv7/Gy2VeF8g/DZWy\n svv3v/kd+l36zVmKJWe/Ylv31Cv6fd1DQ0J+ZPubEz0n2GKIbXZAkojSY9jY+BvvAL1olBoA\n wz8EGE1EAZurugRN3AWMzAR09460ButAC04C2iva51sTgG7XJ1yixUsPYehQzdxdS6TTPPrj\n PUwiWCxtwLjrwhxz0kp8b7gXEmyQNuLU+NesNiIF3ada5zhJ2oTu6oE5NkrLsed4lNE6HSJG\n 4laNt+GvtR7QeDEOB72CxsswdNTJJZZA6X3AI74zgibKAd+pHplvZaD3ryuzLIqs9DB6WtZp\n 9hYMNHVyCRulhXh9ZFHCZmexwvcxq9kGPFRi1NombL3cPW8jTv+zQLNl9Pa3zr/PecBB+yko\n h5Rj/8+qBXBBslKo5mYr6nqrciBVNeeqhdbs1Nfycr+F2c8amglGm6El/moAJBFMCwz5T6Rn\n GnXm/WpRbgBQZE1LDFs7Q3uNhixz0VuKLS/TVmhR1AA8IHKmZMOjdbf2GKVsc4HyhqLkK7Z7\n KSMmLS2GDdPusxfSq9aMObNw7O2RWJljVSxndOvN/rwbRW1P/rz7dcufvHJ2e49fOXhjYQwP\n 35cvR9P2Hl7z7LDnxZmLvxgzTMkvrXh5j2Xgmecvrow993n5l9sCKZGNO9fuCpvSHrG3/fiH\n P7V0S/jxycnJ+y0rNhU0dAvRFzqdQuWBqsiybw76TJy6z5y+mrWp5v8AmMZ7AagDAAA=", "\n H4sIAAAAAAAAAzWSa0hTYRjHfc85O7vU6jSt3iQqR2YUzc7U9mim0afzoSjo8qE0G3pQ0W12\n zgwtCLtoMS+ZSlDG8oJks7uaF6x0kaZTRM0bZZkIkZmZaUxdlpf69oPf///wwPPISNUvylMW\n azTzglEfr6YVlGOuaWCHEKaN2Jn2wQcetVoRDH0oJmEwb4CG9PHLBPTZQqGu6rYEcj6mEJCV\n 84OAqlILDaODFykYm6gi4P1zhxRudV6UwoT9sxQy2/MRfHaNkHCz4CeCdmulBKYbamn47iqi\n IGumG8G1ijcImjJ+UJBXU40gzcLA+L27Uih+vwEmBt9Q4Ogvl8L9qQ4SKlt/I7je9AhBW9of\n yV4vbqagRMIV130huNzCDpJr7L8h5TKarQT3ZKya4L6/6Ka5rAob4lqG0kmubNhJH1Ic1wQL\n pkQzvynGJJr3qE+woNWwgaDR+gdqWD9deJA2QO0bEhzFx8ee4QXfkFOamM6hIWnC6P6kqd5C\n MgXNBFuQXIYZf1zfVIQsSCFTMSUIN4+USixINi8w/jpMLmXcsavHQi9lfiI8XD6+KGhmK3Zc\n tRILwoN5R+OuKxeoBeHO6LDL9pJYYIrxxqkj/WiBlUwgnp548G/qRlz2uH6R5UwQLsv/uMgq\n JhZfGKihl3gD7r0zSWSjFQXIzYY8+ETREG0QtRpRbxATjdGaSJPhKZq/+bPG6YpqZBk7bEeM\n DKmXKxN2sxEqif6MmGywIywj1R7KfW2OkypllD75LC+YIoTEeF60o4D5Ba+TnqsjTfMfZDRH\n sAGsDgJZnZ/Obxeo1yqvMg1hKiZab+bjeD6BF/73CJncMwVZ16+zn195iSlp+WZL2PJJztaq\n 7neHrzI4jzq9l0VvL/ud5Eq6tzr14fCanDhlT8DcpPfpxsaZg3mTmW8Vrl+dHaNCX2lY0mxH\n pFfMlDO4t8f6ajZX4vQ44kb5WFd2Ra7bfIA5Efo6SNFcPKeZtNVmpsqN2TWv8e5jyeckJXHe\n n9SUGKNnt5GCqP8LOHBGfAkDAAA=" ], "X-CMS-MailID": "20200811085306eucas1p2028e8b747d3a1b5d659e1e554a4aca84", "X-Msg-Generator": "CA", "Content-Type": "text/plain; charset=\"utf-8\"", "X-RootMTR": "20200811085306eucas1p2028e8b747d3a1b5d659e1e554a4aca84", "X-EPHeader": "CA", "CMS-TYPE": "201P", "X-CMS-RootMailID": "20200811085306eucas1p2028e8b747d3a1b5d659e1e554a4aca84", "References": "<20200427095737.11082-1-i.dyukov@samsung.com>\n <20200811085246.28735-1-i.dyukov@samsung.com>\n <CGME20200811085306eucas1p2028e8b747d3a1b5d659e1e554a4aca84@eucas1p2.samsung.com>", "Subject": "[dpdk-dev] [PATCH v9 03/24] app: UNKNOWN link speed print", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "Reply-To": "i.dyukov@samsung.com", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add usage of rte_eth_link_to_str function to example\napplications and docs\n\nSigned-off-by: Ivan Dyukov <i.dyukov@samsung.com>\n---\n app/proc-info/main.c | 13 ++++++-----\n app/test-pipeline/init.c | 11 ++++-----\n app/test-pmd/config.c | 23 ++++++++++++-------\n app/test-pmd/testpmd.c | 12 ++++------\n app/test/test_ethdev_link.c | 6 ++---\n app/test/test_pmd_perf.c | 17 ++++++--------\n doc/guides/sample_app_ug/link_status_intr.rst | 10 ++++----\n 7 files changed, 46 insertions(+), 46 deletions(-)", "diff": "diff --git a/app/proc-info/main.c b/app/proc-info/main.c\nindex abeca4aab..a315f22ce 100644\n--- a/app/proc-info/main.c\n+++ b/app/proc-info/main.c\n@@ -672,6 +672,7 @@ show_port(void)\n \t\tstruct rte_eth_dev_info dev_info;\n \t\tstruct rte_eth_rxq_info queue_info;\n \t\tstruct rte_eth_rss_conf rss_conf;\n+\t\tchar link_status_text[100];\n \n \t\tmemset(&rss_conf, 0, sizeof(rss_conf));\n \n@@ -685,12 +686,12 @@ show_port(void)\n \t\t\tprintf(\"Link get failed (port %u): %s\\n\",\n \t\t\t i, rte_strerror(-ret));\n \t\t} else {\n-\t\t\tprintf(\"\\t -- link speed %d duplex %d,\"\n-\t\t\t\t\t\" auto neg %d status %d\\n\",\n-\t\t\t\t\tlink.link_speed,\n-\t\t\t\t\tlink.link_duplex,\n-\t\t\t\t\tlink.link_autoneg,\n-\t\t\t\t\tlink.link_status);\n+\t\t\trte_eth_link_to_str(link_status_text,\n+\t\t\t\t\tsizeof(link_status_text),\n+\t\t\t\t\t\"\\t -- link speed: %M, duplex: %D,\"\n+\t\t\t\t\t\" auto neg: %A, status: %S\\n\",\n+\t\t\t\t\t&link);\n+\t\t\tprintf(\"%s\", link_status_text);\n \t\t}\n \t\tprintf(\"\\t -- promiscuous (%d)\\n\",\n \t\t\t\trte_eth_promiscuous_get(i));\ndiff --git a/app/test-pipeline/init.c b/app/test-pipeline/init.c\nindex 67d54ae05..b85db3826 100644\n--- a/app/test-pipeline/init.c\n+++ b/app/test-pipeline/init.c\n@@ -155,7 +155,7 @@ static void\n app_ports_check_link(void)\n {\n \tuint32_t all_ports_up, i;\n-\n+\tchar link_status_text[50];\n \tall_ports_up = 1;\n \n \tfor (i = 0; i < app.n_ports; i++) {\n@@ -173,12 +173,11 @@ app_ports_check_link(void)\n \t\t\tall_ports_up = 0;\n \t\t\tcontinue;\n \t\t}\n-\n-\t\tRTE_LOG(INFO, USER1, \"Port %u (%u Gbps) %s\\n\",\n+\t\trte_eth_link_to_str(link_status_text, sizeof(link_status_text),\n+\t\t\t\t \"(%G Gbps) %S\", &link);\n+\t\tRTE_LOG(INFO, USER1, \"Port %u %s\\n\",\n \t\t\tport,\n-\t\t\tlink.link_speed / 1000,\n-\t\t\tlink.link_status ? \"UP\" : \"DOWN\");\n-\n+\t\t\tlink_status_text);\n \t\tif (link.link_status == ETH_LINK_DOWN)\n \t\t\tall_ports_up = 0;\n \t}\ndiff --git a/app/test-pmd/config.c b/app/test-pmd/config.c\nindex a7112c998..a34aed123 100644\n--- a/app/test-pmd/config.c\n+++ b/app/test-pmd/config.c\n@@ -564,6 +564,7 @@ port_infos_display(portid_t port_id)\n \tchar name[RTE_ETH_NAME_MAX_LEN];\n \tint ret;\n \tchar fw_version[ETHDEV_FWVERS_LEN];\n+\tchar link_status[70];\n \n \tif (port_id_is_invalid(port_id, ENABLED_WARN)) {\n \t\tprint_valid_ports();\n@@ -604,10 +605,11 @@ port_infos_display(portid_t port_id)\n \t} else\n \t\tprintf(\"\\nmemory allocation on the socket: %u\",port->socket_id);\n \n-\tprintf(\"\\nLink status: %s\\n\", (link.link_status) ? (\"up\") : (\"down\"));\n-\tprintf(\"Link speed: %u Mbps\\n\", (unsigned) link.link_speed);\n-\tprintf(\"Link duplex: %s\\n\", (link.link_duplex == ETH_LINK_FULL_DUPLEX) ?\n-\t (\"full-duplex\") : (\"half-duplex\"));\n+\trte_eth_link_to_str(link_status, sizeof(link_status),\n+\t\t\t \"\\nLink status: %S\\n\"\n+\t\t\t \"Link speed: %M Mbps\\n\"\n+\t\t\t \"Link duplex: %D\\n\", &link);\n+\tprintf(\"%s\", link_status);\n \n \tif (!rte_eth_dev_get_mtu(port_id, &mtu))\n \t\tprintf(\"MTU: %u\\n\", mtu);\n@@ -730,6 +732,8 @@ port_summary_display(portid_t port_id)\n \tstruct rte_eth_link link;\n \tstruct rte_eth_dev_info dev_info;\n \tchar name[RTE_ETH_NAME_MAX_LEN];\n+\tchar status_text[6];\n+\tchar speed_text[12];\n \tint ret;\n \n \tif (port_id_is_invalid(port_id, ENABLED_WARN)) {\n@@ -750,12 +754,14 @@ port_summary_display(portid_t port_id)\n \tif (ret != 0)\n \t\treturn;\n \n-\tprintf(\"%-4d %02X:%02X:%02X:%02X:%02X:%02X %-12s %-14s %-8s %uMbps\\n\",\n+\trte_eth_link_to_str(status_text, 6, \"%S\", &link);\n+\trte_eth_link_to_str(speed_text, 12, \"%M\", &link);\n+\tprintf(\"%-4d %02X:%02X:%02X:%02X:%02X:%02X %-12s %-14s %-8s %sMbps\\n\",\n \t\tport_id, mac_addr.addr_bytes[0], mac_addr.addr_bytes[1],\n \t\tmac_addr.addr_bytes[2], mac_addr.addr_bytes[3],\n \t\tmac_addr.addr_bytes[4], mac_addr.addr_bytes[5], name,\n-\t\tdev_info.driver_name, (link.link_status) ? (\"up\") : (\"down\"),\n-\t\t(unsigned int) link.link_speed);\n+\t\tdev_info.driver_name, status_text,\n+\t\tspeed_text);\n }\n \n void\n@@ -3899,7 +3905,8 @@ set_queue_rate_limit(portid_t port_id, uint16_t queue_idx, uint16_t rate)\n \tret = eth_link_get_nowait_print_err(port_id, &link);\n \tif (ret < 0)\n \t\treturn 1;\n-\tif (rate > link.link_speed) {\n+\tif (link.link_speed != ETH_SPEED_NUM_UNKNOWN &&\n+\t rate > link.link_speed) {\n \t\tprintf(\"Invalid rate value:%u bigger than link speed: %u\\n\",\n \t\t\trate, link.link_speed);\n \t\treturn 1;\ndiff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c\nindex 4989d22ca..1d294641b 100644\n--- a/app/test-pmd/testpmd.c\n+++ b/app/test-pmd/testpmd.c\n@@ -2991,6 +2991,7 @@ check_all_ports_link_status(uint32_t port_mask)\n \tuint8_t count, all_ports_up, print_flag = 0;\n \tstruct rte_eth_link link;\n \tint ret;\n+\tchar link_status[ETH_LINK_MAX_STR_LEN];\n \n \tprintf(\"Checking link statuses...\\n\");\n \tfflush(stdout);\n@@ -3010,14 +3011,9 @@ check_all_ports_link_status(uint32_t port_mask)\n \t\t\t}\n \t\t\t/* print link status if flag set */\n \t\t\tif (print_flag == 1) {\n-\t\t\t\tif (link.link_status)\n-\t\t\t\t\tprintf(\n-\t\t\t\t\t\"Port%d Link Up. speed %u Mbps- %s\\n\",\n-\t\t\t\t\tportid, link.link_speed,\n-\t\t\t\t(link.link_duplex == ETH_LINK_FULL_DUPLEX) ?\n-\t\t\t\t\t(\"full-duplex\") : (\"half-duplex\"));\n-\t\t\t\telse\n-\t\t\t\t\tprintf(\"Port %d Link Down\\n\", portid);\n+\t\t\t\trte_eth_link_to_str(link_status,\n+\t\t\t\t\tsizeof(link_status), NULL, &link);\n+\t\t\t\tprintf(\"Port %d %s\\n\", portid, link_status);\n \t\t\t\tcontinue;\n \t\t\t}\n \t\t\t/* clear all_ports_up flag if any link down */\ndiff --git a/app/test/test_ethdev_link.c b/app/test/test_ethdev_link.c\nindex b501deefe..8e2a8be13 100644\n--- a/app/test/test_ethdev_link.c\n+++ b/app/test/test_ethdev_link.c\n@@ -19,7 +19,7 @@ test_link_status_up_default(void)\n \t\t.link_autoneg = ETH_LINK_AUTONEG,\n \t\t.link_duplex = ETH_LINK_FULL_DUPLEX\n \t};\n-\tchar text[RTE_ETH_LINK_MAX_STR_LEN + 1];\n+\tchar text[ETH_LINK_MAX_STR_LEN + 1];\n \n \tret = rte_eth_link_to_str(text, sizeof(text), NULL, &link_status);\n \tRTE_TEST_ASSERT(ret > 0, \"Failed to format default string\\n\");\n@@ -51,7 +51,7 @@ test_link_status_up_default(void)\n \tlink_status.link_autoneg = ETH_LINK_AUTONEG;\n \tret = rte_eth_link_to_str(text, sizeof(text), NULL, &link_status);\n \tprintf(\"Default link up #4:len = %d, %s\\n\", ret, text);\n-\tRTE_TEST_ASSERT(ret > RTE_ETH_LINK_MAX_STR_LEN,\n+\tRTE_TEST_ASSERT(ret < ETH_LINK_MAX_STR_LEN,\n \t\t\"String length exceeds max allowed value\\n\");\n \treturn TEST_SUCCESS;\n }\n@@ -66,7 +66,7 @@ test_link_status_down_default(void)\n \t\t.link_autoneg = ETH_LINK_AUTONEG,\n \t\t.link_duplex = ETH_LINK_FULL_DUPLEX\n \t};\n-\tchar text[RTE_ETH_LINK_MAX_STR_LEN];\n+\tchar text[ETH_LINK_MAX_STR_LEN];\n \n \tret = rte_eth_link_to_str(text, sizeof(text), NULL, &link_status);\n \tRTE_TEST_ASSERT(ret > 0, \"Failed to format default string\\n\");\ndiff --git a/app/test/test_pmd_perf.c b/app/test/test_pmd_perf.c\nindex 352cd4715..9d38382c2 100644\n--- a/app/test/test_pmd_perf.c\n+++ b/app/test/test_pmd_perf.c\n@@ -126,6 +126,7 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask)\n \tuint8_t count, all_ports_up, print_flag = 0;\n \tstruct rte_eth_link link;\n \tint ret;\n+\tchar link_status[ETH_LINK_MAX_STR_LEN];\n \n \tprintf(\"Checking link statuses...\\n\");\n \tfflush(stdout);\n@@ -146,16 +147,12 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask)\n \n \t\t\t/* print link status if flag set */\n \t\t\tif (print_flag == 1) {\n-\t\t\t\tif (link.link_status) {\n-\t\t\t\t\tprintf(\n-\t\t\t\t\t\"Port%d Link Up. Speed %u Mbps - %s\\n\",\n-\t\t\t\t\t\tportid, link.link_speed,\n-\t\t\t\t(link.link_duplex == ETH_LINK_FULL_DUPLEX) ?\n-\t\t\t\t\t(\"full-duplex\") : (\"half-duplex\"));\n-\t\t\t\t\tif (link_mbps == 0)\n-\t\t\t\t\t\tlink_mbps = link.link_speed;\n-\t\t\t\t} else\n-\t\t\t\t\tprintf(\"Port %d Link Down\\n\", portid);\n+\t\t\t\tif (link.link_status && link_mbps == 0)\n+\t\t\t\t\tlink_mbps = link.link_speed;\n+\n+\t\t\t\trte_eth_link_to_str(link_status,\n+\t\t\t\t\tsizeof(link_status), NULL, &link);\n+\t\t\t\tprintf(\"Port %d %s\\n\", portid, link_status);\n \t\t\t\tcontinue;\n \t\t\t}\n \t\t\t/* clear all_ports_up flag if any link down */\ndiff --git a/doc/guides/sample_app_ug/link_status_intr.rst b/doc/guides/sample_app_ug/link_status_intr.rst\nindex 04c40f285..2f7eb61c2 100644\n--- a/doc/guides/sample_app_ug/link_status_intr.rst\n+++ b/doc/guides/sample_app_ug/link_status_intr.rst\n@@ -158,6 +158,7 @@ An example callback function that has been written as indicated below.\n {\n struct rte_eth_link link;\n int ret;\n+ char link_status[RTE_ETH_LINK_MAX_STR_LEN];\n \n RTE_SET_USED(param);\n \n@@ -169,11 +170,10 @@ An example callback function that has been written as indicated below.\n if (ret < 0) {\n printf(\"Failed to get port %d link status: %s\\n\\n\",\n port_id, rte_strerror(-ret));\n- } else if (link.link_status) {\n- printf(\"Port %d Link Up - speed %u Mbps - %s\\n\\n\", port_id, (unsigned)link.link_speed,\n- (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? (\"full-duplex\") : (\"half-duplex\"));\n- } else\n- printf(\"Port %d Link Down\\n\\n\", port_id);\n+ } else {\n+ rte_eth_link_to_str(link_status, sizeof(link_status), NULL, &link);\n+ printf(\"Port %d %s\\n\\n\", port_id, link_status);\n+ }\n }\n \n This function is called when a link status interrupt is present for the right port.\n", "prefixes": [ "v9", "03/24" ] }