Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/75368/?format=api
{ "id": 75368, "url": "http://patches.dpdk.org/api/patches/75368/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200811062917.7007-5-stevex.yang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200811062917.7007-5-stevex.yang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200811062917.7007-5-stevex.yang@intel.com", "date": "2020-08-11T06:29:14", "name": "[4/7] net/iavf: fix setting of MAC address on iavf", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "02fad0796830fe26e622dae7e361f8bec535d84a", "submitter": { "id": 1883, "url": "http://patches.dpdk.org/api/people/1883/?format=api", "name": "Steve Yang", "email": "stevex.yang@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200811062917.7007-5-stevex.yang@intel.com/mbox/", "series": [ { "id": 11583, "url": "http://patches.dpdk.org/api/series/11583/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11583", "date": "2020-08-11T06:29:10", "name": "Bugs Porting from I40evf For IAVF Feature", "version": 1, "mbox": "http://patches.dpdk.org/series/11583/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/75368/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/75368/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6DC8DA04D8;\n\tTue, 11 Aug 2020 08:49:58 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 8B15D1C0B5;\n\tTue, 11 Aug 2020 08:49:35 +0200 (CEST)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n by dpdk.org (Postfix) with ESMTP id E6CD31C0B3\n for <dev@dpdk.org>; Tue, 11 Aug 2020 08:49:33 +0200 (CEST)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 10 Aug 2020 23:49:33 -0700", "from intel-npg-odc-srv01.cd.intel.com ([10.240.178.134])\n by fmsmga001.fm.intel.com with ESMTP; 10 Aug 2020 23:49:32 -0700" ], "IronPort-SDR": [ "\n iCj3oov0SAu0Kmao/9AJft7U7B845WT6MegGlyIU41Ke1e6zsijVJ1QmxswlwU6CiRgkDe/NEx\n Ov1HyIBIK9Nw==", "\n uea6Jhikq0m6mJPQGszsQDcJBoBX4l42wPAnzGFYKR8yw0nxfGEN1g709QcYeuG6CYWSp8OZMS\n o4WsJ8z4l0YA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9709\"; a=\"171722167\"", "E=Sophos;i=\"5.75,460,1589266800\"; d=\"scan'208\";a=\"171722167\"", "E=Sophos;i=\"5.75,460,1589266800\"; d=\"scan'208\";a=\"398445751\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "SteveX Yang <stevex.yang@intel.com>", "To": "jingjing.wu@intel.com,\n\tbeilei.xing@intel.com,\n\tdev@dpdk.org", "Cc": "SteveX Yang <stevex.yang@intel.com>", "Date": "Tue, 11 Aug 2020 06:29:14 +0000", "Message-Id": "<20200811062917.7007-5-stevex.yang@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200811062917.7007-1-stevex.yang@intel.com>", "References": "<20200811062917.7007-1-stevex.yang@intel.com>", "Subject": "[dpdk-dev] [PATCH 4/7] net/iavf: fix setting of MAC address on iavf", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When setting the MAC address, the ethdev layer copies the new mac\naddress in dev->data->mac_addrs[0] before calling the dev_ops.\n\nTherefore, is_same_ether_addr(mac_addr, dev->data->mac_addrs) was\nalways true, and the MAC was never set. Remove this test to fix the\nissue.\n\nFixes: 538da7a1cad2 (\"net: add rte prefix to ether functions\")\n\nSigned-off-by: SteveX Yang <stevex.yang@intel.com>\n---\n drivers/net/iavf/iavf_ethdev.c | 3 ---\n 1 file changed, 3 deletions(-)", "diff": "diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c\nindex 349c82cae..f16aff531 100644\n--- a/drivers/net/iavf/iavf_ethdev.c\n+++ b/drivers/net/iavf/iavf_ethdev.c\n@@ -978,9 +978,6 @@ iavf_dev_set_default_mac_addr(struct rte_eth_dev *dev,\n \told_addr = (struct rte_ether_addr *)hw->mac.addr;\n \tperm_addr = (struct rte_ether_addr *)hw->mac.perm_addr;\n \n-\tif (rte_is_same_ether_addr(mac_addr, old_addr))\n-\t\treturn 0;\n-\n \t/* If the MAC address is configured by host, skip the setting */\n \tif (rte_is_valid_assigned_ether_addr(perm_addr))\n \t\treturn -EPERM;\n", "prefixes": [ "4/7" ] }