Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/75366/?format=api
{ "id": 75366, "url": "http://patches.dpdk.org/api/patches/75366/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200811062917.7007-3-stevex.yang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200811062917.7007-3-stevex.yang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200811062917.7007-3-stevex.yang@intel.com", "date": "2020-08-11T06:29:12", "name": "[2/7] net/iavf: set speed to undefined for default case", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "3d82916eb285de45d801492139e4733fd2389bb7", "submitter": { "id": 1883, "url": "http://patches.dpdk.org/api/people/1883/?format=api", "name": "Steve Yang", "email": "stevex.yang@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200811062917.7007-3-stevex.yang@intel.com/mbox/", "series": [ { "id": 11583, "url": "http://patches.dpdk.org/api/series/11583/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11583", "date": "2020-08-11T06:29:10", "name": "Bugs Porting from I40evf For IAVF Feature", "version": 1, "mbox": "http://patches.dpdk.org/series/11583/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/75366/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/75366/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C7B11A04D8;\n\tTue, 11 Aug 2020 08:49:37 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E9B3A1C07D;\n\tTue, 11 Aug 2020 08:49:31 +0200 (CEST)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n by dpdk.org (Postfix) with ESMTP id 750AE1C00D\n for <dev@dpdk.org>; Tue, 11 Aug 2020 08:49:29 +0200 (CEST)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 10 Aug 2020 23:49:29 -0700", "from intel-npg-odc-srv01.cd.intel.com ([10.240.178.134])\n by fmsmga001.fm.intel.com with ESMTP; 10 Aug 2020 23:49:27 -0700" ], "IronPort-SDR": [ "\n PlbekWEbxeilZ5doQPj/hrcxksrHR7fEV7XIJwNMsYvlS07uTyUcv7F2TG2Qkf61X/qH7eIYT1\n YWOsoodKcMSg==", "\n +cYmaH/yrmcWowajs2Ab7e1ChY/m1TYppkWQJRF0GlMdX1Xeb1IWXOHYZjkWEXi8Gx16t8//2d\n dMa3DiULQRlg==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9709\"; a=\"171722156\"", "E=Sophos;i=\"5.75,460,1589266800\"; d=\"scan'208\";a=\"171722156\"", "E=Sophos;i=\"5.75,460,1589266800\"; d=\"scan'208\";a=\"398445740\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "SteveX Yang <stevex.yang@intel.com>", "To": "jingjing.wu@intel.com,\n\tbeilei.xing@intel.com,\n\tdev@dpdk.org", "Cc": "SteveX Yang <stevex.yang@intel.com>", "Date": "Tue, 11 Aug 2020 06:29:12 +0000", "Message-Id": "<20200811062917.7007-3-stevex.yang@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200811062917.7007-1-stevex.yang@intel.com>", "References": "<20200811062917.7007-1-stevex.yang@intel.com>", "Subject": "[dpdk-dev] [PATCH 2/7] net/iavf: set speed to undefined for default\n\tcase", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "During PF/VF link update, a default speed value of 100M will be set\nif get_link_info has failed or speed is unknown.\n\nConsequently if PF is put in no-carrier state, VFs will switch to\n\"in carrier\" state due to a link up + a link speed set to 100M\n(default value if no speed detected).\n\nTo be consistent with linux drivers on which PF and VFs are in\nsame carrier state, sets default speed to undefined (instead of 100M)\nand updates a link status of VF only if link is up and speed is\ndifferent from undefined.\n\nFixes: 48de41ca11f0 (\"net/avf: enable link status update\")\n\nSigned-off-by: SteveX Yang <stevex.yang@intel.com>\n---\n drivers/net/iavf/iavf_ethdev.c | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c\nindex f9dd5710c..ae508f2f0 100644\n--- a/drivers/net/iavf/iavf_ethdev.c\n+++ b/drivers/net/iavf/iavf_ethdev.c\n@@ -620,8 +620,9 @@ iavf_dev_link_update(struct rte_eth_dev *dev,\n \t}\n \n \tnew_link.link_duplex = ETH_LINK_FULL_DUPLEX;\n-\tnew_link.link_status = vf->link_up ? ETH_LINK_UP :\n-\t\t\t\t\t ETH_LINK_DOWN;\n+\tnew_link.link_status = (vf->link_up &&\n+\t\t\t\tnew_link.link_speed != ETH_SPEED_NUM_NONE)\n+\t\t\t\t? ETH_LINK_UP : ETH_LINK_DOWN;\n \tnew_link.link_autoneg = !(dev->data->dev_conf.link_speeds &\n \t\t\t\tETH_LINK_SPEED_FIXED);\n \n", "prefixes": [ "2/7" ] }