Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 75241,
    "url": "http://patches.dpdk.org/api/patches/75241/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200805154601.19609-3-steven.lariau@arm.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20200805154601.19609-3-steven.lariau@arm.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20200805154601.19609-3-steven.lariau@arm.com",
    "date": "2020-08-05T15:45:59",
    "name": "[2/4] test/stack: launch tests with mp remote launch API",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "24716248375e4d744fd8b962b386a79ab3b5fd1b",
    "submitter": {
        "id": 1862,
        "url": "http://patches.dpdk.org/api/people/1862/?format=api",
        "name": "Steven Lariau",
        "email": "steven.lariau@arm.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200805154601.19609-3-steven.lariau@arm.com/mbox/",
    "series": [
        {
            "id": 11525,
            "url": "http://patches.dpdk.org/api/series/11525/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11525",
            "date": "2020-08-05T15:45:57",
            "name": "test/stack: improve multithreaded test",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/11525/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/75241/comments/",
    "check": "warning",
    "checks": "http://patches.dpdk.org/api/patches/75241/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id ED6A2A0351;\n\tThu,  6 Aug 2020 12:27:46 +0200 (CEST)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 33AB01C0D1;\n\tThu,  6 Aug 2020 12:27:37 +0200 (CEST)",
            "from foss.arm.com (foss.arm.com [217.140.110.172])\n by dpdk.org (Postfix) with ESMTP id 04BC82B98\n for <dev@dpdk.org>; Wed,  5 Aug 2020 17:46:25 +0200 (CEST)",
            "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 754CD1476;\n Wed,  5 Aug 2020 08:46:24 -0700 (PDT)",
            "from localhost.localdomain (unknown [10.57.38.158])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 95A053F7D7;\n Wed,  5 Aug 2020 08:46:23 -0700 (PDT)"
        ],
        "From": "Steven Lariau <steven.lariau@arm.com>",
        "To": "Gage Eads <gage.eads@intel.com>,\n\tOlivier Matz <olivier.matz@6wind.com>",
        "Cc": "dev@dpdk.org, honnappa.nagarahalli@arm.com, nd@arm.com,\n Steven Lariau <steven.lariau@arm.com>",
        "Date": "Wed,  5 Aug 2020 16:45:59 +0100",
        "Message-Id": "<20200805154601.19609-3-steven.lariau@arm.com>",
        "X-Mailer": "git-send-email 2.17.1",
        "In-Reply-To": "<20200805154601.19609-1-steven.lariau@arm.com>",
        "References": "<20200805154601.19609-1-steven.lariau@arm.com>",
        "X-Mailman-Approved-At": "Thu, 06 Aug 2020 12:27:33 +0200",
        "Subject": "[dpdk-dev] [PATCH 2/4] test/stack: launch tests with mp remote\n\tlaunch API",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "All the cores use the same argument object, so there is no need to use\na loop to launch the test on every core one by one.\nReplace loop with one call to rte_eal_mp_remote_launch\n\n\nSigned-off-by: Steven Lariau <steven.lariau@arm.com>\nReviewed-by: Dharmik Thakkar <dharmik.thakkar@arm.com>\nReviewed-by: Phil Yang <phil.yang@arm.com>\nReviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>\n---\n app/test/test_stack.c | 11 ++---------\n 1 file changed, 2 insertions(+), 9 deletions(-)",
    "diff": "diff --git a/app/test/test_stack.c b/app/test/test_stack.c\nindex 5a7273a7d..c100d9faf 100644\n--- a/app/test/test_stack.c\n+++ b/app/test/test_stack.c\n@@ -322,7 +322,6 @@ static int\n test_stack_multithreaded(uint32_t flags)\n {\n \tstruct test_args args;\n-\tunsigned int lcore_id;\n \tstruct rte_stack *s;\n \trte_atomic64_t size;\n \n@@ -345,14 +344,8 @@ test_stack_multithreaded(uint32_t flags)\n \targs.s = s;\n \targs.sz = &size;\n \n-\tRTE_LCORE_FOREACH_SLAVE(lcore_id) {\n-\t\tif (rte_eal_remote_launch(stack_thread_push_pop,\n-\t\t\t\t\t  &args, lcore_id))\n-\t\t\trte_panic(\"Failed to launch lcore %d\\n\", lcore_id);\n-\t}\n-\n-\tstack_thread_push_pop(&args);\n-\n+\tif (rte_eal_mp_remote_launch(stack_thread_push_pop, &args, CALL_MASTER))\n+\t\trte_panic(\"Failed to launch tests\\n\");\n \trte_eal_mp_wait_lcore();\n \n \trte_stack_free(s);\n",
    "prefixes": [
        "2/4"
    ]
}