Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/75103/?format=api
{ "id": 75103, "url": "http://patches.dpdk.org/api/patches/75103/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/4e9c6206a7fd6a119349df92ce6b3e625eedb2da.1596196484.git.wangyunjian@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<4e9c6206a7fd6a119349df92ce6b3e625eedb2da.1596196484.git.wangyunjian@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/4e9c6206a7fd6a119349df92ce6b3e625eedb2da.1596196484.git.wangyunjian@huawei.com", "date": "2020-07-31T12:08:55", "name": "[1/2] net/bnxt: fix memory leak when freeing vf_info", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "9747fc3745f244439f13fd9451b07f9dd601195c", "submitter": { "id": 551, "url": "http://patches.dpdk.org/api/people/551/?format=api", "name": "Yunjian Wang", "email": "wangyunjian@huawei.com" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/4e9c6206a7fd6a119349df92ce6b3e625eedb2da.1596196484.git.wangyunjian@huawei.com/mbox/", "series": [ { "id": 11437, "url": "http://patches.dpdk.org/api/series/11437/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11437", "date": "2020-07-31T12:08:35", "name": "fixes for bnxt driver", "version": 1, "mbox": "http://patches.dpdk.org/series/11437/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/75103/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/75103/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 73973A052B;\n\tFri, 31 Jul 2020 14:09:09 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 8628A1C025;\n\tFri, 31 Jul 2020 14:09:08 +0200 (CEST)", "from huawei.com (szxga06-in.huawei.com [45.249.212.32])\n by dpdk.org (Postfix) with ESMTP id 3F28B1C00F;\n Fri, 31 Jul 2020 14:09:07 +0200 (CEST)", "from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.58])\n by Forcepoint Email with ESMTP id 50927693A84C8DA873C7;\n Fri, 31 Jul 2020 20:09:04 +0800 (CST)", "from localhost (10.174.185.168) by DGGEMS402-HUB.china.huawei.com\n (10.3.19.202) with Microsoft SMTP Server id 14.3.487.0; Fri, 31 Jul 2020\n 20:08:57 +0800" ], "From": "wangyunjian <wangyunjian@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<ajit.khaparde@broadcom.com>, <somnath.kotur@broadcom.com>,\n <jerry.lilijun@huawei.com>, <xudingke@huawei.com>, Yunjian Wang\n <wangyunjian@huawei.com>, <stable@dpdk.org>", "Date": "Fri, 31 Jul 2020 20:08:55 +0800", "Message-ID": "\n <4e9c6206a7fd6a119349df92ce6b3e625eedb2da.1596196484.git.wangyunjian@huawei.com>", "X-Mailer": "git-send-email 1.9.5.msysgit.1", "In-Reply-To": "<cover.1596196484.git.wangyunjian@huawei.com>", "References": "<cover.1596196484.git.wangyunjian@huawei.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.174.185.168]", "X-CFilter-Loop": "Reflected", "Subject": "[dpdk-dev] [PATCH 1/2] net/bnxt: fix memory leak when freeing\n\tvf_info", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Yunjian Wang <wangyunjian@huawei.com>\n\nWhen freeing a vf_info, we should free the 'vlan_as_table'\nand 'vlan_table' for the vf_info.\n\nFixes: b7778e8a1c00 (\"net/bnxt: refactor to properly allocate resources for PF/VF\")\nCc: stable@dpdk.org\n\nSigned-off-by: Yunjian Wang <wangyunjian@huawei.com>\n---\n drivers/net/bnxt/bnxt_ethdev.c | 3 +--\n drivers/net/bnxt/bnxt_hwrm.c | 16 +++++++++++++++-\n drivers/net/bnxt/bnxt_hwrm.h | 1 +\n 3 files changed, 17 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex 510a0d9e0..e64c147be 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -1360,8 +1360,7 @@ static void bnxt_dev_close_op(struct rte_eth_dev *eth_dev)\n \trte_memzone_free((const struct rte_memzone *)bp->rx_mem_zone);\n \tbp->rx_mem_zone = NULL;\n \n-\trte_free(bp->pf->vf_info);\n-\tbp->pf->vf_info = NULL;\n+\tbnxt_hwrm_free_vf_info(bp);\n \n \trte_free(bp->grp_info);\n \tbp->grp_info = NULL;\ndiff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c\nindex 8296d1d44..643dd9897 100644\n--- a/drivers/net/bnxt/bnxt_hwrm.c\n+++ b/drivers/net/bnxt/bnxt_hwrm.c\n@@ -670,6 +670,20 @@ static int bnxt_hwrm_ptp_qcfg(struct bnxt *bp)\n \treturn 0;\n }\n \n+void bnxt_hwrm_free_vf_info(struct bnxt *bp)\n+{\n+\tint i;\n+\n+\tfor (i = 0; i < bp->pf->max_vfs; i++) {\n+\t\trte_free(bp->pf->vf_info[i].vlan_table);\n+\t\tbp->pf->vf_info[i].vlan_table = NULL;\n+\t\trte_free(bp->pf->vf_info[i].vlan_as_table);\n+\t\tbp->pf->vf_info[i].vlan_as_table = NULL;\n+\t}\n+\trte_free(bp->pf->vf_info);\n+\tbp->pf->vf_info = NULL;\n+}\n+\n static int __bnxt_hwrm_func_qcaps(struct bnxt *bp)\n {\n \tint rc = 0;\n@@ -696,7 +710,7 @@ static int __bnxt_hwrm_func_qcaps(struct bnxt *bp)\n \t\tnew_max_vfs = bp->pdev->max_vfs;\n \t\tif (new_max_vfs != bp->pf->max_vfs) {\n \t\t\tif (bp->pf->vf_info)\n-\t\t\t\trte_free(bp->pf->vf_info);\n+\t\t\t\tbnxt_hwrm_free_vf_info(bp);\n \t\t\tbp->pf->vf_info = rte_malloc(\"bnxt_vf_info\",\n \t\t\t sizeof(bp->pf->vf_info[0]) * new_max_vfs, 0);\n \t\t\tbp->pf->max_vfs = new_max_vfs;\ndiff --git a/drivers/net/bnxt/bnxt_hwrm.h b/drivers/net/bnxt/bnxt_hwrm.h\nindex 4a2af13c9..eaabe1ffc 100644\n--- a/drivers/net/bnxt/bnxt_hwrm.h\n+++ b/drivers/net/bnxt/bnxt_hwrm.h\n@@ -280,4 +280,5 @@ int bnxt_clear_one_vnic_filter(struct bnxt *bp,\n \t\t\t struct bnxt_filter_info *filter);\n int bnxt_hwrm_cfa_vfr_alloc(struct bnxt *bp, uint16_t vf_idx);\n int bnxt_hwrm_cfa_vfr_free(struct bnxt *bp, uint16_t vf_idx);\n+void bnxt_hwrm_free_vf_info(struct bnxt *bp);\n #endif\n", "prefixes": [ "1/2" ] }