Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/75009/?format=api
{ "id": 75009, "url": "http://patches.dpdk.org/api/patches/75009/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200729140459.5227-4-somnath.kotur@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200729140459.5227-4-somnath.kotur@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200729140459.5227-4-somnath.kotur@broadcom.com", "date": "2020-07-29T14:04:58", "name": "[3/4] net/bnxt: cleanups and checks for ulp context allocation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "dad00b12b0043500083feb649359a01ea23d7b4d", "submitter": { "id": 908, "url": "http://patches.dpdk.org/api/people/908/?format=api", "name": "Somnath Kotur", "email": "somnath.kotur@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200729140459.5227-4-somnath.kotur@broadcom.com/mbox/", "series": [ { "id": 11403, "url": "http://patches.dpdk.org/api/series/11403/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11403", "date": "2020-07-29T14:04:55", "name": "bnxt patches", "version": 1, "mbox": "http://patches.dpdk.org/series/11403/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/75009/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/75009/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 62726A052B;\n\tWed, 29 Jul 2020 16:11:13 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 531731C038;\n\tWed, 29 Jul 2020 16:10:42 +0200 (CEST)", "from relay.smtp.broadcom.com (unknown [192.19.232.149])\n by dpdk.org (Postfix) with ESMTP id C53E41C023\n for <dev@dpdk.org>; Wed, 29 Jul 2020 16:10:36 +0200 (CEST)", "from dhcp-10-123-153-55.dhcp.broadcom.net\n (bgccx-dev-host-lnx35.bec.broadcom.net [10.123.153.55])\n by relay.smtp.broadcom.com (Postfix) with ESMTP id 4AAA31BDB0A;\n Wed, 29 Jul 2020 07:10:35 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 relay.smtp.broadcom.com 4AAA31BDB0A", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1596031836;\n bh=t0H1+xtEmnYsj0XTbjLVNpYU2AwXyZEcpiwOWHPQHKw=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=hDto5oSKwEWiuCChKQ+PJek6EZNEM2HE62yYnSu9+JULTSvEz/Ol1VEhMeMasNqye\n faFhMJy5pqUuY2yRW2Ou4IgY21Ja0+Nnm3VAq62+cZPSCUif4ptqjoTSWxRLBFCNZa\n 43yVlRWoLtdO5sq2D/FfHjAc9jrdrkjEwpQvmzYo=", "From": "Somnath Kotur <somnath.kotur@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com", "Date": "Wed, 29 Jul 2020 19:34:58 +0530", "Message-Id": "<20200729140459.5227-4-somnath.kotur@broadcom.com>", "X-Mailer": "git-send-email 2.10.1.613.g2cc2e70", "In-Reply-To": "<20200729140459.5227-1-somnath.kotur@broadcom.com>", "References": "<20200729140459.5227-1-somnath.kotur@broadcom.com>", "Subject": "[dpdk-dev] [PATCH 3/4] net/bnxt: cleanups and checks for ulp\n\tcontext allocation", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Set ulp_ctx explicitly to NULL in ulp_ctx_deinit() so that representor\ninit is aborted if parent ulp context is not initialized.\nAlso check for the same before creation of port default rules.\nAdditional checks in VF rep dev ops for proper parent dev initialization\n\nFixes: 322bd6e70272 (\"net/bnxt: add port representor infrastructure\")\nFixes: 313ac35ac701 (\"net/bnxt: support ULP session manager init\")\n\nReviewed-by: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>\nSigned-off-by: Somnath Kotur <somnath.kotur@broadcom.com>\n---\n drivers/net/bnxt/bnxt_reps.c | 18 ++++++++++++++++++\n drivers/net/bnxt/tf_ulp/bnxt_ulp.c | 2 ++\n drivers/net/bnxt/tf_ulp/ulp_def_rules.c | 2 +-\n 3 files changed, 21 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_reps.c b/drivers/net/bnxt/bnxt_reps.c\nindex 6fa9a30..2941aff 100644\n--- a/drivers/net/bnxt/bnxt_reps.c\n+++ b/drivers/net/bnxt/bnxt_reps.c\n@@ -319,6 +319,7 @@ static int bnxt_vfr_alloc(struct rte_eth_dev *vfr_ethdev)\n {\n \tint rc = 0;\n \tstruct bnxt_vf_representor *vfr = vfr_ethdev->data->dev_private;\n+\tstruct bnxt *parent_bp;\n \n \tif (!vfr || !vfr->parent_dev) {\n \t\tPMD_DRV_LOG(ERR,\n@@ -326,6 +327,13 @@ static int bnxt_vfr_alloc(struct rte_eth_dev *vfr_ethdev)\n \t\treturn -ENOMEM;\n \t}\n \n+\tparent_bp = vfr->parent_dev->data->dev_private;\n+\tif (parent_bp && !parent_bp->ulp_ctx) {\n+\t\tPMD_DRV_LOG(ERR,\n+\t\t\t \"ulp context not allocated for parent\\n\");\n+\t\treturn -EIO;\n+\t}\n+\n \t/* Check if representor has been already allocated in FW */\n \tif (vfr->vfr_tx_cfa_action)\n \t\treturn 0;\n@@ -534,6 +542,11 @@ int bnxt_vf_rep_rx_queue_setup_op(struct rte_eth_dev *eth_dev,\n \t\treturn -EINVAL;\n \t}\n \n+\tif (!parent_bp->rx_queues) {\n+\t\tPMD_DRV_LOG(ERR, \"Parent Rx qs not configured yet\\n\");\n+\t\treturn -EINVAL;\n+\t}\n+\n \tparent_rxq = parent_bp->rx_queues[queue_idx];\n \tif (!parent_rxq) {\n \t\tPMD_DRV_LOG(ERR, \"Parent RxQ has not been configured yet\\n\");\n@@ -628,6 +641,11 @@ int bnxt_vf_rep_tx_queue_setup_op(struct rte_eth_dev *eth_dev,\n \t\treturn -EINVAL;\n \t}\n \n+\tif (!parent_bp->tx_queues) {\n+\t\tPMD_DRV_LOG(ERR, \"Parent Tx qs not configured yet\\n\");\n+\t\treturn -EINVAL;\n+\t}\n+\n \tparent_txq = parent_bp->tx_queues[queue_idx];\n \tif (!parent_txq) {\n \t\tPMD_DRV_LOG(ERR, \"Parent TxQ has not been configured yet\\n\");\ndiff --git a/drivers/net/bnxt/tf_ulp/bnxt_ulp.c b/drivers/net/bnxt/tf_ulp/bnxt_ulp.c\nindex 077527f..c19cd1d 100644\n--- a/drivers/net/bnxt/tf_ulp/bnxt_ulp.c\n+++ b/drivers/net/bnxt/tf_ulp/bnxt_ulp.c\n@@ -884,6 +884,8 @@ bnxt_ulp_deinit(struct bnxt *bp)\n \tulp_session_deinit(session);\n \n \trte_free(bp->ulp_ctx);\n+\n+\tbp->ulp_ctx = NULL;\n }\n \n /* Function to set the Mark DB into the context */\ndiff --git a/drivers/net/bnxt/tf_ulp/ulp_def_rules.c b/drivers/net/bnxt/tf_ulp/ulp_def_rules.c\nindex 9fb1a02..46acc1d 100644\n--- a/drivers/net/bnxt/tf_ulp/ulp_def_rules.c\n+++ b/drivers/net/bnxt/tf_ulp/ulp_def_rules.c\n@@ -465,7 +465,7 @@ bnxt_ulp_create_df_rules(struct bnxt *bp)\n \tint rc;\n \n \tif (!BNXT_TRUFLOW_EN(bp) ||\n-\t BNXT_ETH_DEV_IS_REPRESENTOR(bp->eth_dev))\n+\t BNXT_ETH_DEV_IS_REPRESENTOR(bp->eth_dev) || !bp->ulp_ctx)\n \t\treturn 0;\n \n \tport_id = bp->eth_dev->data->port_id;\n", "prefixes": [ "3/4" ] }