Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 74433,
    "url": "http://patches.dpdk.org/api/patches/74433/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200719101816.16406-8-ophirmu@mellanox.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20200719101816.16406-8-ophirmu@mellanox.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20200719101816.16406-8-ophirmu@mellanox.com",
    "date": "2020-07-19T10:18:15",
    "name": "[v3,7/8] net/mlx5: refactor multi process communication",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "2361a08a5fad7af11c5db5a0bcec9385b54e98fb",
    "submitter": {
        "id": 793,
        "url": "http://patches.dpdk.org/api/people/793/?format=api",
        "name": "Ophir Munk",
        "email": "ophirmu@mellanox.com"
    },
    "delegate": {
        "id": 3268,
        "url": "http://patches.dpdk.org/api/users/3268/?format=api",
        "username": "rasland",
        "first_name": "Raslan",
        "last_name": "Darawsheh",
        "email": "rasland@nvidia.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200719101816.16406-8-ophirmu@mellanox.com/mbox/",
    "series": [
        {
            "id": 11146,
            "url": "http://patches.dpdk.org/api/series/11146/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11146",
            "date": "2020-07-19T10:18:08",
            "name": "mlx5 PMD multi OS support - part #3",
            "version": 3,
            "mbox": "http://patches.dpdk.org/series/11146/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/74433/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/74433/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 539C4A0540;\n\tSun, 19 Jul 2020 12:19:40 +0200 (CEST)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 41ABE1C119;\n\tSun, 19 Jul 2020 12:18:41 +0200 (CEST)",
            "from EUR05-AM6-obe.outbound.protection.outlook.com\n (mail-am6eur05on2068.outbound.protection.outlook.com [40.107.22.68])\n by dpdk.org (Postfix) with ESMTP id E7BB21C0C0\n for <dev@dpdk.org>; Sun, 19 Jul 2020 12:18:32 +0200 (CEST)",
            "from AM0PR05MB4209.eurprd05.prod.outlook.com (2603:10a6:208:61::22)\n by AM0PR05MB6324.eurprd05.prod.outlook.com (2603:10a6:208:143::14)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.25; Sun, 19 Jul\n 2020 10:18:31 +0000",
            "from AM0PR05MB4209.eurprd05.prod.outlook.com\n ([fe80::3949:70c3:126:3972]) by AM0PR05MB4209.eurprd05.prod.outlook.com\n ([fe80::3949:70c3:126:3972%7]) with mapi id 15.20.3195.024; Sun, 19 Jul 2020\n 10:18:31 +0000",
            "from mellanox.com (37.142.13.130) by\n AM0PR05CA0090.eurprd05.prod.outlook.com (2603:10a6:208:136::30) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.18 via Frontend\n Transport; Sun, 19 Jul 2020 10:18:31 +0000"
        ],
        "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=eiTzWD6AgGDt2ZMlsS2/Ll8pkfBeivx7AFKROLRrDBxtNuxIthy7XUhmZXnfUsvwKav85NhQ4f4rNpnJDG6k8mqPYwmi4wTA0XMWkDMZV/whhbanFGEC+oLsuJGp3YE1PoAEfeB11CMC0ignkVkwOlqbEoQ8x6jFA7d7DepC7m8VCKHwPu0Q87HsMAB6r9IU/FL5341HzcBQ4mGZeTuA17PEgijNoQ9Gr8EBGjo1qo7ch2yyDrip0/klQlvwk827tJu13n9lm6+etO+15OJownZX+aCkKt0aT8cAEnacMHHR9mviyzDdwC4xqJiiaTYE7PMWFUcr1KpJBl0jxOy8zw==",
        "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=iurf9sTnW7+6XiTsJG4KgOxB12uH9ZAtRP9iBE1Ymeo=;\n b=Qc1Rjo+sDpOuPIV8tblq9WtWgwezMfhNj3Jy6GACSLDy22Xv9tnPL+IYKVB6EYUj5TJ2IDV2wHM22laRiY5+RYgX5ywL/6u6A00sCffigiePwBQcHyOrcOLsj1dXv89fE6w90QalHZTExCg0GfeZ/1yuBDt1136pPFslGvV8ujMpPKgKA40GBKIBFrGPRDn78RxixVx2QDvSpl3nyU/SONwU1qmzTXz9ipz9EGl+XK6oms0ISAA3lRIQ3M5E2xNHBSKgUSw8HSy16Ke6OqhMu9aaOoQscNvyqyjorsIKI7DTmPqw0BcMK6efyGpSNQSWzbsx8dm0tS6oqBiQJee05g==",
        "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com;\n dkim=pass header.d=mellanox.com; arc=none",
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=iurf9sTnW7+6XiTsJG4KgOxB12uH9ZAtRP9iBE1Ymeo=;\n b=WMeGgRKzJsgQZ8ZZF8HaRoLj7WjXUfHJH3dOFgoqhqqydSD+Ot+JI3hCS4tfM+MWA4lp+pSJ68ITJ0GK3F/5HtmsGw7d6kdbmz+KeRVmavOyvr9+n8ckU9FB5WQuyWhrm3878nVzO7hMRGP0+MEUorPZUasMIQ54cybpRylJtJs=",
        "Authentication-Results": "dpdk.org; dkim=none (message not signed)\n header.d=none;dpdk.org; dmarc=none action=none header.from=mellanox.com;",
        "From": "Ophir Munk <ophirmu@mellanox.com>",
        "To": "dev@dpdk.org",
        "Cc": "Raslan Darawsheh <rasland@mellanox.com>,\n Ophir Munk <ophirmu@mellanox.com>,\n Matan Azrad <matan@mellanox.com>",
        "Date": "Sun, 19 Jul 2020 10:18:15 +0000",
        "Message-Id": "<20200719101816.16406-8-ophirmu@mellanox.com>",
        "X-Mailer": [
            "git-send-email 2.8.4",
            "git-send-email 2.8.4"
        ],
        "In-Reply-To": "<20200719101816.16406-1-ophirmu@mellanox.com>",
        "References": "<20200719071112.8540-9-ophirmu@mellanox.com>\n <20200719101816.16406-1-ophirmu@mellanox.com>",
        "Content-Type": "text/plain",
        "X-ClientProxiedBy": "AM0PR05CA0090.eurprd05.prod.outlook.com\n (2603:10a6:208:136::30) To AM0PR05MB4209.eurprd05.prod.outlook.com\n (2603:10a6:208:61::22)",
        "MIME-Version": "1.0",
        "X-MS-Exchange-MessageSentRepresentingType": "1",
        "X-Originating-IP": "[37.142.13.130]",
        "X-MS-PublicTrafficType": "Email",
        "X-MS-Office365-Filtering-HT": "Tenant",
        "X-MS-Office365-Filtering-Correlation-Id": "8c5d71f2-d0d5-48ad-f348-08d82bcd163d",
        "X-MS-TrafficTypeDiagnostic": "AM0PR05MB6324:",
        "X-LD-Processed": "a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtFwd",
        "X-MS-Exchange-Transport-Forked": "True",
        "X-Microsoft-Antispam-PRVS": "\n <AM0PR05MB6324AC85DD2609BCC6EECF26D17A0@AM0PR05MB6324.eurprd05.prod.outlook.com>",
        "X-MS-Oob-TLC-OOBClassifiers": "OLM:216;",
        "X-MS-Exchange-SenderADCheck": "1",
        "X-Microsoft-Antispam": "BCL:0;",
        "X-Microsoft-Antispam-Message-Info": "\n RulGBb7wdfV++MmRsvWC5nDd4Eyw0ugo/xvBZFP5YiFaGHjBqTYXprxc0Q515aZW9uCtSAen6NF7GUAzqQq+fJnYDGlY01S964577GdngwUkIBkZC82gNus3D4y+zj3Q72cKfBN+wrnOyAqEMkdh/BLEuTrvqyUq1kpdOgoXg2KrZpeY5UOmIXZDPjN88IWpIbL4Oyt1Pr9W3LhVdYj13gPa3iBhBClpIWZ8o/2vi5uaZco2Gr2FPP78yppQaYhimzD7CHMqbcy6WMJZCosWSSb84Yw5CDuRUXgmibMBdKdwCC6kV6shKP/RZIT0nXVr2mVcVM+mjwm5aIwYDU/6Tw==",
        "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:AM0PR05MB4209.eurprd05.prod.outlook.com; PTR:; CAT:NONE;\n SFTY:;\n SFS:(4636009)(396003)(346002)(376002)(136003)(39860400002)(366004)(5660300002)(316002)(2906002)(36756003)(54906003)(186003)(2616005)(6666004)(16526019)(4326008)(83380400001)(956004)(30864003)(6916009)(26005)(478600001)(52116002)(7696005)(107886003)(66556008)(86362001)(66476007)(66946007)(1076003)(55016002)(8936002)(8676002)(8886007);\n DIR:OUT; SFP:1101;",
        "X-MS-Exchange-AntiSpam-MessageData": "\n mM/gs+bK85uVAWR0+eIo8nCV/G6al9VDyKZlJS5R/5ggEsUqiaWg67BSE99u388/c6mjaoH+bSmHaJypFd7T2fC30sB3q5btEYOSQy3l5moLAOO33nRtKfHNZZseRc2EfjugjFRBNECp6Ve5t0i9Sz8NEtNZnuYIPYdGmuk0s2cxJ1+hw5eqRqn8TN6t6gAlIWWDzQVpJlvq2BFWnRhfkoU67FF9h7qSvRQ4UnzAG2SUOyRi2JN3B5+83qi0n/5JNC6TIhlXQhJxneTeQL6z9TW4LR+fEGovqAjeFJlGBmOtKeIU2B4ccv0NMSEzQGZ75KHJOPwek8h6s9Q9jWblp1iHXTCrOdJ+Vhy3Ms9yNSiDgBep7Sgf3NlacNHOh4dSGhTmYI31O2eThUSmZYXjlfXItpVMEHI5N4xodysdY7dFMOqEe7p9RKvuM8aI40KWUGeM6o1op436YAxhkc2u9Y6R2k9Cb4qDX2hFGeHeEGWCPieoxs26b9Yn4hxMMcZj",
        "X-OriginatorOrg": "Mellanox.com",
        "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 8c5d71f2-d0d5-48ad-f348-08d82bcd163d",
        "X-MS-Exchange-CrossTenant-AuthSource": "AM0PR05MB4209.eurprd05.prod.outlook.com",
        "X-MS-Exchange-CrossTenant-AuthAs": "Internal",
        "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "19 Jul 2020 10:18:31.7352 (UTC)",
        "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted",
        "X-MS-Exchange-CrossTenant-Id": "a652971c-7d2e-4d9b-a6a4-d149256f461b",
        "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED",
        "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n NF9NahgcaPiDbj1k0eijhwzP8NlyzM8MQPJFNYt00fyzbThkm4NvuyaV1hjvTshkx6ktIQYxNplNUnZUUisIBw==",
        "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "AM0PR05MB6324",
        "Subject": "[dpdk-dev] [PATCH v3 7/8] net/mlx5: refactor multi process\n\tcommunication",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "1. The shared data communication between the primary and the secondary\nprocesses is implemented using Linux API. Move the Linux API code under\nlinux directory (file linux/mlx5_os.c).\n\n2. File net/mlx5/mlx5_mp.c handles requests to the primary and secondary\nprocesses (e.g. start_rxtx, stop_rxtx). It is Linux based so it is moved\nunder linux (new file linux/mlx5_mp_os.c).\n\nSigned-off-by: Ophir Munk <ophirmu@mellanox.com>\nAcked-by: Matan Azrad <matan@mellanox.com>\n---\n drivers/net/mlx5/Makefile           |   2 +-\n drivers/net/mlx5/linux/meson.build  |   1 +\n drivers/net/mlx5/linux/mlx5_mp_os.c | 212 ++++++++++++++++++++++++++++++++++++\n drivers/net/mlx5/linux/mlx5_os.c    | 111 +++++++++++++++++++\n drivers/net/mlx5/meson.build        |   1 -\n drivers/net/mlx5/mlx5.c             | 114 +------------------\n drivers/net/mlx5/mlx5.h             |  13 ++-\n drivers/net/mlx5/mlx5_mp.c          | 212 ------------------------------------\n drivers/net/mlx5/mlx5_trigger.c     |   4 +-\n 9 files changed, 337 insertions(+), 333 deletions(-)\n create mode 100644 drivers/net/mlx5/linux/mlx5_mp_os.c\n delete mode 100644 drivers/net/mlx5/mlx5_mp.c",
    "diff": "diff --git a/drivers/net/mlx5/Makefile b/drivers/net/mlx5/Makefile\nindex 3c5f486..cca7c9e 100644\n--- a/drivers/net/mlx5/Makefile\n+++ b/drivers/net/mlx5/Makefile\n@@ -30,12 +30,12 @@ SRCS-$(CONFIG_RTE_LIBRTE_MLX5_PMD) += mlx5_flow.c\n SRCS-$(CONFIG_RTE_LIBRTE_MLX5_PMD) += mlx5_flow_meter.c\n SRCS-$(CONFIG_RTE_LIBRTE_MLX5_PMD) += mlx5_flow_dv.c\n SRCS-$(CONFIG_RTE_LIBRTE_MLX5_PMD) += mlx5_flow_verbs.c\n-SRCS-$(CONFIG_RTE_LIBRTE_MLX5_PMD) += mlx5_mp.c\n SRCS-$(CONFIG_RTE_LIBRTE_MLX5_PMD) += mlx5_utils.c\n SRCS-$(CONFIG_RTE_LIBRTE_MLX5_PMD) += linux/mlx5_socket.c\n SRCS-$(CONFIG_RTE_LIBRTE_MLX5_PMD) += linux/mlx5_os.c\n SRCS-$(CONFIG_RTE_LIBRTE_MLX5_PMD) += linux/mlx5_ethdev_os.c\n SRCS-$(CONFIG_RTE_LIBRTE_MLX5_PMD) += linux/mlx5_verbs.c\n+SRCS-$(CONFIG_RTE_LIBRTE_MLX5_PMD) += linux/mlx5_mp_os.c\n \n # Basic CFLAGS.\n CFLAGS += -O3\ndiff --git a/drivers/net/mlx5/linux/meson.build b/drivers/net/mlx5/linux/meson.build\nindex 14eed03..2def8e3 100644\n--- a/drivers/net/mlx5/linux/meson.build\n+++ b/drivers/net/mlx5/linux/meson.build\n@@ -7,5 +7,6 @@ sources += files(\n \t'mlx5_os.c',\n \t'mlx5_ethdev_os.c',\n \t'mlx5_verbs.c',\n+\t'mlx5_mp_os.c',\n )\n \ndiff --git a/drivers/net/mlx5/linux/mlx5_mp_os.c b/drivers/net/mlx5/linux/mlx5_mp_os.c\nnew file mode 100644\nindex 0000000..dd9a2c2\n--- /dev/null\n+++ b/drivers/net/mlx5/linux/mlx5_mp_os.c\n@@ -0,0 +1,212 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright 2019 6WIND S.A.\n+ * Copyright 2019 Mellanox Technologies, Ltd\n+ */\n+\n+#include <stdio.h>\n+#include <time.h>\n+\n+#include <rte_eal.h>\n+#include <rte_ethdev_driver.h>\n+#include <rte_string_fns.h>\n+\n+#include <mlx5_common_mp.h>\n+#include <mlx5_common_mr.h>\n+#include <mlx5_malloc.h>\n+\n+#include \"mlx5.h\"\n+#include \"mlx5_rxtx.h\"\n+#include \"mlx5_utils.h\"\n+\n+int\n+mlx5_mp_os_primary_handle(const struct rte_mp_msg *mp_msg, const void *peer)\n+{\n+\tstruct rte_mp_msg mp_res;\n+\tstruct mlx5_mp_param *res = (struct mlx5_mp_param *)mp_res.param;\n+\tconst struct mlx5_mp_param *param =\n+\t\t(const struct mlx5_mp_param *)mp_msg->param;\n+\tstruct rte_eth_dev *dev;\n+\tstruct mlx5_priv *priv;\n+\tstruct mr_cache_entry entry;\n+\tuint32_t lkey;\n+\tint ret;\n+\n+\tMLX5_ASSERT(rte_eal_process_type() == RTE_PROC_PRIMARY);\n+\tif (!rte_eth_dev_is_valid_port(param->port_id)) {\n+\t\trte_errno = ENODEV;\n+\t\tDRV_LOG(ERR, \"port %u invalid port ID\", param->port_id);\n+\t\treturn -rte_errno;\n+\t}\n+\tdev = &rte_eth_devices[param->port_id];\n+\tpriv = dev->data->dev_private;\n+\tswitch (param->type) {\n+\tcase MLX5_MP_REQ_CREATE_MR:\n+\t\tmp_init_msg(&priv->mp_id, &mp_res, param->type);\n+\t\tlkey = mlx5_mr_create_primary(priv->sh->pd,\n+\t\t\t\t\t      &priv->sh->share_cache,\n+\t\t\t\t\t      &entry, param->args.addr,\n+\t\t\t\t\t      priv->config.mr_ext_memseg_en);\n+\t\tif (lkey == UINT32_MAX)\n+\t\t\tres->result = -rte_errno;\n+\t\tret = rte_mp_reply(&mp_res, peer);\n+\t\tbreak;\n+\tcase MLX5_MP_REQ_VERBS_CMD_FD:\n+\t\tmp_init_msg(&priv->mp_id, &mp_res, param->type);\n+\t\tmp_res.num_fds = 1;\n+\t\tmp_res.fds[0] = ((struct ibv_context *)priv->sh->ctx)->cmd_fd;\n+\t\tres->result = 0;\n+\t\tret = rte_mp_reply(&mp_res, peer);\n+\t\tbreak;\n+\tcase MLX5_MP_REQ_QUEUE_STATE_MODIFY:\n+\t\tmp_init_msg(&priv->mp_id, &mp_res, param->type);\n+\t\tres->result = mlx5_queue_state_modify_primary\n+\t\t\t\t\t(dev, &param->args.state_modify);\n+\t\tret = rte_mp_reply(&mp_res, peer);\n+\t\tbreak;\n+\tdefault:\n+\t\trte_errno = EINVAL;\n+\t\tDRV_LOG(ERR, \"port %u invalid mp request type\",\n+\t\t\tdev->data->port_id);\n+\t\treturn -rte_errno;\n+\t}\n+\treturn ret;\n+}\n+\n+/**\n+ * IPC message handler of a secondary process.\n+ *\n+ * @param[in] dev\n+ *   Pointer to Ethernet structure.\n+ * @param[in] peer\n+ *   Pointer to the peer socket path.\n+ *\n+ * @return\n+ *   0 on success, a negative errno value otherwise and rte_errno is set.\n+ */\n+int\n+mlx5_mp_os_secondary_handle(const struct rte_mp_msg *mp_msg, const void *peer)\n+{\n+\tstruct rte_mp_msg mp_res;\n+\tstruct mlx5_mp_param *res = (struct mlx5_mp_param *)mp_res.param;\n+\tconst struct mlx5_mp_param *param =\n+\t\t(const struct mlx5_mp_param *)mp_msg->param;\n+\tstruct rte_eth_dev *dev;\n+\tstruct mlx5_priv *priv;\n+\tint ret;\n+\n+\tMLX5_ASSERT(rte_eal_process_type() == RTE_PROC_SECONDARY);\n+\tif (!rte_eth_dev_is_valid_port(param->port_id)) {\n+\t\trte_errno = ENODEV;\n+\t\tDRV_LOG(ERR, \"port %u invalid port ID\", param->port_id);\n+\t\treturn -rte_errno;\n+\t}\n+\tdev = &rte_eth_devices[param->port_id];\n+\tpriv = dev->data->dev_private;\n+\tswitch (param->type) {\n+\tcase MLX5_MP_REQ_START_RXTX:\n+\t\tDRV_LOG(INFO, \"port %u starting datapath\", dev->data->port_id);\n+\t\trte_mb();\n+\t\tdev->rx_pkt_burst = mlx5_select_rx_function(dev);\n+\t\tdev->tx_pkt_burst = mlx5_select_tx_function(dev);\n+\t\tmp_init_msg(&priv->mp_id, &mp_res, param->type);\n+\t\tres->result = 0;\n+\t\tret = rte_mp_reply(&mp_res, peer);\n+\t\tbreak;\n+\tcase MLX5_MP_REQ_STOP_RXTX:\n+\t\tDRV_LOG(INFO, \"port %u stopping datapath\", dev->data->port_id);\n+\t\tdev->rx_pkt_burst = removed_rx_burst;\n+\t\tdev->tx_pkt_burst = removed_tx_burst;\n+\t\trte_mb();\n+\t\tmp_init_msg(&priv->mp_id, &mp_res, param->type);\n+\t\tres->result = 0;\n+\t\tret = rte_mp_reply(&mp_res, peer);\n+\t\tbreak;\n+\tdefault:\n+\t\trte_errno = EINVAL;\n+\t\tDRV_LOG(ERR, \"port %u invalid mp request type\",\n+\t\t\tdev->data->port_id);\n+\t\treturn -rte_errno;\n+\t}\n+\treturn ret;\n+}\n+\n+/**\n+ * Broadcast request of stopping/starting data-path to secondary processes.\n+ *\n+ * @param[in] dev\n+ *   Pointer to Ethernet structure.\n+ * @param[in] type\n+ *   Request type.\n+ */\n+static void\n+mp_req_on_rxtx(struct rte_eth_dev *dev, enum mlx5_mp_req_type type)\n+{\n+\tstruct rte_mp_msg mp_req;\n+\tstruct rte_mp_msg *mp_res;\n+\tstruct rte_mp_reply mp_rep;\n+\tstruct mlx5_mp_param *res;\n+\tstruct timespec ts = {.tv_sec = MLX5_MP_REQ_TIMEOUT_SEC, .tv_nsec = 0};\n+\tstruct mlx5_priv *priv = dev->data->dev_private;\n+\tint ret;\n+\tint i;\n+\n+\tMLX5_ASSERT(rte_eal_process_type() == RTE_PROC_PRIMARY);\n+\tif (!mlx5_shared_data->secondary_cnt)\n+\t\treturn;\n+\tif (type != MLX5_MP_REQ_START_RXTX && type != MLX5_MP_REQ_STOP_RXTX) {\n+\t\tDRV_LOG(ERR, \"port %u unknown request (req_type %d)\",\n+\t\t\tdev->data->port_id, type);\n+\t\treturn;\n+\t}\n+\tmp_init_msg(&priv->mp_id, &mp_req, type);\n+\tret = rte_mp_request_sync(&mp_req, &mp_rep, &ts);\n+\tif (ret) {\n+\t\tif (rte_errno != ENOTSUP)\n+\t\t\tDRV_LOG(ERR, \"port %u failed to request stop/start Rx/Tx (%d)\",\n+\t\t\t\tdev->data->port_id, type);\n+\t\tgoto exit;\n+\t}\n+\tif (mp_rep.nb_sent != mp_rep.nb_received) {\n+\t\tDRV_LOG(ERR,\n+\t\t\t\"port %u not all secondaries responded (req_type %d)\",\n+\t\t\tdev->data->port_id, type);\n+\t\tgoto exit;\n+\t}\n+\tfor (i = 0; i < mp_rep.nb_received; i++) {\n+\t\tmp_res = &mp_rep.msgs[i];\n+\t\tres = (struct mlx5_mp_param *)mp_res->param;\n+\t\tif (res->result) {\n+\t\t\tDRV_LOG(ERR, \"port %u request failed on secondary #%d\",\n+\t\t\t\tdev->data->port_id, i);\n+\t\t\tgoto exit;\n+\t\t}\n+\t}\n+exit:\n+\tmlx5_free(mp_rep.msgs);\n+}\n+\n+/**\n+ * Broadcast request of starting data-path to secondary processes. The request\n+ * is synchronous.\n+ *\n+ * @param[in] dev\n+ *   Pointer to Ethernet structure.\n+ */\n+void\n+mlx5_mp_os_req_start_rxtx(struct rte_eth_dev *dev)\n+{\n+\tmp_req_on_rxtx(dev, MLX5_MP_REQ_START_RXTX);\n+}\n+\n+/**\n+ * Broadcast request of stopping data-path to secondary processes. The request\n+ * is synchronous.\n+ *\n+ * @param[in] dev\n+ *   Pointer to Ethernet structure.\n+ */\n+void\n+mlx5_mp_os_req_stop_rxtx(struct rte_eth_dev *dev)\n+{\n+\tmp_req_on_rxtx(dev, MLX5_MP_REQ_STOP_RXTX);\n+}\ndiff --git a/drivers/net/mlx5/linux/mlx5_os.c b/drivers/net/mlx5/linux/mlx5_os.c\nindex d3ae3ad..70460ee 100644\n--- a/drivers/net/mlx5/linux/mlx5_os.c\n+++ b/drivers/net/mlx5/linux/mlx5_os.c\n@@ -67,6 +67,14 @@\n #define MLX5DV_CONTEXT_FLAGS_CQE_128B_COMP (1 << 4)\n #endif\n \n+static const char *MZ_MLX5_PMD_SHARED_DATA = \"mlx5_pmd_shared_data\";\n+\n+/* Spinlock for mlx5_shared_data allocation. */\n+static rte_spinlock_t mlx5_shared_data_lock = RTE_SPINLOCK_INITIALIZER;\n+\n+/* Process local data for secondary processes. */\n+static struct mlx5_local_data mlx5_local_data;\n+\n /**\n  * Get mlx5 device attributes. The glue function query_device_ex() is called\n  * with out parameter of type 'struct ibv_device_attr_ex *'. Then fill in mlx5\n@@ -357,6 +365,109 @@ mlx5_os_free_shared_dr(struct mlx5_priv *priv)\n }\n \n /**\n+ * Initialize shared data between primary and secondary process.\n+ *\n+ * A memzone is reserved by primary process and secondary processes attach to\n+ * the memzone.\n+ *\n+ * @return\n+ *   0 on success, a negative errno value otherwise and rte_errno is set.\n+ */\n+static int\n+mlx5_init_shared_data(void)\n+{\n+\tconst struct rte_memzone *mz;\n+\tint ret = 0;\n+\n+\trte_spinlock_lock(&mlx5_shared_data_lock);\n+\tif (mlx5_shared_data == NULL) {\n+\t\tif (rte_eal_process_type() == RTE_PROC_PRIMARY) {\n+\t\t\t/* Allocate shared memory. */\n+\t\t\tmz = rte_memzone_reserve(MZ_MLX5_PMD_SHARED_DATA,\n+\t\t\t\t\t\t sizeof(*mlx5_shared_data),\n+\t\t\t\t\t\t SOCKET_ID_ANY, 0);\n+\t\t\tif (mz == NULL) {\n+\t\t\t\tDRV_LOG(ERR,\n+\t\t\t\t\t\"Cannot allocate mlx5 shared data\");\n+\t\t\t\tret = -rte_errno;\n+\t\t\t\tgoto error;\n+\t\t\t}\n+\t\t\tmlx5_shared_data = mz->addr;\n+\t\t\tmemset(mlx5_shared_data, 0, sizeof(*mlx5_shared_data));\n+\t\t\trte_spinlock_init(&mlx5_shared_data->lock);\n+\t\t} else {\n+\t\t\t/* Lookup allocated shared memory. */\n+\t\t\tmz = rte_memzone_lookup(MZ_MLX5_PMD_SHARED_DATA);\n+\t\t\tif (mz == NULL) {\n+\t\t\t\tDRV_LOG(ERR,\n+\t\t\t\t\t\"Cannot attach mlx5 shared data\");\n+\t\t\t\tret = -rte_errno;\n+\t\t\t\tgoto error;\n+\t\t\t}\n+\t\t\tmlx5_shared_data = mz->addr;\n+\t\t\tmemset(&mlx5_local_data, 0, sizeof(mlx5_local_data));\n+\t\t}\n+\t}\n+error:\n+\trte_spinlock_unlock(&mlx5_shared_data_lock);\n+\treturn ret;\n+}\n+\n+/**\n+ * PMD global initialization.\n+ *\n+ * Independent from individual device, this function initializes global\n+ * per-PMD data structures distinguishing primary and secondary processes.\n+ * Hence, each initialization is called once per a process.\n+ *\n+ * @return\n+ *   0 on success, a negative errno value otherwise and rte_errno is set.\n+ */\n+static int\n+mlx5_init_once(void)\n+{\n+\tstruct mlx5_shared_data *sd;\n+\tstruct mlx5_local_data *ld = &mlx5_local_data;\n+\tint ret = 0;\n+\n+\tif (mlx5_init_shared_data())\n+\t\treturn -rte_errno;\n+\tsd = mlx5_shared_data;\n+\tMLX5_ASSERT(sd);\n+\trte_spinlock_lock(&sd->lock);\n+\tswitch (rte_eal_process_type()) {\n+\tcase RTE_PROC_PRIMARY:\n+\t\tif (sd->init_done)\n+\t\t\tbreak;\n+\t\tLIST_INIT(&sd->mem_event_cb_list);\n+\t\trte_rwlock_init(&sd->mem_event_rwlock);\n+\t\trte_mem_event_callback_register(\"MLX5_MEM_EVENT_CB\",\n+\t\t\t\t\t\tmlx5_mr_mem_event_cb, NULL);\n+\t\tret = mlx5_mp_init_primary(MLX5_MP_NAME,\n+\t\t\t\t\t   mlx5_mp_os_primary_handle);\n+\t\tif (ret)\n+\t\t\tgoto out;\n+\t\tsd->init_done = true;\n+\t\tbreak;\n+\tcase RTE_PROC_SECONDARY:\n+\t\tif (ld->init_done)\n+\t\t\tbreak;\n+\t\tret = mlx5_mp_init_secondary(MLX5_MP_NAME,\n+\t\t\t\t\t     mlx5_mp_os_secondary_handle);\n+\t\tif (ret)\n+\t\t\tgoto out;\n+\t\t++sd->secondary_cnt;\n+\t\tld->init_done = true;\n+\t\tbreak;\n+\tdefault:\n+\t\tbreak;\n+\t}\n+out:\n+\trte_spinlock_unlock(&sd->lock);\n+\treturn ret;\n+}\n+\n+/**\n  * Spawn an Ethernet device from Verbs information.\n  *\n  * @param dpdk_dev\ndiff --git a/drivers/net/mlx5/meson.build b/drivers/net/mlx5/meson.build\nindex e35d90b..3aefb85 100644\n--- a/drivers/net/mlx5/meson.build\n+++ b/drivers/net/mlx5/meson.build\n@@ -22,7 +22,6 @@ sources = files(\n \t'mlx5_rxmode.c',\n \t'mlx5_rxq.c',\n \t'mlx5_rxtx.c',\n-\t'mlx5_mp.c',\n \t'mlx5_stats.c',\n \t'mlx5_trigger.c',\n \t'mlx5_txq.c',\ndiff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c\nindex ab9cb8a..b6d5953 100644\n--- a/drivers/net/mlx5/mlx5.c\n+++ b/drivers/net/mlx5/mlx5.c\n@@ -187,16 +187,11 @@\n /* Decap will be used or not. */\n #define MLX5_DECAP_EN \"decap_en\"\n \n-static const char *MZ_MLX5_PMD_SHARED_DATA = \"mlx5_pmd_shared_data\";\n-\n /* Shared memory between primary and secondary processes. */\n struct mlx5_shared_data *mlx5_shared_data;\n \n-/* Spinlock for mlx5_shared_data allocation. */\n-static rte_spinlock_t mlx5_shared_data_lock = RTE_SPINLOCK_INITIALIZER;\n-\n-/* Process local data for secondary processes. */\n-static struct mlx5_local_data mlx5_local_data;\n+/** Driver-specific log messages type. */\n+int mlx5_logtype;\n \n static LIST_HEAD(, mlx5_dev_ctx_shared) mlx5_dev_ctx_list =\n \t\t\t\t\t\tLIST_HEAD_INITIALIZER();\n@@ -1118,55 +1113,6 @@ mlx5_alloc_table_hash_list(struct mlx5_priv *priv)\n }\n \n /**\n- * Initialize shared data between primary and secondary process.\n- *\n- * A memzone is reserved by primary process and secondary processes attach to\n- * the memzone.\n- *\n- * @return\n- *   0 on success, a negative errno value otherwise and rte_errno is set.\n- */\n-static int\n-mlx5_init_shared_data(void)\n-{\n-\tconst struct rte_memzone *mz;\n-\tint ret = 0;\n-\n-\trte_spinlock_lock(&mlx5_shared_data_lock);\n-\tif (mlx5_shared_data == NULL) {\n-\t\tif (rte_eal_process_type() == RTE_PROC_PRIMARY) {\n-\t\t\t/* Allocate shared memory. */\n-\t\t\tmz = rte_memzone_reserve(MZ_MLX5_PMD_SHARED_DATA,\n-\t\t\t\t\t\t sizeof(*mlx5_shared_data),\n-\t\t\t\t\t\t SOCKET_ID_ANY, 0);\n-\t\t\tif (mz == NULL) {\n-\t\t\t\tDRV_LOG(ERR,\n-\t\t\t\t\t\"Cannot allocate mlx5 shared data\");\n-\t\t\t\tret = -rte_errno;\n-\t\t\t\tgoto error;\n-\t\t\t}\n-\t\t\tmlx5_shared_data = mz->addr;\n-\t\t\tmemset(mlx5_shared_data, 0, sizeof(*mlx5_shared_data));\n-\t\t\trte_spinlock_init(&mlx5_shared_data->lock);\n-\t\t} else {\n-\t\t\t/* Lookup allocated shared memory. */\n-\t\t\tmz = rte_memzone_lookup(MZ_MLX5_PMD_SHARED_DATA);\n-\t\t\tif (mz == NULL) {\n-\t\t\t\tDRV_LOG(ERR,\n-\t\t\t\t\t\"Cannot attach mlx5 shared data\");\n-\t\t\t\tret = -rte_errno;\n-\t\t\t\tgoto error;\n-\t\t\t}\n-\t\t\tmlx5_shared_data = mz->addr;\n-\t\t\tmemset(&mlx5_local_data, 0, sizeof(mlx5_local_data));\n-\t\t}\n-\t}\n-error:\n-\trte_spinlock_unlock(&mlx5_shared_data_lock);\n-\treturn ret;\n-}\n-\n-/**\n  * Retrieve integer value from environment variable.\n  *\n  * @param[in] name\n@@ -1307,7 +1253,7 @@ mlx5_dev_close(struct rte_eth_dev *dev)\n \tdev->tx_pkt_burst = removed_tx_burst;\n \trte_wmb();\n \t/* Disable datapath on secondary process. */\n-\tmlx5_mp_req_stop_rxtx(dev);\n+\tmlx5_mp_os_req_stop_rxtx(dev);\n \t/* Free the eCPRI flex parser resource. */\n \tmlx5_flex_parser_ecpri_release(dev);\n \tif (priv->rxqs != NULL) {\n@@ -1640,60 +1586,6 @@ mlx5_args(struct mlx5_dev_config *config, struct rte_devargs *devargs)\n }\n \n /**\n- * PMD global initialization.\n- *\n- * Independent from individual device, this function initializes global\n- * per-PMD data structures distinguishing primary and secondary processes.\n- * Hence, each initialization is called once per a process.\n- *\n- * @return\n- *   0 on success, a negative errno value otherwise and rte_errno is set.\n- */\n-int\n-mlx5_init_once(void)\n-{\n-\tstruct mlx5_shared_data *sd;\n-\tstruct mlx5_local_data *ld = &mlx5_local_data;\n-\tint ret = 0;\n-\n-\tif (mlx5_init_shared_data())\n-\t\treturn -rte_errno;\n-\tsd = mlx5_shared_data;\n-\tMLX5_ASSERT(sd);\n-\trte_spinlock_lock(&sd->lock);\n-\tswitch (rte_eal_process_type()) {\n-\tcase RTE_PROC_PRIMARY:\n-\t\tif (sd->init_done)\n-\t\t\tbreak;\n-\t\tLIST_INIT(&sd->mem_event_cb_list);\n-\t\trte_rwlock_init(&sd->mem_event_rwlock);\n-\t\trte_mem_event_callback_register(\"MLX5_MEM_EVENT_CB\",\n-\t\t\t\t\t\tmlx5_mr_mem_event_cb, NULL);\n-\t\tret = mlx5_mp_init_primary(MLX5_MP_NAME,\n-\t\t\t\t\t   mlx5_mp_primary_handle);\n-\t\tif (ret)\n-\t\t\tgoto out;\n-\t\tsd->init_done = true;\n-\t\tbreak;\n-\tcase RTE_PROC_SECONDARY:\n-\t\tif (ld->init_done)\n-\t\t\tbreak;\n-\t\tret = mlx5_mp_init_secondary(MLX5_MP_NAME,\n-\t\t\t\t\t     mlx5_mp_secondary_handle);\n-\t\tif (ret)\n-\t\t\tgoto out;\n-\t\t++sd->secondary_cnt;\n-\t\tld->init_done = true;\n-\t\tbreak;\n-\tdefault:\n-\t\tbreak;\n-\t}\n-out:\n-\trte_spinlock_unlock(&sd->lock);\n-\treturn ret;\n-}\n-\n-/**\n  * Configures the minimal amount of data to inline into WQE\n  * while sending packets.\n  *\ndiff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h\nindex 911fd33..ae9f5ff 100644\n--- a/drivers/net/mlx5/mlx5.h\n+++ b/drivers/net/mlx5/mlx5.h\n@@ -793,7 +793,6 @@ void mlx5_set_min_inline(struct mlx5_dev_spawn_data *spawn,\n void mlx5_set_metadata_mask(struct rte_eth_dev *dev);\n int mlx5_dev_check_sibling_config(struct mlx5_priv *priv,\n \t\t\t\t  struct mlx5_dev_config *config);\n-int mlx5_init_once(void);\n int mlx5_dev_configure(struct rte_eth_dev *dev);\n int mlx5_dev_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *info);\n int mlx5_fw_version_get(struct rte_eth_dev *dev, char *fw_ver, size_t fw_size);\n@@ -978,11 +977,13 @@ void mlx5_flow_rxq_dynf_metadata_set(struct rte_eth_dev *dev);\n int mlx5_flow_get_aged_flows(struct rte_eth_dev *dev, void **contexts,\n \t\t\tuint32_t nb_contexts, struct rte_flow_error *error);\n \n-/* mlx5_mp.c */\n-int mlx5_mp_primary_handle(const struct rte_mp_msg *mp_msg, const void *peer);\n-int mlx5_mp_secondary_handle(const struct rte_mp_msg *mp_msg, const void *peer);\n-void mlx5_mp_req_start_rxtx(struct rte_eth_dev *dev);\n-void mlx5_mp_req_stop_rxtx(struct rte_eth_dev *dev);\n+/* mlx5_mp_os.c */\n+int mlx5_mp_os_primary_handle(const struct rte_mp_msg *mp_msg,\n+\t\t\t      const void *peer);\n+int mlx5_mp_os_secondary_handle(const struct rte_mp_msg *mp_msg,\n+\t\t\t\tconst void *peer);\n+void mlx5_mp_os_req_start_rxtx(struct rte_eth_dev *dev);\n+void mlx5_mp_os_req_stop_rxtx(struct rte_eth_dev *dev);\n \n /* mlx5_socket.c */\n \ndiff --git a/drivers/net/mlx5/mlx5_mp.c b/drivers/net/mlx5/mlx5_mp.c\ndeleted file mode 100644\nindex cf6e33b..0000000\n--- a/drivers/net/mlx5/mlx5_mp.c\n+++ /dev/null\n@@ -1,212 +0,0 @@\n-/* SPDX-License-Identifier: BSD-3-Clause\n- * Copyright 2019 6WIND S.A.\n- * Copyright 2019 Mellanox Technologies, Ltd\n- */\n-\n-#include <stdio.h>\n-#include <time.h>\n-\n-#include <rte_eal.h>\n-#include <rte_ethdev_driver.h>\n-#include <rte_string_fns.h>\n-\n-#include <mlx5_common_mp.h>\n-#include <mlx5_common_mr.h>\n-#include <mlx5_malloc.h>\n-\n-#include \"mlx5.h\"\n-#include \"mlx5_rxtx.h\"\n-#include \"mlx5_utils.h\"\n-\n-int\n-mlx5_mp_primary_handle(const struct rte_mp_msg *mp_msg, const void *peer)\n-{\n-\tstruct rte_mp_msg mp_res;\n-\tstruct mlx5_mp_param *res = (struct mlx5_mp_param *)mp_res.param;\n-\tconst struct mlx5_mp_param *param =\n-\t\t(const struct mlx5_mp_param *)mp_msg->param;\n-\tstruct rte_eth_dev *dev;\n-\tstruct mlx5_priv *priv;\n-\tstruct mr_cache_entry entry;\n-\tuint32_t lkey;\n-\tint ret;\n-\n-\tMLX5_ASSERT(rte_eal_process_type() == RTE_PROC_PRIMARY);\n-\tif (!rte_eth_dev_is_valid_port(param->port_id)) {\n-\t\trte_errno = ENODEV;\n-\t\tDRV_LOG(ERR, \"port %u invalid port ID\", param->port_id);\n-\t\treturn -rte_errno;\n-\t}\n-\tdev = &rte_eth_devices[param->port_id];\n-\tpriv = dev->data->dev_private;\n-\tswitch (param->type) {\n-\tcase MLX5_MP_REQ_CREATE_MR:\n-\t\tmp_init_msg(&priv->mp_id, &mp_res, param->type);\n-\t\tlkey = mlx5_mr_create_primary(priv->sh->pd,\n-\t\t\t\t\t      &priv->sh->share_cache,\n-\t\t\t\t\t      &entry, param->args.addr,\n-\t\t\t\t\t      priv->config.mr_ext_memseg_en);\n-\t\tif (lkey == UINT32_MAX)\n-\t\t\tres->result = -rte_errno;\n-\t\tret = rte_mp_reply(&mp_res, peer);\n-\t\tbreak;\n-\tcase MLX5_MP_REQ_VERBS_CMD_FD:\n-\t\tmp_init_msg(&priv->mp_id, &mp_res, param->type);\n-\t\tmp_res.num_fds = 1;\n-\t\tmp_res.fds[0] = ((struct ibv_context *)priv->sh->ctx)->cmd_fd;\n-\t\tres->result = 0;\n-\t\tret = rte_mp_reply(&mp_res, peer);\n-\t\tbreak;\n-\tcase MLX5_MP_REQ_QUEUE_STATE_MODIFY:\n-\t\tmp_init_msg(&priv->mp_id, &mp_res, param->type);\n-\t\tres->result = mlx5_queue_state_modify_primary\n-\t\t\t\t\t(dev, &param->args.state_modify);\n-\t\tret = rte_mp_reply(&mp_res, peer);\n-\t\tbreak;\n-\tdefault:\n-\t\trte_errno = EINVAL;\n-\t\tDRV_LOG(ERR, \"port %u invalid mp request type\",\n-\t\t\tdev->data->port_id);\n-\t\treturn -rte_errno;\n-\t}\n-\treturn ret;\n-}\n-\n-/**\n- * IPC message handler of a secondary process.\n- *\n- * @param[in] dev\n- *   Pointer to Ethernet structure.\n- * @param[in] peer\n- *   Pointer to the peer socket path.\n- *\n- * @return\n- *   0 on success, a negative errno value otherwise and rte_errno is set.\n- */\n-int\n-mlx5_mp_secondary_handle(const struct rte_mp_msg *mp_msg, const void *peer)\n-{\n-\tstruct rte_mp_msg mp_res;\n-\tstruct mlx5_mp_param *res = (struct mlx5_mp_param *)mp_res.param;\n-\tconst struct mlx5_mp_param *param =\n-\t\t(const struct mlx5_mp_param *)mp_msg->param;\n-\tstruct rte_eth_dev *dev;\n-\tstruct mlx5_priv *priv;\n-\tint ret;\n-\n-\tMLX5_ASSERT(rte_eal_process_type() == RTE_PROC_SECONDARY);\n-\tif (!rte_eth_dev_is_valid_port(param->port_id)) {\n-\t\trte_errno = ENODEV;\n-\t\tDRV_LOG(ERR, \"port %u invalid port ID\", param->port_id);\n-\t\treturn -rte_errno;\n-\t}\n-\tdev = &rte_eth_devices[param->port_id];\n-\tpriv = dev->data->dev_private;\n-\tswitch (param->type) {\n-\tcase MLX5_MP_REQ_START_RXTX:\n-\t\tDRV_LOG(INFO, \"port %u starting datapath\", dev->data->port_id);\n-\t\trte_mb();\n-\t\tdev->rx_pkt_burst = mlx5_select_rx_function(dev);\n-\t\tdev->tx_pkt_burst = mlx5_select_tx_function(dev);\n-\t\tmp_init_msg(&priv->mp_id, &mp_res, param->type);\n-\t\tres->result = 0;\n-\t\tret = rte_mp_reply(&mp_res, peer);\n-\t\tbreak;\n-\tcase MLX5_MP_REQ_STOP_RXTX:\n-\t\tDRV_LOG(INFO, \"port %u stopping datapath\", dev->data->port_id);\n-\t\tdev->rx_pkt_burst = removed_rx_burst;\n-\t\tdev->tx_pkt_burst = removed_tx_burst;\n-\t\trte_mb();\n-\t\tmp_init_msg(&priv->mp_id, &mp_res, param->type);\n-\t\tres->result = 0;\n-\t\tret = rte_mp_reply(&mp_res, peer);\n-\t\tbreak;\n-\tdefault:\n-\t\trte_errno = EINVAL;\n-\t\tDRV_LOG(ERR, \"port %u invalid mp request type\",\n-\t\t\tdev->data->port_id);\n-\t\treturn -rte_errno;\n-\t}\n-\treturn ret;\n-}\n-\n-/**\n- * Broadcast request of stopping/starting data-path to secondary processes.\n- *\n- * @param[in] dev\n- *   Pointer to Ethernet structure.\n- * @param[in] type\n- *   Request type.\n- */\n-static void\n-mp_req_on_rxtx(struct rte_eth_dev *dev, enum mlx5_mp_req_type type)\n-{\n-\tstruct rte_mp_msg mp_req;\n-\tstruct rte_mp_msg *mp_res;\n-\tstruct rte_mp_reply mp_rep;\n-\tstruct mlx5_mp_param *res;\n-\tstruct timespec ts = {.tv_sec = MLX5_MP_REQ_TIMEOUT_SEC, .tv_nsec = 0};\n-\tstruct mlx5_priv *priv = dev->data->dev_private;\n-\tint ret;\n-\tint i;\n-\n-\tMLX5_ASSERT(rte_eal_process_type() == RTE_PROC_PRIMARY);\n-\tif (!mlx5_shared_data->secondary_cnt)\n-\t\treturn;\n-\tif (type != MLX5_MP_REQ_START_RXTX && type != MLX5_MP_REQ_STOP_RXTX) {\n-\t\tDRV_LOG(ERR, \"port %u unknown request (req_type %d)\",\n-\t\t\tdev->data->port_id, type);\n-\t\treturn;\n-\t}\n-\tmp_init_msg(&priv->mp_id, &mp_req, type);\n-\tret = rte_mp_request_sync(&mp_req, &mp_rep, &ts);\n-\tif (ret) {\n-\t\tif (rte_errno != ENOTSUP)\n-\t\t\tDRV_LOG(ERR, \"port %u failed to request stop/start Rx/Tx (%d)\",\n-\t\t\t\tdev->data->port_id, type);\n-\t\tgoto exit;\n-\t}\n-\tif (mp_rep.nb_sent != mp_rep.nb_received) {\n-\t\tDRV_LOG(ERR,\n-\t\t\t\"port %u not all secondaries responded (req_type %d)\",\n-\t\t\tdev->data->port_id, type);\n-\t\tgoto exit;\n-\t}\n-\tfor (i = 0; i < mp_rep.nb_received; i++) {\n-\t\tmp_res = &mp_rep.msgs[i];\n-\t\tres = (struct mlx5_mp_param *)mp_res->param;\n-\t\tif (res->result) {\n-\t\t\tDRV_LOG(ERR, \"port %u request failed on secondary #%d\",\n-\t\t\t\tdev->data->port_id, i);\n-\t\t\tgoto exit;\n-\t\t}\n-\t}\n-exit:\n-\tmlx5_free(mp_rep.msgs);\n-}\n-\n-/**\n- * Broadcast request of starting data-path to secondary processes. The request\n- * is synchronous.\n- *\n- * @param[in] dev\n- *   Pointer to Ethernet structure.\n- */\n-void\n-mlx5_mp_req_start_rxtx(struct rte_eth_dev *dev)\n-{\n-\tmp_req_on_rxtx(dev, MLX5_MP_REQ_START_RXTX);\n-}\n-\n-/**\n- * Broadcast request of stopping data-path to secondary processes. The request\n- * is synchronous.\n- *\n- * @param[in] dev\n- *   Pointer to Ethernet structure.\n- */\n-void\n-mlx5_mp_req_stop_rxtx(struct rte_eth_dev *dev)\n-{\n-\tmp_req_on_rxtx(dev, MLX5_MP_REQ_STOP_RXTX);\n-}\ndiff --git a/drivers/net/mlx5/mlx5_trigger.c b/drivers/net/mlx5/mlx5_trigger.c\nindex 6e5a730..6f1e6d4 100644\n--- a/drivers/net/mlx5/mlx5_trigger.c\n+++ b/drivers/net/mlx5/mlx5_trigger.c\n@@ -350,7 +350,7 @@ mlx5_dev_start(struct rte_eth_dev *dev)\n \tdev->tx_pkt_burst = mlx5_select_tx_function(dev);\n \tdev->rx_pkt_burst = mlx5_select_rx_function(dev);\n \t/* Enable datapath on secondary process. */\n-\tmlx5_mp_req_start_rxtx(dev);\n+\tmlx5_mp_os_req_start_rxtx(dev);\n \tif (priv->sh->intr_handle.fd >= 0) {\n \t\tpriv->sh->port[priv->dev_port - 1].ih_port_id =\n \t\t\t\t\t(uint32_t)dev->data->port_id;\n@@ -396,7 +396,7 @@ mlx5_dev_stop(struct rte_eth_dev *dev)\n \tdev->tx_pkt_burst = removed_tx_burst;\n \trte_wmb();\n \t/* Disable datapath on secondary process. */\n-\tmlx5_mp_req_stop_rxtx(dev);\n+\tmlx5_mp_os_req_stop_rxtx(dev);\n \tusleep(1000 * priv->rxqs_n);\n \tDRV_LOG(DEBUG, \"port %u stopping device\", dev->data->port_id);\n \tmlx5_flow_stop_default(dev);\n",
    "prefixes": [
        "v3",
        "7/8"
    ]
}