Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/74141/?format=api
{ "id": 74141, "url": "http://patches.dpdk.org/api/patches/74141/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200715212228.28010-7-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200715212228.28010-7-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20200715212228.28010-7-stephen@networkplumber.org", "date": "2020-07-15T21:22:27", "name": "[v3,6/7] app/proc-info: provide way to request info on owned ports", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "2a09317c267b3d10ed8868baa629443651ad7d95", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200715212228.28010-7-stephen@networkplumber.org/mbox/", "series": [ { "id": 11062, "url": "http://patches.dpdk.org/api/series/11062/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11062", "date": "2020-07-15T21:22:21", "name": "app/proc-info enhancments", "version": 3, "mbox": "http://patches.dpdk.org/series/11062/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/74141/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/74141/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B1D26A0548;\n\tWed, 15 Jul 2020 23:23:35 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4767B1BED2;\n\tWed, 15 Jul 2020 23:22:50 +0200 (CEST)", "from mail-pl1-f194.google.com (mail-pl1-f194.google.com\n [209.85.214.194]) by dpdk.org (Postfix) with ESMTP id 6BAAA1BEA8\n for <dev@dpdk.org>; Wed, 15 Jul 2020 23:22:46 +0200 (CEST)", "by mail-pl1-f194.google.com with SMTP id b9so2923958plx.6\n for <dev@dpdk.org>; Wed, 15 Jul 2020 14:22:46 -0700 (PDT)", "from hermes.corp.microsoft.com (204-195-22-127.wavecable.com.\n [204.195.22.127])\n by smtp.gmail.com with ESMTPSA id s89sm2932600pjj.28.2020.07.15.14.22.43\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 15 Jul 2020 14:22:44 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=GOTx04kn4kl/sqSteU49fcx8GiOrIhe0gsAUDwIWhdk=;\n b=uhJdQfkISTV20gcJrXtOKRcKUliBPutpdat9WwXDJHh7QPIYlDu7jJu2iX9pbYUM7J\n ex8iyRuhe+zLHhkY0CX/ydWGyfa4SUPapbDrmg7+VgEw+k3Q5OQZ6/KF+PV7OBDjwxN0\n pYtKbjismS2VzAz3RMTb1fWpal0nyPAe+Uw11FMFayiQXpK+fQgRfH42POtJ4bwA2n1k\n J9Seeu0SyIDLtWs4VDRH3t8UOlkXh6tFoMq/pwG+U41iAqLc3vwV6+d80btWo34ynMjX\n ycZRUClAG10/TyNGisVwWsCQMJMwSTSj8W+SeI7nzxjy3BGXJ0JvaX+1+BurK5pKlxna\n aBMQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=GOTx04kn4kl/sqSteU49fcx8GiOrIhe0gsAUDwIWhdk=;\n b=NwBUuwFc7uAz57WkBgbtcyGuv63gC8oiSUsnWTwmuKqW3uHFbgUA9eUaHG/PGirDnL\n LBhGw9nRF5iXmcYRz+xxG7njQmDkdpBX0cRNT0enkR/0tlU5ssUFjHzRz8t+BUTKJQa9\n fURsj6FP4o73Owlbo4tY4uPVKCeOAUZlsvhPmt9kf4s4+kj8yEqDfJKu/23kqsoF1y/7\n erjAPSLiTrS00rCvCclrEKLKeVfg7H8kxce9By/8+UiJFN3EXIAgRFSdOJQPHYGQuNEZ\n AsaSq3V+8xhQ/ZtEbv/rX/iVrbAlGitoh2Ytrf5waBSnEbl4evjNlJTtPD8ng7bOBoFx\n k4tA==", "X-Gm-Message-State": "AOAM531yMGOSKWKhPlw+Q18SQBNEqQc3fduPxr1AfkfqL4j6BOh01fUH\n jgykUP2Af+TUpcDg9Ks+Z29iSA==", "X-Google-Smtp-Source": "\n ABdhPJyXyMiwkWvkiMHQc1gk0iX4ZkdHHldYIi+LqJm0NK6rDY4AXfOZdese3eKVmXw0sRWDtJCg3Q==", "X-Received": "by 2002:a17:902:be0e:: with SMTP id\n r14mr1060810pls.309.1594848165588;\n Wed, 15 Jul 2020 14:22:45 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "maryam.tahhan@intel.com, reshma.pattan@intel.com, hemant.agrawal@nxp.com", "Cc": "dev@dpdk.org,\n\tStephen Hemminger <stephen@networkplumber.org>", "Date": "Wed, 15 Jul 2020 14:22:27 -0700", "Message-Id": "<20200715212228.28010-7-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200715212228.28010-1-stephen@networkplumber.org>", "References": "<20200506193741.24117-1-stephen@networkplumber.org>\n <20200715212228.28010-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 6/7] app/proc-info: provide way to request\n\tinfo on owned ports", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "There are cases where a port maybe owned by another (failsafe, netvsc,\nbond); but currently proc-info has no way to look at stats of those\nports. This patch provides way for the user to explicitly ask for these\nports.\n\nIf no portmask is given the output is unchanged; it only shows the\ntop level ports. If portmask requests a specific port it will be\nshown even if owned.\n\nThe device owner is also a useful thing to show in port info.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\nAcked-by: Hemant Agrawal <hemant.agrawal@nxp.com>\n---\n app/proc-info/Makefile | 3 ++\n app/proc-info/main.c | 74 ++++++++++++++++++++++++++++--------------\n 2 files changed, 53 insertions(+), 24 deletions(-)", "diff": "diff --git a/app/proc-info/Makefile b/app/proc-info/Makefile\nindex 214f3f54a1e9..f777e037861f 100644\n--- a/app/proc-info/Makefile\n+++ b/app/proc-info/Makefile\n@@ -5,7 +5,10 @@ include $(RTE_SDK)/mk/rte.vars.mk\n \n APP = dpdk-procinfo\n \n+CFLAGS += -DALLOW_EXPERIMENTAL_API\n+CFLAGS += -O3\n CFLAGS += $(WERROR_FLAGS)\n+CFLAGS += -Wno-deprecated-declarations\n \n # all source are stored in SRCS-y\n \ndiff --git a/app/proc-info/main.c b/app/proc-info/main.c\nindex 5000724fcdd1..14c04f8367f1 100644\n--- a/app/proc-info/main.c\n+++ b/app/proc-info/main.c\n@@ -12,6 +12,7 @@\n #include <stdlib.h>\n #include <getopt.h>\n #include <unistd.h>\n+#include <strings.h>\n \n #include <rte_eal.h>\n #include <rte_common.h>\n@@ -676,19 +677,26 @@ eth_tx_queue_available(uint16_t port_id, uint16_t queue_id, uint16_t n)\n static void\n show_port(void)\n {\n-\tuint16_t i = 0;\n-\tint ret = 0, j, k;\n+\tuint32_t port_mask = enabled_port_mask;\n+\tint i, ret, j, k;\n \n \tsnprintf(bdr_str, MAX_STRING_LEN, \" show - Port PMD \");\n \tSTATS_BDR_STR(10, bdr_str);\n \n-\tRTE_ETH_FOREACH_DEV(i) {\n+\tfor (port_mask = enabled_port_mask; port_mask != 0;\n+\t port_mask &= ~(1u << i)) {\n \t\tuint16_t mtu = 0;\n \t\tstruct rte_eth_link link;\n \t\tstruct rte_eth_dev_info dev_info;\n \t\tstruct rte_eth_rss_conf rss_conf;\n \t\tstruct rte_eth_fc_conf fc_conf;\n \t\tstruct rte_ether_addr mac;\n+\t\tstruct rte_eth_dev_owner owner;\n+\n+\t\ti = ffs(port_mask) - 1;\n+\n+\t\tif (!rte_eth_dev_is_valid_port(i))\n+\t\t\tcontinue;\n \n \t\tmemset(&rss_conf, 0, sizeof(rss_conf));\n \n@@ -707,6 +715,11 @@ show_port(void)\n \t\t dev_info.driver_name, dev_info.device->name,\n \t\t rte_eth_dev_socket_id(i));\n \n+\t\tret = rte_eth_dev_owner_get(i, &owner);\n+\t\tif (ret == 0 && owner.id != RTE_ETH_DEV_NO_OWNER)\n+\t\t\tprintf(\"\\t -- owner %#\"PRIx64\":%s\\n\",\n+\t\t\t owner.id, owner.name);\n+\n \t\tret = rte_eth_link_get(i, &link);\n \t\tif (ret < 0) {\n \t\t\tprintf(\"Link get failed (port %u): %s\\n\",\n@@ -1351,6 +1364,7 @@ main(int argc, char **argv)\n \tchar log_flag[] = \"--log-level=6\";\n \tchar *argp[argc + 4];\n \tuint16_t nb_ports;\n+\tuint32_t port_mask;\n \n \t/* preparse app arguments */\n \tret = proc_info_preparse_args(argc, argv);\n@@ -1394,30 +1408,42 @@ main(int argc, char **argv)\n \tif (nb_ports == 0)\n \t\trte_exit(EXIT_FAILURE, \"No Ethernet ports - bye\\n\");\n \n-\t/* If no port mask was specified*/\n-\tif (enabled_port_mask == 0)\n-\t\tenabled_port_mask = 0xffff;\n-\n-\tRTE_ETH_FOREACH_DEV(i) {\n-\t\tif (enabled_port_mask & (1 << i)) {\n-\t\t\tif (enable_stats)\n-\t\t\t\tnic_stats_display(i);\n-\t\t\telse if (enable_xstats)\n-\t\t\t\tnic_xstats_display(i);\n-\t\t\telse if (reset_stats)\n-\t\t\t\tnic_stats_clear(i);\n-\t\t\telse if (reset_xstats)\n-\t\t\t\tnic_xstats_clear(i);\n-\t\t\telse if (enable_xstats_name)\n-\t\t\t\tnic_xstats_by_name_display(i, xstats_name);\n-\t\t\telse if (nb_xstats_ids > 0)\n-\t\t\t\tnic_xstats_by_ids_display(i, xstats_ids,\n-\t\t\t\t\t\tnb_xstats_ids);\n-\t\t\telse if (enable_metrics)\n-\t\t\t\tmetrics_display(i);\n+\t/* If no port mask was specified, one will be provided */\n+\tif (enabled_port_mask == 0) {\n+\t\tRTE_ETH_FOREACH_DEV(i) {\n+\t\t\tenabled_port_mask |= 1u << i;\n \t\t}\n \t}\n \n+\tfor (port_mask = enabled_port_mask; port_mask != 0;\n+\t port_mask &= ~(1u << i)) {\n+\t\t/* ffs() first bit is 1 not 0 */\n+\t\ti = ffs(port_mask) - 1;\n+\n+\t\tif (i >= RTE_MAX_ETHPORTS)\n+\t\t\tbreak;\n+\n+\t\tif (!rte_eth_dev_is_valid_port(i))\n+\t\t\tcontinue;\n+\n+\t\tif (enable_stats)\n+\t\t\tnic_stats_display(i);\n+\t\telse if (enable_xstats)\n+\t\t\tnic_xstats_display(i);\n+\t\telse if (reset_stats)\n+\t\t\tnic_stats_clear(i);\n+\t\telse if (reset_xstats)\n+\t\t\tnic_xstats_clear(i);\n+\t\telse if (enable_xstats_name)\n+\t\t\tnic_xstats_by_name_display(i, xstats_name);\n+\t\telse if (nb_xstats_ids > 0)\n+\t\t\tnic_xstats_by_ids_display(i, xstats_ids,\n+\t\t\t\t\t\t nb_xstats_ids);\n+\t\telse if (enable_metrics)\n+\t\t\tmetrics_display(i);\n+\n+\t}\n+\n \t/* print port independent stats */\n \tif (enable_metrics)\n \t\tmetrics_display(RTE_METRICS_GLOBAL);\n", "prefixes": [ "v3", "6/7" ] }