Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/73984/?format=api
{ "id": 73984, "url": "http://patches.dpdk.org/api/patches/73984/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200714053919.5609-9-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200714053919.5609-9-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20200714053919.5609-9-stephen@networkplumber.org", "date": "2020-07-14T05:39:16", "name": "[v4,08/11] app/test: use new allowlist and blocklist", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "1ceb34c519947e807a8d028e1ed54df3bc9de234", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200714053919.5609-9-stephen@networkplumber.org/mbox/", "series": [ { "id": 11009, "url": "http://patches.dpdk.org/api/series/11009/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=11009", "date": "2020-07-14T05:39:08", "name": "rename blacklist/whitelist to exclude/include", "version": 4, "mbox": "http://patches.dpdk.org/series/11009/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/73984/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/73984/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8E6BFA0540;\n\tTue, 14 Jul 2020 07:40:52 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2B41A1D545;\n\tTue, 14 Jul 2020 07:39:47 +0200 (CEST)", "from mail-pg1-f193.google.com (mail-pg1-f193.google.com\n [209.85.215.193]) by dpdk.org (Postfix) with ESMTP id A27D81D44D\n for <dev@dpdk.org>; Tue, 14 Jul 2020 07:39:41 +0200 (CEST)", "by mail-pg1-f193.google.com with SMTP id j19so7091876pgm.11\n for <dev@dpdk.org>; Mon, 13 Jul 2020 22:39:41 -0700 (PDT)", "from hermes.corp.microsoft.com (204-195-22-127.wavecable.com.\n [204.195.22.127])\n by smtp.gmail.com with ESMTPSA id h9sm15810259pfk.155.2020.07.13.22.39.38\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 13 Jul 2020 22:39:39 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=y08CVofLWrNVCa/ZxBHEAYEWxvugLfYGWc0Bh888XpU=;\n b=KHFxVl6K8NcSkGuYL4h7qjyKY3Rqcsi/hr+HKC5P6skn6X288oeC2u4MoSHMRoQ9d4\n DfNjPPYTBYB0DSztj+kQt7t1i3cm1mYimCA37qgQXlQX37NijRthkL5UhOY6Lr2a7srA\n 8ejnaWgZLHEJNAxzLQMqZ02g6F88oSiqebE38HEDOR/Mx8LN4wJyBg87hhd/NtDhYGsa\n Qd+OASJk2afLt2OQjP71Vqp4Qbad+Zb0C7zQLNH1ELLfAEW61T//ILgbkwGHKD3fs/Ym\n 4NuORUqFDmEjVoOzlZGTB1bI6S4SYW9H0pKVhPki8l4Q4OVUPdairNZiDxE472rNavcp\n F+5A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=y08CVofLWrNVCa/ZxBHEAYEWxvugLfYGWc0Bh888XpU=;\n b=pYfojJ+hGMP63oUV2Dg1e0iPNYmQ22c4HORx2akBgdiWDdR4Lu69ubA9wkd14r6iwQ\n NtwhXpUoBiJPLdLovZkYkWayCer+XVzezk3TGZqOm7/oP6ScbOYQSS11dWiKeEituw+P\n Zn9NyUxz7gLQ0VFHCV214kwl+PVDKcgUNce4aZtUuFwMh5gnDI1d7sHjKmE5vF5v2S4s\n +/VKVZNdnbqN+rtIzr11f1JXz1x74888qejbPie2yBxxn40tAeCu3cmswkff2MSmTL+o\n djgo4FqIy5mhyL+WGLOXUQjwdSWghkYlmPH6FW5kbGulDHPbuidZhQqNK8G4VUTaiLZr\n qznw==", "X-Gm-Message-State": "AOAM531yvMJtWFTGmn2yY5Fe+AZ+tV6p3KVDLRFplwwMQ1oin4TVFfMk\n wDyQ5zopA9owKI6ybsJ7Rkr4uSdyw0LjhQ==", "X-Google-Smtp-Source": "\n ABdhPJyCJnwCQAYWSO+kUPr+2rUKW4ZteKHMDqYPael2TNq2kouEsSmRUt/vBGUnT5HxXUEEwFGAEg==", "X-Received": "by 2002:a62:8183:: with SMTP id\n t125mr2940265pfd.210.1594705180242;\n Mon, 13 Jul 2020 22:39:40 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Luca Boccassi <bluca@debian.org>", "Date": "Mon, 13 Jul 2020 22:39:16 -0700", "Message-Id": "<20200714053919.5609-9-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.26.2", "In-Reply-To": "<20200714053919.5609-1-stephen@networkplumber.org>", "References": "<20200613000055.7909-1-stephen@networkplumber.org>\n <20200714053919.5609-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v4 08/11] app/test: use new allowlist and\n\tblocklist", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Test the renamed pci-blocklist and pci-allowlist arguments.\nUse new terms in test variable names as well.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\nAcked-by: Luca Boccassi <bluca@debian.org>\n---\n app/test/autotest.py | 16 ++++++------\n app/test/autotest_runner.py | 18 ++++++-------\n app/test/test.c | 2 +-\n app/test/test_eal_flags.c | 52 ++++++++++++++++++-------------------\n 4 files changed, 44 insertions(+), 44 deletions(-)", "diff": "diff --git a/app/test/autotest.py b/app/test/autotest.py\nindex b42f48879cc2..14b39a2e3347 100644\n--- a/app/test/autotest.py\n+++ b/app/test/autotest.py\n@@ -11,7 +11,7 @@\n \n def usage():\n print(\"Usage: autotest.py [test app|test iso image] \",\n- \"[target] [whitelist|-blacklist]\")\n+ \"[target] [allowlist|-blocklist]\")\n \n if len(sys.argv) < 3:\n usage()\n@@ -19,18 +19,18 @@ def usage():\n \n target = sys.argv[2]\n \n-test_whitelist = None\n-test_blacklist = None\n+test_allowlist = None\n+test_blocklist = None\n \n-# get blacklist/whitelist\n+# get blocklist/allowlist\n if len(sys.argv) > 3:\n testlist = sys.argv[3].split(',')\n testlist = [test.lower() for test in testlist]\n if testlist[0].startswith('-'):\n testlist[0] = testlist[0].lstrip('-')\n- test_blacklist = testlist\n+ test_blocklist = testlist\n else:\n- test_whitelist = testlist\n+ test_allowlist = testlist\n \n cmdline = \"%s -c f\" % (sys.argv[1])\n \n@@ -40,8 +40,8 @@ def usage():\n # processes, so make it 1, otherwise make it 4. ignored for non-parallel tests\n n_processes = 1 if \"bsd\" in target else 4\n \n-runner = autotest_runner.AutotestRunner(cmdline, target, test_blacklist,\n- test_whitelist, n_processes)\n+runner = autotest_runner.AutotestRunner(cmdline, target, test_blocklist,\n+ test_allowlist, n_processes)\n \n runner.parallel_tests = autotest_data.parallel_test_list[:]\n runner.non_parallel_tests = autotest_data.non_parallel_test_list[:]\ndiff --git a/app/test/autotest_runner.py b/app/test/autotest_runner.py\nindex 95e74c760dba..72180a172553 100644\n--- a/app/test/autotest_runner.py\n+++ b/app/test/autotest_runner.py\n@@ -193,14 +193,14 @@ class AutotestRunner:\n n_tests = 0\n fails = 0\n log_buffers = []\n- blacklist = []\n- whitelist = []\n+ blocklist = []\n+ allowlist = []\n \n- def __init__(self, cmdline, target, blacklist, whitelist, n_processes):\n+ def __init__(self, cmdline, target, blocklist, allowlist, n_processes):\n self.cmdline = cmdline\n self.target = target\n- self.blacklist = blacklist\n- self.whitelist = whitelist\n+ self.blocklist = blocklist\n+ self.allowlist = allowlist\n self.skipped = []\n self.parallel_tests = []\n self.non_parallel_tests = []\n@@ -274,7 +274,7 @@ def __process_result(self, result):\n self.csvwriter.writerow([test_name, test_result, result_str])\n \n # this function checks individual test and decides if this test should be in\n- # the group by comparing it against whitelist/blacklist. it also checks if\n+ # the group by comparing it against allowlist/blocklist. it also checks if\n # the test is compiled into the binary, and marks it as skipped if necessary\n def __filter_test(self, test):\n test_cmd = test[\"Command\"]\n@@ -284,10 +284,10 @@ def __filter_test(self, test):\n if \"_autotest\" in test_id:\n test_id = test_id[:-len(\"_autotest\")]\n \n- # filter out blacklisted/whitelisted tests\n- if self.blacklist and test_id in self.blacklist:\n+ # filter out blocklisted/allowlisted tests\n+ if self.blocklist and test_id in self.blocklist:\n return False\n- if self.whitelist and test_id not in self.whitelist:\n+ if self.allowlist and test_id not in self.allowlist:\n return False\n \n # if test wasn't compiled in, remove it as well\ndiff --git a/app/test/test.c b/app/test/test.c\nindex 94d26ab1f67c..13253ccee0bb 100644\n--- a/app/test/test.c\n+++ b/app/test/test.c\n@@ -61,7 +61,7 @@ do_recursive_call(void)\n \t\t\t{ \"test_master_lcore_flag\", no_action },\n \t\t\t{ \"test_invalid_n_flag\", no_action },\n \t\t\t{ \"test_no_hpet_flag\", no_action },\n-\t\t\t{ \"test_whitelist_flag\", no_action },\n+\t\t\t{ \"test_allowlist_flag\", no_action },\n \t\t\t{ \"test_invalid_b_flag\", no_action },\n \t\t\t{ \"test_invalid_vdev_flag\", no_action },\n \t\t\t{ \"test_invalid_r_flag\", no_action },\ndiff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c\nindex 4ee809e3db2e..37807d10931d 100644\n--- a/app/test/test_eal_flags.c\n+++ b/app/test/test_eal_flags.c\n@@ -30,7 +30,7 @@\n #define no_hpet \"--no-hpet\"\n #define no_huge \"--no-huge\"\n #define no_shconf \"--no-shconf\"\n-#define pci_whitelist \"--pci-whitelist\"\n+#define pci_allowlist \"--pci-allowlist\"\n #define vdev \"--vdev\"\n #define memtest \"memtest\"\n #define memtest1 \"memtest1\"\n@@ -223,12 +223,12 @@ get_number_of_sockets(void)\n #endif\n \n /*\n- * Test that the app doesn't run with invalid whitelist option.\n+ * Test that the app doesn't run with invalid allowlist option.\n * Final tests ensures it does run with valid options as sanity check (one\n * test for with Domain+BDF, second for just with BDF)\n */\n static int\n-test_whitelist_flag(void)\n+test_allowlist_flag(void)\n {\n \tunsigned i;\n #ifdef RTE_EXEC_ENV_FREEBSD\n@@ -245,45 +245,45 @@ test_whitelist_flag(void)\n \n \tconst char *wlinval[][7] = {\n \t\t{prgname, prefix, mp_flag,\n-\t\t\t\tpci_whitelist, \"error\", \"\", \"\"},\n+\t\t\t\tpci_allowlist, \"error\", \"\", \"\"},\n \t\t{prgname, prefix, mp_flag,\n-\t\t\t\tpci_whitelist, \"0:0:0\", \"\", \"\"},\n+\t\t\t\tpci_allowlist, \"0:0:0\", \"\", \"\"},\n \t\t{prgname, prefix, mp_flag,\n-\t\t\t\tpci_whitelist, \"0:error:0.1\", \"\", \"\"},\n+\t\t\t\tpci_allowlist, \"0:error:0.1\", \"\", \"\"},\n \t\t{prgname, prefix, mp_flag,\n-\t\t\t\tpci_whitelist, \"0:0:0.1error\", \"\", \"\"},\n+\t\t\t\tpci_allowlist, \"0:0:0.1error\", \"\", \"\"},\n \t\t{prgname, prefix, mp_flag,\n-\t\t\t\tpci_whitelist, \"error0:0:0.1\", \"\", \"\"},\n+\t\t\t\tpci_allowlist, \"error0:0:0.1\", \"\", \"\"},\n \t\t{prgname, prefix, mp_flag,\n-\t\t\t\tpci_whitelist, \"0:0:0.1.2\", \"\", \"\"},\n+\t\t\t\tpci_allowlist, \"0:0:0.1.2\", \"\", \"\"},\n \t};\n-\t/* Test with valid whitelist option */\n+\t/* Test with valid allowlist option */\n \tconst char *wlval1[] = {prgname, prefix, mp_flag,\n-\t\t\tpci_whitelist, \"00FF:09:0B.3\"};\n+\t\t\tpci_allowlist, \"00FF:09:0B.3\"};\n \tconst char *wlval2[] = {prgname, prefix, mp_flag,\n-\t\t\tpci_whitelist, \"09:0B.3\", pci_whitelist, \"0a:0b.1\"};\n+\t\t\tpci_allowlist, \"09:0B.3\", pci_allowlist, \"0a:0b.1\"};\n \tconst char *wlval3[] = {prgname, prefix, mp_flag,\n-\t\t\tpci_whitelist, \"09:0B.3,type=test\",\n-\t\t\tpci_whitelist, \"08:00.1,type=normal\",\n+\t\t\tpci_allowlist, \"09:0B.3,type=test\",\n+\t\t\tpci_allowlist, \"08:00.1,type=normal\",\n \t};\n \n \tfor (i = 0; i < RTE_DIM(wlinval); i++) {\n \t\tif (launch_proc(wlinval[i]) == 0) {\n \t\t\tprintf(\"Error - process did run ok with invalid \"\n-\t\t\t \"whitelist parameter\\n\");\n+\t\t\t \"allowlist parameter\\n\");\n \t\t\treturn -1;\n \t\t}\n \t}\n \tif (launch_proc(wlval1) != 0 ) {\n-\t\tprintf(\"Error - process did not run ok with valid whitelist\\n\");\n+\t\tprintf(\"Error - process did not run ok with valid allowlist\\n\");\n \t\treturn -1;\n \t}\n \tif (launch_proc(wlval2) != 0 ) {\n-\t\tprintf(\"Error - process did not run ok with valid whitelist value set\\n\");\n+\t\tprintf(\"Error - process did not run ok with valid allowlist value set\\n\");\n \t\treturn -1;\n \t}\n \tif (launch_proc(wlval3) != 0 ) {\n-\t\tprintf(\"Error - process did not run ok with valid whitelist + args\\n\");\n+\t\tprintf(\"Error - process did not run ok with valid allowlist + args\\n\");\n \t\treturn -1;\n \t}\n \n@@ -291,7 +291,7 @@ test_whitelist_flag(void)\n }\n \n /*\n- * Test that the app doesn't run with invalid blacklist option.\n+ * Test that the app doesn't run with invalid blocklist option.\n * Final test ensures it does run with valid options as sanity check\n */\n static int\n@@ -317,7 +317,7 @@ test_invalid_b_flag(void)\n \t\t{prgname, prefix, mp_flag, \"-b\", \"error0:0:0.1\"},\n \t\t{prgname, prefix, mp_flag, \"-b\", \"0:0:0.1.2\"},\n \t};\n-\t/* Test with valid blacklist option */\n+\t/* Test with valid blocklist option */\n \tconst char *blval[] = {prgname, prefix, mp_flag,\n \t\t\t \"-b\", \"FF:09:0B.3\"};\n \n@@ -326,12 +326,12 @@ test_invalid_b_flag(void)\n \tfor (i = 0; i != RTE_DIM(blinval); i++) {\n \t\tif (launch_proc(blinval[i]) == 0) {\n \t\t\tprintf(\"Error - process did run ok with invalid \"\n-\t\t\t \"blacklist parameter\\n\");\n+\t\t\t \"blocklist parameter\\n\");\n \t\t\treturn -1;\n \t\t}\n \t}\n \tif (launch_proc(blval) != 0) {\n-\t\tprintf(\"Error - process did not run ok with valid blacklist value\\n\");\n+\t\tprintf(\"Error - process did not run ok with valid blocklist value\\n\");\n \t\treturn -1;\n \t}\n \treturn 0;\n@@ -419,7 +419,7 @@ test_invalid_r_flag(void)\n \t\t\t{prgname, prefix, mp_flag, \"-r\", \"-1\"},\n \t\t\t{prgname, prefix, mp_flag, \"-r\", \"17\"},\n \t};\n-\t/* Test with valid blacklist option */\n+\t/* Test with valid blocklist option */\n \tconst char *rval[] = {prgname, prefix, mp_flag, \"-r\", \"16\"};\n \n \tint i;\n@@ -1489,9 +1489,9 @@ test_eal_flags(void)\n \t\treturn ret;\n \t}\n \n-\tret = test_whitelist_flag();\n+\tret = test_allowlist_flag();\n \tif (ret < 0) {\n-\t\tprintf(\"Error in test_invalid_whitelist_flag()\\n\");\n+\t\tprintf(\"Error in test_invalid_allowlist_flag()\\n\");\n \t\treturn ret;\n \t}\n \n@@ -1543,7 +1543,7 @@ REGISTER_TEST_COMMAND(eal_flags_master_opt_autotest, test_master_lcore_flag);\n REGISTER_TEST_COMMAND(eal_flags_n_opt_autotest, test_invalid_n_flag);\n REGISTER_TEST_COMMAND(eal_flags_hpet_autotest, test_no_hpet_flag);\n REGISTER_TEST_COMMAND(eal_flags_no_huge_autotest, test_no_huge_flag);\n-REGISTER_TEST_COMMAND(eal_flags_w_opt_autotest, test_whitelist_flag);\n+REGISTER_TEST_COMMAND(eal_flags_w_opt_autotest, test_allowlist_flag);\n REGISTER_TEST_COMMAND(eal_flags_b_opt_autotest, test_invalid_b_flag);\n REGISTER_TEST_COMMAND(eal_flags_vdev_opt_autotest, test_invalid_vdev_flag);\n REGISTER_TEST_COMMAND(eal_flags_r_opt_autotest, test_invalid_r_flag);\n", "prefixes": [ "v4", "08/11" ] }