Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/71526/?format=api
{ "id": 71526, "url": "http://patches.dpdk.org/api/patches/71526/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200615004354.14380-8-dmitry.kozliuk@gmail.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200615004354.14380-8-dmitry.kozliuk@gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200615004354.14380-8-dmitry.kozliuk@gmail.com", "date": "2020-06-15T00:43:49", "name": "[v9,07/12] eal/windows: add tracing support stubs", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "1c9d7b7c2d2a09637e3adfe24d318158d46c539f", "submitter": { "id": 1581, "url": "http://patches.dpdk.org/api/people/1581/?format=api", "name": "Dmitry Kozlyuk", "email": "dmitry.kozliuk@gmail.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200615004354.14380-8-dmitry.kozliuk@gmail.com/mbox/", "series": [ { "id": 10455, "url": "http://patches.dpdk.org/api/series/10455/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=10455", "date": "2020-06-15T00:43:42", "name": "Windows basic memory management", "version": 9, "mbox": "http://patches.dpdk.org/series/10455/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/71526/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/71526/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E1512A0093;\n\tMon, 15 Jun 2020 02:45:15 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A0CFD1BDF8;\n\tMon, 15 Jun 2020 02:44:25 +0200 (CEST)", "from mail-lf1-f66.google.com (mail-lf1-f66.google.com\n [209.85.167.66]) by dpdk.org (Postfix) with ESMTP id BFCA14C9D\n for <dev@dpdk.org>; Mon, 15 Jun 2020 02:44:10 +0200 (CEST)", "by mail-lf1-f66.google.com with SMTP id g2so870954lfb.0\n for <dev@dpdk.org>; Sun, 14 Jun 2020 17:44:10 -0700 (PDT)", "from localhost.localdomain (broadband-37-110-65-23.ip.moscow.rt.ru.\n [37.110.65.23])\n by smtp.gmail.com with ESMTPSA id f19sm4176342lfk.24.2020.06.14.17.44.09\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 14 Jun 2020 17:44:09 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=LHlAb1z42AG9LyDm6x4AYa/r3zc1UWVG/v4HM8tjcwQ=;\n b=PeoE0SatG2KRJAYxDqYj+b6zMOKi3XR7hsNrnF3/xW5KiAVh7weEje+ApcMGNMj1SL\n 3YMiV8HQhO7/NNDukS/Sldxn3GQ8DP/kkl9OPCzZySPZRrGZMXXZXCT/6+L3T5CEkZGS\n 7AHwIFE7NgfEeDW+BAjMDaHFMuhqS3kPKO2yz7OGpe/aLb0FfXWmtu7YP+nfkyTheFP0\n ReqSBnDs0NCVpp62EfYvlkIjV7bJwCNqP7MrpCTq34eppdRefmSH7XTEOTAt7dzeBCBS\n hwfT5obkAgdtqJRGV1l+ahFyO8sy8euP6L7YDlP9v9Akls81x0yXqg0oxuYC7if0YQTB\n y6XQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=LHlAb1z42AG9LyDm6x4AYa/r3zc1UWVG/v4HM8tjcwQ=;\n b=a1pVnePZko2WyGPK56WUF+wdSjWZgklZ+itnhfAjtFC0QWDhIUAHX18wjlrYHUsvMZ\n Wn6cH4g84QiaFu/7XPPv52V9/ds9HDIGeOt/Q8++mWgOgVTNl3MkSsoc0q2u5rSDiUM7\n Dg0Tm8nEDntOS+UmnI9m79EYzuSxo8hrRLioMUYBNavq2PuocEqM8gzWta2p5RAHoaQf\n jdP0VHkzkZwdtt6lH5ESyxf0CSOQzpd5A12hpRyYTHZxnjZ4QKqsEHQzv3CRgJGEyMxu\n KzVGnNs+G4hGc77NAUaR97vUF0jh8SKdQVLmoywD66qIDHB/E94L8OUQYvxT+QR9EsDw\n lgJQ==", "X-Gm-Message-State": "AOAM532wF/O8YlRWtGMxmz0Egg8yiA5Qj//akg+kQVTdtHbDaN3YkzD9\n 6fzM/rKQPMR3XmSPx+5PrZNlp0sXhzaELw==", "X-Google-Smtp-Source": "\n ABdhPJwIj6k8RjxDyGuJEwAZ/waqwZBLQdE3d4eHl2Be4tV63E1T5vte10fBDJcivR7EwJrSIVSRcA==", "X-Received": "by 2002:ac2:4422:: with SMTP id w2mr3334912lfl.152.1592181850237;\n Sun, 14 Jun 2020 17:44:10 -0700 (PDT)", "From": "Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>", "To": "dev@dpdk.org", "Cc": "Dmitry Malloy <dmitrym@microsoft.com>,\n Narcisa Ana Maria Vasile <Narcisa.Vasile@microsoft.com>,\n Fady Bader <fady@mellanox.com>, Tal Shnaiderman <talshn@mellanox.com>,\n Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,\n Harini Ramakrishnan <harini.ramakrishnan@microsoft.com>,\n Omar Cardona <ocardona@microsoft.com>,\n Pallavi Kadam <pallavi.kadam@intel.com>,\n Ranjit Menon <ranjit.menon@intel.com>", "Date": "Mon, 15 Jun 2020 03:43:49 +0300", "Message-Id": "<20200615004354.14380-8-dmitry.kozliuk@gmail.com>", "X-Mailer": "git-send-email 2.25.4", "In-Reply-To": "<20200615004354.14380-1-dmitry.kozliuk@gmail.com>", "References": "<20200610142730.31376-1-dmitry.kozliuk@gmail.com>\n <20200615004354.14380-1-dmitry.kozliuk@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v9 07/12] eal/windows: add tracing support stubs", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "EAL common code depends on tracepoint calls, but generic implementation\ncannot be enabled on Windows due to missing standard library facilities.\nAdd stub functions to support tracepoint compilation, so that common\ncode does not have to conditionally include tracepoints until proper\nsupport is added.\n\nSigned-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>\n---\n lib/librte_eal/common/eal_common_thread.c | 5 +---\n lib/librte_eal/common/meson.build | 1 +\n lib/librte_eal/windows/eal.c | 34 ++++++++++++++++++++++-\n 3 files changed, 35 insertions(+), 5 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/eal_common_thread.c b/lib/librte_eal/common/eal_common_thread.c\nindex f9f588c17..370bb1b63 100644\n--- a/lib/librte_eal/common/eal_common_thread.c\n+++ b/lib/librte_eal/common/eal_common_thread.c\n@@ -15,9 +15,7 @@\n #include <rte_lcore.h>\n #include <rte_memory.h>\n #include <rte_log.h>\n-#ifndef RTE_EXEC_ENV_WINDOWS\n #include <rte_trace_point.h>\n-#endif\n \n #include \"eal_internal_cfg.h\"\n #include \"eal_private.h\"\n@@ -169,9 +167,8 @@ static void *rte_thread_init(void *arg)\n \t\tfree(params);\n \t}\n \n-#ifndef RTE_EXEC_ENV_WINDOWS\n \t__rte_trace_mem_per_thread_alloc();\n-#endif\n+\n \treturn start_routine(routine_arg);\n }\n \ndiff --git a/lib/librte_eal/common/meson.build b/lib/librte_eal/common/meson.build\nindex d91c22220..4e9208129 100644\n--- a/lib/librte_eal/common/meson.build\n+++ b/lib/librte_eal/common/meson.build\n@@ -14,6 +14,7 @@ if is_windows\n \t\t'eal_common_log.c',\n \t\t'eal_common_options.c',\n \t\t'eal_common_thread.c',\n+\t\t'eal_common_trace_points.c',\n \t)\n \tsubdir_done()\n endif\ndiff --git a/lib/librte_eal/windows/eal.c b/lib/librte_eal/windows/eal.c\nindex d084606a6..e7461f731 100644\n--- a/lib/librte_eal/windows/eal.c\n+++ b/lib/librte_eal/windows/eal.c\n@@ -17,6 +17,7 @@\n #include <eal_filesystem.h>\n #include <eal_options.h>\n #include <eal_private.h>\n+#include <rte_trace_point.h>\n \n #include \"eal_windows.h\"\n \n@@ -221,7 +222,38 @@ rte_eal_init_alert(const char *msg)\n \tRTE_LOG(ERR, EAL, \"%s\\n\", msg);\n }\n \n- /* Launch threads, called at application init(). */\n+/* Stubs to enable EAL trace point compilation\n+ * until eal_common_trace.c can be compiled.\n+ */\n+\n+RTE_DEFINE_PER_LCORE(volatile int, trace_point_sz);\n+RTE_DEFINE_PER_LCORE(void *, trace_mem);\n+\n+void\n+__rte_trace_mem_per_thread_alloc(void)\n+{\n+}\n+\n+void\n+__rte_trace_point_emit_field(size_t sz, const char *field,\n+\tconst char *type)\n+{\n+\tRTE_SET_USED(sz);\n+\tRTE_SET_USED(field);\n+\tRTE_SET_USED(type);\n+}\n+\n+int\n+__rte_trace_point_register(rte_trace_point_t *trace, const char *name,\n+\tvoid (*register_fn)(void))\n+{\n+\tRTE_SET_USED(trace);\n+\tRTE_SET_USED(name);\n+\tRTE_SET_USED(register_fn);\n+\treturn -ENOTSUP;\n+}\n+\n+/* Launch threads, called at application init(). */\n int\n rte_eal_init(int argc, char **argv)\n {\n", "prefixes": [ "v9", "07/12" ] }